[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1839: chore: update plugin catagory display name.

2021-05-05 Thread GitBox 


iamayushdas commented on a change in pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839#discussion_r627054451



##
File path: web/src/components/Plugin/locales/en-US.ts
##
@@ -27,7 +27,7 @@ export default {
   'component.plugin.security': 'Security',
   'component.plugin.traffic': 'Traffic Control',
   'component.plugin.serverless': 'Serverless',
-  'component.plugin.observability': 'Tracing & Metrics & Logging',
+  'component.plugin.observability': 'Observability',

Review comment:
   Don't you think, 
   'Tracing & Metrics & Logging' -  gives a more clear idea
   Just asking




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1839: chore: update plugin catagory display name.

2021-05-05 Thread GitBox 


iamayushdas commented on a change in pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839#discussion_r627054451



##
File path: web/src/components/Plugin/locales/en-US.ts
##
@@ -27,7 +27,7 @@ export default {
   'component.plugin.security': 'Security',
   'component.plugin.traffic': 'Traffic Control',
   'component.plugin.serverless': 'Serverless',
-  'component.plugin.observability': 'Tracing & Metrics & Logging',
+  'component.plugin.observability': 'Observability',

Review comment:
   Don't you think, 
   'Tracing & Metrics & Logging' -  gives a more clear idea




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org