[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1646: feat: added github link to header #1632

[GitBox]

juzhiyuan commented on a change in pull request #1646:
URL: https://github.com/apache/apisix-dashboard/pull/1646#discussion_r599180281



##
File path: web/src/pages/User/Login.tsx
##
@@ -14,17 +14,18 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+import logo from '@/assets/logo.svg';

Review comment:
   no no no, I mean `import { GithubOutlined } from '@ant-design/icons';` 
this line, because it's importing a file from inner module




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1646: feat: added github link to header #1632

[GitBox]

juzhiyuan commented on a change in pull request #1646:
URL: https://github.com/apache/apisix-dashboard/pull/1646#discussion_r599144163



##
File path: web/src/pages/User/Login.tsx
##
@@ -25,6 +25,7 @@ import logo from '@/assets/logo.svg';
 import { getUrlQuery } from '@/helpers';
 import Footer from '@/components/Footer';
 import styles from './Login.less';
+import { GithubOutlined } from '@ant-design/icons';

Review comment:
   Hi, would better move this line to the top :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org