[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-833167386 Fine! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-833151114 > @juzhiyuan @qian0817 > after having a search to those errors regarding jest, > we can give a try to this command after imports > `jest.useFakeTimers();` Hi, may I know which error you mean? If this PR's changes look good to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-832623680 BTW, cc @iamayushdas @stu01509 to have a review when you have time :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-832622927 noted, I will give a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831983979 ok I know what happened -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831982960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831787974 ok, just triggered to redeploy. Codes LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826512410 also cc @guoqqqi to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826512410 also cc @guoqqqi to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
