[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695875548 > @liuxiran I just had a quick discussion with @membphis, he will help you to make sure if the `type` filed is needed :D ok, thanks :), waiting for @membphis `s conclusion This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695875548 > @liuxiran I just had a quick discussion with @membphis, he will help you to make sure if the `type` filed is needed :D ok, thanks :), waiting for @membphis `s conclusion This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695333690 `active.type` is mentioned in the test case [=== TEST 6: invalid route: wrong active.type](https://github.com/apache/apisix/blob/8493a607ce869ab335eac1d0e799ffecff10fb93/t/admin/health-check.t#L239), but no details in the api doc, so there is nothing about it in pr. If this key is needed, it would be better to update doc first :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-692600340 > hi @liuxiran, would you like to implement this feature (if you have free time)? yes, waiting for my pr :)(later this week) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691770513 > Even though we could use Passive Check only, but because once the upstream is down, the Gateway doesn't know when to recover just like Active Check does. > > So we choose to use Passive check only when the Active check is enabled :D so, is it necessary to update the [documentation](https://github.com/apache/apisix/blob/master/doc/health-check.md), add this description? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828 > How about this design? Agree with ui design 👍 , I have a question about interaction logic： refer to the [upstream health-check doc:](https://github.com/apache/apisix/blob/master/doc/health-check.md) active check and passive check could be configured independently and you also say： > Active and passive checks exist in parallel in the upstream module as separate configurations why does `Enable passive check` depend on the active check is enabled? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
