[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api

2020-11-30 Thread GitBox


nic-chen commented on issue #605:
URL: 
https://github.com/apache/apisix-dashboard/issues/605#issuecomment-735708889


   @membphis 
   I think we could move it to 2.2 
   what do you think? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api

2020-11-17 Thread GitBox


nic-chen commented on issue #605:
URL: 
https://github.com/apache/apisix-dashboard/issues/605#issuecomment-729405247


   > @nic-chen do we will implement this feature in milestone `2.2`?
   
   sure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api

2020-11-15 Thread GitBox


nic-chen commented on issue #605:
URL: 
https://github.com/apache/apisix-dashboard/issues/605#issuecomment-727787370


   > @nic-chen will you lead this feature? We have reached a consensus on the 
mailing list
   
   yes, of course.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api

2020-10-26 Thread GitBox


nic-chen commented on issue #605:
URL: 
https://github.com/apache/apisix-dashboard/issues/605#issuecomment-716957534


   we could do this after the feature you mentioned is done.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api

2020-10-26 Thread GitBox


nic-chen commented on issue #605:
URL: 
https://github.com/apache/apisix-dashboard/issues/605#issuecomment-71698


   @liuxiran 
   
   I think we need to update two files:
   
   1. update `schema-sync.lua` so that it can sync all types schemas.
   
   2. update `internal/handler/plugin/plugin.go` so that it can get different 
plugin schema by type through query params
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org