[GitHub] [apisix-dashboard] starsz commented on a change in pull request #900: feat: add version info into manager-api

2020-12-08 Thread GitBox 


starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r538307316



##
File path: api/build.sh
##
@@ -19,6 +19,9 @@ set -ex
 export ENV=local
 pwd=`pwd`
 
+VERSION=$(cat ./api/VERSION)

Review comment:
   Got it. BTW, why we need to add the branch name?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #900: feat: add version info into manager-api

2020-12-07 Thread GitBox 


starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r538005078



##
File path: api/build.sh
##
@@ -19,6 +19,9 @@ set -ex
 export ENV=local
 pwd=`pwd`
 
+VERSION=$(cat ./api/VERSION)

Review comment:
   Hi, I write the `abbreviated commit hash`.
   If the commit hash is the same, we can consider the code is the same.
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #900: feat: add version info into manager-api

2020-12-07 Thread GitBox 


starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537997032



##
File path: api/main.go
##
@@ -35,6 +35,16 @@ import (
"github.com/apisix/manager-api/log"
 )
 
+var Version string
+
+func printInfo() {
+   fmt.Fprint(os.Stdout, "The manager-api is running successfully!\n\n")
+   fmt.Fprintf(os.Stdout, "%-8s: %s\n", "Version", Version)
+   fmt.Fprintf(os.Stdout, "%-8s: %s:%d\n", "Listen", conf.ServerHost, 
conf.ServerPort)
+   fmt.Fprintf(os.Stdout, "%-8s: %s\n", "Loglevel", conf.ErrorLogLevel)

Review comment:
   The listen info is also described in the config file. But we show it.
   So I think it's more convenient for users to get the log file path location 
if the file path is described in `relative path` format.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #900: feat: add version info into manager-api

2020-12-07 Thread GitBox 


starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537994568



##
File path: api/main.go
##
@@ -35,6 +35,16 @@ import (
"github.com/apisix/manager-api/log"
 )
 
+var Version string
+
+func printInfo() {
+   fmt.Fprint(os.Stdout, "The manager-api is running successfully!\n\n")

Review comment:
   Sorry for the PR title. It's not only the version info. It also fixes 
#853.
   And `-v` will be implemented at 
https://github.com/apache/apisix-dashboard/pull/773. Manager-api need a cli 
scafford.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #900: feat: add version info into manager-api

2020-12-07 Thread GitBox 


starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537993157



##
File path: api/build.sh
##
@@ -19,6 +19,9 @@ set -ex
 export ENV=local
 pwd=`pwd`
 
+VERSION=$(cat ./api/VERSION)

Review comment:
   I agree with add go version. But why are branch name and build date 
useful, since we had git commit info.
   
   In fact, I refer the 
[mosn](https://github.com/mosn/mosn/blob/2adbcbc57994288fa4bdeb86bf43973443233a0b/Makefile#L94)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #900: feat: add version info into manager-api

2020-11-28 Thread GitBox 


starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r532165217



##
File path: api/VERSION
##
@@ -0,0 +1 @@
+v2.1-rc1

Review comment:
   Yeah. It's important. I had checked the apisix project. It needs to 
update `version.lua` for every release.
   The same as apisix-dashboard. 
   
   Maybe we can add a checklist to the PR template?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org