[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11
zaunist commented on a change in pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760758406 ## File path: web/src/components/Plugin/data.tsx ## @@ -224,4 +224,22 @@ export const PLUGIN_LIST = { type: PluginType.other, hidden: true, }, + 'authz-casbin': { +type: PluginType.authentication, + }, + 'ldap-auth': { +type: PluginType.authentication, + }, + datadog: { Review comment: ```suggestion 'datadog': { ``` need `'` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11
zaunist commented on a change in pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760742640 ## File path: api/conf/schema.json ## @@ -5501,10 +6814,14 @@ "type": "object" } }, - "required": ["protocol_level", "protocol_name", "upstream"], + "required": [ + "protocol_level", + "protocol_name", + "upstream" + ], "type": "object" }, "version": 0.1 } } -} +} Review comment: Do we need a new line at end of file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org