[GitHub] [apisix-helm-chart] webup commented on a change in pull request #183: feat(apisix): add service monitor support

2021-12-02 Thread GitBox 


webup commented on a change in pull request #183:
URL: https://github.com/apache/apisix-helm-chart/pull/183#discussion_r760885784



##
File path: charts/apisix/templates/configmap.yaml
##
@@ -226,6 +226,13 @@ data:
 
 {{- if .Values.customPlugins.enabled }}
 plugin_attr:
+  {{- if .Values.serviceMonitor.enabled }}
+  prometheus:
+export_addr:
+  ip: 0.0.0.0

Review comment:
   Yes, that's container port, not service port. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] webup commented on a change in pull request #183: feat(apisix): add service monitor support

2021-12-01 Thread GitBox 


webup commented on a change in pull request #183:
URL: https://github.com/apache/apisix-helm-chart/pull/183#discussion_r760210945



##
File path: charts/apisix/templates/configmap.yaml
##
@@ -226,6 +226,13 @@ data:
 
 {{- if .Values.customPlugins.enabled }}
 plugin_attr:
+  {{- if .Values.serviceMonitor.enabled }}
+  prometheus:
+export_addr:
+  ip: 0.0.0.0

Review comment:
   Got your point, while if you check the codes, will find that no ports 
were exposed in `Service`, we only expose one essential container port in 
`Deployment`, and in this way `ServiceMonitor` could still work well.
   
   This 
[issue](https://github.com/prometheus-operator/prometheus-operator/issues/3119#issuecomment-631409690)
 may echo my understanding: "It will scrape all pods behind the service, 
because the `Service` maintains an `Endpoints` object. That's where Prometheus 
discovers the targets from."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] webup commented on a change in pull request #183: feat(apisix): add service monitor support

2021-11-28 Thread GitBox 


webup commented on a change in pull request #183:
URL: https://github.com/apache/apisix-helm-chart/pull/183#discussion_r758051260



##
File path: charts/apisix/templates/configmap.yaml
##
@@ -226,6 +226,13 @@ data:
 
 {{- if .Values.customPlugins.enabled }}
 plugin_attr:
+  {{- if .Values.serviceMonitor.enabled }}
+  prometheus:
+export_addr:
+  ip: 0.0.0.0

Review comment:
   So how shall we expose metrics from APISIX gateway, any better approach?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org