[GitHub] [apisix-ingress-controller] Sindweller commented on a change in pull request #731: feat: Grafana Dashboard Configuration

2021-12-30 Thread GitBox


Sindweller commented on a change in pull request #731:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918809



##
File path: docs/en/latest/plugins/prometheus.md
##
@@ -0,0 +1,124 @@
+---
+title: prometheus
+---
+
+
+
+This guide shows how to monitor Apache APISIX Ingress Controller using 
Prometheus and Grafana.
+
+## Enable Prometheus
+
+You can find example CRD files in 
`apisix-ingress-controller/samples/deploy/crd/v1`.  
+The CRD file `ApisixClusterConfig` is required to use to enable prometheus in 
global configurations.  
+In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe 
Prometheus settings.
+```yaml

Review comment:
   please see if I understand the usage of crd file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] Sindweller commented on a change in pull request #731: feat: Grafana Dashboard Configuration

2021-12-30 Thread GitBox


Sindweller commented on a change in pull request #731:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918809



##
File path: docs/en/latest/plugins/prometheus.md
##
@@ -0,0 +1,124 @@
+---
+title: prometheus
+---
+
+
+
+This guide shows how to monitor Apache APISIX Ingress Controller using 
Prometheus and Grafana.
+
+## Enable Prometheus
+
+You can find example CRD files in 
`apisix-ingress-controller/samples/deploy/crd/v1`.  
+The CRD file `ApisixClusterConfig` is required to use to enable prometheus in 
global configurations.  
+In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe 
Prometheus settings.
+```yaml

Review comment:
   please see if I understand the usage of crd file.
   (in current commit)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org