[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS

2021-05-30 Thread GitBox


codecov-commenter edited a comment on pull request #492:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ecda49b) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f089ffe) will **increase** coverage by `0.16%`.
   > The diff coverage is `1.19%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #492  +/-   ##
   ==
   + Coverage   36.28%   36.44%   +0.16% 
   ==
 Files  50   53   +3 
 Lines4093 4261 +168 
   ==
   + Hits 1485 1553  +68 
   - Misses   2406 2498  +92 
   - Partials  202  210   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==)
 | `1.20% <0.00%> (+1.20%)` | :arrow_up: |
   | 
[pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | `32.06% <100.00%> (-2.98%)` | :arrow_down: |
   | 
[pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==)
 | `51.38% <0.00%> (ø)` | |
   | 
[pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv)
 | `73.33% <0.00%> (ø)` | |
   | 
[pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv)
 | 

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS

2021-05-30 Thread GitBox


codecov-commenter edited a comment on pull request #492:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (600048e) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f089ffe) will **increase** coverage by `0.16%`.
   > The diff coverage is `1.19%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #492  +/-   ##
   ==
   + Coverage   36.28%   36.44%   +0.16% 
   ==
 Files  50   53   +3 
 Lines4093 4261 +168 
   ==
   + Hits 1485 1553  +68 
   - Misses   2406 2498  +92 
   - Partials  202  210   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==)
 | `1.20% <0.00%> (+1.20%)` | :arrow_up: |
   | 
[pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | `32.06% <100.00%> (-2.98%)` | :arrow_down: |
   | 
[pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==)
 | `51.38% <0.00%> (ø)` | |
   | 
[pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv)
 | `73.33% <0.00%> (ø)` | |
   | 
[pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv)
 | 

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS

2021-05-28 Thread GitBox


codecov-commenter edited a comment on pull request #492:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (c6d4f1b) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f089ffe) will **increase** coverage by `0.18%`.
   > The diff coverage is `1.19%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #492  +/-   ##
   ==
   + Coverage   36.28%   36.46%   +0.18% 
   ==
 Files  50   54   +4 
 Lines4093 4262 +169 
   ==
   + Hits 1485 1554  +69 
   - Misses   2406 2498  +92 
   - Partials  202  210   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==)
 | `1.20% <0.00%> (+1.20%)` | :arrow_up: |
   | 
[pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | `32.06% <100.00%> (-2.98%)` | :arrow_down: |
   | 
[pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==)
 | `51.38% <0.00%> (ø)` | |
   | 
[pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv)
 | `28.88% <0.00%> (ø)` | |
   | 
[test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | ... and [2 

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS

2021-05-28 Thread GitBox


codecov-commenter edited a comment on pull request #492:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (5e9d6a8) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f089ffe) will **increase** coverage by `0.16%`.
   > The diff coverage is `1.19%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #492  +/-   ##
   ==
   + Coverage   36.28%   36.44%   +0.16% 
   ==
 Files  50   53   +3 
 Lines4093 4261 +168 
   ==
   + Hits 1485 1553  +68 
   - Misses   2406 2498  +92 
   - Partials  202  210   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==)
 | `1.20% <0.00%> (+1.20%)` | :arrow_up: |
   | 
[pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | `32.06% <100.00%> (-2.98%)` | :arrow_down: |
   | 
[pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==)
 | `51.38% <0.00%> (ø)` | |
   | 
[pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv)
 | `28.88% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv)
 | 

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS

2021-05-27 Thread GitBox


codecov-commenter edited a comment on pull request #492:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (58f1698) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f089ffe) will **increase** coverage by `0.16%`.
   > The diff coverage is `1.20%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #492  +/-   ##
   ==
   + Coverage   36.28%   36.44%   +0.16% 
   ==
 Files  50   53   +3 
 Lines4093 4261 +168 
   ==
   + Hits 1485 1553  +68 
   - Misses   2406 2498  +92 
   - Partials  202  210   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==)
 | `1.20% <0.00%> (+1.20%)` | :arrow_up: |
   | 
[pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | `32.06% <100.00%> (-2.98%)` | :arrow_down: |
   | 
[pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==)
 | `51.38% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv)
 | `73.33% <0.00%> (ø)` | |
   | 
[pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv)
 | 

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS

2021-05-27 Thread GitBox


codecov-commenter edited a comment on pull request #492:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (9ad3254) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f089ffe) will **increase** coverage by `0.16%`.
   > The diff coverage is `1.20%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #492  +/-   ##
   ==
   + Coverage   36.28%   36.44%   +0.16% 
   ==
 Files  50   53   +3 
 Lines4093 4261 +168 
   ==
   + Hits 1485 1553  +68 
   - Misses   2406 2498  +92 
   - Partials  202  210   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==)
 | `1.20% <0.00%> (+1.20%)` | :arrow_up: |
   | 
[pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | `32.06% <100.00%> (-2.98%)` | :arrow_down: |
   | 
[pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==)
 | `51.38% <0.00%> (ø)` | |
   | 
[pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv)
 | `28.88% <0.00%> (ø)` | |
   | 
[pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv)
 | 

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS

2021-05-27 Thread GitBox


codecov-commenter edited a comment on pull request #492:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (18b8f7b) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f089ffe) will **increase** coverage by `0.16%`.
   > The diff coverage is `1.20%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #492  +/-   ##
   ==
   + Coverage   36.28%   36.44%   +0.16% 
   ==
 Files  50   53   +3 
 Lines4093 4261 +168 
   ==
   + Hits 1485 1553  +68 
   - Misses   2406 2498  +92 
   - Partials  202  210   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==)
 | `1.20% <0.00%> (+1.20%)` | :arrow_up: |
   | 
[pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | `32.06% <100.00%> (-2.98%)` | :arrow_down: |
   | 
[pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==)
 | `51.38% <0.00%> (ø)` | |
   | 
[pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv)
 | `73.33% <0.00%> (ø)` | |
   | 
[pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv)
 | 

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS

2021-05-27 Thread GitBox


codecov-commenter edited a comment on pull request #492:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (144512c) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f089ffe) will **increase** coverage by `0.16%`.
   > The diff coverage is `37.11%`.
   
   > :exclamation: Current head 144512c differs from pull request most recent 
head ca94b3e. Consider uploading reports for the commit ca94b3e to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #492  +/-   ##
   ==
   + Coverage   36.28%   36.44%   +0.16% 
   ==
 Files  50   53   +3 
 Lines4093 4261 +168 
   ==
   + Hits 1485 1553  +68 
   - Misses   2406 2498  +92 
   - Partials  202  210   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==)
 | `1.20% <0.00%> (+1.20%)` | :arrow_up: |
   | 
[pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==)
 | `51.38% <ø> (ø)` | |
   | 
[pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv)
 | `28.88% <28.88%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv)
 | `73.33% <73.33%> (ø)` | |
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | `32.06% <100.00%> (-2.98%)` | :arrow_down: |
   | 
[pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv)
 | `100.00% <100.00%> (ø)` | |
   | 

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS

2021-05-27 Thread GitBox


codecov-commenter edited a comment on pull request #492:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (6c11758) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f089ffe) will **decrease** coverage by `0.56%`.
   > The diff coverage is `1.47%`.
   
   > :exclamation: Current head 6c11758 differs from pull request most recent 
head 7f0a35d. Consider uploading reports for the commit 7f0a35d to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #492  +/-   ##
   ==
   - Coverage   36.28%   35.71%   -0.57% 
   ==
 Files  50   50  
 Lines4093 4141  +48 
   ==
   - Hits 1485 1479   -6 
   - Misses   2406 2460  +54 
 Partials  202  202  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | `32.06% <100.00%> (-2.98%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Last update 
[f089ffe...7f0a35d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the