[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #770: feat: implement apisix healthz check
codecov-commenter edited a comment on pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#issuecomment-978870409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #770: feat: implement apisix healthz check
codecov-commenter edited a comment on pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#issuecomment-978870409 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#770](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f2ee888) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/413e7ca3f6287551505b6ae6a9ea9a9cb3547c47?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (413e7ca) will **increase** coverage by `0.04%`. > The diff coverage is `58.82%`. > :exclamation: Current head f2ee888 differs from pull request most recent head 5e970bd. Consider uploading reports for the commit 5e970bd to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #770 +/- ## == + Coverage 33.09% 33.14% +0.04% == Files 67 67 Lines7127 7142 +15 == + Hits 2359 2367 +8 - Misses 4499 4505 +6 - Partials 269 270 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `72.72% <ø> (-2.28%)` | :arrow_down: | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.00% <0.00%> (-0.01%)` | :arrow_down: | | [pkg/api/router/apisix\_healthz.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvYXBpc2l4X2hlYWx0aHouZ28=) | `66.66% <66.66%> (ø)` | | | [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | `82.27% <100.00%> (+0.46%)` | :arrow_up: | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [413e7ca...5e970bd](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #770: feat: implement apisix healthz check
codecov-commenter edited a comment on pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#issuecomment-978870409 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#770](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (23832eb) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/413e7ca3f6287551505b6ae6a9ea9a9cb3547c47?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (413e7ca) will **increase** coverage by `66.90%`. > The diff coverage is `n/a`. > :exclamation: Current head 23832eb differs from pull request most recent head 5e970bd. Consider uploading reports for the commit 5e970bd to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #770 +/- ## + Coverage 33.09% 100.00% +66.90% Files 67 1 -66 Lines7127 1 -7126 - Hits 2359 1 -2358 + Misses 4499 0 -4499 + Partials 269 0 -269 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | | | | [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | | | | [pkg/ingress/compare.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29tcGFyZS5nbw==) | | | | [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | | | | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | | | | [pkg/log/default\_logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2xvZy9kZWZhdWx0X2xvZ2dlci5nbw==) | | | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | | | | [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | | | | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | | | | ... and [56
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #770: feat: implement apisix healthz check
codecov-commenter edited a comment on pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#issuecomment-978870409 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#770](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0482b34) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/413e7ca3f6287551505b6ae6a9ea9a9cb3547c47?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (413e7ca) will **increase** coverage by `0.03%`. > The diff coverage is `56.25%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #770 +/- ## == + Coverage 33.09% 33.13% +0.03% == Files 67 67 Lines7127 7141 +14 == + Hits 2359 2366 +7 - Misses 4499 4505 +6 - Partials 269 270 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `72.72% <ø> (-2.28%)` | :arrow_down: | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.00% <0.00%> (-0.01%)` | :arrow_down: | | [pkg/api/router/apisix\_healthz.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvYXBpc2l4X2hlYWx0aHouZ28=) | `63.63% <63.63%> (ø)` | | | [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | `82.27% <100.00%> (+0.46%)` | :arrow_up: | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [413e7ca...0482b34](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #770: feat: implement apisix healthz check
codecov-commenter edited a comment on pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#issuecomment-978870409 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#770](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1779ece) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b127ff4) will **increase** coverage by `0.04%`. > The diff coverage is `56.25%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #770 +/- ## == + Coverage 32.50% 32.54% +0.04% == Files 66 67 +1 Lines6800 6815 +15 == + Hits 2210 2218 +8 - Misses 4340 4346 +6 - Partials 250 251 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `72.72% <ø> (-2.28%)` | :arrow_down: | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.00% <0.00%> (-0.01%)` | :arrow_down: | | [pkg/api/router/apisix\_healthz.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvYXBpc2l4X2hlYWx0aHouZ28=) | `63.63% <63.63%> (ø)` | | | [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | `82.27% <100.00%> (+0.46%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [b127ff4...1779ece](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
