[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)

2021-12-02 Thread GitBox 


codecov-commenter edited a comment on pull request #772:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (904e1ba) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c6de2deb92c72b8d609490283c930a068df7d23?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (0c6de2d) will **increase** coverage by `0.20%`.
   > The diff coverage is `42.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #772  +/-   ##
   ==
   + Coverage   32.07%   32.28%   +0.20% 
   ==
 Files  65   66   +1 
 Lines6943 7137 +194 
   ==
   + Hits 2227 2304  +77 
   - Misses   4466 4565  +99 
   - Partials  250  268  +18 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=)
 | `67.50% <ø> (ø)` | |
   | 
[pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=)
 | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
   | 
[pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=)
 | `37.33% <37.33%> (ø)` | |
   | 
[pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==)
 | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
   | 
[pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==)
 | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
   | 
[pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==)
 | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
   | 
[pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv)
 | `33.49% <100.00%> (+0.15%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = no

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)

2021-12-01 Thread GitBox 


codecov-commenter edited a comment on pull request #772:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (cf4bbdd) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f4708675c6304ad019881ad7e0ac7a0affd3e6bd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f470867) will **increase** coverage by `0.20%`.
   > The diff coverage is `42.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #772  +/-   ##
   ==
   + Coverage   32.28%   32.49%   +0.20% 
   ==
 Files  66   67   +1 
 Lines6808 7002 +194 
   ==
   + Hits 2198 2275  +77 
   - Misses   4353 4452  +99 
   - Partials  257  275  +18 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=)
 | `67.50% <ø> (ø)` | |
   | 
[pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=)
 | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
   | 
[pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=)
 | `37.33% <37.33%> (ø)` | |
   | 
[pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==)
 | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
   | 
[pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==)
 | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
   | 
[pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==)
 | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
   | 
[pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv)
 | `30.18% <100.00%> (+0.16%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = no

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)

2021-12-01 Thread GitBox 


codecov-commenter edited a comment on pull request #772:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (cf4bbdd) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f4708675c6304ad019881ad7e0ac7a0affd3e6bd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f470867) will **increase** coverage by `0.19%`.
   > The diff coverage is `42.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #772  +/-   ##
   ==
   + Coverage   32.28%   32.48%   +0.19% 
   ==
 Files  66   66  
 Lines6808 7001 +193 
   ==
   + Hits 2198 2274  +76 
   - Misses   4353 4452  +99 
   - Partials  257  275  +18 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=)
 | `67.50% <ø> (ø)` | |
   | 
[pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=)
 | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
   | 
[pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=)
 | `37.33% <37.33%> (ø)` | |
   | 
[pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==)
 | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
   | 
[pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==)
 | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
   | 
[pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==)
 | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
   | 
[pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv)
 | `30.18% <100.00%> (+0.16%)` | :arrow_up: |
   | 
[test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv)
 | | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)

2021-11-25 Thread GitBox 


codecov-commenter edited a comment on pull request #772:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (314d819) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (b127ff4) will **decrease** coverage by `0.08%`.
   > The diff coverage is `42.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #772  +/-   ##
   ==
   - Coverage   32.50%   32.41%   -0.09% 
   ==
 Files  66   67   +1 
 Lines6800 6994 +194 
   ==
   + Hits 2210 2267  +57 
   - Misses   4340 4452 +112 
   - Partials  250  275  +25 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=)
 | `67.50% <ø> (ø)` | |
   | 
[pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=)
 | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
   | 
[pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=)
 | `37.33% <37.33%> (ø)` | |
   | 
[pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==)
 | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
   | 
[pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==)
 | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
   | 
[pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==)
 | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
   | 
[pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv)
 | `30.18% <100.00%> (-3.15%)` | :arrow_down: |
   | 
[pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=)
 | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | 
[pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)

2021-11-24 Thread GitBox 


codecov-commenter edited a comment on pull request #772:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (314d819) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (b127ff4) will **decrease** coverage by `0.09%`.
   > The diff coverage is `42.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #772  +/-   ##
   ==
   - Coverage   32.50%   32.40%   -0.10% 
   ==
 Files  66   66  
 Lines6800 6993 +193 
   ==
   + Hits 2210 2266  +56 
   - Misses   4340 4452 +112 
   - Partials  250  275  +25 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=)
 | `67.50% <ø> (ø)` | |
   | 
[pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=)
 | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
   | 
[pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=)
 | `37.33% <37.33%> (ø)` | |
   | 
[pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==)
 | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
   | 
[pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==)
 | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
   | 
[pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==)
 | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
   | 
[pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv)
 | `30.18% <100.00%> (-3.15%)` | :arrow_down: |
   | 
[pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=)
 | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | 
[pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T