[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #774: fix: delete the cluster object when give up the leadership

2021-11-29 Thread GitBox 


gxthrj commented on pull request #774:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/774#issuecomment-982258373


   > > better to add e2e for this feature.
   > 
   > First of all, this is not a feature, indeed it's a bugfix, also, it's 
tough to add cases for it.
   
   I think the bugfix also need e2e test , You can restart the APISIX pod 
during the test, and then check the behavior of the Ingress controller.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #774: fix: delete the cluster object when give up the leadership

2021-11-28 Thread GitBox 


gxthrj commented on pull request #774:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/774#issuecomment-981245301


   better to add e2e for this feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org