[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-1145611152 @tao12345666333 This issue could be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-1005420014 > [ ] Add docs to describe it. I think it's my job -,-. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-988590163 > @neverCase Thanks for your work, if you have time, you can continue the development of follow-up tasks. ok, got it. I will update it tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978781841 > #694 has been merged. You can do this job @neverCase > > * [ ] Add client implementation to interact with Apache APISIX. ok, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978781461 > * chore: consumer data structures by tokers · Pull Request #470 · apache/apisix-ingress-controller ok, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978772547 > #694 has been merged. You can do this job @neverCase > > * [ ] Add client implementation to interact with Apache APISIX. @tao12345666333 Does this task mean that i should implement the webhook and validation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975203249 > @neverCase I hope you complete the definition of CRD and data type first. eg. #689 or #694 Thanks, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975193336 > @neverCase You can refer to the following PR to split this work. So that others can also develop collaboratively. > > * [chore: consumer data structures by tokers · Pull Request #470 · apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/470) > * [feat: apisixconsumer translator by tokers · Pull Request #474 · apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/474) > * [feat: consumer controller loop by tao12345666333 · Pull Request #516 · apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/516) OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638:
URL:
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975167494
@tao12345666333
hi, should I implement the ApisixPluginConfig in the `TranslateContext`
```sh
// TranslateContext contains APISIX resources generated by the translator.
type TranslateContext struct {
Routes []*apisix.Route
StreamRoutes []*apisix.StreamRoute
Upstreams[]*apisix.Upstream
upstreamMap map[string]struct{}
SSL []*apisix.Ssl
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975023739 i will update today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-973700793 @tao12345666333 @shelltea Actually, I have time to fix this, but I need more help. I'm willing to contribute my codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925507993 > @neverCase You can use `[]ApisixRouteHTTPPlugin` directly, no need to define the list yourself. before pr, should i make up the field `validation` in the `ApisixPluginConfig.yaml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638:
URL:
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925490391
ok, i had created ApisixPluginConfig.yaml and add 3 structs
`ApisixPluginConfig`, `ApisixPluginConfigSpec`, `ApisixPluginConfigList` in the
v2alpha1/types.go.
But i had trouble in making up fields inside `ApisixPluginConfigSpec`,
because i can't find any structs could be linked to the `plugin` in types.go.
```sh
// +genclient
// +genclient:nonNamespaced
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// +kubebuilder:subresource:status
// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
// An ApisixPluginConfig is used to support a group of plugin configs
type ApisixPluginConfig struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
// Spec defines the desired state of ApisixPluginConfigSpec.
Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
Status ApisixStatus `json:"status,omitempty"
yaml:"status,omitempty"`
}
// ApisixPluginConfigSpec defines the desired state of
ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
}
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// ApisixPluginConfigList contains a list of ApisixPluginConfig.
type ApisixPluginConfigList struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixPluginConfig `json:"items,omitempty"
yaml:"items,omitempty"`
}
```
could u provide me more details about the plugins
@tao12345666333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924888688 my plan 1. add ApisixPluginConfig in types.go and generated libraries (such as clientset) 2. add ApisixRoute as a group in config 3. add looper for watching specific resources by using clientset (like k8s.io/client-go) and convert it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924882844 I had replied a mail on the apache mail list, but it seems something wrong. After sending, i can't find my reply on the mail list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924855066 > > ok, got it > > Welcome to submit your plan to the mail list :). OK, i will submit my plan later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924763045 ok, got it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924755949 i'm a volunteer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
