[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-1000988943 ci show there were errors in e2e case `check the ingress lb status is updated` @tao12345666333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-1000148691 @tao12345666333 There were still some errors in ci which I should fix it before. This branch are not accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-119172 > > I could fix it at the same time. > > Great! > > It looks like this is a bug, can you submit a separate PR? Or use a separate commit for the fix, so that I can cherry-pick it to a PR > > I could fix it at the same time. > > Great! > > It looks like this is a bug, can you submit a separate PR? Or use a separate commit for the fix, so that I can cherry-pick it to a PR ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-117205
> Move L282-L286 to the front of L272.
>
> Also, please check other locations in this file at the same time to ensure
that the order of execution is as expected.
>
> Thanks!
ok, got it.
By the way, I found the some other errors from the ci.
```sh
W1222 17:45:44.757323 1 reflector.go:436]
pkg/mod/k8s.io/client-go@v0.21.1/tools/cache/reflector.go:167: watch of
*v2beta3.ApisixUpstream ended with: an error on the server ("unable to decode
an event from the watch stream: unable to decode watch event: no kind
\"ApisixUpstream\" is registered for version \"apisix.apache.org/v2beta3\" in
scheme \"pkg/runtime/scheme.go:100\"") has prevented the request from succeeding
.
W1222 17:45:58.030483 1 reflector.go:436]
pkg/mod/k8s.io/client-go@v0.21.1/tools/cache/reflector.go:167: watch of
*v2beta3.ApisixUpstream ended with: an error on the server ("unable to decode
an event from the watch stream: unable to decode watch event: no kind
\"ApisixUpstream\" is registered for version \"apisix.apache.org/v2beta3\" in
scheme \"pkg/runtime/scheme.go:100\"") has prevented the request from succeeding
```
I could fix it at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-116439 > @neverCase you can check these steps > > https://github.com/apache/apisix-ingress-controller/blob/eff92e084dd8794dc10091380aa7cdbcf707c5dd/pkg/ingress/manifest.go#L260-L287 > > Their order determines the actual execution order. OMG，I ignore it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-101428 ping @tao12345666333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-999516556
I meet a problem.
```sh
2021-12-22T17:18:11+08:00debug ingress/apisix_route.go:312
ApisixRoute add event arrived {"object":
{"metadata":{"name":"httpbin-route","namespace":"ingress-apisix-e2e-tests-default-266676929","uid":"e7a46a77-83a3-4f0f-b66e-9ffacdb79470","resourceVersion":"11216","generation":1,"creationTimestamp":"2021-12-22T09:18:11Z","annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"apisix.apache.org/v2beta3\",\"kind\":\"ApisixRoute\",\"metadata\":{\"annotations\":{},\"name\":\"httpbin-route\",\"namespace\":\"ingress-apisix-e2e-tests-default-266676929\"},\"spec\":{\"http\":[{\"backends\":[{\"serviceName\":\"httpbin-service-e2e-test\",\"servicePort\":80}],\"match\":{\"hosts\":[\"httpbin.com\"],\"paths\":[\"/ip\"]},\"name\":\"rule1\"}]}}\n"},"managedFields":[{"manager":"kubectl-client-side-apply","operation":"Update","apiVersion":"apisix.apache.org/v2beta3","time":"2021-12-22T09:18:11Z","fieldsType":"FieldsV1","fieldsV1":{"f:metadata":{"f:annotations":{".":{},"
f:kubectl.kubernetes.io/last-applied-configuration":{}}},"f:spec":{".":{},"f:http":{]},"spec":{"http":[{"name":"rule1","match":{"paths":["/ip"],"hosts":["httpbin.com"]},"backends":[{"serviceName":"httpbin-service-e2e-test","servicePort":80,"weight":null}],"websocket":false,"authentication":{"enable":false,"type":"","keyauth":{}}}]},"status":{}}}
2021-12-22T17:18:11+08:00debug ingress/apisix_route.go:177
translated ApisixRoute {"routes":
[{"id":"399a015c","name":"ingress-apisix-e2e-tests-default-266676929_httpbin-route_rule1","desc":"Created
by apisix-ingress-controller, DO NOT modify it
manually","labels":{"managed-by":"apisix-ingress-controller"},"hosts":["httpbin.com"],"uris":["/ip"],"upstream_id":"a54fd7e2","plugin_config_id":"3441d0d1"}],
"upstreams":
[{"id":"a54fd7e2","name":"ingress-apisix-e2e-tests-default-266676929_httpbin-service-e2e-test_80","desc":"Created
by apisix-ingress-controller, DO NOT modify it
manually","labels":{"managed-by":"apisix-ingress-controller"},"type":"roundrobin","nodes":[{"host":"10.244.3.54","port":80,"weight":100}],"scheme":"http"}],
"apisix_route": {}}
2021-12-22T17:18:11+08:00debug apisix/upstream.go:136 try to create
upstream {"name":
"ingress-apisix-e2e-tests-default-266676929_httpbin-service-e2e-test_80",
"url": "http://apisix-service-e2e-test:9180/apisix/admin/upstreams;, "cluster":
"default"}
2021-12-22T17:18:11+08:00debug apisix/upstream.go:151 creating
upstream {"body":
"{\"id\":\"a54fd7e2\",\"name\":\"ingress-apisix-e2e-tests-default-266676929_httpbin-service-e2e-test_80\",\"desc\":\"Created
by apisix-ingress-controller, DO NOT modify it
manually\",\"labels\":{\"managed-by\":\"apisix-ingress-controller\"},\"type\":\"roundrobin\",\"nodes\":[{\"host\":\"10.244.3.54\",\"port\":80,\"weight\":100}],\"scheme\":\"http\"}",
"url": "http://apisix-service-e2e-test:9180/apisix/admin/upstreams/a54fd7e2"}
2021-12-22T17:18:11+08:00debug apisix/resource.go:123 got upstream:
{"desc":"Created by apisix-ingress-controller, DO NOT modify it
manually","hash_on":"vars","id":"a54fd7e2","scheme":"http","pass_host":"pass","nodes":[{"host":"10.244.3.54","port":80,"weight":100,"priority":0}],"name":"ingress-apisix-e2e-tests-default-266676929_httpbin-service-e2e-test_80","update_time":1640164691,"type":"roundrobin","create_time":1640164691,"labels":{"managed-by":"apisix-ingress-controller"}}
2021-12-22T17:18:11+08:00debug apisix/route.go:144 try to create
route {"hosts": ["httpbin.com"], "name":
"ingress-apisix-e2e-tests-default-266676929_httpbin-route_rule1", "cluster":
"default", "url": "http://apisix-service-e2e-test:9180/apisix/admin/routes"}
2021-12-22T17:18:11+08:00debug apisix/route.go:160 creating route
{"body":
"{\"id\":\"399a015c\",\"name\":\"ingress-apisix-e2e-tests-default-266676929_httpbin-route_rule1\",\"desc\":\"Created
by apisix-ingress-controller, DO NOT modify it
manually\",\"labels\":{\"managed-by\":\"apisix-ingress-controller\"},\"hosts\":[\"httpbin.com\"],\"uris\":[\"/ip\"],\"upstream_id\":\"a54fd7e2\",\"plugin_config_id\":\"3441d0d1\"}",
"url": "http://apisix-service-e2e-test:9180/apisix/admin/routes/399a015c"}
2021-12-22T17:18:11+08:00error apisix/route.go:164 failed to
create route: unexpected status code 400; error message: {"error_msg":"failed
to fetch plugin config info by plugin config id [3441d0d1], response code: 404"}
2021-12-22T17:18:11+08:00debug apisix/pluginconfig.go:144 try to
create pluginConfig {"name":
"ingress-apisix-e2e-tests-default-266676929_httpbin-service-e2e-test",
"plugins": {}, "cluster": "default", "url":
"http://apisix-service-e2e-test:9180/apisix/admin/plugin_configs"}
2021-12-22T17:18:11+08:00debug
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-998431321 > LGTM Thanks! > > I will run CI again. I'm confused that why the ci run failed some many times. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-998428634 ping @tao12345666333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997193358 e2e-test-ci failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997175498
@tao12345666333
From the
[https://apisix.apache.org/docs/apisix/architecture-design/plugin-config/](url),
I thought the filed `plugin_config_id` maybe `type int`.
But in the apisixv1.Route I found the `UpstreamId` was `type string`.
```sh
// Route apisix route object
// +k8s:deepcopy-gen=true
type Route struct {
Metadata `json:",inline" yaml:",inline"`
Hoststring `json:"host,omitempty"
yaml:"host,omitempty"`
Hosts []string `json:"hosts,omitempty"
yaml:"hosts,omitempty"`
Uri string `json:"uri,omitempty"
yaml:"uri,omitempty"`
Priorityint `json:"priority,omitempty"
yaml:"priority,omitempty"`
Timeout *UpstreamTimeout `json:"timeout,omitempty"
yaml:"timeout,omitempty"`
VarsVars `json:"vars,omitempty"
yaml:"vars,omitempty"`
Uris[]string `json:"uris,omitempty"
yaml:"uris,omitempty"`
Methods []string `json:"methods,omitempty"
yaml:"methods,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"
yaml:"enable_websocket,omitempty"`
RemoteAddrs []string `json:"remote_addrs,omitempty"
yaml:"remote_addrs,omitempty"`
UpstreamId string `json:"upstream_id,omitempty"
yaml:"upstream_id,omitempty"`
Plugins Plugins `json:"plugins,omitempty"
yaml:"plugins,omitempty"`
PluginConfigId string `json:"plugin_config_id,omitempty"
yaml:"plugin_config_id,omitempty"`
}
```
So I'm sure not where are the `PluginConfigId` from, and which type it
should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-995394153 > You can do it in two steps > > 1. First complete the conversion from ApisixPluginConfig to APISIX > 2. Binding ApisixPluginConfig on ApisixRoute > > Feel free to ping me, if you have any questions. ok, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-994246184 ping @tao12345666333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-993136698 @tao12345666333 I had push codes temporarily. But I can't find the relationship between the TranslatorContext and the ApisixRoute correctly. Also in the `configv2beta3.ApisixPluginConfig` crd the `Plugins` was `[]ApisixRouteHTTPPluginConfig`, but in the internal `apisixv1.PluginConfig` the `Plugins` was not a list structure. The problem above make me confused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-993106051 > > #792 has been merged. ok, I will merge it from the master first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990718925 > > I think the current PR can be retained. > > You can create a new PR and only upgrade ApisixPluginConfig to v2beta3 > > You can update this PR after the merger. > > Of course, if you want to completely recreate the PR, you can OK, I reopen it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990714164 > > But the changes about the v2beta3 make me confused, cause my previous pr about the ApisixPluginConfig was in > > the v2beta2 directory > > Yes, apiversion has been upgraded to v2beta3 from #746 > > You can open a new PR to upgrade ApisixPluginConfig to v2beta3. ok, got it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990713769 ping @tao12345666333 > > But the changes about the v2beta3 make me confused, cause my previous pr about the ApisixPluginConfig was in > > the v2beta2 directory > > Yes, apiversion has been upgraded to v2beta3 from #746 > > You can open a new PR to upgrade ApisixPluginConfig to v2beta3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990575890 > Did you merge code from master? Yes. But the changes about the v2beta3 make me confused, cause my previous pr about the ApisixPluginConfig was in the v2beta2 directory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990575780 > Details Yes. But the changes about the v2beta3 make me confused, cause my previous pr about the ApisixPluginConfig was in the v2beta2 directory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-989803554 @tao12345666333 I update it temporarily. Please review it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
