[GitHub] [apisix-ingress-controller] neverCase edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs

2021-11-24 Thread GitBox


neverCase edited a comment on issue #638:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978772547


   > #694 has been merged. 👍 You can do this job @neverCase
   > 
   > * [ ]   Add client implementation to interact with Apache APISIX.
   
   @tao12345666333 
   Does this task mean that i should implement the webhook and validation?
   e.g. `github.com/apache/apisix-ingress-controller/pkg/api/validation"`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] neverCase edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs

2021-09-22 Thread GitBox


neverCase edited a comment on issue #638:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925490391


   ok, i had created ApisixPluginConfig.yaml and add 3 structs 
`ApisixPluginConfig`, `ApisixPluginConfigSpec`, `ApisixPluginConfigList` in the 
v2alpha1/types.go.
   But i had trouble in making up fields inside `ApisixPluginConfigSpec`, 
because i can't find any structs which could be linked to the `plugin` in 
types.go.
   ```sh
   // +genclient
   // +genclient:nonNamespaced
   // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
   // +kubebuilder:subresource:status
   
   // ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
   // An ApisixPluginConfig is used to support a group of plugin configs
   type ApisixPluginConfig struct {
metav1.TypeMeta   `json:",inline" yaml:",inline"`
metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
   
// Spec defines the desired state of ApisixPluginConfigSpec.
Spec   ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
Status ApisixStatus   `json:"status,omitempty" 
yaml:"status,omitempty"`
   }
   
   // ApisixPluginConfigSpec defines the desired state of 
ApisixPluginConfigSpec.
   type ApisixPluginConfigSpec struct {
   }
   
   // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
   
   // ApisixPluginConfigList contains a list of ApisixPluginConfig.
   type ApisixPluginConfigList struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items   []ApisixPluginConfig `json:"items,omitempty" 
yaml:"items,omitempty"`
   }
   
   ```
   could u provide me more details about the plugins
   @tao12345666333 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] neverCase edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs

2021-09-22 Thread GitBox


neverCase edited a comment on issue #638:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924882844


   I had replied a mail on the apache mail list, but it seems something wrong.
   After sending, i can't find my reply on the mail list.
   @tao12345666333 @tokers 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org