[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #731: feat: Grafana Dashboard Configuration

2021-12-30 Thread GitBox


tao12345666333 commented on a change in pull request #731:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918990



##
File path: docs/en/latest/plugins/prometheus.md
##
@@ -0,0 +1,124 @@
+---
+title: prometheus
+---
+
+
+
+This guide shows how to monitor Apache APISIX Ingress Controller using 
Prometheus and Grafana.
+
+## Enable Prometheus
+
+You can find example CRD files in 
`apisix-ingress-controller/samples/deploy/crd/v1`.  
+The CRD file `ApisixClusterConfig` is required to use to enable prometheus in 
global configurations.  
+In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe 
Prometheus settings.
+```yaml

Review comment:
   looks good.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #731: feat: Grafana Dashboard Configuration

2021-12-18 Thread GitBox


tao12345666333 commented on a change in pull request #731:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r771891099



##
File path: docs/en/latest/plugins/prometheus.md
##
@@ -0,0 +1,124 @@
+---
+title: prometheus
+---
+
+
+
+This guide shows how to monitor Apache APISIX Ingress Controller using 
Prometheus and Grafana.
+
+## Enable Prometheus
+
+You can find example CRD files in 
`apisix-ingress-controller/samples/deploy/crd/v1`.  
+The CRD file `ApisixClusterConfig` is required to use to enable prometheus in 
global configurations.  
+In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe 
Prometheus settings.
+```yaml

Review comment:
   This file is a definition file for custom resources. In order to be able 
to configure correctly, we should create a custom resource configuration file, 
like this:
   
   ```yaml
   apiVersion: apisix.apache.org/v2beta3
   kind: ApisixClusterConfig
   metadata:
 name: default
   spec:
 monitoring:
   prometheus:
 enable: true
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org