[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #785: docs: Optimize installation documentation
tao12345666333 commented on a change in pull request #785: URL: https://github.com/apache/apisix-ingress-controller/pull/785#discussion_r763122020 ## File path: docs/en/latest/deployments/minikube.md ## @@ -41,7 +40,7 @@ kubectl create ns ingress-apisix helm install apisix apisix/apisix \ --set gateway.type=NodePort \ --set ingress-controller.enabled=true \ - --namespace ingress-apisix + --namespace ingress-apisix \ --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix Review comment: yep. it was introduced by https://github.com/apache/apisix-ingress-controller/pull/747 I forgot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #785: docs: Optimize installation documentation
tao12345666333 commented on a change in pull request #785: URL: https://github.com/apache/apisix-ingress-controller/pull/785#discussion_r762404700 ## File path: docs/en/latest/deployments/minikube.md ## @@ -41,7 +40,7 @@ kubectl create ns ingress-apisix helm install apisix apisix/apisix \ --set gateway.type=NodePort \ --set ingress-controller.enabled=true \ - --namespace ingress-apisix + --namespace ingress-apisix \ Review comment: Please add one more `--set ingress-controller.config.apisix.serviceNamespace=ingress-apisix` flag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
