[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2022-01-05 Thread GitBox


tao12345666333 commented on issue #822:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1005516444


   
https://github.com/apache/apisix-ingress-controller/pull/760#issuecomment-1005503358
   
   
   > This fix cannot solve the problem in some scenarios, for example: Suppose 
there are two instances of apisix-ingress-controller. When the leader goes down 
for some reason and another instance becomes the leader, the new leader will 
block the resource event due to "client-side throttling" during the list 
resource phase. Because apisix-ingress-controller has not completed the list 
stage at this time, the control loop will definitely be blocked 
![image](https://user-images.githubusercontent.com/21658981/148190919-d3db54fb-2603-4663-9a18-d9574d2f30cd.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2022-01-04 Thread GitBox


tao12345666333 commented on issue #822:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1005373609


   After discussing with @crazyMonkey1995 , he is currently encountering the 
following problems:
   
   * He encountered some 502 errors during rolling updates of a large number of 
instances. (No health check is configured)  The main focus here is that the 
endpoint update is not fast enough. 
   
   * I think there are two pieces of information that need attention.
   
   1. The health check is very helpful for Apache APISIX to remove 
nodes in time;
   2. In #760, we have fixed the usage of workqueue and no longer limit 
the flow, so that the endpoint can be updated more quickly
   
   * action item:
   
   1. Perform stress testing to cover this scenario. @tao12345666333 
   
   * The problem of APISIX Ingress controller  resource limiting.
   * #760 It can solve this problem and has been released in v1.4.
   
   * In the single-instance APISIX scenario, APISIX Ingress controller cannot 
re-establish a connection with the dead apisix
   * https://github.com/apache/apisix-ingress-controller/pull/774  It can 
solve this problem and has been released in v1.4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-31 Thread GitBox


tao12345666333 commented on issue #822:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003308857


   > > > Okay, why not make an appointment next week, so I can summarize it 
briefly.
   > > 
   > > 
   > > Sure. Due to the holiday, how about we make an appointment next Tuesday 
14:00? Or other time you have free.
   > 
   > Emailed you.How about 5pm, I had other arrangements earlier.
   
   ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox


tao12345666333 commented on issue #822:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003267993


   > Okay, why not make an appointment next week, so I can summarize it briefly.
   
   Sure. Due to the holiday, how about we make an appointment next Tuesday 
14:00? Or other time you have free.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox


tao12345666333 commented on issue #822:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003262634


   > I want to know if you would consider combining apisix-ingress-controller 
with this way: [apache/apisix#4880](https://github.com/apache/apisix/pull/4880)
   
   It has not been put into the current roadmap. 
   
   Can we make an online meeting? I want to know the specific problems you are 
currently encountering and your thoughts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox


tao12345666333 commented on issue #822:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003260112


   before #706 , we using `workqueue.AddRateLimited`, this will cause some 
problems. 
   
   >This bug is due to a workqueue shared under the same resource, and a 
ratelimit mechanism is added to this workqueue, but we only need to add the 
ratelimit when retrying fails, and when normal resource changes, we should 
immediately add the workqueue to be processed .
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox


tao12345666333 commented on issue #822:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003259597


   Thanks for your report. 
   
   
   
   
   > * your apisix-ingress-controller version (output of 
apisix-ingress-controller version --long): 2.11.0
   
   What's your apisix-ingress-controller version? The latest version is v1.4 
(not release)
   
   The problem you encountered is somewhat similar to #806  and 
https://github.com/apache/apisix-ingress-controller/pull/760


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org