[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #779: feat: support regex in path

2021-12-07 Thread GitBox


tao12345666333 commented on pull request #779:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-988457214


   ok I understand your situation, I have added it to v1.4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #779: feat: support regex in path

2021-12-07 Thread GitBox


tao12345666333 commented on pull request #779:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-988423022


   Thd code LGTM
   
   I added the label of `do-not-merge/hold` to it because this feature is not 
planned to be in the v1.4 version.
   
   Do you have a strong demand for this feature? @lxm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #779: feat: support regex in path

2021-12-06 Thread GitBox


tao12345666333 commented on pull request #779:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-987633377


   re-run all jobs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #779: feat: support regex in path

2021-12-04 Thread GitBox


tao12345666333 commented on pull request #779:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-985996122


   In addition, can you please add documentation to introduce this feature?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #779: feat: support regex in path

2021-12-04 Thread GitBox


tao12345666333 commented on pull request #779:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-985995871


   Thanks! I have put it in my list.
   
   PS: I will submit a PR to fix the problem of e2e failure (Ingress LB status 
case)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org