[GitHub] [apisix-python-plugin-runner] shuaijinchao commented on a change in pull request #41: refactor(plugin): plugins automatically register and standard interfaces

2022-02-11 Thread GitBox


shuaijinchao commented on a change in pull request #41:
URL: 
https://github.com/apache/apisix-python-plugin-runner/pull/41#discussion_r804470664



##
File path: apisix/runner/server/handle.py
##
@@ -16,7 +16,7 @@
 #
 
 import flatbuffers
-import apisix.runner.plugin.core as runner_plugin
+from apisix.runner.plugin.core import PluginProcess as RunnerPlugin

Review comment:
   OK updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-python-plugin-runner] shuaijinchao commented on a change in pull request #41: refactor(plugin): plugins automatically register and standard interfaces

2022-02-10 Thread GitBox


shuaijinchao commented on a change in pull request #41:
URL: 
https://github.com/apache/apisix-python-plugin-runner/pull/41#discussion_r804391874



##
File path: apisix/runner/server/handle.py
##
@@ -16,7 +16,7 @@
 #
 
 import flatbuffers
-import apisix.runner.plugin.core as runner_plugin
+from apisix.runner.plugin.core import PluginProcess as RunnerPlugin

Review comment:
   Uniform style with other names ^_^




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org