[GitHub] [apisix-website] juzhiyuan commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"
juzhiyuan commented on PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1379873343 Thanks! I will check later 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"
juzhiyuan commented on PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1383334725 Just rerun the CI, there have some lint errors 😅 Can you please take a look? https://github.com/apache/apisix-website/actions/runs/3922964656/jobs/6711895873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"
juzhiyuan commented on PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1384672112 Thanks for the updates, but there still have some lint errors: https://github.com/apache/apisix-website/actions/runs/3933358059/jobs/6729652093 But don't worry, 1. Can you please check the left comments as @Yilialinn reviewed? 2. After that, we will help to resolve the left lint issues for you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"
juzhiyuan commented on PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1385127155 https://user-images.githubusercontent.com/2106987/212867302-424f8258-738d-43a1-b2de-35b374385352.png";> No worry 😅 I see this commit changes a lot, @Yilialinn Please have a review once more . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"
juzhiyuan commented on PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1396397685 Thanks to @MirtoBusico and @Yilialinn! > Hi @juzhiyuan, I've done my review. Hope you can change the status from draft to approve if you have no questions I just changed the status from Draft to Ready for Review :) Usually once the author thinks it's ready, they can change it directly 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
