[GitHub] [incubator-apisix] agile6v edited a comment on issue #1153: feature: support for proxy caching plugin based on disk.
agile6v edited a comment on issue #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-591469470 Hi @moonming Tests cases I think the t/servroot/conf/nginx.conf file should be modified. In recent days, i have been preparing to make a presentation. So I'm gonna add tests in this weekend. And are there any other problems with code implementation? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-apisix] agile6v edited a comment on issue #1153: feature: support for proxy caching plugin based on disk.
agile6v edited a comment on issue #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-590082018 Currently only supports the upstream dynamically specify the cache time. If the upstream does not specify it such as the header `Expires` or `Cache-Control`, the `cache_ttl` in the config.yaml will be used. And the option `hide_cache_headers ` will be decide whether the upstream header `Expires` and `Cache-Control` is sent to the client. It's just a trick. Hopefully it can be easily understand. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
