[GitHub] [incubator-apisix] membphis commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox 
membphis commented on issue #1153: feature: support for proxy caching plugin 
based on disk.
URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-599217208
 
 
   merged, many thx @agile6v 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox 
membphis commented on issue #1153: feature: support for proxy caching plugin 
based on disk.
URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-599215439
 
 
   LGTM, we can merge it after run the test cases.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-14 Thread GitBox 
membphis commented on issue #1153: feature: support for proxy caching plugin 
based on disk.
URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-599168105
 
 
   @agile6v It seems that you have to rebase your branch, this branch has 
conflicted with master branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-02 Thread GitBox 
membphis commented on issue #1153: feature: support for proxy caching plugin 
based on disk.
URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-593721657
 
 
   
https://github.com/apache/incubator-apisix/pull/1153/files/56a1f42fd1e8bd30575856758a51e8a21acf2e4c..b3ccdb372520e2849871afe017591a148be4664c#diff-df639fd03e25e10ae720a3ccd80a9430R187
   
   that is cool.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-01 Thread GitBox 
membphis commented on issue #1153: feature: support for proxy caching plugin 
based on disk.
URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-593183693
 
 
   And I have other new questions:
   
   1. need some e2e test case
   2. need a way to purge the old cache 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-01 Thread GitBox 
membphis commented on issue #1153: feature: support for proxy caching plugin 
based on disk.
URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-593183186
 
 
   How about the new style? I think the new style is simpler.
   
   ```json
   # current style
   "proxy-cache": {
   "cache_key": ["$uri"]
   "cache_bypass": ["$arg_bypass"],
   ... ...
   }
   ```
   
   ```json
   # new style
   "proxy-cache": {
   "cache_key": ["uri"]
   "cache_bypass": ["arg_bypass"],
   ... ...
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services