[GitHub] [incubator-apisix] moonming commented on a change in pull request #1351: [WIP]feature: remove `lua` dir.

[GitBox]

moonming commented on a change in pull request #1351: [WIP]feature: remove 
`lua` dir.
URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r399734871
 
 

 ##
 File path: Contributing.md
 ##
 @@ -98,15 +98,15 @@ Once we've discussed your changes and you've got your code 
ready, make sure that
 $ make lint
 luacheck -q lua
 Total: 0 warnings / 0 errors in 74 files
-./utils/lj-releng lua/*.lua \
-lua/apisix/*.lua \
-lua/apisix/admin/*.lua \
-lua/apisix/core/*.lua \
-lua/apisix/http/*.lua \
-lua/apisix/http/router/*.lua \
-lua/apisix/plugins/*.lua \
-lua/apisix/plugins/grpc-transcode/*.lua \
-lua/apisix/plugins/limit-count/*.lua > \
+./utils/lj-releng \
 
 Review comment:
   moved `apisix.lua` to `apisix/init.lua`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1351: [WIP]feature: remove `lua` dir.

[GitBox]

moonming commented on a change in pull request #1351: [WIP]feature: remove 
`lua` dir.
URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r399596776
 
 

 ##
 File path: bin/apisix
 ##
 @@ -113,9 +113,8 @@ env APISIX_PROFILE;
 
 {% if stream_proxy then %}
 stream {
-lua_package_path  
"$prefix/deps/share/lua/5.1/?.lua;/usr/share/lua/5.1/apisix/lua/?.lua;]=]
-  .. [=[/usr/local/share/lua/5.1/apisix/lua/?.lua;]=]
-  .. [=[$prefix/deps/share/lua/5.1/apisix/lua/?.lua;]=]
+lua_package_path  "$prefix/deps/share/lua/5.1/?.lua;]=]
+  .. [=[$prefix/deps/share/lua/5.1/apisix/?.lua;]=]
 
 Review comment:
   which line?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services