Re: [PR] feat: Add route lables to the full log [apisix]
shreemaan-abhishek closed pull request #11072: feat: Add route lables to the full log URL: https://github.com/apache/apisix/pull/11072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: Add route lables to the full log [apisix]
shreemaan-abhishek commented on PR #11072: URL: https://github.com/apache/apisix/pull/11072#issuecomment-2014499327 @madhawa-gunasekara sorry but, we don't need this PR, ref: https://github.com/apache/apisix/issues/11071#issuecomment-2014287614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: Add route lables to the full log [apisix]
madhawa-gunasekara commented on PR #11072: URL: https://github.com/apache/apisix/pull/11072#issuecomment-2014462731 Hi @shreemaan-abhishek I fixed it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: Add route lables to the full log [apisix]
shreemaan-abhishek commented on PR #11072: URL: https://github.com/apache/apisix/pull/11072#issuecomment-2012009898 @madhawa-gunasekara the test cases are failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: Add route lables to the full log [apisix]
madhawa-gunasekara commented on PR #11072: URL: https://github.com/apache/apisix/pull/11072#issuecomment-2011927980 Hi @Revolyssup, I added the test case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: Add route lables to the full log [apisix]
Revolyssup commented on PR #11072: URL: https://github.com/apache/apisix/pull/11072#issuecomment-2011393840 Will you please add a corresponding test case which confirms that log contains the label? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] feat: Add route lables to the full log [apisix]
madhawa-gunasekara opened a new pull request, #11072: URL: https://github.com/apache/apisix/pull/11072 ### Description Fixes #11071 ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
