Re: [PR] feat: Autogenerate random API Key with helm install if not passed [apisix-helm-chart]
AlinsRan commented on code in PR #740:
URL: https://github.com/apache/apisix-helm-chart/pull/740#discussion_r1558860687
##
charts/apisix/templates/configmap.yaml:
##
@@ -326,6 +326,8 @@ data:
- name: "admin"
{{- if .Values.apisix.admin.credentials.secretName }}
key: ${{"{{"}}APISIX_ADMIN_KEY{{"}}"}}
+{{- else if eq .Values.apisix.admin.credentials.admin "" }}
+key: {{ randAlphaNum 32 }}
Review Comment:
Is it regenerated when upgrading the version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: Autogenerate random API Key with helm install if not passed [apisix-helm-chart]
AlinsRan commented on code in PR #740:
URL: https://github.com/apache/apisix-helm-chart/pull/740#discussion_r1558858640
##
charts/apisix/templates/configmap.yaml:
##
@@ -326,6 +326,8 @@ data:
- name: "admin"
{{- if .Values.apisix.admin.credentials.secretName }}
key: ${{"{{"}}APISIX_ADMIN_KEY{{"}}"}}
+{{- else if eq .Values.apisix.admin.credentials.admin "" }}
+key: {{ randAlphaNum 32 }}
Review Comment:
You can add a prompt here.
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/NOTES.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: Autogenerate random API Key with helm install if not passed [apisix-helm-chart]
Revolyssup commented on code in PR #740:
URL: https://github.com/apache/apisix-helm-chart/pull/740#discussion_r1545268994
##
charts/apisix/templates/configmap.yaml:
##
@@ -326,6 +326,8 @@ data:
- name: "admin"
{{- if .Values.apisix.admin.credentials.secretName }}
key: ${{"{{"}}APISIX_ADMIN_KEY{{"}}"}}
+{{- else if eq .Values.apisix.admin.credentials.admin "" }}
+key: {{ randAlphaNum 32 }}
Review Comment:
I have added that in the README against this particular key.
https://github.com/apache/apisix-helm-chart/pull/740/files#diff-3169e4e147b847e17edc927d65d4aa9cb5db1a436d62acf059c166e898f9f3fdR46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: Autogenerate random API Key with helm install if not passed [apisix-helm-chart]
starsz commented on code in PR #740:
URL: https://github.com/apache/apisix-helm-chart/pull/740#discussion_r1540768643
##
charts/apisix/templates/configmap.yaml:
##
@@ -326,6 +326,8 @@ data:
- name: "admin"
{{- if .Values.apisix.admin.credentials.secretName }}
key: ${{"{{"}}APISIX_ADMIN_KEY{{"}}"}}
+{{- else if eq .Values.apisix.admin.credentials.admin "" }}
+key: {{ randAlphaNum 32 }}
Review Comment:
I think we can write how to get the key in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: Autogenerate random API Key with helm install if not passed [apisix-helm-chart]
Revolyssup commented on code in PR #740:
URL: https://github.com/apache/apisix-helm-chart/pull/740#discussion_r1540666022
##
charts/apisix/templates/configmap.yaml:
##
@@ -326,6 +326,8 @@ data:
- name: "admin"
{{- if .Values.apisix.admin.credentials.secretName }}
key: ${{"{{"}}APISIX_ADMIN_KEY{{"}}"}}
+{{- else if eq .Values.apisix.admin.credentials.admin "" }}
+key: {{ randAlphaNum 32 }}
Review Comment:
Since this is in the confimap. Users can look at the configmap using kubectl
to look at the key. Is there an issue there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: Autogenerate random API Key with helm install if not passed [apisix-helm-chart]
AlinsRan commented on code in PR #740:
URL: https://github.com/apache/apisix-helm-chart/pull/740#discussion_r1537154140
##
charts/apisix/templates/configmap.yaml:
##
@@ -326,6 +326,8 @@ data:
- name: "admin"
{{- if .Values.apisix.admin.credentials.secretName }}
key: ${{"{{"}}APISIX_ADMIN_KEY{{"}}"}}
+{{- else if eq .Values.apisix.admin.credentials.admin "" }}
+key: {{ randAlphaNum 32 }}
Review Comment:
How do users know the key? You need to add a prompt output.
Perhaps managing admin-key through a secret would be more appropriate.
What do you think？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] feat: Autogenerate random API Key with helm install if not passed [apisix-helm-chart]
Revolyssup opened a new pull request, #740: URL: https://github.com/apache/apisix-helm-chart/pull/740 This PR is part of the proposal which removes hardcoding of sensitive API keys by autogenerating them at either application level(APISIX) or deployment level(like helm chart.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
