Change in asterixdb[master]: some pretty printing refactoring/cleanup

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring/cleanup
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/110/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add init parameter option for external functions.

2016-07-18 Thread Xikui Wang (Code Review) 
Xikui Wang has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1006

Change subject: Add init parameter option for external functions.
..

Add init parameter option for external functions.

Add one attribute to the external function descriptor.xml
STRING_VALUE

Change-Id: I437880a700f61440ffab9f44035798e538fb9ff5
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java
M asterixdb/asterix-external-data/src/main/resources/schema/library.xsd
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Function.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FunctionTupleTranslator.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/AsterixExternalScalarFunctionInfo.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/ExternalFunctionCompilerUtil.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixExternalFunctionInfo.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/IExternalFunctionInfo.java
12 files changed, 46 insertions(+), 12 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/06/1006/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
index 92ef062..536b664 100755
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
@@ -247,7 +247,7 @@
 }
 Function f = new Function(dataverse, libraryName + "#" + 
function.getName().trim(), args.size(),
 args, function.getReturnType().trim(), 
function.getDefinition().trim(),
-library.getLanguage().trim(), 
function.getFunctionType().trim());
+library.getLanguage().trim(), 
function.getFunctionType().trim(), function.getInitParameters());
 MetadataManager.INSTANCE.addFunction(mdTxnCtx, f);
 if (LOGGER.isLoggable(Level.INFO)) {
 LOGGER.info("Installed function: " + libraryName + "#" 
+ function.getName().trim());
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
index 295b308..e1c5cde 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
@@ -1796,9 +1796,10 @@
 if (dv == null) {
 throw new AlgebricksException("There is no dataverse with this 
name " + dataverse + ".");
 }
+// for cfs, assign null to init_para for now.
 Function function = new Function(dataverse, functionName, 
cfs.getaAterixFunction().getArity(),
 cfs.getParamList(), Function.RETURNTYPE_VOID, 
cfs.getFunctionBody(), Function.LANGUAGE_AQL,
-FunctionKind.SCALAR.toString());
+FunctionKind.SCALAR.toString(), null);
 MetadataManager.INSTANCE.addFunction(mdTxnCtx, function);
 
 MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java
index 50dc28e..b46 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java
@@ -55,6 +55,7 @@
 private final JObjectPointableVisitor pointableVisitor;
 private final PointableAllocator pointableAllocator;
 private final Map poolTypeInfo;
+private final String initParameters;
 
 private boolean isValidResult = false;
 
@@ -71,6 +72,7 @@
 }
 this.resultHolder = objectPool.allocate(finfo.getReturnType());
 this.poolTypeInfo = new

Change in asterixdb[master]: RangeGenerator aggfunc for the numeric/asciiString datatype ...

2016-07-18 Thread Michael Blow (Code Review) 
Michael Blow has posted comments on this change.

Change subject: RangeGenerator aggfunc for the numeric/asciiString datatype 
based on parallel streaming histogram.
..


Patch Set 36:

(13 comments)

https://asterix-gerrit.ics.uci.edu/#/c/806/36/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/GlobalRangeGeneratorTypeComputer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/GlobalRangeGeneratorTypeComputer.java:

Line 30: public class GlobalRangeGeneratorTypeComputer  extends 
AbstractResultTypeComputer {
extra space before extends


https://asterix-gerrit.ics.uci.edu/#/c/806/36/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarRangeGeneratorAggregateDescriptor.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarRangeGeneratorAggregateDescriptor.java:

Line 28: public final static FunctionIdentifier FID = 
AsterixBuiltinFunctions.SCALAR_RG;
final static -> static final


https://asterix-gerrit.ics.uci.edu/#/c/806/36/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractRangeGeneratorAggregateFunction.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractRangeGeneratorAggregateFunction.java:

Line 323: for (int i = 0; i < listItems.size(); i++) {
Seems it might be a little cleaner to use the enhanced for loop:

for (ARecordVisitablePointable item : listPointable.getItems()) ...


Line 384: for (int i = 0; i < rangeMap.size(); i++) {
Seems it might be a little cleaner to use the enhanced for loop here


Line 409: for (int i = 0; i < rangeMap.size(); i++) {
Seems it might be a little cleaner to use the enhanced for loop here


Line 442: translateVal = (ShortPointable) 
BytePointable.FACTORY.createPointable();
bad cast (BytePointable)


https://asterix-gerrit.ics.uci.edu/#/c/806/36/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/LocalRangeGeneratorAggregateFunction.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/LocalRangeGeneratorAggregateFunction.java:

Line 42: finishPartialResults(result);
making sure this is the right method to call (partial)


https://asterix-gerrit.ics.uci.edu/#/c/806/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHeapList.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHeapList.java:

Line 24: public void increase(int index, K key) throws HyracksDataException;
can remove redundant 'public' modifier (all methods)


https://asterix-gerrit.ics.uci.edu/#/c/806/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHistogram.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHistogram.java:

Line 27:  * @author michael
remove @author


Line 30: public enum HistogramType {
can remove redundant 'public' modifier (all enums & methods)


https://asterix-gerrit.ics.uci.edu/#/c/806/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IQuantileList.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IQuantileList.java:

Line 27: public int size();
can remove redundant 'public' modifier (all methods)


https://asterix-gerrit.ics.uci.edu/#/c/806/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/DominantQuantile.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/DominantQuantile.java:

Line 70: return super.hashCode();
Hashcode function should be implemented or this class may not behave as 
expected in a hashset/map.


https://asterix-gerrit.ics.uci.edu/#/c/806/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/GenericQuantile.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/GenericQuantile.java:

Line 73: return super.hashCode();
Hashcode function should be implemented or this class may not behave as 
expected in a hashset/map.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/806
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I450d0962fbeacfb2b6ab9fae0750f025ef17ba01
Gerrit-PatchSet: 36
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia

[jira] [Updated] (ASTERIXDB-1535) CC stop answering through 19002 API port

2016-07-18 Thread Jianfeng Jia (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jianfeng Jia updated ASTERIXDB-1535:

Attachment: cc.jstack

> CC stop answering through 19002 API port
> 
>
> Key: ASTERIXDB-1535
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1535
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: HTTP API
> Environment: master
> commit a89fae64ac21fb8eefde79f79d2dbe1a0e54c364
> Date:   Wed Jul 6 07:58:55 2016 -0700
>Reporter: Jianfeng Jia
>Assignee: Ian Maxon
> Attachments: cc.jstack
>
>
> The /adminconsole showed that there are many pending jobs while the 
> ingestion and the query works fine in nc. 
> If this situation lasts longer enough, say 2 days, the 19002 API will stop 
> response any queries, while the web interface from 19001 port can still 
> answer the query.
> I need to restart the cluster to recover the service. Before that I record 
> the jstack log of the cc as attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ASTERIXDB-1535) CC stop answering through 19002 API port

2016-07-18 Thread Jianfeng Jia (JIRA) 

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383556#comment-15383556
 ] 

Jianfeng Jia commented on ASTERIXDB-1535:
-

[~imaxon] I don't know who to assign to. I temporary assign it to you :-)

> CC stop answering through 19002 API port
> 
>
> Key: ASTERIXDB-1535
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1535
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: HTTP API
> Environment: master
> commit a89fae64ac21fb8eefde79f79d2dbe1a0e54c364
> Date:   Wed Jul 6 07:58:55 2016 -0700
>Reporter: Jianfeng Jia
>Assignee: Ian Maxon
>
> The /adminconsole showed that there are many pending jobs while the 
> ingestion and the query works fine in nc. 
> If this situation lasts longer enough, say 2 days, the 19002 API will stop 
> response any queries, while the web interface from 19001 port can still 
> answer the query.
> I need to restart the cluster to recover the service. Before that I record 
> the jstack log of the cc as attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ASTERIXDB-1534) NPE when restart the server

2016-07-18 Thread Jianfeng Jia (JIRA) 
Jianfeng Jia created ASTERIXDB-1534:
---

 Summary: NPE when restart the server
 Key: ASTERIXDB-1534
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1534
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: Feeds, Storage
 Environment: master 
commit a89fae64ac21fb8eefde79f79d2dbe1a0e54c364
Date:   Wed Jul 6 07:58:55 2016 -0700
Reporter: Jianfeng Jia
Assignee: Michael Blow


When I stop and start the cluster by managix, I hit the following error:

{code}
ERROR: 
/rhome/jianfeng/managix/home/asterix/cloudberry/.nfs02180534118e 
(No such file or directory)
j
{code}

And no nc and cc got started.
After a while, I ran the managix start again, the cluster restart successfully. 

But one of the dataset  can't answer any queries. The simplest select query
{code}
for $t in dataset twitter.ds_tweet limit 5 return $t
{code}

 will give me the following error:

{code}
Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: 
org.apache.hyracks.api.exceptions.HyracksDataException: 
java.util.concurrent.ExecutionException: 
org.apache.hyracks.api.exceptions.HyracksDataException: 
java.lang.NullPointerException
at 
org.apache.hyracks.control.common.utils.ExceptionUtils.setNodeIds(ExceptionUtils.java:45)
at org.apache.hyracks.control.nc.Task.run(Task.java:319)
... 3 more
Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: 
java.util.concurrent.ExecutionException: 
org.apache.hyracks.api.exceptions.HyracksDataException: 
java.lang.NullPointerException
at 
org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.runInParallel(SuperActivityOperatorNodePushable.java:218)
at 
org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.initialize(SuperActivityOperatorNodePushable.java:83)
at org.apache.hyracks.control.nc.Task.run(Task.java:263)
... 3 more
Caused by: java.util.concurrent.ExecutionException: 
org.apache.hyracks.api.exceptions.HyracksDataException: 
java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.util.concurrent.FutureTask.get(FutureTask.java:192)
at 
org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.runInParallel(SuperActivityOperatorNodePushable.java:212)
... 5 more
Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: 
java.lang.NullPointerException
at 
org.apache.hyracks.storage.am.common.dataflow.IndexSearchOperatorNodePushable.nextFrame(IndexSearchOperatorNodePushable.java:187)
at 
org.apache.hyracks.dataflow.common.comm.io.AbstractFrameAppender.write(AbstractFrameAppender.java:93)
at 
org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushAndReset(AbstractOneInputOneOutputOneFramePushRuntime.java:63)
at 
org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushIfNotFailed(AbstractOneInputOneOutputOneFramePushRuntime.java:69)
at 
org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.close(AbstractOneInputOneOutputOneFramePushRuntime.java:55)
at 
org.apache.hyracks.algebricks.runtime.operators.std.AssignRuntimeFactory$1.close(AssignRuntimeFactory.java:122)
at 
org.apache.hyracks.algebricks.runtime.operators.std.EmptyTupleSourceRuntimeFactory$1.close(EmptyTupleSourceRuntimeFactory.java:60)
at 
org.apache.hyracks.algebricks.runtime.operators.meta.AlgebricksMetaOperatorDescriptor$1.initialize(AlgebricksMetaOperatorDescriptor.java:116)
at 
org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.lambda$initialize$0(SuperActivityOperatorNodePushable.java:83)
at 
org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$$Lambda$1/350086994.runAction(Unknown
 Source)
at 
org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$1.call(SuperActivityOperatorNodePushable.java:205)
at 
org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$1.call(SuperActivityOperatorNodePushable.java:202)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
... 3 more
Caused by: java.lang.NullPointerException
at 
org.apache.hyracks.storage.am.common.frames.TreeIndexNSMFrame.getTupleCount(TreeIndexNSMFrame.java:287)
at 
org.apache.hyracks.storage.am.btree.impls.BTreeRangeSearchCursor.hasNext(BTreeRangeSearchCursor.java:141)
at 
org.apache.hyracks.storage.am.lsm.invertedindex.ondisk.PartitionedOnDiskInvertedIndex.openInvertedListPartitionCursors(PartitionedOnDiskInvertedIndex.java:98)
at 
org.apache.hyracks.storage.am.lsm.invertedindex.search.PartitionedTOccurrenceSearcher.search(PartitionedTOccurrenceSearcher.java:116)
at

Change in asterixdb[master]: Add Test NodeController, Test Data Generator, and Marker Logs

2016-07-18 Thread Michael Blow (Code Review) 
Michael Blow has posted comments on this change.

Change subject: Add Test NodeController, Test Data Generator, and Marker Logs
..


Patch Set 10:

(9 comments)

https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java:

Line 733: : 
storageProperties.getMemoryComponentNumPages();
not a fan, i think the original version is much easier to read


Line 759: int numPages =
not a fan, i think the original version is much easier to read


https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogMarkerCallback.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogMarkerCallback.java:

Line 28: public static final String KEY_MARKER_CALLBACK = "MARKER_CALLBACK";
Should we remove the redundant modifiers (public static final) given that this 
is a new interface?


Line 36: public void before(ByteBuffer buffer);
remove public


Line 43: public void after(long lsn);
remove public


https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java:

Line 258: switch (logType) {
> MAJOR SonarQube violation:
Can we restore the default case?  Even if a no-op, this is good documentation 
that other case should do nothing.  If we are handling all cases, we should add 
a default case that throws IllegalStateException()


https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java:

Line 92: file.getParentFile().mkdirs();
Isn't the issue still present, (reported in patch 7)


https://asterix-gerrit.ics.uci.edu/#/c/962/10/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/MessagingFrameTupleAppender.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/MessagingFrameTupleAppender.java:

Line 119: int messageSize = message.getBuffer().limit() - 
message.getBuffer().position();
Can we add a local final variable for message.getBuffer()?  Seems nice since we 
call it 3 times (from 4 places).


https://asterix-gerrit.ics.uci.edu/#/c/962/10/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java:

Line 476: return (metadataPageNum * bufferCache.getPageSize()) + 
LIFOMetaDataFrame.LSN_OFFSET;
> CRITICAL SonarQube violation:
+1- I would cast bufferCache.getPageSize() to long


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/962
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9aa8de758b7d26ca34868b16e5ce693e0c0243
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: some pretty printing refactoring/cleanup

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring/cleanup
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/110/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring/cleanup

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring/cleanup
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring/cleanup

2016-07-18 Thread Till Westmann (Code Review) 
Hello Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1004

to look at the new patch set (#6).

Change subject: some pretty printing refactoring/cleanup
..

some pretty printing refactoring/cleanup

- introduce AlgebricksAppendable
- use AlgebricksAppendable instead of PrintWriter and StringBuilder for plan
  printing
- avoid creation of intermediate strings for each Operator
- only log plans in the optimizer if the log-level requires it
- change param to indent output JSON from INDENT to PRETTY

Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java
A 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AlgebricksAppendable.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/AbstractRuleController.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java
M 
hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java
12 files changed, 350 insertions(+), 276 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/04/1004/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/109/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in incubator-asterixdb-site[asf-site]: Update dev-setup to use IntelliJ instead

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Update dev-setup to use IntelliJ instead
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asf-site/74/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1005
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd497
Gerrit-PatchSet: 1
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in incubator-asterixdb-site[asf-site]: Update dev-setup to use IntelliJ instead

2016-07-18 Thread Ian Maxon (Code Review) 
Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1005

Change subject: Update dev-setup to use IntelliJ instead
..

Update dev-setup to use IntelliJ instead

Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd497
---
M dev-setup.md
1 file changed, 13 insertions(+), 29 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/incubator-asterixdb-site 
refs/changes/05/1005/1

diff --git a/dev-setup.md b/dev-setup.md
index 75642cc..a71d47c 100644
--- a/dev-setup.md
+++ b/dev-setup.md
@@ -45,39 +45,23 @@
 
 You will now have `$HOME/workspace/asterixdb/`.
 
-2. Go to the asterixdb folder and install it's artifacts to the local Maven 
repository by executing the following commands:
+2. In Intellij, import asterixdb as an existing Maven Project.
+* `File -> New -> Project from existing sources`, or `Import project...' when 
on a new install
+* Then, select the 'pom.xml' in the root of the checked out git repository. 
+* The default options for import should suffice, so just click `Next`
+* Also click `Next` when selecting for profiles and versions
+* On the JDK Selection screen, be sure to select a JDK > 1.8, OpenJDK or 
Oracle is fine.
+* Give IntelliJ some time to import the Maven project and its dependencies
+* Once everything is finished, you should see 'asterixdb' and 
'hyracks-fullstack' modules in the "Project" view.
 
-cd asterixdb/
-mvn install -DskipTests
-
-3. In Eclipse, import asterixdb as an existing Maven Project.
-* `File -> Import -> Maven -> Existing Maven Projects -> Next`
-* Specify the Root directory as `asterixdb` and then click Next until Finish 
is enabled.
-* If Eclipse tries to install the `m2e` (Maven To Eclipse) connector, let it 
do so.
-* There might be some plugin errors; however, that is not a big deal. Wait 
until the job finishes.
-* Then, click Finish. Restart Eclipse if asked to do so.
-
-4. Fix Eclipse's build path to include compile-time generated sources.
-* Right click the project where a red X mark is shown(e.g. `asterix-algebra`. 
Then resolve by applying the following:
-  * Right click asterix-algebra. Click Build Path and Configure Build Path. 
Click Add Folder.
-  * Under the `target -> generated sources`, check the parent folder of the 
`org` folder and click OK.
-  * For example, if the directory structure is "target - generated-sources - 
javacc - org - apache ...", check the javacc directory and click OK. Then X 
mark will dissapear.
-* Repeat this step to all projects which show a red X mark except 
"asterix-fuzzyjoin" and "asterix-transactions".
-* It may be the case that only "asterix-algebra" and "asterix-external-data" 
will require these steps.
-* If you see "plugin execution not covered by lifecycle configuration" errors 
such as this one - "Plugin execution not covered by lifecycle configuration: 
org.apache.asterix:asterix-test-datagenerator-maven-plugin:0.8.9-SNAPSHOT:generate-testdata
 (execution: replace-template-data, phase: process-test-resources)", try to 
resolve it using the quick fix feature. You can call this feature by right 
click on the error and select "quick fix". And then choose "Mark goal 
generate-testdata as ignored in Eclipse build in Eclipse preferences". 
-
-5. Set up Eclipse code formatting rules
+3. Set up IntelliJ code formatting rules
 * Download files 
[AsterixCodeFormatProfile.xml](https://cwiki.apache.org/confluence/download/attachments/61322291/AsterixCodeFormatProfile.xml)
 
 
[AsterixCleanupFormatProfile.xml](https://cwiki.apache.org/confluence/download/attachments/61322291/AsterixCleanupFormatProfile.xml)
-* Import profiles into Eclipse
-  * Preferences -> Java -> Code style -> Formatter -> Import -> Select 
AsterixCodeFormatProfile.xml
-  * Preferences -> Java -> Code style -> Clean up -> Import -> Select 
AsterixCleanupFormatProfile.xml
-  * Preferences -> Java -> Editor -> Save actions -> Perform the selected 
action on save -> Format source code
+* Import profiles into IntelliJ
+* `File -> Settings -> Editor -> Code Style -> Java`
+* Then, click the `Manage...` button
+* Click `Import` and import the `AsterixCodeFormatProfile.xml` as an 
Eclipse XML profile.
 
-6. Lastly, go to the asterixdb folder and execute following command again. 
This is required since Eclipse might have cleaned the projects and rebuilt the 
them without creating all necessary classes. Currently, some of the class files 
can be only built using mvn command.
-
-cd asterixdb/
-mvn install -DskipTests
 
 ---
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1005
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd497
Gerrit-PatchSet: 1
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Ian Maxon

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Yingyi Bu (Code Review) 
Yingyi Bu has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1931/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Till Westmann (Code Review) 
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1004

to look at the new patch set (#5).

Change subject: some pretty printing refactoring
..

some pretty printing refactoring

- introduce AlgebricksAppendable
- use AlgebricksAppendable instead of PrintWriter and StringBuilder for plan
  printing
- only log plans in the optimizer if the log-level requires it
- change param to indent output JSON from INDENT to PRETTY

Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java
A 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AlgebricksAppendable.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/AbstractRuleController.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java
M 
hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java
12 files changed, 198 insertions(+), 110 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/04/1004/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1930/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Till Westmann (Code Review) 
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1004

to look at the new patch set (#4).

Change subject: some pretty printing refactoring
..

some pretty printing refactoring

- introduce AlgebricksAppendable
- use AlgebricksAppendable instead of PrintWriter and StringBuilder for plan
  printing
- only log plans in the optimizer if the log-level requires it
- change param to indent output JSON from INDENT to PRETTY

Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java
A 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AlgebricksAppendable.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/AbstractRuleController.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java
M 
hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java
12 files changed, 198 insertions(+), 107 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/04/1004/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu

Change in asterixdb[master]: Range connector updates to support interval partitioning.

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Range connector updates to support interval partitioning.
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/108/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/803
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I551e3196d8a101cf94c084c14842aa1af11632ce
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Range connector updates to support interval partitioning.

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Range connector updates to support interval partitioning.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1929/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/803
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I551e3196d8a101cf94c084c14842aa1af11632ce
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/107/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1928/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Till Westmann (Code Review) 
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1004

to look at the new patch set (#3).

Change subject: some pretty printing refactoring
..

some pretty printing refactoring

- introduce AlgebricksAppendable
- use AlgebricksAppendable instead of PrintWriter and StringBuilder for plan
  printing
- only log plans in the optimizer if the log-level requires it
- change param to indent output JSON from INDENT to PRETTY

Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java
A 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AlgebricksAppendable.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/AbstractRuleController.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java
M 
hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java
12 files changed, 194 insertions(+), 107 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/04/1004/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/107/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1927/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Till Westmann (Code Review) 
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1004

to look at the new patch set (#2).

Change subject: some pretty printing refactoring
..

some pretty printing refactoring

- use Appendable instead of PrintWriter and StringBuilder for plan printing
- only log plans in the optimizer if the log-level requires it
- change param to indent output JSON from INDENT to PRETTY

Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java
6 files changed, 423 insertions(+), 265 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/04/1004/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: some pretty printing refactoring
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1926/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: some pretty printing refactoring

2016-07-18 Thread Till Westmann (Code Review) 
Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1004

Change subject: some pretty printing refactoring
..

some pretty printing refactoring

- use Appendable instead of PrintWriter and StringBuilder for plan printing
- only log plans in the optimizer if the log-level requires it
- change param to indent output JSON from INDENT to PRETTY

Change-Id: Ied0203adc51e9710690ace74fe1e152eb7a716e8
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java
6 files changed, 426 insertions(+), 265 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/04/1004/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
index c09b424..5b28848 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
@@ -18,6 +18,7 @@
  */
 package org.apache.asterix.api.common;
 
+import java.io.IOException;
 import java.io.PrintWriter;
 import java.util.HashMap;
 import java.util.Map;
@@ -103,7 +104,7 @@
 public static final String FORMAT_QUOTE_RECORD = "quote-record";
 
 public interface ResultDecorator {
-PrintWriter print(PrintWriter pw);
+Appendable append(Appendable app) throws IOException;
 }
 
 // Standard execution flags.
@@ -193,12 +194,12 @@
 return this.fmt;
 }
 
-public PrintWriter resultPrefix(PrintWriter pw) {
-return this.preResultDecorator != null ? 
this.preResultDecorator.print(pw) : pw;
+public Appendable resultPrefix(Appendable app) throws IOException {
+return this.preResultDecorator != null ? 
this.preResultDecorator.append(app) : app;
 };
 
-public PrintWriter resultPostfix(PrintWriter pw) {
-return this.postResultDecorator != null ? 
this.postResultDecorator.print(pw) : pw;
+public Appendable resultPostfix(Appendable app) throws IOException {
+return this.postResultDecorator != null ? 
this.postResultDecorator.append(app) : app;
 };
 
 /**
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 8fa09a4..baa3c05 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -66,7 +66,7 @@
 STATEMENT("statement"),
 FORMAT("format"),
 // Asterix
-INDENT("indent");
+PRETTY("pretty");
 
 private final String str;
 
@@ -244,23 +244,23 @@
  * output-format based on the Accept: header and other servlet parameters.
  */
 private static SessionConfig createSessionConfig(HttpServletRequest 
request, PrintWriter resultWriter) {
-SessionConfig.ResultDecorator resultPrefix = (PrintWriter pw) -> {
-pw.print("\t\"");
-pw.print(ResultFields.RESULTS.str());
-pw.print("\": ");
-return pw;
+SessionConfig.ResultDecorator resultPrefix = (Appendable app) -> {
+app.append("\t\"");
+app.append(ResultFields.RESULTS.str());
+app.append("\": ");
+return app;
 };
 
-SessionConfig.ResultDecorator resultPostfix = (PrintWriter pw) -> {
-pw.print("\t,\n");
-return pw;
+SessionConfig.ResultDecorator resultPostfix = (Appendable app) -> {
+app.append("\t,\n");
+return app;
 };
 
 String formatstr = 
request.getParameter(Parameter.FORMAT.str()).toLowerCase();
 SessionConfig.OutputFormat format = getFormat(formatstr);
 SessionConfig sessionConfig = new SessionConfig(resultWriter, format, 
resultPrefix, resultPostfix);
 sessionConfig.set(SessionConfig.FORMAT_WRAPPER_ARRAY, true);
-boolean indentJson = 
Boolean.parseBoolean(request.getParameter(Parameter.INDENT.str()));
+boolean indentJson =

Change in asterixdb[master]: Index-only plan

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 16: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/106/ : 
UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1533) AsterixDB web UI query box background needs updating

2016-07-18 Thread Michael J. Carey (JIRA) 

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382921#comment-15382921
 ] 

Michael J. Carey commented on ASTERIXDB-1533:
-

I will get Ian to help me "do this myself" actually - great super-simple 
getting acquainted change.  (And I'll also catch up with him about the GSoC web 
UI status.)

> AsterixDB web UI query box background needs updating
> 
>
> Key: ASTERIXDB-1533
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1533
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Web Interface
> Environment: Current AsterixDB on any platform (in any browser :-))
>Reporter: Michael J. Carey
>Assignee: Michael J. Carey
>Priority: Critical
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> The background text in the empty query box says "Type your AQL query..."
> The "AQL" part should be dropped now that we support SQL++ too.
> :-)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (ASTERIXDB-1533) AsterixDB web UI query box background needs updating

2016-07-18 Thread Michael J. Carey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael J. Carey reassigned ASTERIXDB-1533:
---

Assignee: Michael J. Carey  (was: Ian Maxon)

> AsterixDB web UI query box background needs updating
> 
>
> Key: ASTERIXDB-1533
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1533
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Web Interface
> Environment: Current AsterixDB on any platform (in any browser :-))
>Reporter: Michael J. Carey
>Assignee: Michael J. Carey
>Priority: Critical
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> The background text in the empty query box says "Type your AQL query..."
> The "AQL" part should be dropped now that we support SQL++ too.
> :-)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Index-only plan

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 16:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/106/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-only plan

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 16:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-only plan

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1925/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-only plan

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 15:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-only plan

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1924/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: AsterixDB Schema Inferencer

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: AsterixDB Schema Inferencer
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/105/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1003
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6077216ba457a182e8034ed47536fc5f4dcb639
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: AsterixDB Schema Inferencer

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: AsterixDB Schema Inferencer
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/105/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1003
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6077216ba457a182e8034ed47536fc5f4dcb639
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: AsterixDB Schema Inferencer

2016-07-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: AsterixDB Schema Inferencer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1923/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1003
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6077216ba457a182e8034ed47536fc5f4dcb639
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: AsterixDB Schema Inferencer

2016-07-18 Thread Wail Alkowaileet (Code Review) 
Wail Alkowaileet has posted comments on this change.

Change subject: AsterixDB Schema Inferencer
..


Patch Set 1:

Can someone please delete this one submission ?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/832
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaf8ab8264f860509721f04f4f9230f279b82eab
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Sattam Alsubaiee 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No