Change in asterixdb[master]: Feed tutorial revise.
Jenkins has posted comments on this change. Change subject: Feed tutorial revise. .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/577/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1152 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110e2225a3036109bf58a9ef529407de955335ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-1609) TwitterParser does not parse closed-nullable fields.
[
https://issues.apache.org/jira/browse/ASTERIXDB-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469673#comment-15469673
]
Xikui Wang commented on ASTERIXDB-1609:
---
[~wyk]
:) You caught me right there. I realize that only after I almost finished the
current implementation. It turns out using ADMParser is totally reasonable and
easy. I just finished the patch for this and will submit it later.
As for the bug, I tried your ddl with ADMParser. Everything is fine in the
ingestion part, but I hit an IndexOutOfBoundsException. That's usually due to
NULL values. Did you try this DDL with ADMParser loading JSON?
> TwitterParser does not parse closed-nullable fields.
>
>
> Key: ASTERIXDB-1609
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1609
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: Data Model, Feeds
>Reporter: Wail Alkowaileet
>Assignee: Xikui Wang
>
> TwitterParser doesn't support types NULL/MISSING
> To reproduce, connect TwitterFeed using the defined type below. I
> roundtrip-ed it using load statement and it was successfully loaded.
> DDL:
> {noformat}
> drop dataverse feeds if exists;
> create dataverse feeds;
> use dataverse feeds;
> create type userType1 as open {
> 'utc_offset':int64?,
> 'friends_count':int64?,
> 'profile_image_url_https':string?,
> 'listed_count':int64?,
> 'profile_background_image_url':string?,
> 'default_profile_image':boolean?,
> 'favourites_count':int64?,
> 'description':string?,
> 'created_at':string?,
> 'is_translator':boolean?,
> 'profile_background_image_url_https':string?,
> 'protected':boolean?,
> 'screen_name':string?,
> 'id_str':string?,
> 'profile_link_color':string?,
> 'id':int64?,
> 'geo_enabled':boolean?,
> 'profile_background_color':string?,
> 'lang':string?,
> 'profile_sidebar_border_color':string?,
> 'profile_text_color':string?,
> 'verified':boolean?,
> 'profile_image_url':string?,
> 'time_zone':string?,
> 'contributors_enabled':boolean?,
> 'profile_background_tile':boolean?,
> 'profile_banner_url':string?,
> 'statuses_count':int64?,
> 'followers_count':int64?,
> 'profile_use_background_image':boolean?,
> 'default_profile':boolean?,
> 'name':string?,
> 'location':string?,
> 'profile_sidebar_fill_color':string?,
> 'url':string?
> }
> create type smallType1 as open {
> 'w':int64?,
> 'h':int64?,
> 'resize':string?
> }
> create type largeType1 as open {
> 'w':int64?,
> 'h':int64?,
> 'resize':string?
> }
> create type thumbType1 as open {
> 'w':int64?,
> 'h':int64?,
> 'resize':string?
> }
> create type mediumType1 as open {
> 'w':int64?,
> 'h':int64?,
> 'resize':string?
> }
> create type sizesType1 as open {
> 'small':smallType1?,
> 'large':largeType1?,
> 'thumb':thumbType1?,
> 'medium':mediumType1?
> }
> create type listType2 as open {
> 'content_type':string?,
> 'bitrate':int64?,
> 'url':string?
> }
> create type video_infoType1 as open {
> 'aspect_ratio':[int64]?,
> 'duration_millis':int64?,
> 'variants':[listType2]?
> }
> create type listType1 as open {
> 'display_url':string?,
> 'indices':[int64]?,
> 'sizes':sizesType1?,
> 'id_str':string?,
> 'expanded_url':string?,
> 'media_url_https':string?,
> 'id':int64?,
> 'type':string?,
> 'media_url':string?,
> 'url':string?,
> 'video_info':video_infoType1?,
> 'source_user_id':int64?,
> 'source_status_id':int64?,
> 'source_status_id_str':string?,
> 'source_user_id_str':string?
> }
> create type extended_entitiesType1 as open {
> 'media':[listType1]?
> }
> create type smallType2 as open {
> 'w':int64?,
> 'h':int64?,
> 'resize':string?
> }
> create type largeType2 as open {
> 'w':int64?,
> 'h':int64?,
> 'resize':string?
> }
> create type thumbType2 as open {
> 'w':int64?,
> 'h':int64?,
> 'resize':string?
> }
> create type mediumType2 as open {
> 'w':int64?,
> 'h':int64?,
> 'resize':string?
> }
> create type sizesType2 as open {
> 'small':smallType2?,
> 'large':largeType2?,
> 'thumb':thumbType2?,
> 'medium':mediumType2?
> }
> create type listType3 as open {
> 'display_url':string?,
> 'indices':[int64]?,
> 'sizes':sizesType2?,
> 'id_str':string?,
> 'expanded_url':string?,
> 'media_url_https':string?,
> 'id':int64?,
> 'type':string?,
> 'media_url':string?,
> 'url':string?,
> 'source_user_id':int64?,
> 'source_status_id':int64?,
> 'source_status_id_str':string?,
> 'source_user_id_str':string?
> }
> create type listType4 as open {
> 'display_url':string?
Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Till Westmann has posted comments on this change.
Change subject: Extend Cluster API Servlet, += Config / Stats
..
Patch Set 3:
(5 comments)
Looks good, just a question wrt the HTTP status code that gets returned, if the
URI does not identify a valid resource.
https://asterix-gerrit.ics.uci.edu/#/c/1147/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java:
Line 73: throw new IllegalArgumentException();
Shouldn't we just get a 404 here, ff the path (URL) is not valid?
Line 88: throw new IllegalArgumentException("unknown nc: " + node);
Same here?
Line 100: throw new IllegalArgumentException();
Or here?
Line 125: throw new IllegalArgumentException("unknown nc: " + node);
Or here?
https://asterix-gerrit.ics.uci.edu/#/c/1147/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:
Line 76: import static
org.apache.asterix.api.http.servlet.ServletConstants.HYRACKS_CONNECTION_ATTR;
Wow, these sure seem to be moving around :)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1147
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: Feed tutorial revise.
Jenkins has posted comments on this change. Change subject: Feed tutorial revise. .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/577/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1152 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110e2225a3036109bf58a9ef529407de955335ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Jenkins has posted comments on this change. Change subject: Extend Cluster API Servlet, += Config / Stats .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/576/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
[jira] [Closed] (ASTERIXDB-1581) Subquery inside case when clause - ConcurrentModificationException is thrown
[
https://issues.apache.org/jira/browse/ASTERIXDB-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yingyi Bu closed ASTERIXDB-1581.
Resolution: Fixed
Fixed with regression tests.
> Subquery inside case when clause - ConcurrentModificationException is thrown
>
>
> Key: ASTERIXDB-1581
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1581
> Project: Apache AsterixDB
> Issue Type: Bug
> Environment: Master branch with latest commit id:
> bd3a535b171a5cc7486175
>Reporter: Vignesh Raghunathan
>Assignee: Yingyi Bu
>Priority: Critical
> Labels: soon
> Attachments: tpcdsadb.txt
>
>
> To reproduce the issue run the following sqlpp query after creating the types
> and datasets in the attached file tpcdsadb:
> {code}
> select case when (select value count(ss)
> from store_sales ss
> where ss_quantity >= 1 and ss_quantity <= 20) > 25437
> then (select avg(ss_ext_discount_amt)
> from store_sales
> where ss_quantity >= 1 and ss_quantity <= 20)
> else (select avg(ss_net_profit)
> from store_sales
> where ss_quantity >= 1 and ss_quantity <= 20) end bucket1
> from reason
> where r_reason_sk = 1;
> {code}
> Result:
> {code}
> java.util.ConcurrentModificationException
> at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429)
> at java.util.HashMap$KeyIterator.next(HashMap.java:1453)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:640)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:183)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:126)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.AggregateOperator.accept(AggregateOperator.java:55)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitSingleInputOperator(InlineAllNtsInSubplanVisitor.java:690)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAssignOperator(InlineAllNtsInSubplanVisitor.java:469)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAssignOperator(InlineAllNtsInSubplanVisitor.java:126)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.AssignOperator.accept(AssignOperator.java:63)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitSingleInputOperator(InlineAllNtsInSubplanVisitor.java:690)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:635)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:183)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:126)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.AggregateOperator.accept(AggregateOperator.java:55)
> at
> org.apache.asterix.optimizer.rules.subplan.SubplanFlatteningUtil.inlineAllNestedTupleSource(SubplanFlatteningUtil.java:67)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.applyGeneralFlattening(InlineSubplanInputForNestedTupleSourceRule.java:351)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.rewriteSubplanOperator(InlineSubplanInputForNestedTupleSourceRule.java:291)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.traverseNonSubplanOperator(InlineSubplanInputForNestedTupleSourceRule.java:313)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.rewriteSubplanOperator(InlineSubplanInputForNestedTupleSourceRule.java:280)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.traverseNonSubplanOperator(InlineSubplanInputForNestedTupleSourceRule.java:313)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.rewriteSubplanOperator(InlineSubplanInputForNestedTupleSourceRule.java:280)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.traverseNonSubplanOperator(InlineSubplanInputForNestedTupleSourceRule.java:313)
> at
> org.apache.asterix.optimizer.rules.subpla
[jira] [Resolved] (ASTERIXDB-1352) RSS Adapter Missing
[
https://issues.apache.org/jira/browse/ASTERIXDB-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xikui Wang resolved ASTERIXDB-1352.
---
Resolution: Fixed
Fixed this in the tutorial change.
> RSS Adapter Missing
> ---
>
> Key: ASTERIXDB-1352
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1352
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: Adapters
>Reporter: Xikui Wang
>Assignee: Xikui Wang
>Priority: Trivial
>
> I found the RSS feed adaptor is not working properly when I was going through
> the documentation. I tried the rss feed example in the documentation page and
> I got following.
> {quote}
> SyntaxError:
> org.apache.hyracks.algebricks.common.exceptions.AlgebricksException: unable
> to create adapter
> {quote}
> The errors message:
> {quote}
> org.apache.hyracks.algebricks.common.exceptions.AlgebricksException: unable
> to create adapter
> at
> org.apache.asterix.metadata.feeds.FeedMetadataUtil.getPrimaryFeedFactoryAndOutput(FeedMetadataUtil.java:554)
> at
> org.apache.asterix.metadata.declared.AqlMetadataProvider.buildFeedIntakeRuntime(AqlMetadataProvider.java:617)
> at
> org.apache.asterix.app.external.FeedOperations.buildFeedIntakeJobSpec(FeedOperations.java:83)
> at
> org.apache.asterix.aql.translator.QueryTranslator.handleConnectFeedStatement(QueryTranslator.java:2201)
> at
> org.apache.asterix.aql.translator.QueryTranslator.compileAndExecute(QueryTranslator.java:367)
> at
> org.apache.asterix.aql.translator.QueryTranslator.compileAndExecute(QueryTranslator.java:253)
> at
> org.apache.asterix.api.http.servlet.APIServlet.doPost(APIServlet.java:148)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:546)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:483)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:228)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:956)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:411)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:188)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:891)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:114)
> at org.eclipse.jetty.server.Server.handle(Server.java:353)
> at
> org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:598)
> at
> org.eclipse.jetty.server.HttpConnection$RequestHandler.content(HttpConnection.java:1076)
> at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:805)
> at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:218)
> at
> org.eclipse.jetty.server.HttpConnection.handle(HttpConnection.java:427)
> at
> org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:510)
> at
> org.eclipse.jetty.io.nio.SelectChannelEndPoint.access$000(SelectChannelEndPoint.java:34)
> at
> org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:40)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:450)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: org.apache.asterix.common.exceptions.AsterixException: The
> parameter parser must be specified.
> at
> org.apache.asterix.external.util.ExternalDataUtils.validateParameters(ExternalDataUtils.java:89)
> at
> org.apache.asterix.external.provider.AdapterFactoryProvider.getAdapterFactory(AdapterFactoryProvider.java:44)
> at
> org.apache.asterix.metadata.feeds.FeedMetadataUtil.getPrimaryFeedFactoryAndOutput(FeedMetadataUtil.java:510)
> ... 28 more
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Change in asterixdb[master]: Feed tutorial revise.
Jenkins has posted comments on this change. Change subject: Feed tutorial revise. .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2541/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1152 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110e2225a3036109bf58a9ef529407de955335ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Feed tutorial revise.
Xikui Wang has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1152
Change subject: Feed tutorial revise.
..
Feed tutorial revise.
1. Fix 1352.
2. Revise the twitter feed part to work with the new tweet parser.
Change-Id: I110e2225a3036109bf58a9ef529407de955335ab
---
M asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md
1 file changed, 13 insertions(+), 15 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/52/1152/1
diff --git a/asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md
b/asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md
index 39e04b1..54bfaa5 100644
--- a/asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md
+++ b/asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md
@@ -61,22 +61,18 @@
create dataverse feeds;
use dataverse feeds;
-create type TwitterUser if not exists as open{
-screen_name: string,
-language: string,
-friends_count: int32,
-status_count: int32,
-name: string,
-followers_count: int32
+create type TwitterUser as closed{
+screen_name: string,
+lang: string,
+friends_count: int32,
+statuses_count: int32
};
-create type Tweet if not exists as open{
-id: string,
-user: TwitterUser,
-latitude:double,
-longitude:double,
-created_at:string,
-message_text:string
-};
+
+create type Tweet as open
+{
+ id: int64,
+ user: TwitterUser
+}
create dataset Tweets (Tweet)
primary key id;
@@ -103,6 +99,7 @@
create feed TwitterFeed if not exists using "push_twitter"
(("type-name"="Tweet"),
+ ("format"="twitter-status"),
("consumer.key"=""),
("consumer.secret"="**"),
("access.token"="**"),
@@ -185,6 +182,7 @@
create feed my_feed using
rss_feed (
("type-name"="Rss"),
+ ("format"="rss"),
("url"="http://rss.cnn.com/rss/edition.rss";)
);
--
To view, visit https://asterix-gerrit.ics.uci.edu/1152
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I110e2225a3036109bf58a9ef529407de955335ab
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang
[jira] [Commented] (ASTERIXDB-1581) Subquery inside case when clause - ConcurrentModificationException is thrown
[
https://issues.apache.org/jira/browse/ASTERIXDB-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469516#comment-15469516
]
ASF subversion and git services commented on ASTERIXDB-1581:
Commit c89d668f68e5430a6ba4455daf8f9cd6f7040dd8 in asterixdb's branch
refs/heads/master from [~buyingyi]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=c89d668 ]
ASTERIXDB-1581: fix subquery decorrelation.
- fix concurrent modification exception;
- fix variable substitution ordering;
- fix required partitioning property for DataSourceScan;
- fix partitioning property enforcer for nested operators;
- fix recursive subplan decorrelation;
- fix CardinalityInferenceVisitor;
- add a rule to switch inner join branches;
- fix SimpleUnnestToProductRule;
- add test cases which are variants of ASTERIXDB-1581.
Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1125
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Till Westmann
> Subquery inside case when clause - ConcurrentModificationException is thrown
>
>
> Key: ASTERIXDB-1581
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1581
> Project: Apache AsterixDB
> Issue Type: Bug
> Environment: Master branch with latest commit id:
> bd3a535b171a5cc7486175
>Reporter: Vignesh Raghunathan
>Assignee: Yingyi Bu
>Priority: Critical
> Labels: soon
> Attachments: tpcdsadb.txt
>
>
> To reproduce the issue run the following sqlpp query after creating the types
> and datasets in the attached file tpcdsadb:
> {code}
> select case when (select value count(ss)
> from store_sales ss
> where ss_quantity >= 1 and ss_quantity <= 20) > 25437
> then (select avg(ss_ext_discount_amt)
> from store_sales
> where ss_quantity >= 1 and ss_quantity <= 20)
> else (select avg(ss_net_profit)
> from store_sales
> where ss_quantity >= 1 and ss_quantity <= 20) end bucket1
> from reason
> where r_reason_sk = 1;
> {code}
> Result:
> {code}
> java.util.ConcurrentModificationException
> at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429)
> at java.util.HashMap$KeyIterator.next(HashMap.java:1453)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:640)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:183)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:126)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.AggregateOperator.accept(AggregateOperator.java:55)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitSingleInputOperator(InlineAllNtsInSubplanVisitor.java:690)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAssignOperator(InlineAllNtsInSubplanVisitor.java:469)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAssignOperator(InlineAllNtsInSubplanVisitor.java:126)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.AssignOperator.accept(AssignOperator.java:63)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitSingleInputOperator(InlineAllNtsInSubplanVisitor.java:690)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:635)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:183)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:126)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.AggregateOperator.accept(AggregateOperator.java:55)
> at
> org.apache.asterix.optimizer.rules.subplan.SubplanFlatteningUtil.inlineAllNestedTupleSource(SubplanFlatteningUtil.java:67)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.applyGeneralFlattening(InlineSubplanInputForNestedTupleSourceRule.java:351)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.rewriteSubplanOperator(InlineSubplanInputForNestedTupleSourceRule.java:291)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupl
[jira] [Assigned] (ASTERIXDB-1352) RSS Adapter Missing
[
https://issues.apache.org/jira/browse/ASTERIXDB-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xikui Wang reassigned ASTERIXDB-1352:
-
Assignee: Xikui Wang (was: Abdullah Alamoudi)
> RSS Adapter Missing
> ---
>
> Key: ASTERIXDB-1352
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1352
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: Adapters
>Reporter: Xikui Wang
>Assignee: Xikui Wang
>Priority: Trivial
>
> I found the RSS feed adaptor is not working properly when I was going through
> the documentation. I tried the rss feed example in the documentation page and
> I got following.
> {quote}
> SyntaxError:
> org.apache.hyracks.algebricks.common.exceptions.AlgebricksException: unable
> to create adapter
> {quote}
> The errors message:
> {quote}
> org.apache.hyracks.algebricks.common.exceptions.AlgebricksException: unable
> to create adapter
> at
> org.apache.asterix.metadata.feeds.FeedMetadataUtil.getPrimaryFeedFactoryAndOutput(FeedMetadataUtil.java:554)
> at
> org.apache.asterix.metadata.declared.AqlMetadataProvider.buildFeedIntakeRuntime(AqlMetadataProvider.java:617)
> at
> org.apache.asterix.app.external.FeedOperations.buildFeedIntakeJobSpec(FeedOperations.java:83)
> at
> org.apache.asterix.aql.translator.QueryTranslator.handleConnectFeedStatement(QueryTranslator.java:2201)
> at
> org.apache.asterix.aql.translator.QueryTranslator.compileAndExecute(QueryTranslator.java:367)
> at
> org.apache.asterix.aql.translator.QueryTranslator.compileAndExecute(QueryTranslator.java:253)
> at
> org.apache.asterix.api.http.servlet.APIServlet.doPost(APIServlet.java:148)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:546)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:483)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:228)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:956)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:411)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:188)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:891)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:114)
> at org.eclipse.jetty.server.Server.handle(Server.java:353)
> at
> org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:598)
> at
> org.eclipse.jetty.server.HttpConnection$RequestHandler.content(HttpConnection.java:1076)
> at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:805)
> at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:218)
> at
> org.eclipse.jetty.server.HttpConnection.handle(HttpConnection.java:427)
> at
> org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:510)
> at
> org.eclipse.jetty.io.nio.SelectChannelEndPoint.access$000(SelectChannelEndPoint.java:34)
> at
> org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:40)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:450)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: org.apache.asterix.common.exceptions.AsterixException: The
> parameter parser must be specified.
> at
> org.apache.asterix.external.util.ExternalDataUtils.validateParameters(ExternalDataUtils.java:89)
> at
> org.apache.asterix.external.provider.AdapterFactoryProvider.getAdapterFactory(AdapterFactoryProvider.java:44)
> at
> org.apache.asterix.metadata.feeds.FeedMetadataUtil.getPrimaryFeedFactoryAndOutput(FeedMetadataUtil.java:510)
> ... 28 more
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ASTERIXDB-1581) Subquery inside case when clause - ConcurrentModificationException is thrown
[
https://issues.apache.org/jira/browse/ASTERIXDB-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469517#comment-15469517
]
ASF subversion and git services commented on ASTERIXDB-1581:
Commit c89d668f68e5430a6ba4455daf8f9cd6f7040dd8 in asterixdb's branch
refs/heads/master from [~buyingyi]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=c89d668 ]
ASTERIXDB-1581: fix subquery decorrelation.
- fix concurrent modification exception;
- fix variable substitution ordering;
- fix required partitioning property for DataSourceScan;
- fix partitioning property enforcer for nested operators;
- fix recursive subplan decorrelation;
- fix CardinalityInferenceVisitor;
- add a rule to switch inner join branches;
- fix SimpleUnnestToProductRule;
- add test cases which are variants of ASTERIXDB-1581.
Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1125
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Till Westmann
> Subquery inside case when clause - ConcurrentModificationException is thrown
>
>
> Key: ASTERIXDB-1581
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1581
> Project: Apache AsterixDB
> Issue Type: Bug
> Environment: Master branch with latest commit id:
> bd3a535b171a5cc7486175
>Reporter: Vignesh Raghunathan
>Assignee: Yingyi Bu
>Priority: Critical
> Labels: soon
> Attachments: tpcdsadb.txt
>
>
> To reproduce the issue run the following sqlpp query after creating the types
> and datasets in the attached file tpcdsadb:
> {code}
> select case when (select value count(ss)
> from store_sales ss
> where ss_quantity >= 1 and ss_quantity <= 20) > 25437
> then (select avg(ss_ext_discount_amt)
> from store_sales
> where ss_quantity >= 1 and ss_quantity <= 20)
> else (select avg(ss_net_profit)
> from store_sales
> where ss_quantity >= 1 and ss_quantity <= 20) end bucket1
> from reason
> where r_reason_sk = 1;
> {code}
> Result:
> {code}
> java.util.ConcurrentModificationException
> at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429)
> at java.util.HashMap$KeyIterator.next(HashMap.java:1453)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:640)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:183)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:126)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.AggregateOperator.accept(AggregateOperator.java:55)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitSingleInputOperator(InlineAllNtsInSubplanVisitor.java:690)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAssignOperator(InlineAllNtsInSubplanVisitor.java:469)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAssignOperator(InlineAllNtsInSubplanVisitor.java:126)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.AssignOperator.accept(AssignOperator.java:63)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitSingleInputOperator(InlineAllNtsInSubplanVisitor.java:690)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:635)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:183)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineAllNtsInSubplanVisitor.visitAggregateOperator(InlineAllNtsInSubplanVisitor.java:126)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.AggregateOperator.accept(AggregateOperator.java:55)
> at
> org.apache.asterix.optimizer.rules.subplan.SubplanFlatteningUtil.inlineAllNestedTupleSource(SubplanFlatteningUtil.java:67)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.applyGeneralFlattening(InlineSubplanInputForNestedTupleSourceRule.java:351)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupleSourceRule.rewriteSubplanOperator(InlineSubplanInputForNestedTupleSourceRule.java:291)
> at
> org.apache.asterix.optimizer.rules.subplan.InlineSubplanInputForNestedTupl
[jira] [Resolved] (ASTERIXDB-1567) Add upsert option for Feed Ingestion
[ https://issues.apache.org/jira/browse/ASTERIXDB-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xikui Wang resolved ASTERIXDB-1567. --- Resolution: Fixed Fixed in the updated patch. > Add upsert option for Feed Ingestion > > > Key: ASTERIXDB-1567 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1567 > Project: Apache AsterixDB > Issue Type: Improvement >Reporter: Xikui Wang >Assignee: Xikui Wang > > Allow feed ingestion to use upsert for processing incoming records. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ASTERIXDB-1394) TweetParser can only take dataset with specific fields in specific order
[
https://issues.apache.org/jira/browse/ASTERIXDB-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xikui Wang resolved ASTERIXDB-1394.
---
Resolution: Fixed
> TweetParser can only take dataset with specific fields in specific order
>
>
> Key: ASTERIXDB-1394
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1394
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: Adapters
>Reporter: Xikui Wang
>Assignee: Xikui Wang
>Priority: Minor
>
> The TweetParser can only take dataset definition with specific order as
> follow:
> {quote}
> create type Tweet if not exists as open\{
> id: string,
> user: TwitterUser,
> latitude:double,
> longitude:double,
> created_at:string,
> message_text:string
> \};
> {quote}
> Different order will cause type cast exception since the order is fixed in
> code. Also the names of field and number is also fixed, no more or less.
> Also Tweet cannot have extra field, and extra field will cause
> ArrayIndexOutOfBoundsException in IDataParser.writeRecord
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Till Westmann has submitted this change and it was merged. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. ASTERIXDB-1581: fix subquery decorrelation. - fix concurrent modification exception; - fix variable substitution ordering; - fix required partitioning property for DataSourceScan; - fix partitioning property enforcer for nested operators; - fix recursive subplan decorrelation; - fix CardinalityInferenceVisitor; - add a rule to switch inner join branches; - fix SimpleUnnestToProductRule; - add test cases which are variants of ASTERIXDB-1581. Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Reviewed-on: https://asterix-gerrit.ics.uci.edu/1125 Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Till Westmann --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanFlatteningUtil.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-2.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-3.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581-correlated.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581.sqlpp M asterixdb/asterix-app/src/test/resources/optimizerts/results/filter-nested.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-2.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-3.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/nest_aggregate.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1018.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1019.plan A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_s
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. Patch Set 11: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Jenkins has posted comments on this change. Change subject: Extend Cluster API Servlet, += Config / Stats .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/576/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. Patch Set 11: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/574/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Jenkins has posted comments on this change. Change subject: Extend Cluster API Servlet, += Config / Stats .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1147 to look at the new patch set (#3). Change subject: Extend Cluster API Servlet, += Config / Stats .. Extend Cluster API Servlet, += Config / Stats New APIs to return NC stats & configs, discoverable URIs returned as part of /admin/cluster. Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterAPIServlet.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/AsterixClusterProperties.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceRemoteProxy.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/NodesRESTAPIFunction.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeDetailsJSONWork.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NodeRegistration.java A hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/PidHelper.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java 17 files changed, 426 insertions(+), 76 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/47/1147/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Jenkins has posted comments on this change. Change subject: Extend Cluster API Servlet, += Config / Stats .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2540/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Jenkins has posted comments on this change. Change subject: Extend Cluster API Servlet, += Config / Stats .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/575/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Add upsert option for feed
Michael Blow has posted comments on this change. Change subject: Add upsert option for feed .. Patch Set 13: Code-Review+1 Would like Abdullah to review as well. -- To view, visit https://asterix-gerrit.ics.uci.edu/1068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5133e7c6941fea4110cc9983f99502f364dc810 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Jenkins has posted comments on this change. Change subject: Extend Cluster API Servlet, += Config / Stats .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Jenkins has posted comments on this change. Change subject: Extend Cluster API Servlet, += Config / Stats .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2539/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1147 to look at the new patch set (#2). Change subject: Extend Cluster API Servlet, += Config / Stats .. Extend Cluster API Servlet, += Config / Stats New APIs to return NC stats & configs, discoverable URIs returned as part of /admin/cluster. Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterAPIServlet.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/AsterixClusterProperties.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceRemoteProxy.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/NodesRESTAPIFunction.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeDetailsJSONWork.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NodeRegistration.java A hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/PidHelper.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java 17 files changed, 426 insertions(+), 76 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/47/1147/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. Patch Set 11: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/574/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2538/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. Patch Set 10: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/573/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. Patch Set 11: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2537/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1125 to look at the new patch set (#11). Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. ASTERIXDB-1581: fix subquery decorrelation. - fix concurrent modification exception; - fix variable substitution ordering; - fix required partitioning property for DataSourceScan; - fix partitioning property enforcer for nested operators; - fix recursive subplan decorrelation; - fix CardinalityInferenceVisitor; - add a rule to switch inner join branches; - fix SimpleUnnestToProductRule; - add test cases which are variants of ASTERIXDB-1581. Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanFlatteningUtil.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-2.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-3.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581-correlated.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581.sqlpp M asterixdb/asterix-app/src/test/resources/optimizerts/results/filter-nested.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-2.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-3.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/nest_aggregate.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1018.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1019.plan A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-A
Change in asterixdb[master]: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By ...
Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By to conform to the memory budget .. Patch Set 9: (19 comments) Some high level comments: 1. The accounting of memory budget is still based on #Frames instead of #Bytes? How does the Big Object case get handled? 2. IMO, GC should be internal to SerializableHashTable. SerializableHashTable itself can decide whether to do GC or not in insert/delete based on a certain policy, e.g., memory is full in the last N calls and the ratio of wasted space is higher than some threshold. 3. I don't recall the exact reason why an additional parameter compiler.grouphashtablememory is needed. If it is really needed, we'd better audit in AsterixCompilerProperties.getGroupHashTableMemorySize(), e.g., it couldn't go beyond an certain upper bound calculated from compiler.groupmemory, assuming each tuple only have one int8 field payload (which is the worst case). 4. It seems that the GC code in SerializableHashTable could be simplified, using Arrays.fill(...). ByteBuffer.writeXXX() is not as efficient as direct bytes reads/writes. 5. The GC policy and GC implementation needs to be tested more thoroughly, probably using MockIto. Especially, we might want to make sure the GC code is not run too often. 6. This change should better be perf-tested as it will impact Hash Join performance as well (I guess). One possibility could be to run Jianfeng's Micro-benchmark that he used for the Big Object change to contrast the versions with/without this change. 7. Address SonarQube comments as much as possible, e.g., useless assignments and useless parens. https://asterix-gerrit.ics.uci.edu/#/c/1056/9/asterixdb/asterix-docker/docker/asterix-configuration.xml File asterixdb/asterix-docker/docker/asterix-configuration.xml: Line 251: more efficiently using pointers. Actual Group-by value is stored in data table. "Group-by value" -> "aggregate values" Line 253: the same as the given value divided by 40 bytes. (E.g., 16MB / 40 = 419,430). Can you add the explanation of why 40 is the number into the comments? https://asterix-gerrit.ics.uci.edu/#/c/1056/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java: Line 91: final ITuplePartitionComputer tpc1 = new FieldHashPartitionComputerFamily(intermediateResultKeys, better variable name. e.g., tpcIntermediate https://asterix-gerrit.ics.uci.edu/#/c/1056/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/ISpillableTable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/ISpillableTable.java: Line 55: * @return annotate @return. https://asterix-gerrit.ics.uci.edu/#/c/1056/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/external/ExternalHashGroupBy.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/external/ExternalHashGroupBy.java: Line 79: result = table.insert(accessor, i); flip the else branch as the if branch, and hence not nest more than 4 levels. https://asterix-gerrit.ics.uci.edu/#/c/1056/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/ISerializableTable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/ISerializableTable.java: Line 43: boolean isGarbageCollectioNeeded(); This method is never called. Do we really need it? Line 46: throws HyracksDataException; Why does this need to be expose to the outside? It seems to be that this should be internal to this HashTable and automatically invoked in the insert/delete calls from time to time. https://asterix-gerrit.ics.uci.edu/#/c/1056/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java: Line 47: private static int INVALID_VALUE = -1; 1. static final 2. can we write -1 as 0x, such that you can use arrays.fill(...) instead of ByteBuffer.writeInt(...), which is more convenient and more efficient? Line 68: int nextSlotIntPosInPageForGC = 0; Why do ***GC need to class fields instead of local variables? It seems to me that they are all local to the GC procedure. It seems tthat the GC procedure stops any insert/delete and can be stateless. Line 262:
Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates. .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/572/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1151 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. Patch Set 10: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/573/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. Patch Set 10: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2536/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Yingyi Bu has posted comments on this change.
Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..
Patch Set 9:
(5 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1125/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IDataSource.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IDataSource.java:
Line 36: public boolean isScanAccessPathALeaf();
> I think that we should keep the comment until the issue is fixed.
Done
https://asterix-gerrit.ics.uci.edu/#/c/1125/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/CardinalityInferenceVisitor.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/CardinalityInferenceVisitor.java:
Line 84: private static final long ZERO_OR_ONE = 0L;
> Not an issue, just a question: Why are these long values?
Hopefully the visitor can be enhanced to do "real" cardinality estimation where
a long value is needed...
However, currently it only does simple "symbolic executions"... I can turn
this down to a byte.
https://asterix-gerrit.ics.uci.edu/#/c/1125/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java:
Line 273: long cardinality = operator.accept(visitor, null);
> inline like above?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1125/9/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SimpleUnnestToProductRule.java
File
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SimpleUnnestToProductRule.java:
Line 60: if (!(op2 instanceof AbstractScanOperator) &&
!descOrSelfIsSourceScan(op2)) {
> It's not part of this change, but why do we need an instanceof here. Can't
Done
Line 152: && op.getOperatorTag() != LogicalOperatorTag.UNNEST) {
> It seems that the 2nd condition is always true, if the first condition is t
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: Yingyi Bu
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1125 to look at the new patch set (#10). Change subject: ASTERIXDB-1581: fix subquery decorrelation. .. ASTERIXDB-1581: fix subquery decorrelation. - fix concurrent modification exception; - fix variable substitution ordering; - fix required partitioning property for DataSourceScan; - fix partitioning property enforcer for nested operators; - fix recursive subplan decorrelation; - fix CardinalityInferenceVisitor; - add a rule to switch inner join branches; - fix SimpleUnnestToProductRule; - add test cases which are variants of ASTERIXDB-1581. Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanFlatteningUtil.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-2.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-3.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581-correlated.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581.sqlpp M asterixdb/asterix-app/src/test/resources/optimizerts/results/filter-nested.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-2.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-3.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/nest_aggregate.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1018.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1019.plan A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-A
Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates. .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/572/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1151 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates. .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2535/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1151 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.
Preston Carman has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1151
Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..
ASTERIXDB-1635 Fix for overlap-bins start for dates.
Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
---
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/temporal/overlap_bins/overlap_bins.3.ast
M asterixdb/asterix-doc/src/site/markdown/aql/functions.md
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DateTimeFormatUtils.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DurationArithmeticOperations.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/OverlapBinsDescriptor.java
8 files changed, 145 insertions(+), 127 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/51/1151/1
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
index 8011ad6..bfb5527 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
@@ -25,5 +25,5 @@
let $itv2 := interval(date("1984-03-17"), date("2013-08-22"))
let $itv3 := interval(datetime("1800-01-01T23:59:48.938"),
datetime("2015-07-26T13:28:30.218"))
return { "timebins": overlap-bins($itv1, time("00:00:00"),
day-time-duration("PT30M")),
- "datebins": overlap-bins($itv2, date("1990-01-01"),
year-month-duration("P20Y")),
+ "datebins": overlap-bins($itv2, date("1990-01-01"),
year-month-duration("P10Y")),
"datetimebins": overlap-bins($itv3,
datetime("1900-01-01T00:00:00.000"), year-month-duration("P100Y")) }
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
index e42707f..90cd95e 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
@@ -22,6 +22,6 @@
**/
{
'timebins':`overlap-bins`(interval(time('17:23:37'),time('18:30:21')),time('00:00:00'),`day-time-duration`('PT30M')),
-
'datebins':`overlap-bins`(interval(date('1984-03-17'),date('2013-08-22')),date('1990-01-01'),`year-month-duration`('P20Y')),
+
'datebins':`overlap-bins`(interval(date('1984-03-17'),date('2013-08-22')),date('1990-01-01'),`year-month-duration`('P10Y')),
'datetimebins':`overlap-bins`(interval(datetime('1800-01-01T23:59:48.938'),datetime('2015-07-26T13:28:30.218')),datetime('1900-01-01T00:00:00.000'),
`year-month-duration`('P100Y'))};
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
index 493a1ca..14f6aae 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
@@ -1 +1 @@
-{ "timebins": [ interval(time("17:00:00.000Z"), time("17:30:00.000Z")),
interval(time("17:30:00.000Z"), time("18:00:00.000Z")),
interval(time("18:00:00.000Z"), time("18:30:00.000Z")),
interval(time("18:30:00.000Z"), time("19:00:00.000Z")) ], "datebins": [
interval(date("1970-01-01"), date("1990-01-01")), interval(date("1990-01-01"),
date("2010-01-01")), interval(date("2010-01-01"), date("2030-01-01")) ],
"datetimebins": [ interval(datetime("1800-01-01T00:00:00.000Z"),
datetime("1900-01-01T00:00:00.000Z")),
interval(datetime("1900-01-01T00:00:00.000Z"),
datetime("2000-01-01T00:00:00.000Z")),
interval(datetime("2000-01-01T00:00:00.000Z"),
datetime("2100-01-01T00:00:00.000Z")) ] }
+{ "timebins": [ interval(time("17:00:00.000Z"), time("17:30:00.000Z")),
interval(time("17:30:00.000Z"), time("18:00:00.000Z")),
interval(time("18:00:00.000Z"), time("18:30:00.000Z")),
interval(time("18:30:00.000Z"), time("19:00:00.000Z")) ], "datebins": [
interval(date("1980-01-01"), date("1990-01-01")), interval(date("19
[jira] [Created] (ASTERIXDB-1635) Overlap-bins does not start at the correct bin for dates
Preston Carman created ASTERIXDB-1635:
-
Summary: Overlap-bins does not start at the correct bin for dates
Key: ASTERIXDB-1635
URL: https://issues.apache.org/jira/browse/ASTERIXDB-1635
Project: Apache AsterixDB
Issue Type: Bug
Reporter: Preston Carman
Assignee: Preston Carman
Priority: Minor
Using the example on the documentation, I changed the date overlap-bins to use
10 years. The change now produces the wrong result. The result starts from 1970
instead of the correct year.
The issue is because the days are not converted to ms when picking the starting
bin.
Sample query:
{noformat}
let $itv1 := interval(time("17:23:37"), time("18:30:21"))
let $itv2 := interval(date("1984-03-17"), date("2013-08-22"))
let $itv3 := interval(datetime("1800-01-01T23:59:48.938"),
datetime("2015-07-26T13:28:30.218"))
return { "timebins": overlap-bins($itv1, time("00:00:00"),
day-time-duration("PT30M")),
"datebins": overlap-bins($itv2, date("1990-01-01"),
year-month-duration("P10Y")),
"datetimebins": overlap-bins($itv3, datetime("1900-01-01T00:00:00.000"),
year-month-duration("P100Y")) }
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.
Till Westmann has posted comments on this change.
Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..
Patch Set 9:
(5 comments)
Just a few comments.
https://asterix-gerrit.ics.uci.edu/#/c/1125/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IDataSource.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IDataSource.java:
Line 36: public boolean isScanAccessPathALeaf();
I think that we should keep the comment until the issue is fixed.
https://asterix-gerrit.ics.uci.edu/#/c/1125/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/CardinalityInferenceVisitor.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/CardinalityInferenceVisitor.java:
Line 84: private static final long ZERO_OR_ONE = 0L;
Not an issue, just a question: Why are these long values?
https://asterix-gerrit.ics.uci.edu/#/c/1125/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java:
Line 273: long cardinality = operator.accept(visitor, null);
inline like above?
https://asterix-gerrit.ics.uci.edu/#/c/1125/9/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SimpleUnnestToProductRule.java
File
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SimpleUnnestToProductRule.java:
Line 60: if (!(op2 instanceof AbstractScanOperator) &&
!descOrSelfIsSourceScan(op2)) {
It's not part of this change, but why do we need an instanceof here. Can't we
decide this based on the operator tag?
Line 152: && op.getOperatorTag() != LogicalOperatorTag.UNNEST) {
It seems that the 2nd condition is always true, if the first condition is true.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: Access To Node Configuration & Statistics
Till Westmann has posted comments on this change.
Change subject: Access To Node Configuration & Statistics
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java
File
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java:
Line 291: if (includeConfig) {
> Is the existing HTTP API documented somewhere? I can update that. A test
It's probably not documented anywhere. Maybe we should start a doc?
--
To view, visit https://asterix-gerrit.ics.uci.edu/1147
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: Access To Node Configuration & Statistics
Michael Blow has posted comments on this change.
Change subject: Access To Node Configuration & Statistics
..
Patch Set 1:
(7 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:
Line 242: ServletMapping mapping = new ServletMapping();
> What does this add?
This enables a servlet to be mapped to multiple paths.
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java
File
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java:
Line 34: import org.json.JSONObject;
> Would be nice not to have a dependency on JSONObject in this interface.
Done
Line 197: *@param includeConfig @return {@link JSONObject} containing the
node details
> WS
Done
Line 200: public String getNodeDetailsJSON(String nodeId, boolean
includeStats, boolean includeConfig) throws Exception;
> It seems that we don't use this method. Do we need to expose it on the Hyra
The next patch will introduce a usage, sorry.
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java
File
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java:
Line 59: public String getNodeDetailsJSON(String nodeId, boolean
includeStats, boolean includeConfig) throws Exception;
> This also seems to be unused.
The next patch will introduce a usage, sorry.
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java
File
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java:
Line 291: if (includeConfig) {
> How do I access add this information from the HTTP API? Do we have docs/a t
Is the existing HTTP API documented somewhere? I can update that. A test is
forthcoming.
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeDetailsJSONWork.java
File
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeDetailsJSONWork.java:
Line 56: detail = ncs.toDetailedJSON(includeStats, includeConfig);
> Conditional expression?
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1147
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: Added BAD as an extension to Asterix
Jenkins has posted comments on this change. Change subject: Added BAD as an extension to Asterix .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2534/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Added BAD as an extension to Asterix
Steven Jacobs has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1150 Change subject: Added BAD as an extension to Asterix .. Added BAD as an extension to Asterix Users can create and delete repetitive channels Users can subscribe to and unsubscribe from channels Users can create and drop brokers Added Channel Tests Additional Changes: Allow commits to be non-sink operators (contnue job pipeline after commit) Enhanced Insert AQL Added "return records" and "returning [fieldName]" "return records" returns to the user all records that were inserted "returning [fieldName]" returns only the valuse inserted for [fieldName] Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 --- M .gitignore M asterixdb/asterix-active/pom.xml M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/CommitOperator.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitPOperator.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntimeFactory.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/UpsertCommitRuntime.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceStaticTypeCastForInsertRule.java R asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableFuncExpr.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java A asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/dml/insert-return-records/insert-return-records.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/dml/insert-returning-fieldname/insert-returning-fieldname.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml R asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IActiveLifecycleEventSubscriber.java R asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/watch/FeedActivity.java A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/watch/FeedActivityDetails.java M asterixdb/asterix
[jira] [Created] (ASTERIXDB-1634) LangRecordParseUtil.exprToStringLiteral only supports string values
Till created ASTERIXDB-1634: --- Summary: LangRecordParseUtil.exprToStringLiteral only supports string values Key: ASTERIXDB-1634 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1634 Project: Apache AsterixDB Issue Type: Bug Components: AsterixDB, Translator - AQL Reporter: Till Assignee: Abdullah Alamoudi LangRecordParseUtil.exprToStringLiteral is used to create records for record literals (record constructors that only contain literal leaves) that are provided in the query language, e.g. to provide parameters for DDL statements. However, right now this method only supports string literals as leaves. To provide configuration information, numbers or booleans should be supported as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Jenkins has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/571/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Assigned] (ASTERIXDB-1632) Query having subquery referring to with clause returns incorrect results
[
https://issues.apache.org/jira/browse/ASTERIXDB-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yingyi Bu reassigned ASTERIXDB-1632:
Assignee: Yingyi Bu
> Query having subquery referring to with clause returns incorrect results
>
>
> Key: ASTERIXDB-1632
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1632
> Project: Apache AsterixDB
> Issue Type: Bug
> Environment: Master branch with latest commit 2b95d9ac95aa6f4dd847
>Reporter: Vignesh Raghunathan
>Assignee: Yingyi Bu
>
> To reproduce the issue, run the following sqlpp statements:
> {code}
> drop dataverse sampdb if exists;
> create dataverse sampdb;
> use sampdb;
> drop dataset samptable if exists;
> drop type samptabletype if exists;
> create type samptabletype as closed {
> id: int8
> };
> create dataset samptable(samptabletype) primary key id;
> insert into samptable ({'id' : 1});
> insert into samptable ({'id' : 2});
> insert into samptable ({'id' : 3});
> with samptab as (
> select id from samptable
> )
> select st1.id
> from samptab st1
> where st1.id > (select value avg(st2.id) from samptab st2);
> {code}
> The query doesn't return {id:3}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (ASTERIXDB-1632) Query having subquery referring to with clause returns incorrect results
[
https://issues.apache.org/jira/browse/ASTERIXDB-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yingyi Bu closed ASTERIXDB-1632.
Resolution: Not A Problem
> Query having subquery referring to with clause returns incorrect results
>
>
> Key: ASTERIXDB-1632
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1632
> Project: Apache AsterixDB
> Issue Type: Bug
> Environment: Master branch with latest commit 2b95d9ac95aa6f4dd847
>Reporter: Vignesh Raghunathan
>Assignee: Yingyi Bu
>
> To reproduce the issue, run the following sqlpp statements:
> {code}
> drop dataverse sampdb if exists;
> create dataverse sampdb;
> use sampdb;
> drop dataset samptable if exists;
> drop type samptabletype if exists;
> create type samptabletype as closed {
> id: int8
> };
> create dataset samptable(samptabletype) primary key id;
> insert into samptable ({'id' : 1});
> insert into samptable ({'id' : 2});
> insert into samptable ({'id' : 3});
> with samptab as (
> select id from samptable
> )
> select st1.id
> from samptab st1
> where st1.id > (select value avg(st2.id) from samptab st2);
> {code}
> The query doesn't return {id:3}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ASTERIXDB-1632) Query having subquery referring to with clause returns incorrect results
[
https://issues.apache.org/jira/browse/ASTERIXDB-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468198#comment-15468198
]
Yingyi Bu commented on ASTERIXDB-1632:
--
[~vignesh.raghunathan], this is expected -- any SELECT subquery in SQL++
returns a collection instead of a scalar value.
Also, comparing un-comparable types returns a null, for instance:
1>[1];
returns null.
Hence, the where filter in your query always return null and all input tuples
are dis-qualified.
For your query, you might want to say:
with samptab as (
select id from samptable
)
select st1.id
from samptab st1
where st1.id > (select value avg(st2.id) from samptab st2)[0];
> Query having subquery referring to with clause returns incorrect results
>
>
> Key: ASTERIXDB-1632
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1632
> Project: Apache AsterixDB
> Issue Type: Bug
> Environment: Master branch with latest commit 2b95d9ac95aa6f4dd847
>Reporter: Vignesh Raghunathan
>
> To reproduce the issue, run the following sqlpp statements:
> {code}
> drop dataverse sampdb if exists;
> create dataverse sampdb;
> use sampdb;
> drop dataset samptable if exists;
> drop type samptabletype if exists;
> create type samptabletype as closed {
> id: int8
> };
> create dataset samptable(samptabletype) primary key id;
> insert into samptable ({'id' : 1});
> insert into samptable ({'id' : 2});
> insert into samptable ({'id' : 3});
> with samptab as (
> select id from samptable
> )
> select st1.id
> from samptab st1
> where st1.id > (select value avg(st2.id) from samptab st2);
> {code}
> The query doesn't return {id:3}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Change in asterixdb[master]: Small Cleanup
Michael Blow has submitted this change and it was merged.
Change subject: Small Cleanup
..
Small Cleanup
Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1145
Tested-by: Jenkins
Reviewed-by: Michael Blow
Integration-Tests: Jenkins
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/LookupAdapterFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IAdapterFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReaderFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/SocketClientInputStreamFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/RecordWithPKTestReaderFactory.java
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
M
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
14 files changed, 143 insertions(+), 60 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified; Verified
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
index c8a9566..5df687a 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
@@ -38,7 +38,6 @@
import
org.apache.asterix.common.ioopcallbacks.LSMBTreeIOOperationCallbackFactory;
import
org.apache.asterix.common.ioopcallbacks.LSMBTreeWithBuddyIOOperationCallbackFactory;
import
org.apache.asterix.common.ioopcallbacks.LSMRTreeIOOperationCallbackFactory;
-import org.apache.asterix.runtime.util.AsterixRuntimeComponentsProvider;
import
org.apache.asterix.dataflow.data.nontagged.valueproviders.AqlPrimitiveValueProviderFactory;
import org.apache.asterix.external.api.IAdapterFactory;
import org.apache.asterix.external.indexing.ExternalFile;
@@ -71,6 +70,7 @@
import org.apache.asterix.om.types.IAType;
import org.apache.asterix.om.util.NonTaggedFormatUtil;
import org.apache.asterix.runtime.util.AsterixAppContextInfo;
+import org.apache.asterix.runtime.util.AsterixRuntimeComponentsProvider;
import
org.apache.asterix.transaction.management.opcallbacks.SecondaryIndexOperationTrackerProvider;
import
org.apache.asterix.transaction.management.resource.ExternalBTreeLocalResourceMetadata;
import
org.apache.asterix.transaction.management.resource.PersistentLocalResourceFactoryProvider;
@@ -90,6 +90,7 @@
import org.apache.hyracks.api.dataflow.value.ISerializerDeserializer;
import org.apache.hyracks.api.dataflow.value.ITypeTraits;
import org.apache.hyracks.api.dataflow.value.RecordDescriptor;
+import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.job.JobSpecification;
import org.apache.hyracks.dataflow.std.file.IFileSplitProvider;
import org.apache.hyracks.storage.am.common.api.IPrimitiveValueProviderFactory;
@@ -255,13 +256,15 @@
* @param files
* @param indexerDesc
* @return
- * @throws AsterixException
+ * @throws AlgebricksException
+ * @throws HyracksDataException
* @throws Exception
*/
private static Pair
getExternalDataIndexingOperator(
AqlMetadataProvider metadataProvider, JobSpecification
jobSpec, IAType itemType, Dataset dataset,
-List files, RecordDescriptor indexerDesc)
throws AsterixException {
+List files, RecordDescriptor indexerDesc)
+throws HyracksDataException, AlgebricksException {
ExternalDatasetDetails externalDatasetDetails =
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Jenkins has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/571/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-1633) Tests for scan after restart
Ian Maxon created ASTERIXDB-1633: Summary: Tests for scan after restart Key: ASTERIXDB-1633 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1633 Project: Apache AsterixDB Issue Type: Bug Reporter: Ian Maxon Assignee: Ian Maxon We should have tests that try to scan a non-trivial amount of data, with and without filters, after restart. This should stop issues like ASTERIXDB-1534 from happening undetected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Jenkins has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Jenkins has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2533/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1148 to look at the new patch set (#3). Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Small Cleanup Towards Fixing LifeCycle Issues Before this change, dataset lifecycle manager was providing a set of functionalities that are loosly related to management of datasets and indexes. However, it was not clear what the possible states of a dataset or an index and what is the responsibility of each object. This change takes the first step towards fixing this area. Indexes of a dataset are now grouped together under a single lifecycle class A resource aka dataset must be created outside the lifecycle manager and registered with it before it can be assigned resources (memory) and before it can be used by any operation. This is still not the case. Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 --- M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActiveManagerMessage.java M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActivePartitionMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContextProviderForRecovery.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IAsterixAppRuntimeContext.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicyFactory.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfo.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycle.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetVirtualBufferCaches.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/IndexInfo.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/Info.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java D asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/AbstractApplicationMessage.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/IApplicationMessage.java D asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/IApplicationMessageCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/ICCMessageBroker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IAsterixAppRuntimeContextProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/AbstractFailbackPlanMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/CompleteFailbackRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/CompleteFailbackResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/PreparePartitionsFailbackRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/PreparePartitionsFailbackResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReplicaEventMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportMaxResourceIdMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportMaxResourceIdRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ResourceIdRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ResourceIdRequestResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/r
Change in asterixdb[master]: Access To Node Configuration & Statistics
Till Westmann has posted comments on this change.
Change subject: Access To Node Configuration & Statistics
..
Patch Set 1:
(7 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:
Line 242: ServletMapping mapping = new ServletMapping();
What does this add?
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java
File
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java:
Line 34: import org.json.JSONObject;
Would be nice not to have a dependency on JSONObject in this interface.
Line 197: *@param includeConfig @return {@link JSONObject} containing the
node details
WS
Line 200: public String getNodeDetailsJSON(String nodeId, boolean
includeStats, boolean includeConfig) throws Exception;
It seems that we don't use this method. Do we need to expose it on the Hyracks
client connection? Is this access useful for extensions?
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java
File
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java:
Line 59: public String getNodeDetailsJSON(String nodeId, boolean
includeStats, boolean includeConfig) throws Exception;
This also seems to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java
File
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java:
Line 291: if (includeConfig) {
How do I access add this information from the HTTP API? Do we have docs/a test?
https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeDetailsJSONWork.java
File
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeDetailsJSONWork.java:
Line 56: detail = ncs.toDetailedJSON(includeStats, includeConfig);
Conditional expression?
--
To view, visit https://asterix-gerrit.ics.uci.edu/1147
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Jenkins has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Jenkins has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2532/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1148 to look at the new patch set (#2). Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Small Cleanup Towards Fixing LifeCycle Issues Before this change, dataset lifecycle manager was providing a set of functionalities that are loosly related to management of datasets and indexes. However, it was not clear what the possible states of a dataset or an index and what is the responsibility of each object. This change takes the first step towards fixing this area. Indexes of a dataset are now grouped together under a single lifecycle class A resource aka dataset must be created outside the lifecycle manager and registered with it before it can be assigned resources (memory) and before it can be used by any operation. This is still not the case. Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 --- M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActiveManagerMessage.java M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActivePartitionMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContextProviderForRecovery.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IAsterixAppRuntimeContext.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicyFactory.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfo.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycle.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetVirtualBufferCaches.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/IndexInfo.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/Info.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java D asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/AbstractApplicationMessage.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/IApplicationMessage.java D asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/IApplicationMessageCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/ICCMessageBroker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IAsterixAppRuntimeContextProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/AbstractFailbackPlanMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/CompleteFailbackRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/CompleteFailbackResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/PreparePartitionsFailbackRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/PreparePartitionsFailbackResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReplicaEventMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportMaxResourceIdMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportMaxResourceIdRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ResourceIdRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ResourceIdRequestResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/r
Change in asterixdb[master]: Small Cleanup
Jenkins has posted comments on this change. Change subject: Small Cleanup .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/570/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1145 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Jenkins has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/569/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup
Michael Blow has posted comments on this change. Change subject: Small Cleanup .. Patch Set 2: Code-Review+2 If we don't like the SQ error with labels, we could extract a method for the outer loop. -- To view, visit https://asterix-gerrit.ics.uci.edu/1145 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup
Jenkins has posted comments on this change. Change subject: Small Cleanup .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/570/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1145 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: PLEASE EDIT to provide a meaningful commit message!
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1149
Change subject: PLEASE EDIT to provide a meaningful commit message!
..
PLEASE EDIT to provide a meaningful commit message!
The following commits from your working branch will be included:
commit 7f7a592ab3f5decaee50326704fbfd082c9a7267
Author: Abdullah Alamoudi
Date: Sun Sep 4 01:05:41 2016 +0300
Small Cleanup
Change-Id: I7fdc43c6aed99cab7aedb1d900c0b8725abd7892
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/LookupAdapterFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IAdapterFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReaderFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/SocketClientInputStreamFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/RecordWithPKTestReaderFactory.java
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
M
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
14 files changed, 143 insertions(+), 60 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/49/1149/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
index c8a9566..5df687a 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
@@ -38,7 +38,6 @@
import
org.apache.asterix.common.ioopcallbacks.LSMBTreeIOOperationCallbackFactory;
import
org.apache.asterix.common.ioopcallbacks.LSMBTreeWithBuddyIOOperationCallbackFactory;
import
org.apache.asterix.common.ioopcallbacks.LSMRTreeIOOperationCallbackFactory;
-import org.apache.asterix.runtime.util.AsterixRuntimeComponentsProvider;
import
org.apache.asterix.dataflow.data.nontagged.valueproviders.AqlPrimitiveValueProviderFactory;
import org.apache.asterix.external.api.IAdapterFactory;
import org.apache.asterix.external.indexing.ExternalFile;
@@ -71,6 +70,7 @@
import org.apache.asterix.om.types.IAType;
import org.apache.asterix.om.util.NonTaggedFormatUtil;
import org.apache.asterix.runtime.util.AsterixAppContextInfo;
+import org.apache.asterix.runtime.util.AsterixRuntimeComponentsProvider;
import
org.apache.asterix.transaction.management.opcallbacks.SecondaryIndexOperationTrackerProvider;
import
org.apache.asterix.transaction.management.resource.ExternalBTreeLocalResourceMetadata;
import
org.apache.asterix.transaction.management.resource.PersistentLocalResourceFactoryProvider;
@@ -90,6 +90,7 @@
import org.apache.hyracks.api.dataflow.value.ISerializerDeserializer;
import org.apache.hyracks.api.dataflow.value.ITypeTraits;
import org.apache.hyracks.api.dataflow.value.RecordDescriptor;
+import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.job.JobSpecification;
import org.apache.hyracks.dataflow.std.file.IFileSplitProvider;
import org.apache.hyracks.storage.am.common.api.IPrimitiveValueProviderFactory;
@@ -255,13 +256,15 @@
* @param files
* @param indexerDesc
* @return
- * @throws AsterixException
+ * @throws AlgebricksException
+ * @throws HyracksDataException
* @throws Exception
*/
private static Pair
getExternalDataIndexingOperator(
AqlMetadataProvider metadataProvider, JobSpecification
jobSpec, IAType itemType, Dataset dataset,
-List files, RecordDescriptor indexerDesc)
throws AsterixException {
+List files, RecordDescripto
Change in asterixdb[master]: Small Cleanup
abdullah alamoudi has uploaded a new patch set (#2). Change subject: Small Cleanup .. Small Cleanup Change-Id: I7fdc43c6aed99cab7aedb1d900c0b8725abd7892 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/LookupAdapterFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IAdapterFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/SocketClientInputStreamFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/RecordWithPKTestReaderFactory.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java 14 files changed, 143 insertions(+), 60 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/49/1149/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1149 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7fdc43c6aed99cab7aedb1d900c0b8725abd7892 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Jenkins has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/569/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup
abdullah alamoudi has abandoned this change. Change subject: Small Cleanup .. Abandoned Duplicate -- To view, visit https://asterix-gerrit.ics.uci.edu/1149 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7fdc43c6aed99cab7aedb1d900c0b8725abd7892 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: Small Cleanup
Jenkins has posted comments on this change. Change subject: Small Cleanup .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2531/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1145 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1145 to look at the new patch set (#2). Change subject: Small Cleanup .. Small Cleanup Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/LookupAdapterFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IAdapterFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/SocketClientInputStreamFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/RecordWithPKTestReaderFactory.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java 14 files changed, 143 insertions(+), 60 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/45/1145/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1145 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Small Cleanup
Jenkins has posted comments on this change. Change subject: Small Cleanup .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2530/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1149 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fdc43c6aed99cab7aedb1d900c0b8725abd7892 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup
Michael Blow has posted comments on this change.
Change subject: Small Cleanup
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1145/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java:
Line 95: while (i < count) {
> Done
We can either ignore the warning, or extract a method for the loop, then use no
label and "return locs" instead of "break outer"
--
To view, visit https://asterix-gerrit.ics.uci.edu/1145
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: Small Cleanup
abdullah alamoudi has posted comments on this change.
Change subject: Small Cleanup
..
Patch Set 1:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1145/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java:
Line 92: throw new AlgebricksException("Configurations don't
have any stores");
> What are the multiple configurations? Should this be
Done
Line 95: while (i < count) {
> if a label (e.g. outer) is added to this while, you can keep the foreach an
Done
Sonar says: Refactor the code to remove this label and the need for it.
Line 102: i++;
> e.g. if (++i == count) { break outer; }
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1145
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Jenkins has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Jenkins has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2529/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Small Cleanup
Michael Blow has posted comments on this change.
Change subject: Small Cleanup
..
Patch Set 1:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1145/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java:
Line 92: throw new AlgebricksException("Configurations don't
have any stores");
What are the multiple configurations? Should this be
Configuration doesn't?
Line 95: while (i < count) {
if a label (e.g. outer) is added to this while, you can keep the foreach and
just add the break outer when incrementing i below, and you can remove all the
intermediate && i < count checks
Line 102: i++;
e.g. if (++i == count) { break outer; }
--
To view, visit https://asterix-gerrit.ics.uci.edu/1145
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-HasComments: Yes
Change in asterixdb[master]: Equivalence induced operations and the testCases
Jenkins has posted comments on this change. Change subject: Equivalence induced operations and the testCases .. Patch Set 32: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/568/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 Gerrit-PatchSet: 32 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Equivalence induced operations and the testCases
Jenkins has posted comments on this change. Change subject: Equivalence induced operations and the testCases .. Patch Set 32: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/568/ -- To view, visit https://asterix-gerrit.ics.uci.edu/428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 Gerrit-PatchSet: 32 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Equivalence induced operations and the testCases
Jenkins has posted comments on this change. Change subject: Equivalence induced operations and the testCases .. Patch Set 32: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 Gerrit-PatchSet: 32 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Equivalence induced operations and the testCases
Hello Steven Jacobs, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/428 to look at the new patch set (#32). Change subject: Equivalence induced operations and the testCases .. Equivalence induced operations and the testCases exchange optimization for lookup and delete when the search condition is merely composed of the single primary key. Merge current master onto the branch Setup the restricted NodeDomain information in case the query condition explicitly/implicitly contains a single primary key. 1. Cover the insert/delete/upsert/query operations in both structural and semi-structural schemas. 2. Fixed the partition constraint bug in ASTERIXDB-1016 3. Temporarily enforce the secondary delete/insert node selection derived from the primary key, which will be removed once the AqlMetadataProvider disable the private constraints of secondary operations. Merge current master onto the branch Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/IndexSearchPOperator.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/AnalysisUtil.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AddEquivalenceClassForRecordConstructorRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceRandomPartitioningFeedComputationRule.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PreComputePartitionIdForRoutableOperationRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/util/EquivalenceClassUtils.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/util/ExpressionUtil.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/query_issue849-2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query_issue849.plan M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DatasetDataSource.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/FDsAndEquivClassesVisitor.java A hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/ProducedVariableExpressionListVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/VariableUtilities.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/BulkloadPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IndexBulkloadPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IndexInsertDeleteUpsertPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/InsertDeleteUpsertPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/BroadcastPartitioningProperty.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/DefaultNodeGroupDomain.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/FileSplitDomain.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/INodeDomain.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/IPartitioningProperty.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/OrderedPartitionedProperty.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/RandomPartitioningProperty.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/ResultSetDomain.java M hyracks-fu
Change in asterixdb[master]: Equivalence induced operations and the testCases
Jenkins has posted comments on this change. Change subject: Equivalence induced operations and the testCases .. Patch Set 32: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2528/ -- To view, visit https://asterix-gerrit.ics.uci.edu/428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 Gerrit-PatchSet: 32 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Equivalence induced operations and the testCases
Jenkins has posted comments on this change. Change subject: Equivalence induced operations and the testCases .. Patch Set 31: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/567/ -- To view, visit https://asterix-gerrit.ics.uci.edu/428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Equivalence induced operations and the testCases
Jenkins has posted comments on this change. Change subject: Equivalence induced operations and the testCases .. Patch Set 31: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Equivalence induced operations and the testCases
Jenkins has posted comments on this change. Change subject: Equivalence induced operations and the testCases .. Patch Set 31: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2527/ -- To view, visit https://asterix-gerrit.ics.uci.edu/428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Equivalence induced operations and the testCases
Hello Steven Jacobs, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/428 to look at the new patch set (#31). Change subject: Equivalence induced operations and the testCases .. Equivalence induced operations and the testCases exchange optimization for lookup and delete when the search condition is merely composed of the single primary key. Merge current master onto the branch Setup the restricted NodeDomain information in case the query condition explicitly/implicitly contains a single primary key. 1. Cover the insert/delete/upsert/query operations in both structural and semi-structural schemas. 2. Fixed the partition constraint bug in ASTERIXDB-1016 3. Temporarily enforce the secondary delete/insert node selection derived from the primary key, which will be removed once the AqlMetadataProvider disable the private constraints of secondary operations. Merge current master onto the branch Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/IndexSearchPOperator.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/AnalysisUtil.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AddEquivalenceClassForRecordConstructorRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceRandomPartitioningFeedComputationRule.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PreComputePartitionIdForRoutableOperationRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/util/EquivalenceClassUtils.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/util/ExpressionUtil.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/query_issue849-2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query_issue849.plan M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DatasetDataSource.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/InsertDeleteUpsertOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/FDsAndEquivClassesVisitor.java A hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/ProducedVariableExpressionListVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/VariableUtilities.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/BulkloadPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IndexBulkloadPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IndexInsertDeleteUpsertPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/InsertDeleteUpsertPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/BroadcastPartitioningProperty.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/DefaultNodeGroupDomain.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/FileSplitDomain.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/INodeDomain.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/IPartitioningProperty.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/OrderedPartitionedProperty.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/RandomPartitioningProperty.
