Change in asterixdb[master]: Easier to read parser errors for SQL++
Jenkins has posted comments on this change. Change subject: Easier to read parser errors for SQL++ .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2673/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1182 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13fd54fe2b1237b937a1706cf83fb47ce536b546 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Easier to read parser errors for SQL++
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1182
Change subject: Easier to read parser errors for SQL++
..
Easier to read parser errors for SQL++
Change-Id: I13fd54fe2b1237b937a1706cf83fb47ce536b546
---
M
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
2 files changed, 130 insertions(+), 6 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/82/1182/1
diff --git
a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java
b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java
index dc0fa93..4c4766a 100644
---
a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java
+++
b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java
@@ -29,6 +29,9 @@
public class ScopeChecker {
+protected static String QUOT = "\"";
+protected static String NL = "\n";
+
protected Counter varCounter = new Counter(-1);
protected Stack scopeStack = new Stack();
@@ -57,7 +60,6 @@
/**
* Create a new scope, using the top scope in scopeStack as parent scope
*
- * @param scopeStack
* @return new scope
*/
public final Scope createNewScope() {
@@ -70,7 +72,6 @@
/**
* Extend the current scope
*
- * @param scopeStack
* @return
*/
public final Scope extendCurrentScope() {
@@ -172,6 +173,86 @@
return false;
}
+protected String eol = System.getProperty("line.separator", NL);
+
+protected int appendExpected(StringBuilder expected, int[][]
expectedTokenSequences, String[] tokenImage) {
+int maxSize = 0;
+for (int i = 0; i < expectedTokenSequences.length; i++) {
+if (maxSize < expectedTokenSequences[i].length) {
+maxSize = expectedTokenSequences[i].length;
+}
+for (int j = 0; j < expectedTokenSequences[i].length; j++) {
+append(expected,
fixQuotes(tokenImage[expectedTokenSequences[i][j]]));
+append(expected, " ");
+}
+if (expectedTokenSequences[i][expectedTokenSequences[i].length -
1] != 0) {
+append(expected, "...");
+}
+append(expected, eol);
+append(expected, "");
+}
+return maxSize;
+}
+
+private void append(StringBuilder expected, String str) {
+if (expected != null) {
+expected.append(str);
+}
+}
+
+protected String fixQuotes(String token) {
+final int last = token.length() - 1;
+if (token.charAt(0) == '"' && token.charAt(last) == '"') {
+return "'" + token.substring(1, last) + "'";
+} else {
+return token;
+}
+}
+
+protected static String addEscapes(String str) {
+StringBuilder retval = new StringBuilder();
+char ch;
+for (int i = 0; i < str.length(); i++) {
+switch (str.charAt(i)) {
+case 0:
+continue;
+case '\b':
+retval.append("\\b");
+continue;
+case '\t':
+retval.append("\\t");
+continue;
+case '\n':
+retval.append("\\n");
+continue;
+case '\f':
+retval.append("\\f");
+continue;
+case '\r':
+retval.append("\\r");
+continue;
+case '\"':
+retval.append("\\\"");
+continue;
+case '\'':
+retval.append("\\\'");
+continue;
+case '\\':
+retval.append("");
+continue;
+default:
+if ((ch = str.charAt(i)) < 0x20 || ch > 0x7e) {
+String s = "" + Integer.toString(ch, 16);
+retval.append("\\u" + s.substring(s.length() - 4,
s.length()));
+} else {
+retval.append(ch);
+}
+continue;
+}
+}
+return retval.toString();
+}
+
public static final String removeQuotesAndEscapes(String s) {
char q = s.charAt(0); // simple or double quote
String stripped = s.substring(1, s.length() - 1);
@@ -220,6 +301,10 @@
return res.toString();
}
+public String getLine(int line) {
+return inputLines[line - 1];
+}
+
public String extractFragment(
Change in asterixdb[master]: simplify error message
Till Westmann has submitted this change and it was merged.
Change subject: simplify error message
..
simplify error message
Provide an exception class only if no message is available and provide only
the simple name of the class, if it is given.
Change-Id: I09c8ef4e3b594801304e2168508b780a443ab6a1
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1181
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Yingyi Bu
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Yingyi Bu: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 3b69dd1..132737b 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -49,8 +49,8 @@
import org.apache.asterix.lang.common.base.Statement;
import org.apache.asterix.metadata.MetadataManager;
import org.apache.asterix.translator.IStatementExecutor;
-import org.apache.asterix.translator.IStatementExecutorFactory;
import org.apache.asterix.translator.IStatementExecutor.Stats;
+import org.apache.asterix.translator.IStatementExecutorFactory;
import org.apache.commons.io.IOUtils;
import
org.apache.hyracks.algebricks.core.algebra.prettyprint.AlgebricksAppendable;
import org.apache.hyracks.api.client.IHyracksClientConnection;
@@ -341,8 +341,8 @@
pw.print("\": [{ \n");
printField(pw, ErrorField.CODE.str(), "1");
final String msg = rootCause.getMessage();
-printField(pw, ErrorField.MSG.str(),
-JSONUtil.escape(rootCause.getClass().getName() + ": " + (msg
!= null ? msg : "")), addStack);
+printField(pw, ErrorField.MSG.str(), JSONUtil.escape(msg != null ? msg
: rootCause.getClass().getSimpleName()),
+addStack);
if (addStack) {
StringWriter sw = new StringWriter();
PrintWriter stackWriter = new PrintWriter(sw);
@@ -424,8 +424,8 @@
IParser parser =
compilationProvider.getParserFactory().createParser(query);
List aqlStatements = parser.parse();
MetadataManager.INSTANCE.init();
-IStatementExecutor translator =
-statementExecutorFactory.create(aqlStatements,
sessionConfig, compilationProvider);
+IStatementExecutor translator =
statementExecutorFactory.create(aqlStatements, sessionConfig,
+compilationProvider);
execStart = System.nanoTime();
translator.compileAndExecute(hcc, hds,
QueryTranslator.ResultDelivery.SYNC, stats);
execEnd = System.nanoTime();
--
To view, visit https://asterix-gerrit.ics.uci.edu/1181
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09c8ef4e3b594801304e2168508b780a443ab6a1
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: simplify error message
Yingyi Bu has posted comments on this change. Change subject: simplify error message .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1181 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09c8ef4e3b594801304e2168508b780a443ab6a1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Enhanced Insert AQL
Jenkins has posted comments on this change. Change subject: Enhanced Insert AQL .. Patch Set 10: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/660/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1566, ASTERIXDB-1628: Fixed External Hash Group By...
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1566, ASTERIXDB-1628: Fixed External Hash Group By to conform to the memory budget .. Patch Set 9: (25 comments) https://asterix-gerrit.ics.uci.edu/#/c/1056/9/asterixdb/asterix-docker/docker/asterix-configuration.xml File asterixdb/asterix-docker/docker/asterix-configuration.xml: Line 251: more efficiently using pointers. Actual Group-by value is stored in data table. > "Group-by value" -> "aggregate values" Per our discussion, this parameter will not be used. Line 253: the same as the given value divided by 40 bytes. (E.g., 16MB / 40 = 419,430). > Can you add the explanation of why 40 is the number into the comments? Per our discussion, this parameter will not be used. https://asterix-gerrit.ics.uci.edu/#/c/1056/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java: Line 91: final ITuplePartitionComputer tpc1 = new FieldHashPartitionComputerFamily(intermediateResultKeys, > better variable name. e.g., Done https://asterix-gerrit.ics.uci.edu/#/c/1056/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/ISpillableTable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/ISpillableTable.java: Line 55: * @return > annotate @return. Done https://asterix-gerrit.ics.uci.edu/#/c/1056/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/external/ExternalHashGroupBy.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/external/ExternalHashGroupBy.java: Line 79: result = table.insert(accessor, i); > flip the else branch as the if branch, and hence not nest more than 4 level Done https://asterix-gerrit.ics.uci.edu/#/c/1056/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/ISerializableTable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/ISerializableTable.java: Line 43: boolean isGarbageCollectioNeeded(); > This method is never called. Do we really need it? Actually, this will be called during a partition spill to the disk from the caller due to a budget exceed. Line 46: throws HyracksDataException; > Why does this need to be expose to the outside? Because we do a garbage collection need check when we spill a data partition to the disk, not after each insertion. So, if the check says the garbage collection is required, we need to have a way to execute the garbage collection. https://asterix-gerrit.ics.uci.edu/#/c/1056/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java: Line 47: private static int INVALID_VALUE = -1; > 1. static final Done Line 262: lastContentFrame.writeInt(lastOffsetInCurrentFrame + i, INVALID_VALUE); > Simplify that using Arrays.fill(...). Done Line 384: for (int i = 0; i < frameCapacity; i++) > Simplify that using one line: Done Line 413: int numberOfHeaderFrame = (int) Math.ceil(tableSize * 2 / frameSize); > MAJOR SonarQube violation: Done Line 413: int numberOfHeaderFrame = (int) Math.ceil(tableSize * 2 / frameSize); > CRITICAL SonarQube violation: Done Line 413: int numberOfHeaderFrame = (int) Math.ceil(tableSize * 2 / frameSize); > Pls address this. Done Line 414: int numberOfContentFrame = (int) Math > Pls address this. Done Line 414: int numberOfContentFrame = (int) Math > MAJOR SonarQube violation: Done Line 415: .ceil((getNumberOfEntryInSlot() * 2 * getUnitSize() * tableSize) / frameSize); > CRITICAL SonarQube violation: Done Line 439: // For calculating the original hash value > wastedIntSpaceCount is not modified after executeGarbageCollection? Done Line 440: TuplePointer tmpTuplePointerForGC = new TuplePointer(); > reuse the object. Done Line 445: int slotCapacity = 0; > MAJOR SonarQube violation: Done Line 446: int slotUsedCount = 0; > MAJOR SonarQube violation: Done Line 447: int capacityInIntCount = 0; > MAJOR SonarQube violation: Done Line 462: slotCapacity = INVALID_VALUE; > MAJOR SonarQube violation: Done Line 463: slotUsedCount = INVALID_VALUE; > MAJOR SonarQube violation: Done Line 486:
Change in asterixdb[master]: ASTERIXDB-1566, ASTERIXDB-1628: Fixed External Hash Group By...
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1566, ASTERIXDB-1628: Fixed External Hash Group By to conform to the memory budget .. Patch Set 10: @Yingyi: thanks for the comments. -- To view, visit https://asterix-gerrit.ics.uci.edu/1056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Enhanced Insert AQL
Michael Carey has posted comments on this change. Change subject: Enhanced Insert AQL .. Patch Set 10: I couldn't figure out how to publish my comment on Till's comment - but the gist is I like the variant: insert into dataset b as $b ( for $a in dataset a where $a.x > 5 return $a ) returning func($b) Where func($b) is a placeholder for any AQL query involving $b. -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Enhanced Insert AQL
Steven Jacobs has posted comments on this change. Change subject: Enhanced Insert AQL .. Patch Set 10: @Mike: I'm not seeing your comment, maybe it hasn't been published yet? Okay, I will start working on this change now. I think I will start with the first of the two suggested syntaxes (unless Mike's comment has a third option), and maybe we can discuss final syntax in our next BAD meeting (if not sooner). -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Enhanced Insert AQL
Michael Carey has posted comments on this change. Change subject: Enhanced Insert AQL .. Patch Set 10: I added a comment on the syntax - I would like to second Till's change (modulo finalizing the var-binding syntax). -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Enhanced Insert AQL
Michael Carey has posted comments on this change. Change subject: Enhanced Insert AQL .. Patch Set 10: Code-Review-1 I added a common on the syntax - I would like to second Till's change (modulo finalizing the var-binding syntax). -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Enhanced Insert AQL
Jenkins has posted comments on this change. Change subject: Enhanced Insert AQL .. Patch Set 10: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/660/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Enhanced Insert AQL
Steven Jacobs has posted comments on this change.
Change subject: Enhanced Insert AQL
..
Patch Set 9:
(14 comments)
I addressed everything except for the documentation comment. Does this comment
fit more into the "It would be even cooler if we could do this" or the "it
seems wrong to do it without this" category?
To me it seems like the former. If this is the case, maybe we can create this
as an enhancement Jira issue? The reason I suggest this is that it would be a
nontrivial change, and I'm not sure I'm currently in the position to dedicate
the cycles for it.
I think there are definitely good use cases for this change as it is now, so it
doesn't seem to be to be "baked" just for my change.
However, if the change as it is now fits into the "it seems wrong" category,
please let me know and we can talk more about it.
https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java
File
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java:
Line 34: public boolean isEntityUsingDataset(String dataverseName, String
datasetName);
> Seems unrelated ..
I need to add a line to the commit saying "Prepare Asterix for Channel
Extension"
https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java:
Line 54: int resultSetIdCounter) throws HyracksDataException,
AlgebricksException;
> Seems unrelated as well ...
I need to add a line to the commit saying "Prepare Asterix for Channel
Extension"
https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java:
Line 101: if (op1.getOperatorTag() ==
LogicalOperatorTag.EXTENSION_OPERATOR) {
> This seems unrelated as well ...
This one is a case of name crossover :)
An EXTENSION_OPERATOR actually has nothing to do with Asterix Extensions. It is
an operator that holds an underlying operator (in this case a commit).
https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java:
Line 96: if (op0.getOperatorTag() !=
LogicalOperatorTag.EXTENSION_OPERATOR
> Seems unrelated.
This one is a case of name crossover :) An EXTENSION_OPERATOR actually has
nothing to do with Asterix Extensions. It is an operator that holds an
underlying operator (in this case a commit).
https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceStaticTypeCastForInsertRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceStaticTypeCastForInsertRule.java:
Line 96: if (op1.getOperatorTag() ==
LogicalOperatorTag.EXTENSION_OPERATOR) {
> Seems unrelated ...
This one is a case of name crossover :) An EXTENSION_OPERATOR actually has
nothing to do with Asterix Extensions. It is an operator that holds an
underlying operator (in this case a commit).
https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java:
Line 66: ExtensionOperator eOp = (ExtensionOperator) op;
> Seems unrelated.
This one is a case of name crossover :) An EXTENSION_OPERATOR actually has
nothing to do with Asterix Extensions. It is an operator that holds an
underlying operator (in this case a commit).
https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java:
Line 26: import org.apache.asterix.external.feed.watch.FeedActivityDetails;
> Seems unrelated.
I removed the class FeedActivity which wasn't being used.
https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java:
Line 305: throws AlgebricksException {
> Revert this file?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/or
Change in asterixdb[master]: Enhanced Insert AQL
Jenkins has posted comments on this change. Change subject: Enhanced Insert AQL .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2672/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Enhanced Insert AQL
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1150 to look at the new patch set (#10). Change subject: Enhanced Insert AQL .. Enhanced Insert AQL Added "return records" and "returning [fieldName]" "return records" returns to the user all records that were inserted "returning [fieldName]" returns only the values inserted for [fieldName] Allow commits to be non-sink operators (contnue job pipeline after commit) Additionally, this change makes small modifications to the extension code to prepare for the BAD extension Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 --- M asterixdb/asterix-active/pom.xml M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/CommitOperator.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitPOperator.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntimeFactory.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/UpsertCommitRuntime.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceStaticTypeCastForInsertRule.java R asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java A asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/dml/insert-return-records/insert-return-records.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/dml/insert-returning-fieldname/insert-returning-fieldname.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-doc/src/site/markdown/aql/manual.md R asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IActiveLifecycleEventSubscriber.java R asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/watch/FeedActivity.java A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/watch/FeedActivityDetails.java M asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/InsertStatement.java M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/UpsertStatement.java M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUU
Change in asterixdb[master]: Add <> as a synonym to !=.
Yingyi Bu has submitted this change and it was merged. Change subject: Add <> as a synonym to !=. .. Add <> as a synonym to !=. Change-Id: I3c670cf3d0e53725dce8ef2acb33970f8030a0a8 Reviewed-on: https://asterix-gerrit.ics.uci.edu/1180 Sonar-Qube: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Till Westmann --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/neq_02/neq_02.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj 3 files changed, 34 insertions(+), 2 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; No violations found; Verified diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/neq_02/neq_02.3.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/neq_02/neq_02.3.query.sqlpp new file mode 100644 index 000..8a6cf27 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/neq_02/neq_02.3.query.sqlpp @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +select element x +from [1,2,2] as x +where x <> 2 +; diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml index 932a602..54f06e6 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml +++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml @@ -1077,6 +1077,11 @@ neq_01 + + +neq_01 + +
Change in asterixdb[master]: Add <> as a synonym to !=.
Till Westmann has posted comments on this change. Change subject: Add <> as a synonym to !=. .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1180 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c670cf3d0e53725dce8ef2acb33970f8030a0a8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: simplify error message
Jenkins has posted comments on this change. Change subject: simplify error message .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/659/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1181 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09c8ef4e3b594801304e2168508b780a443ab6a1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: avoid some exception wrapping
Jenkins has posted comments on this change. Change subject: avoid some exception wrapping .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/658/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1179 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Full-text search implementation step 1
Taewoo Kim has abandoned this change. Change subject: Full-text search implementation step 1 .. Abandoned -- To view, visit https://asterix-gerrit.ics.uci.edu/1175 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Add <> as a synonym to !=.
Jenkins has posted comments on this change. Change subject: Add <> as a synonym to !=. .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/657/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1180 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c670cf3d0e53725dce8ef2acb33970f8030a0a8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: simplify error message
Jenkins has posted comments on this change. Change subject: simplify error message .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/659/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1181 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09c8ef4e3b594801304e2168508b780a443ab6a1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: avoid some exception wrapping
Michael Blow has posted comments on this change. Change subject: avoid some exception wrapping .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1179 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: avoid some exception wrapping
Jenkins has posted comments on this change. Change subject: avoid some exception wrapping .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/658/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1179 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Add <> as a synonym to !=.
Jenkins has posted comments on this change. Change subject: Add <> as a synonym to !=. .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/657/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1180 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c670cf3d0e53725dce8ef2acb33970f8030a0a8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: simplify error message
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1181
Change subject: simplify error message
..
simplify error message
Provide an exception class only if no message is available and provide only
the simple name of the class, if it is given.
Change-Id: I09c8ef4e3b594801304e2168508b780a443ab6a1
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/81/1181/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 3b69dd1..132737b 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -49,8 +49,8 @@
import org.apache.asterix.lang.common.base.Statement;
import org.apache.asterix.metadata.MetadataManager;
import org.apache.asterix.translator.IStatementExecutor;
-import org.apache.asterix.translator.IStatementExecutorFactory;
import org.apache.asterix.translator.IStatementExecutor.Stats;
+import org.apache.asterix.translator.IStatementExecutorFactory;
import org.apache.commons.io.IOUtils;
import
org.apache.hyracks.algebricks.core.algebra.prettyprint.AlgebricksAppendable;
import org.apache.hyracks.api.client.IHyracksClientConnection;
@@ -341,8 +341,8 @@
pw.print("\": [{ \n");
printField(pw, ErrorField.CODE.str(), "1");
final String msg = rootCause.getMessage();
-printField(pw, ErrorField.MSG.str(),
-JSONUtil.escape(rootCause.getClass().getName() + ": " + (msg
!= null ? msg : "")), addStack);
+printField(pw, ErrorField.MSG.str(), JSONUtil.escape(msg != null ? msg
: rootCause.getClass().getSimpleName()),
+addStack);
if (addStack) {
StringWriter sw = new StringWriter();
PrintWriter stackWriter = new PrintWriter(sw);
@@ -424,8 +424,8 @@
IParser parser =
compilationProvider.getParserFactory().createParser(query);
List aqlStatements = parser.parse();
MetadataManager.INSTANCE.init();
-IStatementExecutor translator =
-statementExecutorFactory.create(aqlStatements,
sessionConfig, compilationProvider);
+IStatementExecutor translator =
statementExecutorFactory.create(aqlStatements, sessionConfig,
+compilationProvider);
execStart = System.nanoTime();
translator.compileAndExecute(hcc, hds,
QueryTranslator.ResultDelivery.SYNC, stats);
execEnd = System.nanoTime();
--
To view, visit https://asterix-gerrit.ics.uci.edu/1181
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09c8ef4e3b594801304e2168508b780a443ab6a1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Change in asterixdb[master]: simplify error message
Jenkins has posted comments on this change. Change subject: simplify error message .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2671/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1181 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09c8ef4e3b594801304e2168508b780a443ab6a1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multi...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multiple plan paths handling .. Patch Set 14: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/656/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1073 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69e055572f024f28a857d4e64916b4806e63c083 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: avoid some exception wrapping
Jenkins has posted comments on this change. Change subject: avoid some exception wrapping .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1179 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: avoid some exception wrapping
Jenkins has posted comments on this change. Change subject: avoid some exception wrapping .. Patch Set 1: Integration-Tests-1 Integration Tests Timed Out https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/654/ : ABORTED -- To view, visit https://asterix-gerrit.ics.uci.edu/1179 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: avoid some exception wrapping
Jenkins has posted comments on this change. Change subject: avoid some exception wrapping .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2670/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1179 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: avoid some exception wrapping
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1179 to look at the new patch set (#2). Change subject: avoid some exception wrapping .. avoid some exception wrapping Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java M asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractExperiment7Builder.java M asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractExperiment8Builder.java M asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractExperiment9Builder.java M asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/Experiment8ABuilder.java M asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/Experiment8BBuilder.java M asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/Experiment8CBuilder.java M asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/Experiment8DBuilder.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FilesIndexDescription.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/ListItemBinaryHashFunctionFactory.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksJobletContext.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/deployment/DeploymentUtils.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Joblet.java 14 files changed, 82 insertions(+), 119 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/79/1179/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1179 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: Add <> as a synonym to !=.
Jenkins has posted comments on this change. Change subject: Add <> as a synonym to !=. .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2669/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1180 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c670cf3d0e53725dce8ef2acb33970f8030a0a8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add <> as a synonym to !=.
Yingyi Bu has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1180 Change subject: Add <> as a synonym to !=. .. Add <> as a synonym to !=. Change-Id: I3c670cf3d0e53725dce8ef2acb33970f8030a0a8 --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/neq_02/neq_02.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj 3 files changed, 34 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/80/1180/1 diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/neq_02/neq_02.3.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/neq_02/neq_02.3.query.sqlpp new file mode 100644 index 000..8a6cf27 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/neq_02/neq_02.3.query.sqlpp @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +select element x +from [1,2,2] as x +where x <> 2 +; diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml index 932a602..54f06e6 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml +++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml @@ -1077,6 +1077,11 @@ neq_01 + + +neq_01 + +
Change in asterixdb[master]: WIP - stop transaction subsystem
Jenkins has posted comments on this change. Change subject: WIP - stop transaction subsystem .. Patch Set 9: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/655/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/847 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67a977fa1f2718e02b2bfb28a2b0ed2d5242a7 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: WIP - inline variable
Jenkins has posted comments on this change. Change subject: WIP - inline variable .. Patch Set 10: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/653/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/848 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multi...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multiple plan paths handling .. Patch Set 14: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/656/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1073 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69e055572f024f28a857d4e64916b4806e63c083 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Jenkins has posted comments on this change. Change subject: some WebUI hackery .. Patch Set 11: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/652/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: WIP - stop transaction subsystem
Jenkins has posted comments on this change. Change subject: WIP - stop transaction subsystem .. Patch Set 9: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/655/ -- To view, visit https://asterix-gerrit.ics.uci.edu/847 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67a977fa1f2718e02b2bfb28a2b0ed2d5242a7 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: avoid some exception wrapping
Jenkins has posted comments on this change. Change subject: avoid some exception wrapping .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/654/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1179 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Jenkins has posted comments on this change. Change subject: some WebUI hackery .. Patch Set 11: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/652/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multi...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multiple plan paths handling .. Patch Set 14: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1073 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69e055572f024f28a857d4e64916b4806e63c083 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: WIP - inline variable
Jenkins has posted comments on this change. Change subject: WIP - inline variable .. Patch Set 10: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/653/ -- To view, visit https://asterix-gerrit.ics.uci.edu/848 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multi...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multiple plan paths handling .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2668/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1073 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69e055572f024f28a857d4e64916b4806e63c083 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: avoid some exception wrapping
Michael Blow has posted comments on this change.
Change subject: avoid some exception wrapping
..
Patch Set 1:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1179/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:
Line 334: throw new AlgebricksException("Unexpected
OutputFormat!");
/!"/: " + conf.fmt()/
https://asterix-gerrit.ics.uci.edu/#/c/1179/1/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java
File
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java:
Line 162: throw new
Exception(report.getException().getMessage());
> CRITICAL SonarQube violation:
Why not throw report.getException()? This is still wrapping and in the case of
many exceptions losing a lot of information.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1179
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enhanced Insert AQL Added "return records" and "returning [f...
Steven Jacobs has posted comments on this change. Change subject: Enhanced Insert AQL Added "return records" and "returning [fieldName]" "return records" returns to the user all records that were inserted "returning [fieldName]" returns only the valuse inserted for [fieldName] Allow commits to be non-sink operators (con .. Patch Set 9: There are some changes that are specifically for Extensions. I guess I need to add a line to the commit saying "Prepare Asterix for Channel Extension" The changes to Extension Statement are because there are more parameters that an Extension might need other than what Abdullah originally included (e.g. if you have a statement that returns results). I'll address the individual comments as well. -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: WIP - stop transaction subsystem
Jenkins has posted comments on this change. Change subject: WIP - stop transaction subsystem .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2667/ -- To view, visit https://asterix-gerrit.ics.uci.edu/847 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67a977fa1f2718e02b2bfb28a2b0ed2d5242a7 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multi...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1073 to look at the new patch set (#14). Change subject: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multiple plan paths handling .. ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multiple plan paths handling - ASTERIXDB-1081: Fixed RemoveUnusedAssignAndAggregateRule to reflect multiple paths in the plan. - ASTERIXDB-1086: Fixed IntroduceProjectsRule to reflect multiples paths in the plan. - ASTERIXDB-1246: Fixed RemoveRedundantGroupByDecorVarsRule to remove decor variables before IntroduceProjects rule fires. Change-Id: I69e055572f024f28a857d4e64916b4806e63c083 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/IntroduceProjectsRule.java D hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveRedundantGroupByDecorVars.java A hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveRedundantGroupByDecorVarsRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveUnusedAssignAndAggregateRule.java 8 files changed, 449 insertions(+), 213 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/73/1073/14 -- To view, visit https://asterix-gerrit.ics.uci.edu/1073 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69e055572f024f28a857d4e64916b4806e63c083 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: avoid some exception wrapping
Jenkins has posted comments on this change. Change subject: avoid some exception wrapping .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1179 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: WIP - stop transaction subsystem
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/847 to look at the new patch set (#9). Change subject: WIP - stop transaction subsystem .. WIP - stop transaction subsystem Change-Id: I9a67a977fa1f2718e02b2bfb28a2b0ed2d5242a7 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IAsterixAppRuntimeContext.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionSubsystem.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointThread.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionSubsystem.java 6 files changed, 37 insertions(+), 16 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/47/847/9 -- To view, visit https://asterix-gerrit.ics.uci.edu/847 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a67a977fa1f2718e02b2bfb28a2b0ed2d5242a7 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: avoid some exception wrapping
Jenkins has posted comments on this change. Change subject: avoid some exception wrapping .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2666/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1179 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: avoid some exception wrapping
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1179
Change subject: avoid some exception wrapping
..
avoid some exception wrapping
Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java
M
asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractExperiment7Builder.java
M
asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractExperiment8Builder.java
M
asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractExperiment9Builder.java
M
asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/Experiment8ABuilder.java
M
asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/Experiment8BBuilder.java
M
asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/Experiment8CBuilder.java
M
asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/Experiment8DBuilder.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FilesIndexDescription.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/ListItemBinaryHashFunctionFactory.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksJobletContext.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/deployment/DeploymentUtils.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Joblet.java
14 files changed, 80 insertions(+), 118 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/79/1179/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
index 76d0245..7579ec7 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
@@ -331,7 +331,7 @@
builder.setPrinterProvider(format.getCleanJSONPrinterFactoryProvider());
break;
default:
-throw new RuntimeException("Unexpected OutputFormat!");
+throw new AlgebricksException("Unexpected OutputFormat!");
}
builder.setSerializerDeserializerProvider(format.getSerdeProvider());
diff --git
a/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java
b/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java
index 28abc5c..ea385d4 100644
---
a/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java
+++
b/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java
@@ -159,7 +159,7 @@
break;
}
} else {
-throw new RuntimeException(report.getException().getMessage());
+throw new Exception(report.getException().getMessage());
}
}
}
diff --git
a/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractExperiment7Builder.java
b/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractExperiment7Builder.java
index d955167..947291c 100644
---
a/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractExperiment7Builder.java
+++
b/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractExperiment7Builder.java
@@ -19,6 +19,7 @@
package org.apache.asterix.experiment.builder;
+import java.io.IOException;
import java.nio.ByteBuffer;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
@@ -26,8 +27,6 @@
import java.util.List;
import java.util.Map;
import java.util.Random;
-
-import org.apache.commons.lang3.StringUtils;
import org.apache.asterix.experiment.action.base.AbstractAction;
import org.apache.asterix.experiment.action.base.IAction;
@@ -43,6 +42,7 @@
import
org.apache.asterix.experiment.client.LSMExperimentSetRunner.LSMExperimentSetRunnerConfig;
import org.apache.asterix.experiment.client.OrchestratorServer7;
import
org.apache.asterix.experiment.client.OrchestratorServer7.IProtocolActionBuilder;
+import org.apache.commons.lang3.StringUtils;
public abstract class AbstractExperiment7Builder extends
AbstractLSMBaseExperimentBui
Change in asterixdb[master]: WIP - inline variable
Jenkins has posted comments on this change. Change subject: WIP - inline variable .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2665/ -- To view, visit https://asterix-gerrit.ics.uci.edu/848 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: WIP - inline variable
Hello Michael Blow, Yingyi Bu, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/848 to look at the new patch set (#10). Change subject: WIP - inline variable .. WIP - inline variable Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/ClusterPartition.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/48/848/10 -- To view, visit https://asterix-gerrit.ics.uci.edu/848 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: some WebUI hackery
Jenkins has posted comments on this change. Change subject: some WebUI hackery .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2664/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Hello Michael Blow, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1097 to look at the new patch set (#11). Change subject: some WebUI hackery .. some WebUI hackery - use query/service endpoint (and SQL++) - add option to display JSON - some code simplification Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java M asterixdb/asterix-app/src/main/resources/queryui/css/master.css M asterixdb/asterix-app/src/main/resources/queryui/js/main.js M asterixdb/asterix-app/src/main/resources/queryui/queryui.html 4 files changed, 62 insertions(+), 57 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/97/1097/11 -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Add Default Dataverse and AnyObject Datatype
Jenkins has posted comments on this change. Change subject: Add Default Dataverse and AnyObject Datatype .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2663/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1174 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie02c74c8b005dce73888afd4dfe19ede2c60a8e8 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-1535) CC stop answering query from 19002 RESTAPI port
[ https://issues.apache.org/jira/browse/ASTERIXDB-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496489#comment-15496489 ] Jianfeng Jia commented on ASTERIXDB-1535: - One more thing, the job was finished and acked to the client successfully anyway. > CC stop answering query from 19002 RESTAPI port > --- > > Key: ASTERIXDB-1535 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1535 > Project: Apache AsterixDB > Issue Type: Bug > Components: HTTP API > Environment: master > commit a89fae64ac21fb8eefde79f79d2dbe1a0e54c364 > Date: Wed Jul 6 07:58:55 2016 -0700 >Reporter: Jianfeng Jia >Assignee: Ian Maxon > Attachments: cc.jstack > > > The /adminconsole showed that there are many pending jobs while the > ingestion and the query works fine in nc. > If this situation lasts longer enough, say 2 days, the 19002 API will stop > response any queries, while the web interface from 19001 port can still > answer the query. > I need to restart the cluster to recover the service. Before that I record > the jstack log of the cc as attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ASTERIXDB-1535) CC stop answering query from 19002 RESTAPI port
[
https://issues.apache.org/jira/browse/ASTERIXDB-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496479#comment-15496479
]
Jianfeng Jia commented on ASTERIXDB-1535:
-
Here are some new updates.
The never-ending job id is JID:1125 that is an upserting job
The cc log shows that it haven't received the `Task Complete` msg from
partition 3.
{code}
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.cc.scheduler.ActivityClusterPlanner
planActivityCluster
INFO: Tasks: [TID:ANID:ODID:1:1:0, TID:ANID:ODID:1:1:1, TID:ANID:ODID:1:1:2,
TID:ANID:ODID:1:1:3, TID:ANID:ODID:1:1:4, TID:ANID:ODID:1:1:5,
TID:ANID:ODID:1:1:6, TID:ANID:ODID:1:1:7, TID:ANID:ODID:1:1:8,
TID:ANID:ODID:1:1:9]
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread run
INFO: Executing: TaskComplete:
[cloudberry_pu[JID:1125:TAID:TID:ANID:ODID:1:1:6:0]
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread run
INFO: Executing: TaskComplete:
[cloudberry_np[JID:1125:TAID:TID:ANID:ODID:1:1:4:0]
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread run
INFO: Executing: TaskComplete:
[cloudberry_ac[JID:1125:TAID:TID:ANID:ODID:1:1:1:0]
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread run
INFO: Executing: TaskComplete:
[cloudberry_fr[JID:1125:TAID:TID:ANID:ODID:1:1:2:0]
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread run
INFO: Executing: TaskComplete:
[cloudberry_ac[JID:1125:TAID:TID:ANID:ODID:1:1:0:0]
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread run
INFO: Executing: TaskComplete:
[cloudberry_pu[JID:1125:TAID:TID:ANID:ODID:1:1:7:0]
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread run
INFO: Executing: TaskComplete:
[cloudberry_np[JID:1125:TAID:TID:ANID:ODID:1:1:5:0]
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread run
INFO: Executing: TaskComplete:
[cloudberry_th[JID:1125:TAID:TID:ANID:ODID:1:1:8:0]
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread run
INFO: Executing: TaskComplete:
[cloudberry_th[JID:1125:TAID:TID:ANID:ODID:1:1:9:0]
{code}
The corresponding nc log shows that it indeed didn't send the `Task Complete`
msg
{code}
INFO: Executing: StartTasks
Sep 15, 2016 5:07:17 PM org.apache.hyracks.control.nc.work.StartTasksWork run
INFO: Initializing TAID:TID:ANID:ODID:1:1:2:0 ->
[org.apache.hyracks.dataflow.std.sort.ExternalSortOperatorDescriptor$2@48103132,
org.apache.hyracks.dataflow.std.sort.ExternalSortOperatorDescriptor$2@7bd26066,
org.apache.hyracks.dataflow.std.intersect.IntersectOperatorDescriptor$IntersectActivity@740e36f9,
org.apache.hyracks.storage.am.btree.dataflow.BTreeSearchOperatorDescriptor@2964994,
org.apache.asterix.runtime.operators.AsterixLSMTreeUpsertOperatorDescriptor@4b467155,
Asterix {
stream-project [1];
assign [1] :=
[org.apache.asterix.runtime.evaluators.functions.records.FieldAccessByIndexEvalFactory$_EvaluatorFactoryGen@237ff90b];
stream-select
org.apache.asterix.runtime.evaluators.functions.AndDescriptor$2@26c3aa63;
stream-project [0];
assign [1] :=
[org.apache.asterix.runtime.evaluators.functions.records.FieldAccessByIndexEvalFactory$_EvaluatorFactoryGen@16a98dc6];
}, Asterix {
assign [3] :=
[org.apache.asterix.runtime.evaluators.functions.OrDescriptor$2@6e1d9a9f];
stream-project [3, 1];
commit;
}]
Sep 15, 2016 5:07:17 PM org.apache.hyracks.control.nc.work.StartTasksWork run
INFO: Initializing TAID:TID:ANID:ODID:1:1:3:0 ->
[org.apache.hyracks.dataflow.std.sort.ExternalSortOperatorDescriptor$2@48103132,
org.apache.hyracks.dataflow.std.sort.ExternalSortOperatorDescriptor$2@7bd26066,
org.apache.hyracks.dataflow.std.intersect.IntersectOperatorDescriptor$IntersectActivity@740e36f9,
org.apache.hyracks.storage.am.btree.dataflow.BTreeSearchOperatorDescriptor@2964994,
org.apache.asterix.runtime.operators.AsterixLSMTreeUpsertOperatorDescriptor@4b467155,
Asterix {
stream-project [1];
assign [1] :=
[org.apache.asterix.runtime.evaluators.functions.records.FieldAccessByIndexEvalFactory$_EvaluatorFactoryGen@237ff90b];
stream-select
org.apache.asterix.runtime.evaluators.functions.AndDescriptor$2@26c3aa63;
stream-project [0];
assign [1] :=
[org.apache.asterix.runtime.evaluators.functions.records.FieldAccessByIndexEvalFactory$_EvaluatorFactoryGen@16a98dc6];
}, Asterix {
assign [3] :=
[org.apache.asterix.runtime.evaluators.functions.OrDescriptor$2@6e1d9a9f];
stream-project [3, 1];
commit;
}]
Sep 15, 2016 5:07:17 PM
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread run
INFO: Executing: NotifyTaskComplete
Sep 15, 2016 5:07:25 PM
org.apache.hyracks.contr
[jira] [Created] (ASTERIXDB-1643) Creating a type which reference types in other dataverses creates a duplicate of the referenced type
Abdullah Alamoudi created ASTERIXDB-1643: Summary: Creating a type which reference types in other dataverses creates a duplicate of the referenced type Key: ASTERIXDB-1643 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1643 Project: Apache AsterixDB Issue Type: Bug Reporter: Abdullah Alamoudi Assignee: Abdullah Alamoudi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ASTERIXDB-1642) Failure in a job with massively parallel task only stops tasks that have already started
Abdullah Alamoudi created ASTERIXDB-1642: Summary: Failure in a job with massively parallel task only stops tasks that have already started Key: ASTERIXDB-1642 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1642 Project: Apache AsterixDB Issue Type: Bug Reporter: Abdullah Alamoudi Assignee: Abdullah Alamoudi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
