Change in asterixdb[master]: Deps++, Refactor ClusterManager
Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1298
Change subject: Deps++, Refactor ClusterManager
..
Deps++, Refactor ClusterManager
- Exclude runtime-scoped junit from appassembler-booter dep
Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterWorkExecutor.java
M asterixdb/asterix-client-helper/pom.xml
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IClusterManager.java
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManager.java
A
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManagerProvider.java
M asterixdb/asterix-server/pom.xml
8 files changed, 138 insertions(+), 46 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/98/1298/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
index 764b559..919af33 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
@@ -62,7 +62,7 @@
import org.apache.asterix.metadata.MetadataManager;
import org.apache.asterix.metadata.api.IAsterixStateProxy;
import org.apache.asterix.metadata.bootstrap.AsterixStateProxy;
-import org.apache.asterix.metadata.cluster.ClusterManager;
+import org.apache.asterix.metadata.cluster.ClusterManagerProvider;
import org.apache.asterix.runtime.util.AsterixAppContextInfo;
import org.apache.hyracks.api.application.ICCApplicationContext;
import org.apache.hyracks.api.application.ICCApplicationEntryPoint;
@@ -128,7 +128,7 @@
server.start();
}
-
ClusterManager.INSTANCE.registerSubscriber(GlobalRecoveryManager.instance());
+
ClusterManagerProvider.getClusterManager().registerSubscriber(GlobalRecoveryManager.instance());
ccAppCtx.addClusterLifecycleListener(ClusterLifecycleListener.INSTANCE);
ccAppCtx.setMessageBroker(messageBroker);
@@ -323,13 +323,7 @@
@Override
public void startupCompleted() throws Exception {
-// Notify Zookeeper that the startup is complete
-ILookupService zookeeperService = ClusterManager.getLookupService();
-if (zookeeperService != null) {
-// Our asterix app runtimes tests don't use zookeeper
-
zookeeperService.reportClusterState(ClusterProperties.INSTANCE.getCluster().getInstanceName(),
-ClusterState.ACTIVE);
-}
+ClusterManagerProvider.getClusterManager().notifyStartupCompleted();
}
public static synchronized void setAsterixStateProxy(IAsterixStateProxy
proxy) {
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
index 75cbe44..7863557 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
@@ -37,7 +37,7 @@
import org.apache.asterix.metadata.MetadataManager;
import org.apache.asterix.metadata.cluster.AddNodeWork;
import org.apache.asterix.metadata.cluster.AddNodeWorkResponse;
-import org.apache.asterix.metadata.cluster.ClusterManager;
+import org.apache.asterix.metadata.cluster.ClusterManagerProvider;
import org.apache.asterix.metadata.cluster.RemoveNodeWork;
import org.apache.asterix.metadata.cluster.RemoveNodeWorkResponse;
import org.apache.asterix.runtime.util.ClusterStateManager;
@@ -79,7 +79,7 @@
Set nodeAddition = new HashSet();
nodeAddition.add(nodeId);
updateProgress(ClusterEventType.NODE_JOIN, nodeAddition);
-Set subscribers =
ClusterManager.INSTANCE.getRegisteredClusterEventSubscribers();
+Set subscribers =
ClusterManagerProvider.getClusterManager().getRegisteredClusterEventSubscribers();
Set work = new
HashSet();
for (IClusterEventsSubscriber sub : subscribers) {
Set workRequest =
sub.notifyNodeJoin(nodeId);
@@ -105,7 +105,7 @@
}
}
updateProgress(ClusterEventType.NODE_FAILURE, deadNodeIds);
-Set subscribers =
ClusterManager.INSTANCE.getRegisteredClusterEventSubscribers();
+Set subscribers =
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Jenkins has posted comments on this change. Change subject: Deps++, Refactor ClusterManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3062/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Michael Blow has posted comments on this change.
Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
..
Patch Set 2:
(4 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1296/2/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:
Line 89: public static final int TRUNCATE_THRESHOLD = 16384;
> Why this number? And why the fix for the truncation? I can see where maybe
I like powers of two, and seemed like a decent amount of data to print. The
context is that my 20MB line was crashing IDEA, and is pretty useless when
printed.
https://asterix-gerrit.ics.uci.edu/#/c/1296/2/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
File
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java:
Line 109: appendChannel = getFileChannel(appendLSN.get(), false);
> Might be good for that to just be a static final variable. I get why it's 0
Done
Line 158: final int logSize = logRecord.getLogSize();
> The 'final' here is just for legibility, yes?
Yes
Line 189: } catch (InterruptedException e) {
> CRITICAL SonarQube violation:
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1296
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Ian Maxon
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1296 to look at the new patch set (#3). Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. ASTERIXDB-1696 - Big Object Spanning Log File Boundary - Big objects spanning log file boundary produces ArrayIndexOutOfBoundsException. Refactored large log page logic to correctly handle big objects at log file boundaries. - Add regression test Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc --- M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java M asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java M asterixdb/asterix-test-framework/src/main/resources/Catalog.xsd M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManagerWithReplication.java 7 files changed, 67 insertions(+), 56 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/96/1296/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3063/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Jenkins has posted comments on this change. Change subject: Deps++, Refactor ClusterManager .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/961/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Jenkins has posted comments on this change. Change subject: Deps++, Refactor ClusterManager .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/961/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1695 Fix Functions in Default Dataverse
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1297 to look at the new patch set (#2). Change subject: ASTERIXDB-1695 Fix Functions in Default Dataverse .. ASTERIXDB-1695 Fix Functions in Default Dataverse Change-Id: I7f08c0acaccdcfaeb4fc9cfb1529214b543d0e86 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/default/default.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/default/default.2.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/default/default.3.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/types/default/default.2.adm M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java 6 files changed, 77 insertions(+), 10 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/97/1297/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1297 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7f08c0acaccdcfaeb4fc9cfb1529214b543d0e86 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: ASTERIXDB-1695 Fix Functions in Default Dataverse
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1695 Fix Functions in Default Dataverse .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3064/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1297 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f08c0acaccdcfaeb4fc9cfb1529214b543d0e86 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: leaner .gitignore
Till Westmann has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1299 Change subject: leaner .gitignore .. leaner .gitignore Change-Id: I52ba4f1052c7c83b5a4875dd86b3f3a57e0ca9cb --- M .gitignore 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/99/1299/1 diff --git a/.gitignore b/.gitignore index 6c88169..b51e271 100644 --- a/.gitignore +++ b/.gitignore @@ -9,9 +9,6 @@ build asterixdb/asterix-opt asterixdb/asterix-app/src/test/resources/externallib -asterixdb/asterix-app/opt_parserts/ -asterixdb/asterix-app/rttest/ -asterixdb/asterix-app/runtime_parserts/ asterixdb/asterix-app/library asterixdb/asterix-app/data/csv/beer.csv asterixdb/asterix-installer/src/test/resources/clusterts/asterix-installer-*-SNAPSHOT-binary-assembly -- To view, visit https://asterix-gerrit.ics.uci.edu/1299 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I52ba4f1052c7c83b5a4875dd86b3f3a57e0ca9cb Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann
Change in asterixdb[master]: leaner .gitignore
Jenkins has posted comments on this change. Change subject: leaner .gitignore .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3065/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1299 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ba4f1052c7c83b5a4875dd86b3f3a57e0ca9cb Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 1
Jenkins has posted comments on this change. Change subject: Full-text implementation step 1 .. Patch Set 11: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1228 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 1
Jenkins has posted comments on this change. Change subject: Full-text implementation step 1 .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3066/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1228 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: dead code elimination in asterix-events
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1300
Change subject: dead code elimination in asterix-events
..
dead code elimination in asterix-events
Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685
---
D
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/ClusterInfo.java
D
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/NodeInfo.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/driver/EventDriver.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/error/OutputHandler.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/error/VerificationUtil.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java
D
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/DefaultOutputHandler.java
D
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/ErrorHandler.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/EventExecutor.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/EventTask.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/EventUtil.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/model/AsterixInstance.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/model/BackupInfo.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/model/ProcessInfo.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventService.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventServiceUtil.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/ServiceProvider.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/ZooKeeperService.java
M
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/util/PatternCreator.java
M
asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/command/LogCommand.java
20 files changed, 47 insertions(+), 297 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/00/1300/1
diff --git
a/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/ClusterInfo.java
b/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/ClusterInfo.java
deleted file mode 100644
index d996e0e..000
---
a/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/ClusterInfo.java
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.asterix.event.api;
-
-import java.util.List;
-
-public class ClusterInfo {
-
-List nodes;
-
-public ClusterInfo(List nodes) {
-this.nodes = nodes;
-}
-}
diff --git
a/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/NodeInfo.java
b/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/NodeInfo.java
deleted file mode 100644
index d2dab4c..000
---
a/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/NodeInfo.java
+++ /dev/null
@@ -1,38 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.asterix.event.api;
-
-public class NodeInfo {
-
-private
[jira] [Created] (ASTERIXDB-1697) Joining results of with throws NullPointerException
Vignesh Raghunathan created ASTERIXDB-1697:
--
Summary: Joining results of with throws NullPointerException
Key: ASTERIXDB-1697
URL: https://issues.apache.org/jira/browse/ASTERIXDB-1697
Project: Apache AsterixDB
Issue Type: Bug
Reporter: Vignesh Raghunathan
To reproduce the issue, run the following sql++ statements:
{code}
drop dataverse sampdb if exists;
create dataverse sampdb;
use sampdb;
drop dataset samptable if exists;
drop type samptabletype if exists;
create type samptabletype as closed {
id: int8
};
create dataset samptable1(samptabletype) primary key id;
insert into samptable1 ({'id' : 1});
insert into samptable1 ({'id' : 2});
insert into samptable1 ({'id' : 3});
create dataset samptable2(samptabletype) primary key id;
insert into samptable2 ({'id' : 1});
insert into samptable2 ({'id' : 2});
insert into samptable2 ({'id' : 3});
drop dataset jointable if exists;
drop type jointabletype if exists;
create type jointabletype as closed {
id: int8
};
create dataset jointable(jointabletype) primary key id;
insert into jointable ({'id' : 0});
insert into jointable ({'id' : 1});
with samptab1 as (
select id
from samptable1
),
samptab2 as (
select id
from samptable2
)
select *
from
jointable as jt1
left outer join
samptab1 as st1
on jt1.id = 0
left outer join
samptab2 as st2
on jt1.id = 1
or st1.id = st2.id
left outer join
samptab1 as st12
on jt1.id = 1
or st12.id = st2.id;
{code}
Please see the attached logs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (ASTERIXDB-1697) Joining results of with throws NullPointerException
[
https://issues.apache.org/jira/browse/ASTERIXDB-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yingyi Bu reassigned ASTERIXDB-1697:
Assignee: Yingyi Bu
> Joining results of with throws NullPointerException
> ---
>
> Key: ASTERIXDB-1697
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1697
> Project: Apache AsterixDB
> Issue Type: Bug
>Reporter: Vignesh Raghunathan
>Assignee: Yingyi Bu
> Attachments: cc.log, my_asterix_nc1.log, my_asterix_nc2.log
>
>
> To reproduce the issue, run the following sql++ statements:
> {code}
> drop dataverse sampdb if exists;
> create dataverse sampdb;
> use sampdb;
> drop dataset samptable if exists;
> drop type samptabletype if exists;
> create type samptabletype as closed {
> id: int8
> };
> create dataset samptable1(samptabletype) primary key id;
> insert into samptable1 ({'id' : 1});
> insert into samptable1 ({'id' : 2});
> insert into samptable1 ({'id' : 3});
> create dataset samptable2(samptabletype) primary key id;
> insert into samptable2 ({'id' : 1});
> insert into samptable2 ({'id' : 2});
> insert into samptable2 ({'id' : 3});
> drop dataset jointable if exists;
> drop type jointabletype if exists;
> create type jointabletype as closed {
> id: int8
> };
> create dataset jointable(jointabletype) primary key id;
> insert into jointable ({'id' : 0});
> insert into jointable ({'id' : 1});
> with samptab1 as (
> select id
> from samptable1
> ),
> samptab2 as (
> select id
> from samptable2
> )
> select *
> from
> jointable as jt1
> left outer join
> samptab1 as st1
> on jt1.id = 0
> left outer join
> samptab2 as st2
> on jt1.id = 1
> or st1.id = st2.id
> left outer join
> samptab1 as st12
> on jt1.id = 1
> or st12.id = st2.id;
> {code}
> Please see the attached logs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ASTERIXDB-1697) Joining results of with throws NullPointerException
[
https://issues.apache.org/jira/browse/ASTERIXDB-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vignesh Raghunathan updated ASTERIXDB-1697:
---
Attachment: my_asterix_nc2.log
my_asterix_nc1.log
cc.log
> Joining results of with throws NullPointerException
> ---
>
> Key: ASTERIXDB-1697
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1697
> Project: Apache AsterixDB
> Issue Type: Bug
>Reporter: Vignesh Raghunathan
> Attachments: cc.log, my_asterix_nc1.log, my_asterix_nc2.log
>
>
> To reproduce the issue, run the following sql++ statements:
> {code}
> drop dataverse sampdb if exists;
> create dataverse sampdb;
> use sampdb;
> drop dataset samptable if exists;
> drop type samptabletype if exists;
> create type samptabletype as closed {
> id: int8
> };
> create dataset samptable1(samptabletype) primary key id;
> insert into samptable1 ({'id' : 1});
> insert into samptable1 ({'id' : 2});
> insert into samptable1 ({'id' : 3});
> create dataset samptable2(samptabletype) primary key id;
> insert into samptable2 ({'id' : 1});
> insert into samptable2 ({'id' : 2});
> insert into samptable2 ({'id' : 3});
> drop dataset jointable if exists;
> drop type jointabletype if exists;
> create type jointabletype as closed {
> id: int8
> };
> create dataset jointable(jointabletype) primary key id;
> insert into jointable ({'id' : 0});
> insert into jointable ({'id' : 1});
> with samptab1 as (
> select id
> from samptable1
> ),
> samptab2 as (
> select id
> from samptable2
> )
> select *
> from
> jointable as jt1
> left outer join
> samptab1 as st1
> on jt1.id = 0
> left outer join
> samptab2 as st2
> on jt1.id = 1
> or st1.id = st2.id
> left outer join
> samptab1 as st12
> on jt1.id = 1
> or st12.id = st2.id;
> {code}
> Please see the attached logs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Change in asterixdb[master]: dead code elimination in asterix-events
Jenkins has posted comments on this change. Change subject: dead code elimination in asterix-events .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3067/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1300 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Till Westmann has posted comments on this change. Change subject: Deps++, Refactor ClusterManager .. Patch Set 1: (1 comment) Fix the long lines in ClusterLifecycleListener and maybe throw if eventHome is null? https://asterix-gerrit.ics.uci.edu/#/c/1298/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManager.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManager.java: Line 66: String eventHome = asterixCluster == null ? null Seems that bad stuff could happen if eventHome is null ... -- To view, visit https://asterix-gerrit.ics.uci.edu/1298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. Patch Set 3: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1695 Fix Functions in Default Dataverse
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1695 Fix Functions in Default Dataverse .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/962/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1297 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f08c0acaccdcfaeb4fc9cfb1529214b543d0e86 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: leaner .gitignore
Jenkins has posted comments on this change. Change subject: leaner .gitignore .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/963/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1299 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ba4f1052c7c83b5a4875dd86b3f3a57e0ca9cb Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 1
Jenkins has posted comments on this change. Change subject: Full-text implementation step 1 .. Patch Set 11: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/964/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1228 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Hello Till Westmann, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1296 to look at the new patch set (#4). Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. ASTERIXDB-1696 - Big Object Spanning Log File Boundary - Big objects spanning log file boundary produces ArrayIndexOutOfBoundsException. Refactored large log page logic to correctly handle big objects at log file boundaries. - Add regression test Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc --- M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java M asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java M asterixdb/asterix-test-framework/src/main/resources/Catalog.xsd M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManagerWithReplication.java 7 files changed, 62 insertions(+), 53 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/96/1296/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3068/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Michael Blow has posted comments on this change.
Change subject: Deps++, Refactor ClusterManager
..
Patch Set 1:
(5 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1298/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java:
Line 82: Set subscribers =
ClusterManagerProvider.getClusterManager().getRegisteredClusterEventSubscribers();
> MAJOR SonarQube violation:
Done
Line 108: Set subscribers =
ClusterManagerProvider.getClusterManager().getRegisteredClusterEventSubscribers();
> MAJOR SonarQube violation:
Done
https://asterix-gerrit.ics.uci.edu/#/c/1298/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManager.java
File
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManager.java:
Line 66: String eventHome = asterixCluster == null ? null
> Seems that bad stuff could happen if eventHome is null ...
Done
https://asterix-gerrit.ics.uci.edu/#/c/1298/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManagerProvider.java
File
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManagerProvider.java:
Line 31: public class ClusterManagerProvider {
> MAJOR SonarQube violation:
Done
Line 37: private static final class Holder {
> MAJOR SonarQube violation:
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1298
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1298 to look at the new patch set (#2). Change subject: Deps++, Refactor ClusterManager .. Deps++, Refactor ClusterManager - Exclude runtime-scoped junit from appassembler-booter dep Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterWorkExecutor.java M asterixdb/asterix-client-helper/pom.xml M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IClusterManager.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManager.java A asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManagerProvider.java M asterixdb/asterix-server/pom.xml 8 files changed, 146 insertions(+), 50 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/98/1298/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Till Westmann has posted comments on this change. Change subject: Deps++, Refactor ClusterManager .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Jenkins has posted comments on this change. Change subject: Deps++, Refactor ClusterManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3069/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: dead code elimination in asterix-events
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1300 to look at the new patch set (#2). Change subject: dead code elimination in asterix-events .. dead code elimination in asterix-events Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 --- D asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/ClusterInfo.java D asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/NodeInfo.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/driver/EventDriver.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/error/OutputHandler.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/error/VerificationUtil.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java D asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/DefaultOutputHandler.java D asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/ErrorHandler.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/EventExecutor.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/EventTask.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/EventUtil.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/model/AsterixInstance.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/model/BackupInfo.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/model/ProcessInfo.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventService.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventServiceUtil.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/ServiceProvider.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/ZooKeeperService.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/util/PatternCreator.java M asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/command/LogCommand.java 20 files changed, 55 insertions(+), 318 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/00/1300/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1300 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: dead code elimination in asterix-events
Michael Blow has posted comments on this change. Change subject: dead code elimination in asterix-events .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1300 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: dead code elimination in asterix-events
Jenkins has posted comments on this change. Change subject: dead code elimination in asterix-events .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3070/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1300 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1695 Fix Functions in Default Dataverse
Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1695 Fix Functions in Default Dataverse .. Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1297/2/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java: Line 106: + "(...)\", the dataverse \"" + signature.getNamespace() + "\" cannot be found!"); extract signature.getNamespace() and call that before the if-block? -- To view, visit https://asterix-gerrit.ics.uci.edu/1297 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f08c0acaccdcfaeb4fc9cfb1529214b543d0e86 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Hello Till Westmann, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1296 to look at the new patch set (#5). Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. ASTERIXDB-1696 - Big Object Spanning Log File Boundary - Big objects spanning log file boundary produces ArrayIndexOutOfBoundsException. Refactored large log page logic to correctly handle big objects at log file boundaries. - Add regression test Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc --- M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java M asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java M asterixdb/asterix-test-framework/src/main/resources/Catalog.xsd M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManagerWithReplication.java 7 files changed, 67 insertions(+), 56 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/96/1296/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Michael Blow has submitted this change and it was merged.
Change subject: Deps++, Refactor ClusterManager
..
Deps++, Refactor ClusterManager
- Exclude runtime-scoped junit from appassembler-booter dep
Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1298
Reviewed-by: Till Westmann
Tested-by: Jenkins
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterWorkExecutor.java
M asterixdb/asterix-client-helper/pom.xml
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IClusterManager.java
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManager.java
A
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManagerProvider.java
M asterixdb/asterix-server/pom.xml
8 files changed, 146 insertions(+), 50 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
index 764b559..919af33 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
@@ -62,7 +62,7 @@
import org.apache.asterix.metadata.MetadataManager;
import org.apache.asterix.metadata.api.IAsterixStateProxy;
import org.apache.asterix.metadata.bootstrap.AsterixStateProxy;
-import org.apache.asterix.metadata.cluster.ClusterManager;
+import org.apache.asterix.metadata.cluster.ClusterManagerProvider;
import org.apache.asterix.runtime.util.AsterixAppContextInfo;
import org.apache.hyracks.api.application.ICCApplicationContext;
import org.apache.hyracks.api.application.ICCApplicationEntryPoint;
@@ -128,7 +128,7 @@
server.start();
}
-
ClusterManager.INSTANCE.registerSubscriber(GlobalRecoveryManager.instance());
+
ClusterManagerProvider.getClusterManager().registerSubscriber(GlobalRecoveryManager.instance());
ccAppCtx.addClusterLifecycleListener(ClusterLifecycleListener.INSTANCE);
ccAppCtx.setMessageBroker(messageBroker);
@@ -323,13 +323,7 @@
@Override
public void startupCompleted() throws Exception {
-// Notify Zookeeper that the startup is complete
-ILookupService zookeeperService = ClusterManager.getLookupService();
-if (zookeeperService != null) {
-// Our asterix app runtimes tests don't use zookeeper
-
zookeeperService.reportClusterState(ClusterProperties.INSTANCE.getCluster().getInstanceName(),
-ClusterState.ACTIVE);
-}
+ClusterManagerProvider.getClusterManager().notifyStartupCompleted();
}
public static synchronized void setAsterixStateProxy(IAsterixStateProxy
proxy) {
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
index 75cbe44..7a4ff13 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
@@ -37,7 +37,7 @@
import org.apache.asterix.metadata.MetadataManager;
import org.apache.asterix.metadata.cluster.AddNodeWork;
import org.apache.asterix.metadata.cluster.AddNodeWorkResponse;
-import org.apache.asterix.metadata.cluster.ClusterManager;
+import org.apache.asterix.metadata.cluster.ClusterManagerProvider;
import org.apache.asterix.metadata.cluster.RemoveNodeWork;
import org.apache.asterix.metadata.cluster.RemoveNodeWorkResponse;
import org.apache.asterix.runtime.util.ClusterStateManager;
@@ -79,7 +79,8 @@
Set nodeAddition = new HashSet();
nodeAddition.add(nodeId);
updateProgress(ClusterEventType.NODE_JOIN, nodeAddition);
-Set subscribers =
ClusterManager.INSTANCE.getRegisteredClusterEventSubscribers();
+Set subscribers =
+
ClusterManagerProvider.getClusterManager().getRegisteredClusterEventSubscribers();
Set work = new
HashSet();
for (IClusterEventsSubscriber sub : subscribers) {
Set workRequest =
sub.notifyNodeJoin(nodeId);
@@ -105,7 +106,8 @@
}
}
updateProgress(ClusterEventType.NODE_FAILURE, deadNodeIds);
-
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3071/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1695 Fix Functions in Default Dataverse
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1695 Fix Functions in Default Dataverse .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/962/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1297 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f08c0acaccdcfaeb4fc9cfb1529214b543d0e86 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: leaner .gitignore
Jenkins has posted comments on this change. Change subject: leaner .gitignore .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/963/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1299 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ba4f1052c7c83b5a4875dd86b3f3a57e0ca9cb Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 1
Jenkins has posted comments on this change. Change subject: Full-text implementation step 1 .. Patch Set 11: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/964/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1228 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Jenkins has posted comments on this change. Change subject: Deps++, Refactor ClusterManager .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/967/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Murtadha Hubail has posted comments on this change. Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. Patch Set 5: Code-Review+2 Just a general comment that is not related to this change only. We have some test cases that depend on our current test instance default configurations (dataset memory budget, log file size, ect..). If we change these default configurations, then those test cases won't be testing what they are meant to test anymore. It would be a nice enhancement to our test framework if we could specify certain configurations to be used for certain tests. -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/966/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: dead code elimination in asterix-events
Jenkins has posted comments on this change. Change subject: dead code elimination in asterix-events .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/968/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1300 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Ian Maxon has posted comments on this change. Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: dead code elimination in asterix-events
Hello Michael Blow, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1300 to look at the new patch set (#3). Change subject: dead code elimination in asterix-events .. dead code elimination in asterix-events Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 --- D asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/ClusterInfo.java D asterixdb/asterix-events/src/main/java/org/apache/asterix/event/api/NodeInfo.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/driver/EventDriver.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/error/OutputHandler.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/error/VerificationUtil.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java D asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/DefaultOutputHandler.java D asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/ErrorHandler.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/EventExecutor.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/EventTask.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/EventUtil.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/model/AsterixInstance.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/model/BackupInfo.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/model/ProcessInfo.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventService.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventServiceUtil.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/ServiceProvider.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/ZooKeeperService.java M asterixdb/asterix-events/src/main/java/org/apache/asterix/event/util/PatternCreator.java M asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/command/LogCommand.java 20 files changed, 54 insertions(+), 323 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/00/1300/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1300 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: dead code elimination in asterix-events
Jenkins has posted comments on this change. Change subject: dead code elimination in asterix-events .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3072/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1300 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Michael Blow has submitted this change and it was merged.
Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
..
ASTERIXDB-1696 - Big Object Spanning Log File Boundary
- Big objects spanning log file boundary produces
ArrayIndexOutOfBoundsException. Refactored large log page logic to
correctly handle big objects at log file boundaries.
- Add regression test
Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1296
Reviewed-by: Murtadha Hubail
Reviewed-by: Ian Maxon
Tested-by: Jenkins
---
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M
asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java
M asterixdb/asterix-test-framework/src/main/resources/Catalog.xsd
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManagerWithReplication.java
7 files changed, 67 insertions(+), 56 deletions(-)
Approvals:
Murtadha Hubail: Looks good to me, approved
Ian Maxon: Looks good to me, approved
Jenkins: Verified
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
index 15bb500..8ed833f 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
@@ -117,6 +117,7 @@
@Test
public void test() throws Exception {
+int repeat = ExecutionTest.repeat * tcCtx.getRepeat();
try {
for (int i = 1; i <= repeat; i++) {
if (repeat > 1) {
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
index d0e342c..7a19102 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
@@ -6731,7 +6731,7 @@
big_object_load_only_20M
-
+
big_object_feed_20M
diff --git
a/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
b/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
index 29c0afd..741518a 100644
---
a/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
+++
b/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
@@ -66,6 +66,7 @@
import org.apache.http.impl.client.HttpClients;
import org.apache.http.impl.client.StandardHttpRequestRetryHandler;
import org.apache.http.util.EntityUtils;
+import org.apache.hyracks.util.StorageUtil;
import org.json.JSONArray;
import org.json.JSONException;
import org.json.JSONObject;
@@ -85,6 +86,7 @@
private static final Pattern POLL_TIMEOUT_PATTERN =
Pattern.compile("polltimeoutsecs=(\\d+)(\\D|$)",
Pattern.MULTILINE);
private static final Pattern POLL_DELAY_PATTERN =
Pattern.compile("polldelaysecs=(\\d+)(\\D|$)", Pattern.MULTILINE);
+public static final int TRUNCATE_THRESHOLD = 16384;
private static Method managixExecuteMethod = null;
private static final HashMap runningTestServers =
new HashMap<>();
@@ -147,30 +149,24 @@
if (lineExpected.isEmpty()) {
continue;
}
-throw new ComparisonException(
-"Result for " + scriptFile + " changed at line " +
num + ":\n< " + lineExpected + "\n> ");
+throwLineChanged(scriptFile, lineExpected, "", num);
}
// Comparing result equality but ignore "Time"-prefixed
fields. (for metadata tests.)
String[] lineSplitsExpected = lineExpected.split("Time");
String[] lineSplitsActual = lineActual.split("Time");
if (lineSplitsExpected.length != lineSplitsActual.length) {
-throw new ComparisonException(
-"Result for " + scriptFile + " changed at line " +
num + ":\n< " + lineExpected
-+ "\n> " + lineActual);
+throwLineChanged(scriptFile, lineExpected, lineActual,
num);
}
if (!equalStrings(lineSplitsExpected[0], lineSplitsActual[0],
regex)) {
-throw new ComparisonExceptio
[jira] [Commented] (ASTERIXDB-1696) Big objects spanning log file boundary produces ArrayIndexOutOfBoundsException
[ https://issues.apache.org/jira/browse/ASTERIXDB-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586318#comment-15586318 ] ASF subversion and git services commented on ASTERIXDB-1696: Commit f309eb4afc5387f120359c27a3742d6b03eda30f in asterixdb's branch refs/heads/master from [~mblow] [ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=f309eb4 ] ASTERIXDB-1696 - Big Object Spanning Log File Boundary - Big objects spanning log file boundary produces ArrayIndexOutOfBoundsException. Refactored large log page logic to correctly handle big objects at log file boundaries. - Add regression test Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Reviewed-on: https://asterix-gerrit.ics.uci.edu/1296 Reviewed-by: Murtadha Hubail Reviewed-by: Ian Maxon Tested-by: Jenkins > Big objects spanning log file boundary produces ArrayIndexOutOfBoundsException > -- > > Key: ASTERIXDB-1696 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1696 > Project: Apache AsterixDB > Issue Type: Bug > Components: AsterixDB >Reporter: Michael Blow >Assignee: Michael Blow > > FYI: each test will be run 1000 times. > [1/1000] Expected results file: > /var/folders/5x/qdtntlds0fgcgknzwf61khvhgn/T/template.5778240242743996115.big_object_feed_20M.1.adm > [2/1000] Expected results file: > /var/folders/5x/qdtntlds0fgcgknzwf61khvhgn/T/template.1266068079871898912.big_object_feed_20M.1.adm > [3/1000] Expected results file: > /var/folders/5x/qdtntlds0fgcgknzwf61khvhgn/T/template.6993159241126337116.big_object_feed_20M.1.adm > [4/1000] Expected results file: > /var/folders/5x/qdtntlds0fgcgknzwf61khvhgn/T/template.596733397297092827.big_object_feed_20M.1.adm > [5/1000] java.lang.ArrayIndexOutOfBoundsException > at java.lang.System.arraycopy(Native Method) > at > org.apache.hyracks.storage.am.common.tuples.SimpleTupleWriter.writeTuple(SimpleTupleWriter.java:82) > at > org.apache.asterix.common.transactions.LogRecord.writeTuple(LogRecord.java:212) > at > org.apache.asterix.common.transactions.LogRecord.doWriteLogRecord(LogRecord.java:146) > at > org.apache.asterix.common.transactions.LogRecord.writeLogRecord(LogRecord.java:182) > at > org.apache.asterix.transaction.management.service.logging.LogBuffer.append(LogBuffer.java:92) > at > org.apache.asterix.transaction.management.service.logging.LogManager.syncAppendToLogTail(LogManager.java:170) > at > org.apache.asterix.transaction.management.service.logging.LogManager.appendToLogTail(LogManager.java:128) > at > org.apache.asterix.transaction.management.service.logging.LogManager.log(LogManager.java:124) > at > org.apache.asterix.transaction.management.opcallbacks.AbstractIndexModificationOperationCallback.log(AbstractIndexModificationOperationCallback.java:81) > at > org.apache.asterix.transaction.management.opcallbacks.PrimaryIndexModificationOperationCallback.found(PrimaryIndexModificationOperationCallback.java:108) > at > org.apache.hyracks.storage.am.btree.impls.BTree.insertLeaf(BTree.java:376) > at > org.apache.hyracks.storage.am.btree.impls.BTree.upsertLeaf(BTree.java:530) > at > org.apache.hyracks.storage.am.btree.impls.BTree.performOp(BTree.java:771) > at > org.apache.hyracks.storage.am.btree.impls.BTree.insertUpdateOrDelete(BTree.java:312) > at > org.apache.hyracks.storage.am.btree.impls.BTree.upsert(BTree.java:345) > at > org.apache.hyracks.storage.am.btree.impls.BTree.access$500(BTree.java:74) > at > org.apache.hyracks.storage.am.btree.impls.BTree$BTreeAccessor.upsertIfConditionElseInsert(BTree.java:953) > at > org.apache.hyracks.storage.am.lsm.btree.impls.LSMBTree.insert(LSMBTree.java:402) > at > org.apache.hyracks.storage.am.lsm.btree.impls.LSMBTree.modify(LSMBTree.java:343) > at > org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness.modify(LSMHarness.java:376) > at > org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness.modify(LSMHarness.java:363) > at > org.apache.hyracks.storage.am.lsm.common.impls.LSMTreeIndexAccessor.insert(LSMTreeIndexAccessor.java:50) > at > org.apache.asterix.common.dataflow.AsterixLSMInsertDeleteOperatorNodePushable.nextFrame(AsterixLSMInsertDeleteOperatorNodePushable.java:126) > at > org.apache.asterix.external.feed.dataflow.SyncFeedRuntimeInputHandler.nextFrame(SyncFeedRuntimeInputHandler.java:46) > at > org.apache.asterix.external.operators.FeedMetaStoreNodePushable.nextFrame(FeedMetaStoreNodePushable.java:145) > at org.apache.hyracks.control.nc.Task.pushFrames(Task.java:361) > at org.apache.hyracks.control.nc.Task.run(Task.java:309) > at > j
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/969/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Deps++, Refactor ClusterManager
Jenkins has posted comments on this change. Change subject: Deps++, Refactor ClusterManager .. Patch Set 2: Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/967/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: dead code elimination in asterix-events
Jenkins has posted comments on this change. Change subject: dead code elimination in asterix-events .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/970/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1300 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1301
Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
..
Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
- Managix options for cc / nc java opts are not used for NC service
clustes, omit these from the cluster HTTP api.
- Ini jvm.args should take precedence over $JAVA_OPTS in environment
when launching NCDriver
Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89
---
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
2 files changed, 11 insertions(+), 10 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/01/1301/1
diff --git
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
index 1a9096d..15a1f39 100644
---
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
+++
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
@@ -92,13 +92,11 @@
PropertyInterpreters.getLevelPropertyInterpreter());
}
-@PropertyKey(EXTERNAL_NC_JAVA_OPTS_KEY)
public String getNCJavaParams() {
return accessor.getProperty(EXTERNAL_NC_JAVA_OPTS_KEY,
EXTERNAL_NC_JAVA_OPTS_DEFAULT,
PropertyInterpreters.getStringPropertyInterpreter());
}
-@PropertyKey(EXTERNAL_CC_JAVA_OPTS_KEY)
public String getCCJavaParams() {
return accessor.getProperty(EXTERNAL_CC_JAVA_OPTS_KEY,
EXTERNAL_CC_JAVA_OPTS_DEFAULT,
PropertyInterpreters.getStringPropertyInterpreter());
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
index 848bdd2..8ca61ad 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
@@ -105,17 +105,20 @@
}
private static void configEnvironment(Map env) {
-if (env.containsKey("JAVA_OPTS")) {
-if (LOGGER.isLoggable(Level.INFO)) {
-LOGGER.info("Keeping JAVA_OPTS from environment");
+String jvmargs = IniUtils.getString(ini, nodeSection, "jvm.args",
null);
+if (jvmargs != null) {
+LOGGER.info("Using JAVA_OPTS from conf file (jvm.args)");
+} else {
+jvmargs = env.get("JAVA_OPTS");
+if (jvmargs != null) {
+LOGGER.info("Using JAVA_OPTS from environment");
+} else {
+LOGGER.info("Using default JAVA_OPTS");
+jvmargs = "-Xmx1536m";
}
-return;
}
-String jvmargs = IniUtils.getString(ini, nodeSection, "jvm.args",
"-Xmx1536m");
env.put("JAVA_OPTS", jvmargs);
-if (LOGGER.isLoggable(Level.INFO)) {
-LOGGER.info("Setting JAVA_OPTS to " + jvmargs);
-}
+LOGGER.info("Setting JAVA_OPTS to " + jvmargs);
}
/**
--
To view, visit https://asterix-gerrit.ics.uci.edu/1301
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3073/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Michael Blow has uploaded a new patch set (#2). Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env - Managix options for cc / nc java opts are not used for NC service clusters, omit these from the cluster HTTP api. - Ini jvm.args should take precedence over $JAVA_OPTS in environment when launching NCDriver Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java 2 files changed, 11 insertions(+), 10 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/01/1301/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3074/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: dead code elimination in asterix-events
Jenkins has posted comments on this change. Change subject: dead code elimination in asterix-events .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/970/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1300 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary .. Patch Set 5: Integration Tests Timed Out https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/969/ : ABORTED -- To view, visit https://asterix-gerrit.ics.uci.edu/1296 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: fix some log levels
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1302
Change subject: fix some log levels
..
fix some log levels
Change-Id: I4810f02e1be0b4a4b5238afa7b929ff547beef06
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/02/1302/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
index d4d2bce..d6961b3 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
@@ -119,8 +119,8 @@
}
componentDumpStream = new FileOutputStream(f);
}
-if (LOGGER.isLoggable(Level.SEVERE)) {
-LOGGER.severe("Stopping component instance" +
component.getClass().getName() + " dump state "
+if (LOGGER.isLoggable(Level.INFO)) {
+LOGGER.info("Stopping component instance " +
component.getClass().getName() + " dump state "
+ dumpState + " dump path " + componentDumpPath);
}
component.stop(dumpState, componentDumpStream);
@@ -143,12 +143,12 @@
dumpPath = configuration.get(Config.DUMP_PATH_KEY);
if (dumpPath == null) {
dumpPath = System.getProperty("user.dir");
-if (LOGGER.isLoggable(Level.SEVERE)) {
-LOGGER.severe("dump path not configured. Using current
directory " + dumpPath);
+if (LOGGER.isLoggable(Level.WARNING)) {
+LOGGER.warning("dump path not configured. Using current
directory " + dumpPath);
}
}
if (LOGGER.isLoggable(Level.INFO)) {
-LOGGER.severe("LifecycleComponentManager configured " + this);
+LOGGER.info("LifecycleComponentManager configured " + this);
}
configured = true;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/1302
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4810f02e1be0b4a4b5238afa7b929ff547beef06
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Change in asterixdb[master]: fix some log levels
Jenkins has posted comments on this change. Change subject: fix some log levels .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3075/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1302 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4810f02e1be0b4a4b5238afa7b929ff547beef06 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1301 to look at the new patch set (#3). Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env - Managix options for cc / nc java opts are not used for NC service clustes, omit these from the cluster HTTP api. - Ini jvm.args should take precedence over $JAVA_OPTS in environment when launching NCDriver Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 --- M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java 3 files changed, 11 insertions(+), 12 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/01/1301/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3076/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: fix some log levels
Jenkins has posted comments on this change. Change subject: fix some log levels .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/971/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1302 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4810f02e1be0b4a4b5238afa7b929ff547beef06 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Till Westmann has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1301/3//COMMIT_MSG Commit Message: Line 10: clustes, omit these from the cluster HTTP api. s/clustes/ clusters/ also break lines after 77 chars -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/972/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: fix some log levels
Jenkins has posted comments on this change. Change subject: fix some log levels .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/971/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1302 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4810f02e1be0b4a4b5238afa7b929ff547beef06 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: fix some log levels
Michael Blow has posted comments on this change. Change subject: fix some log levels .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1302 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4810f02e1be0b4a4b5238afa7b929ff547beef06 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Documentation cleanup.
Till Westmann has posted comments on this change.
Change subject: Documentation cleanup.
..
Patch Set 4:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1295/4/asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser-new/classad-parser-new.3.ddl.aql
File
asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser-new/classad-parser-new.3.ddl.aql:
Line 25: ("object-start"="["),
I think that this will break the ClassAd parser.
https://asterix-gerrit.ics.uci.edu/#/c/1295/4/asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/get-object-field-value/documentation-example/documentation-example.2.query.aql
File
asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/get-object-field-value/documentation-example/documentation-example.2.query.aql:
Line 28: return get-object-field-value($r1, "address")
Did the result change as well?
https://asterix-gerrit.ics.uci.edu/#/c/1295/4/asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md
File asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md:
Line 240: - *excess.objects.discard*: Set to true if excess objects should be
discarded. (Default: false)
Is this changed in the code as well?
--
To view, visit https://asterix-gerrit.ics.uci.edu/1295
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb2be81d1bfa37dd876cd36a7a5bb824bc3ab86
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: Introduce XML Reader & Parser
Till Westmann has posted comments on this change. Change subject: Introduce XML Reader & Parser .. Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1269/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/XMLFileParser.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/XMLFileParser.java: Line 48: JSONObject xmlObj = XML.toJSONObject(record.toString()); > I found this in the org.json.XML documentation. "Some information may be lost" doesn't sound ideal :) Is this aiming to be a general purpose XML ingestion method or is there a specific use-case that needs to be addressed? -- To view, visit https://asterix-gerrit.ics.uci.edu/1269 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 3: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/972/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-1698) Secondary index doesn't follow the compaction policy
Jianfeng Jia created ASTERIXDB-1698:
---
Summary: Secondary index doesn't follow the compaction policy
Key: ASTERIXDB-1698
URL: https://issues.apache.org/jira/browse/ASTERIXDB-1698
Project: Apache AsterixDB
Issue Type: Bug
Components: Storage
Environment: master : 4819ea44723b87a68406d248782861cf6e5d3305
Reporter: Jianfeng Jia
Assignee: Ian Maxon
Here is the ddl for the dataset:
{code}
create dataset ds_tweet(typeTweet) if not exists primary key id using
compaction policy prefix
(("max-mergable-component-size"="134217728"),("max-tolerance-component-count"="10"))
with filter on create_at ;
create index text_idx if not exists on ds_tweet("text") type keyword;
{code}
In this case, I want to create a smaller component around 128M. During the data
ingestion phase, it works well, and the size of each text_idx component is also
small (~80M each). I assume it also followed the component size constraint?
After ingestion, I found that I needed to build another index,
{code}
create index time_idx if not exists on ds_tweet(create_at) type btree;
{code}
When it finished, I found that this time_idx didn't follow the constraint and
ended up with one giant 1.2G component on each partition.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Change in asterixdb[master]: Documentation cleanup.
Yingyi Bu has posted comments on this change.
Change subject: Documentation cleanup.
..
Patch Set 4:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1295/4/asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser-new/classad-parser-new.3.ddl.aql
File
asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser-new/classad-parser-new.3.ddl.aql:
Line 25: ("object-start"="["),
> I think that this will break the ClassAd parser.
Done
https://asterix-gerrit.ics.uci.edu/#/c/1295/4/asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/get-object-field-value/documentation-example/documentation-example.2.query.aql
File
asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/get-object-field-value/documentation-example/documentation-example.2.query.aql:
Line 28: return get-object-field-value($r1, "address")
> Did the result change as well?
I think gerrit is doing diff on different files?
https://asterix-gerrit.ics.uci.edu/#/c/1295/4/asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md
File asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md:
Line 240: - *excess.objects.discard*: Set to true if excess objects should be
discarded. (Default: false)
> Is this changed in the code as well?
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1295
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb2be81d1bfa37dd876cd36a7a5bb824bc3ab86
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: Yingyi Bu
Gerrit-HasComments: Yes
Change in asterixdb[master]: fix some log levels
Till Westmann has submitted this change and it was merged.
Change subject: fix some log levels
..
fix some log levels
Change-Id: I4810f02e1be0b4a4b5238afa7b929ff547beef06
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1302
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Michael Blow
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
index d4d2bce..d6961b3 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
@@ -119,8 +119,8 @@
}
componentDumpStream = new FileOutputStream(f);
}
-if (LOGGER.isLoggable(Level.SEVERE)) {
-LOGGER.severe("Stopping component instance" +
component.getClass().getName() + " dump state "
+if (LOGGER.isLoggable(Level.INFO)) {
+LOGGER.info("Stopping component instance " +
component.getClass().getName() + " dump state "
+ dumpState + " dump path " + componentDumpPath);
}
component.stop(dumpState, componentDumpStream);
@@ -143,12 +143,12 @@
dumpPath = configuration.get(Config.DUMP_PATH_KEY);
if (dumpPath == null) {
dumpPath = System.getProperty("user.dir");
-if (LOGGER.isLoggable(Level.SEVERE)) {
-LOGGER.severe("dump path not configured. Using current
directory " + dumpPath);
+if (LOGGER.isLoggable(Level.WARNING)) {
+LOGGER.warning("dump path not configured. Using current
directory " + dumpPath);
}
}
if (LOGGER.isLoggable(Level.INFO)) {
-LOGGER.severe("LifecycleComponentManager configured " + this);
+LOGGER.info("LifecycleComponentManager configured " + this);
}
configured = true;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/1302
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4810f02e1be0b4a4b5238afa7b929ff547beef06
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: Documentation cleanup.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1295 to look at the new patch set (#5). Change subject: Documentation cleanup. .. Documentation cleanup. 1. "record"->"object", 2. JSONify sqlpp/3_query.md. Change-Id: Idcb2be81d1bfa37dd876cd36a7a5bb824bc3ab86 --- M asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/opentype-insert2/opentype-insert2.1.ddl.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/opentype-insert2/opentype-insert2.2.update.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/opentype-insert2/opentype-insert2.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/ObjectsQueries.xml R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.10.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.11.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.12.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.4.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.5.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.6.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.7.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.8.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.9.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-closed-fieldname-conflict_issue173/closed-closed-fieldname-conflict_issue173.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-closed-fieldname-conflict_issue173/closed-closed-fieldname-conflict_issue173.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-closed-fieldname-conflict_issue173/closed-closed-fieldname-conflict_issue173.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-nullable-fields_issue1616/closed-nullable-fileds_issue1616.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-nullable-fields_issue1616/closed-nullable-fileds_issue1616.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-nullable-fields_issue1616/closed-nullable-fileds_issue1616.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_01/closed-record-constructor_01.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_01/closed-record-constructor_01.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_01/closed-record-constructor_01.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_02/closed-record-constructor_02.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_02/closed-record-constructor_02.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_02/closed-record-constructor_02.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_03/closed-record-constructor_03.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_03/closed-record-constructor_03.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_03/closed-record-constructor_03.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/expFieldName/expFieldName.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/expFieldName/expFieldName.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/expFieldName/expFieldName.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/field-access-by-index_01/field-access-by-index_01.1.ddl.aql R asterixdb/asterix-app/src/test/resource
Change in asterixdb[master]: Documentation cleanup.
Jenkins has posted comments on this change. Change subject: Documentation cleanup. .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3077/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1295 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcb2be81d1bfa37dd876cd36a7a5bb824bc3ab86 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Documentation cleanup.
Till Westmann has posted comments on this change. Change subject: Documentation cleanup. .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1295 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcb2be81d1bfa37dd876cd36a7a5bb824bc3ab86 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Till Westmann has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 3: TRIGGER asterix-gerrit-integration-tests -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/973/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity
Ian Maxon has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1303
Change subject: Make Lock Manager Statistics at FINE granularity
..
Make Lock Manager Statistics at FINE granularity
It seems like in some scenarios the Lock manager can output a large volume
of logs and this can get excessive quickly. Our default level is at INFO
so I thought FINE might be more appropriate.
I also made the Managix Log append rather than clobber the old logs.
Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
---
M asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
M asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
3 files changed, 12 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/03/1303/1
diff --git
a/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
b/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
index b7481e9..4696cbd 100644
--- a/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
+++ b/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
@@ -67,4 +67,9 @@
ccArgs=$ccArgs' -cc-root '$CC_ROOT
fi
cd $WORKING_DIR
-$ASTERIX_HOME/bin/asterixcc echo $ccArgs &> $LOG_DIR/cc.log
\ No newline at end of file
+DATE=`date`
+
+echo "
"
>> $LOG_DIR/cc.log
+echo "LOG START: $DATE" >> $LOG_DIR/cc.log
+echo "
"
>> $LOG_DIR/cc.log
+$ASTERIX_HOME/bin/asterixcc echo $ccArgs &>> $LOG_DIR/cc.log
\ No newline at end of file
diff --git
a/asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
b/asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
index 4884872..50427ae 100644
--- a/asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
+++ b/asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
@@ -28,4 +28,8 @@
cd $WORKING_DIR
+DATE=`date`
+echo "
"
>> $LOG_DIR/$LOG_DIR/${NC_ID}.log
+echo "LOG START: $DATE" >> $LOG_DIR/$LOG_DIR/${NC_ID}.log
+echo "
"
>> $LOG_DIR/$LOG_DIR/${NC_ID}.log
$ASTERIX_HOME/bin/asterixnc -node-id $NC_ID -cc-host $CC_HOST -cc-port
$CLUSTER_NET_PORT -cluster-net-ip-address $IP_LOCATION -data-ip-address
$IP_LOCATION -iodevices $IO_DEVICES -result-ip-address $IP_LOCATION --
$INITIAL_RUN_FLAG &> $LOG_DIR/${NC_ID}.log
diff --git
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
index 8dcc1be..faec2ed 100644
---
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
+++
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
@@ -555,7 +555,7 @@
LOGGER.finer("del job slot " + TypeUtil.Global.toString(jobSlot));
jobArenaMgr.deallocate(jobSlot);
jobId2JobSlotMap.remove(jobId);
-stats.logCounters(LOGGER, Level.INFO, true);
+stats.logCounters(LOGGER, Level.FINE, true);
}
private long findOrAllocJobSlot(int jobId) {
@@ -662,7 +662,7 @@
}
private long findResourceInGroup(ResourceGroup group, int dsId, int
entityHashValue) {
-stats.logCounters(LOGGER, Level.INFO, false);
+stats.logCounters(LOGGER, Level.FINE, false);
long resSlot = group.firstResourceIndex.get();
while (resSlot != NILL) {
// either we already have a lock on this resource or we have a
--
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon
Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity
Jenkins has posted comments on this change. Change subject: Make Lock Manager Statistics at FINE granularity .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3078/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1303 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity
Ian Maxon has uploaded a new patch set (#2). Change subject: Make Lock Manager Statistics at FINE granularity .. Make Lock Manager Statistics at FINE granularity It seems like in some scenarios the Lock manager can output a large volume of logs and this can get excessive quickly. Our default level is at INFO so I thought FINE might be more appropriate. I also made the Managix Log append rather than clobber the old logs. Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2 --- M asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh M asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java 3 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/03/1303/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1303 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: dead code elimination in asterix-events
abdullah alamoudi has posted comments on this change. Change subject: dead code elimination in asterix-events .. Patch Set 3: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1300 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8873652ca6b3add003e7454d09c175b2218ed685 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Documentation cleanup.
Jenkins has posted comments on this change. Change subject: Documentation cleanup. .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/974/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1295 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcb2be81d1bfa37dd876cd36a7a5bb824bc3ab86 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1303 to look at the new patch set (#3). Change subject: Make Lock Manager Statistics at FINE granularity .. Make Lock Manager Statistics at FINE granularity It seems like in some scenarios the Lock manager can output a large volume of logs and this can get excessive quickly. Our default level is at INFO so I thought FINE might be more appropriate. I also made the Managix Log append rather than clobber the old logs. Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2 --- M asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh M asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java 3 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/03/1303/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1303 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity
Jenkins has posted comments on this change. Change subject: Make Lock Manager Statistics at FINE granularity .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3080/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1303 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1695 Fix Functions in Default Dataverse
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1297 to look at the new patch set (#3). Change subject: ASTERIXDB-1695 Fix Functions in Default Dataverse .. ASTERIXDB-1695 Fix Functions in Default Dataverse Change-Id: I7f08c0acaccdcfaeb4fc9cfb1529214b543d0e86 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/default/default.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/default/default.2.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/default/default.3.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/types/default/default.2.adm M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java 6 files changed, 78 insertions(+), 10 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/97/1297/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1297 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7f08c0acaccdcfaeb4fc9cfb1529214b543d0e86 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity
Jenkins has posted comments on this change. Change subject: Make Lock Manager Statistics at FINE granularity .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3079/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1303 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1695 Fix Functions in Default Dataverse
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1695 Fix Functions in Default Dataverse .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3081/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1297 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f08c0acaccdcfaeb4fc9cfb1529214b543d0e86 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/973/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity
Jenkins has posted comments on this change. Change subject: Make Lock Manager Statistics at FINE granularity .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/975/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1303 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Documentation cleanup.
Jenkins has posted comments on this change. Change subject: Documentation cleanup. .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/974/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1295 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcb2be81d1bfa37dd876cd36a7a5bb824bc3ab86 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1695 Fix Functions in Default Dataverse
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1695 Fix Functions in Default Dataverse .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/976/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1297 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f08c0acaccdcfaeb4fc9cfb1529214b543d0e86 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Documentation cleanup.
Yingyi Bu has submitted this change and it was merged. Change subject: Documentation cleanup. .. Documentation cleanup. 1. "record"->"object", 2. JSONify sqlpp/3_query.md. Change-Id: Idcb2be81d1bfa37dd876cd36a7a5bb824bc3ab86 Reviewed-on: https://asterix-gerrit.ics.uci.edu/1295 Reviewed-by: Till Westmann Sonar-Qube: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins --- M asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/opentype-insert2/opentype-insert2.1.ddl.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/opentype-insert2/opentype-insert2.2.update.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/opentype-insert2/opentype-insert2.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/ObjectsQueries.xml R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.10.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.11.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.12.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.4.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.5.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.6.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.7.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.8.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/access-nested-fields/access-nested-fields.9.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-closed-fieldname-conflict_issue173/closed-closed-fieldname-conflict_issue173.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-closed-fieldname-conflict_issue173/closed-closed-fieldname-conflict_issue173.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-closed-fieldname-conflict_issue173/closed-closed-fieldname-conflict_issue173.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-nullable-fields_issue1616/closed-nullable-fileds_issue1616.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-nullable-fields_issue1616/closed-nullable-fileds_issue1616.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-nullable-fields_issue1616/closed-nullable-fileds_issue1616.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_01/closed-record-constructor_01.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_01/closed-record-constructor_01.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_01/closed-record-constructor_01.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_02/closed-record-constructor_02.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_02/closed-record-constructor_02.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_02/closed-record-constructor_02.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_03/closed-record-constructor_03.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_03/closed-record-constructor_03.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/closed-object-constructor_03/closed-record-constructor_03.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/expFieldName/expFieldName.1.ddl.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/expFieldName/expFieldName.2.update.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/expFieldName/expFieldName.3.query.aql R asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/field-access-by-index_01/field-access-by-in
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1301 to look at the new patch set (#4). Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env - Managix options for cc / nc java opts are not used for NC service clusters, omit these from the cluster HTTP api. - Ini jvm.args should take precedence over $JAVA_OPTS in environment when launching NCDriver Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 --- M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java 3 files changed, 11 insertions(+), 12 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/01/1301/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3082/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Jenkins has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Till Westmann has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Michael Blow has submitted this change and it was merged.
Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
..
Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
- Managix options for cc / nc java opts are not used for NC service
clusters, omit these from the cluster HTTP api.
- Ini jvm.args should take precedence over $JAVA_OPTS in environment
when launching NCDriver
Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1301
Sonar-Qube: Jenkins
Reviewed-by: Till Westmann
Tested-by: Michael Blow
Integration-Tests: Michael Blow
---
M
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
3 files changed, 11 insertions(+), 12 deletions(-)
Approvals:
Michael Blow: Verified; Verified
Till Westmann: Looks good to me, approved
Jenkins: No violations found
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
index d076f74..0db4561 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
@@ -6,7 +6,6 @@
},
"config": {
"api.port": 19002,
-"cc.java.opts": "-Xmx1024m",
"cluster.partitions": {
"0": "ID:0, Original Node: asterix_nc1, IODevice: 0, Active Node:
asterix_nc1",
"1": "ID:1, Original Node: asterix_nc1, IODevice: 1, Active Node:
asterix_nc1",
@@ -33,7 +32,6 @@
"metadata.partition": "ID:0, Original Node: asterix_nc1, IODevice: 0,
Active Node: asterix_nc1",
"metadata.port": 0,
"metadata.registration.timeout.secs": 60,
-"nc.java.opts": "-Xmx1024m",
"node.partitions": {
"asterix_nc1": [
"ID:0, Original Node: asterix_nc1, IODevice: 0, Active Node:
asterix_nc1",
diff --git
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
index 1a9096d..15a1f39 100644
---
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
+++
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
@@ -92,13 +92,11 @@
PropertyInterpreters.getLevelPropertyInterpreter());
}
-@PropertyKey(EXTERNAL_NC_JAVA_OPTS_KEY)
public String getNCJavaParams() {
return accessor.getProperty(EXTERNAL_NC_JAVA_OPTS_KEY,
EXTERNAL_NC_JAVA_OPTS_DEFAULT,
PropertyInterpreters.getStringPropertyInterpreter());
}
-@PropertyKey(EXTERNAL_CC_JAVA_OPTS_KEY)
public String getCCJavaParams() {
return accessor.getProperty(EXTERNAL_CC_JAVA_OPTS_KEY,
EXTERNAL_CC_JAVA_OPTS_DEFAULT,
PropertyInterpreters.getStringPropertyInterpreter());
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
index 848bdd2..8ca61ad 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
@@ -105,17 +105,20 @@
}
private static void configEnvironment(Map env) {
-if (env.containsKey("JAVA_OPTS")) {
-if (LOGGER.isLoggable(Level.INFO)) {
-LOGGER.info("Keeping JAVA_OPTS from environment");
+String jvmargs = IniUtils.getString(ini, nodeSection, "jvm.args",
null);
+if (jvmargs != null) {
+LOGGER.info("Using JAVA_OPTS from conf file (jvm.args)");
+} else {
+jvmargs = env.get("JAVA_OPTS");
+if (jvmargs != null) {
+LOGGER.info("Using JAVA_OPTS from environment");
+} else {
+LOGGER.info("Using default JAVA_OPTS");
+jvmargs = "-Xmx1536m";
}
-return;
}
-String jvmargs = IniUtils.getString(ini, nodeSection, "jvm.args",
"-Xmx1536m");
env.put("JAVA_OPTS", jvmargs);
-if (LOGGER.isLoggable(Level.INFO)) {
-
Change in asterixdb[master]: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env
Michael Blow has posted comments on this change. Change subject: Omit Managix [nc|cc].java.opts From HTTP Api, Ini > Env .. Patch Set 4: Verified+1 Integration-Tests+1 Carrying forward +1s on commit-message only change. -- To view, visit https://asterix-gerrit.ics.uci.edu/1301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If52da9f5cc2a66b7c327f39a6e4ea51d4a8ccf89 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
