Change in asterixdb[master]: Optimize PartitionWriter

2016-11-06 Thread Till Westmann (Code Review) 
Till Westmann has posted comments on this change.

Change subject: Optimize PartitionWriter
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1347
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36c58b143f3fc2d37b180559c11c1566bcc1a86
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Optimize PartitionWriter

2016-11-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Optimize PartitionWriter
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3261/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1347
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36c58b143f3fc2d37b180559c11c1566bcc1a86
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Optimize PartitionWriter

2016-11-06 Thread abdullah alamoudi (Code Review) 
abdullah alamoudi has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1347

Change subject: Optimize PartitionWriter
..

Optimize PartitionWriter

Change-Id: Ic36c58b143f3fc2d37b180559c11c1566bcc1a86
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/PartitionDataWriter.java
1 file changed, 12 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/47/1347/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/PartitionDataWriter.java
 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/PartitionDataWriter.java
index c047567..013472f 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/PartitionDataWriter.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/PartitionDataWriter.java
@@ -40,13 +40,14 @@
 private final FrameTupleAccessor tupleAccessor;
 private final ITuplePartitionComputer tpc;
 private final IHyracksTaskContext ctx;
-private boolean allocatedFrame = false;
+private boolean[] allocatedFrames;
 
 public PartitionDataWriter(IHyracksTaskContext ctx, int 
consumerPartitionCount, IPartitionWriterFactory pwFactory,
 RecordDescriptor recordDescriptor, ITuplePartitionComputer tpc) 
throws HyracksDataException {
 this.consumerPartitionCount = consumerPartitionCount;
 pWriters = new IFrameWriter[consumerPartitionCount];
 isOpen = new boolean[consumerPartitionCount];
+allocatedFrames = new boolean[consumerPartitionCount];
 appenders = new FrameTupleAppender[consumerPartitionCount];
 for (int i = 0; i < consumerPartitionCount; ++i) {
 try {
@@ -70,7 +71,7 @@
 HyracksDataException closeException = null;
 for (int i = 0; i < pWriters.length; ++i) {
 if (isOpen[i]) {
-if (allocatedFrame) {
+if (allocatedFrames[i] && appenders[i].getTupleCount() > 0) {
 try {
 appenders[i].write(pWriters[i], true);
 } catch (Throwable th) {
@@ -103,9 +104,6 @@
 isOpen[i] = true;
 pWriters[i].open();
 }
-if (!allocatedFrame) {
-allocateFrames();
-}
 }
 
 @Override
@@ -114,15 +112,16 @@
 int tupleCount = tupleAccessor.getTupleCount();
 for (int i = 0; i < tupleCount; ++i) {
 int h = tpc.partition(tupleAccessor, i, consumerPartitionCount);
+if (!allocatedFrames[h]) {
+allocateFrames(h);
+}
 FrameUtils.appendToWriter(pWriters[h], appenders[h], 
tupleAccessor, i);
 }
 }
 
-private void allocateFrames() throws HyracksDataException {
-for (int i = 0; i < appenders.length; ++i) {
-appenders[i].reset(new VSizeFrame(ctx), true);
-}
-allocatedFrame = true;
+private void allocateFrames(int i) throws HyracksDataException {
+appenders[i].reset(new VSizeFrame(ctx), true);
+allocatedFrames[i] = true;
 }
 
 @Override
@@ -149,7 +148,9 @@
 @Override
 public void flush() throws HyracksDataException {
 for (int i = 0; i < consumerPartitionCount; i++) {
-appenders[i].flush(pWriters[i]);
+if (allocatedFrames[i]) {
+appenders[i].flush(pWriters[i]);
+}
 }
 }
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1347
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic36c58b143f3fc2d37b180559c11c1566bcc1a86
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi

Change in asterixdb[master]: ASTERIXDB-1570: "Unable to find free page in buffer cache af...

2016-11-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1570: "Unable to find free page in buffer cache after 
1000 cycles"
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1346
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I620de9ade875f7f7de26aa7495d9fd873824ac83
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1570: "Unable to find free page in buffer cache af...

2016-11-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1570: "Unable to find free page in buffer cache after 
1000 cycles"
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3260/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1346
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I620de9ade875f7f7de26aa7495d9fd873824ac83
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1570: "Unable to find free page in buffer cache af...

2016-11-06 Thread Michael Blow (Code Review) 
Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1346

Change subject: ASTERIXDB-1570: "Unable to find free page in buffer cache after 
1000 cycles"
..

ASTERIXDB-1570: "Unable to find free page in buffer cache after 1000 cycles"

Increase test buffer cache size to reliably accomodate 20M values

Change-Id: I620de9ade875f7f7de26aa7495d9fd873824ac83
---
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
3 files changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/46/1346/1

diff --git 
a/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml 
b/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
index ef0cdf2..90dbe5f 100644
--- a/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
+++ b/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
@@ -74,15 +74,15 @@
 storage.buffercache.pagesize
 32KB
 The page size in bytes for pages in the buffer cache.
-  (Default = "32768" // 32KB)
+  (Default = "128KB")
 
   
   
 storage.buffercache.size
-32MB
+48MB
 The size of memory allocated to the disk buffer cache.
-  The value should be a multiple of the buffer cache page size(Default
-  = "33554432" // 32MB)
+  The value should be a multiple of the buffer cache page size
+  (Default = "512MB")
 
   
   
diff --git 
a/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
 
b/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
index c6da1c0..4080325 100644
--- 
a/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
+++ 
b/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
@@ -185,8 +185,7 @@
 }
 lineActual = readerActual.readLine();
 if (lineActual != null) {
-throw new ComparisonException(
-"Result for " + scriptFile + " changed at line " + num 
+ ":\n< \n> " + lineActual);
+throwLineChanged(scriptFile, "", lineActual, num);
 }
 } catch (Exception e) {
 System.err.println("Actual results file: " + 
actualFile.toString());
diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
index ed33cc4..8ff9ab6 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
@@ -1248,7 +1248,7 @@
 
 private ICachedPage getPageLoop(long dpid, int multiplier, boolean 
confiscate)
 throws HyracksDataException {
-final long startingPinCount = masterPinCount.get();
+final long startingPinCount = DEBUG ? masterPinCount.get() : -1;
 int cycleCount = 0;
 try {
 while (true) {
@@ -1291,15 +1291,16 @@
 if (cycleCount > MAX_PIN_ATTEMPT_CYCLES) {
 cycleCount = 0; // suppress warning below
 throw new HyracksDataException("Unable to find free page 
in buffer cache after "
-+ MAX_PIN_ATTEMPT_CYCLES + " cycles (buffer cache 
undersized?); "
-+ (masterPinCount.get() - startingPinCount) + " 
successful pins since start of cycle");
++ MAX_PIN_ATTEMPT_CYCLES + " cycles (buffer cache 
undersized?)" + (DEBUG ? " ; "
++ (masterPinCount.get() - startingPinCount) + " 
successful pins since start of cycle"
+: ""));
 }
 }
 } finally {
 if (cycleCount > PIN_ATTEMPT_CYCLES_WARNING_THRESHOLD && 
LOGGER.isLoggable(Level.WARNING)) {
 LOGGER.warning("Took " + cycleCount + " cycles to find free 
page in buffer cache.  (buffer cache " +
-"undersized?); " + (masterPinCount.get() - 
startingPinCount) +
-" successful pins since start of cycle");
+"undersized?)" + (DEBUG ? " ; " + 
(masterPinCount.get() - startingPinCount) +
+" successful pins since start of cycle" : ""));
 }
 }
 }

-- 
To view, visit

Change in asterixdb[master]: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

2016-11-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1099/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

2016-11-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3259/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

2016-11-06 Thread Xikui Wang (Code Review) 
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1339

to look at the new patch set (#4).

Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
..

Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

1. For ASTERIXDB-1609, add UNION type check in writeField, and add one
more case for orderedList.
2. For OrderedList bug, change UnorderedListBuilder to
OrderedListBuilder.

Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java
1 file changed, 68 insertions(+), 28 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/39/1339/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang

Change in asterixdb[master]: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

2016-11-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1098/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

2016-11-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3258/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No

Change in asterixdb[master]: Disable hash merge exchange.

2016-11-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Disable hash merge exchange.
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1345
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If82c4e4db1d4340cdd53d17e48a193ab2b7a05e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Disable hash merge exchange.

2016-11-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Disable hash merge exchange.
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3257/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1345
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If82c4e4db1d4340cdd53d17e48a193ab2b7a05e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Disable hash merge exchange.

2016-11-06 Thread Yingyi Bu (Code Review) 
Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1345

Change subject: Disable hash merge exchange.
..

Disable hash merge exchange.

- Hash merge exchange does not work very well on large clusters.

Change-Id: If82c4e4db1d4340cdd53d17e48a193ab2b7a05e0
---
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/consolidate-selects-complex.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/count-tweets.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/fj-phase1.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inlined_q18_large_volume_customer.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/orders-aggreg.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/orders-index-search-conjunctive-open_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/orders-index-search-conjunctive-open_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/orders-index-search-conjunctive_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/orders-index-search-conjunctive_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/q01_pricing_summary_report_nt.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/q2.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1263.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1343-2.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1343-3.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1343-4.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1343.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-830.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue601.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue697.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue785.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue810-2.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/rtree-secondary-index-open.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/rtree-secondary-index.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/scan-delete-rtree-secondary-index.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/skip-index/skip-rtree-secondary-index.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/split-materialization-above-join.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1580.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1591.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping_broadcast.plan
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java
36 files changed, 261 insertions(+), 238 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/45/1345/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
index 773be15..94bf390 100644
--- 
a/asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
@@ -3,12 +3,12 @@
 -- STREAM_PROJECT  |PARTITIONED|
   -- ASSIGN  |PARTITIONED|
 -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
-  -- PRE_CLUSTERED_GROUP_BY[$$26]  |PARTITIONED|
+  -- SORT_GROUP_BY[$$26]  |PARTITIONED|
   {
 -- AGGREGATE  |LOCAL|
   -- NESTED_TUPLE_SOURCE  |LOCAL|
   }
--- HASH_PARTITION_MERGE_EXCHANGE MERGE:[$$26(ASC)] HASH:[$$26]  
|PARTITIONED|
+-- HASH_PARTITION_EXCHANGE [$$26]  |PARTITIONED|
   -- SORT_GROUP_BY[$$22]  |PARTITIONED|
   {
 -- AGGREGATE  |LOCAL|
diff --git

Change in asterixdb[master]: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

2016-11-06 Thread Wail Alkowaileet (Code Review) 
Wail Alkowaileet has posted comments on this change.

Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
..


Patch Set 2:

Hi Xikui,

I tried to see the output of the new parser.
I noticed something different:
{ "id": 795240956979126272, "user": { "screen_name": "77mono7", "lang": "ja", 
"friends_count": 65, "statuses_count": 712 }, "in_reply_to_status_id_str": 
"795234196201426946", "in_reply_to_status_id": 795234196201426946, 
"created_at": "Sun Nov 06 12:26:33 + 2016", "in_reply_to_user_id_str": 
"762203399202799616", "source": "Twitter for iPhone", "retweet_count": 0, 
"retweeted": false, "filter_level": "low", "in_reply_to_screen_name": 
"77mono7", "is_quote_status": false, "id_str": "795240956979126272", 
"in_reply_to_user_id": 762203399202799616, "favorite_count": 0, "text": 
"仲良くしてね", "lang": "ja", "favorited": false, "truncated": false, "timestamp_ms": 
"1478435193663", "entities": {  } }

You can see 'entities' as an empty record. I'm not sure how is that mapped in 
AsterixDB ? it's not null or missing.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No