Change in asterixdb[master]: Add record reader and parser for CAP messages
Jenkins has posted comments on this change. Change subject: Add record reader and parser for CAP messages .. Patch Set 15: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3511/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1269 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: Add record reader and parser for CAP messages
Till Westmann has posted comments on this change.
Change subject: Add record reader and parser for CAP messages
..
Patch Set 13:
(8 comments)
Submitting some comments on a older patchset - sorry.
https://asterix-gerrit.ics.uci.edu/#/c/1269/13/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/CAPMessageRecordReader.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/CAPMessageRecordReader.java:
Line 36: if (collection != null) {
Could we replace this by
this.recordLvl = Boolean.parseBoolean(collection) ? 1 : 0;
?
Line 52: final int IN_SCHEMA_DEFINITION = 7;
These are really helpful, but I think that they could be static final class
members (or you could us an enum if you don't need the fact that they are ints).
Line 82: if (state == IN_START_OF_ELEMENT_NAME) {
A nested switch might be better.
Line 88: } else if (state == START_OF_PROLOG) {
Should this be "IN_PROLOG"?
Line 114: if (state == START_OF_ELEMENT_NAME) {
A nested switch might be better.
Line 129: return newRecordFormed;
This is always true, right?
https://asterix-gerrit.ics.uci.edu/#/c/1269/13/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/CAPMessageParser.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/CAPMessageParser.java:
Line 101: private void resetPools() {
Inline reset pools?
Line 171: parentPath = String.join(".", curPathStack);
As it's only used inside this method, parentPath could be a local variable.
However, another concern is that String.join will probably allocate a few
objects for every element. It would be interesting to see, if parsing many of
these messages will lead to a lot of garbage collection.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1269
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: Xikui Wang
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1287/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1287/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1288/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...
Jenkins has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule .. Patch Set 15: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/19/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1350 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779 Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...
Jenkins has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule .. Patch Set 15: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/19/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/1350 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779 Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fix for ASTERIXDB-1738: Change feed fails to delete record w...
Ian Maxon has posted comments on this change. Change subject: Fix for ASTERIXDB-1738: Change feed fails to delete record with meta PK .. Patch Set 5: Sorry, I was testing the BAD job, I need to make it so it doesn't vote. -- To view, visit https://asterix-gerrit.ics.uci.edu/1351 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ce8d9c69f96593ee305cfad4b44e486c9f1d6cc Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1288/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Verified+1 Carrying forward +1 from Jenkins -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1289/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1290/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/20/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Extract common code of [Optimizer|Smoke]ParserTest
Michael Blow has posted comments on this change. Change subject: Extract common code of [Optimizer|Smoke]ParserTest .. Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1379/3/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java: Line 91: .charAt(0)); extra newline? Also, we could use File.separator & File.separatorChar in place of SEPARATOR and SEPARATOR.charAt(0) -- To view, visit https://asterix-gerrit.ics.uci.edu/1379 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3512/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Hello Yingyi Bu, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/586 to look at the new patch set (#6). Change subject: Fix ASTERIXDB-1255 .. Fix ASTERIXDB-1255 This changes enable dynamic hashtable size in SimilarityJaccardEvaluator Change-Id: I08c550d35d864df08792369d38ff81012e3976af --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/86/586/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: minor POM cleanup
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/850 to look at the new patch set (#6). Change subject: minor POM cleanup .. minor POM cleanup Change-Id: Iea7296c8cfd5d62df5c5419e69a4890e73c2b29a --- M asterixdb/asterix-external-data/pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/50/850/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/850 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iea7296c8cfd5d62df5c5419e69a4890e73c2b29a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: minor POM cleanup
Jenkins has posted comments on this change. Change subject: minor POM cleanup .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3513/ -- To view, visit https://asterix-gerrit.ics.uci.edu/850 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7296c8cfd5d62df5c5419e69a4890e73c2b29a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Extract common code of [Optimizer|Smoke]ParserTest
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1379 to look at the new patch set (#4). Change subject: Extract common code of [Optimizer|Smoke]ParserTest .. Extract common code of [Optimizer|Smoke]ParserTest Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff --- M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java 3 files changed, 103 insertions(+), 105 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/79/1379/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1379 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Extract common code of [Optimizer|Smoke]ParserTest
Jenkins has posted comments on this change. Change subject: Extract common code of [Optimizer|Smoke]ParserTest .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3514/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1379 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: some code reduction/cleanup
Michael Blow has posted comments on this change. Change subject: some code reduction/cleanup .. Patch Set 8: -Code-Review This needs to be manually rebased. -- To view, visit https://asterix-gerrit.ics.uci.edu/916 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I179a16fc183bd50d5d58cc12321234df1615abfd Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Cameron Samak Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1291/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1290/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Extract common code of [Optimizer|Smoke]ParserTest
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1379 to look at the new patch set (#5). Change subject: Extract common code of [Optimizer|Smoke]ParserTest .. Extract common code of [Optimizer|Smoke]ParserTest Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff --- M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java 3 files changed, 101 insertions(+), 103 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/79/1379/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/1379 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Extract common code of [Optimizer|Smoke]ParserTest
Jenkins has posted comments on this change. Change subject: Extract common code of [Optimizer|Smoke]ParserTest .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3515/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1379 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/21/ -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: minor POM cleanup
Jenkins has posted comments on this change. Change subject: minor POM cleanup .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1292/ -- To view, visit https://asterix-gerrit.ics.uci.edu/850 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7296c8cfd5d62df5c5419e69a4890e73c2b29a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 2
Taewoo Kim has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1383
Change subject: Full-text implementation step 2
..
Full-text implementation step 2
- Parameter checking during the compilation is now applied.
Change-Id: Idec6b602ff7797846fd237a924005031c2395346
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java
M asterixdb/asterix-doc/src/site/site.xml
4 files changed, 249 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/83/1383/1
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
index f6526c4..32d766b 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
@@ -64,6 +64,7 @@
defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs,
RuleCollections.buildLoadFieldsRuleCollection()));
defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl,
RuleCollections.buildDataExchangeRuleCollection()));
defaultLogicalRewrites.add(new Pair<>(seqCtrlNoDfs,
RuleCollections.buildConsolidationRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl,
RuleCollections.buildFulltextContainsRuleCollection()));
defaultLogicalRewrites.add(new Pair<>(seqCtrlNoDfs,
RuleCollections.buildAccessMethodRuleCollection()));
defaultLogicalRewrites.add(new Pair<>(seqCtrlNoDfs,
RuleCollections.buildPlanCleanupRuleCollection()));
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
index 3efc4dc..8e318be 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
@@ -35,6 +35,7 @@
import org.apache.asterix.optimizer.rules.ExtractDistinctByExpressionsRule;
import org.apache.asterix.optimizer.rules.ExtractOrderExpressionsRule;
import org.apache.asterix.optimizer.rules.FeedScanCollectionToUnnest;
+import org.apache.asterix.optimizer.rules.FullTextContainsParameterCheckRule;
import org.apache.asterix.optimizer.rules.FuzzyEqRule;
import org.apache.asterix.optimizer.rules.InjectTypeCastForSwitchCaseRule;
import org.apache.asterix.optimizer.rules.InjectTypeCastForUnionRule;
@@ -154,6 +155,12 @@
return autogen;
}
+public static final List
buildFulltextContainsRuleCollection() {
+List ftRule = new LinkedList<>();
+ftRule.add(new FullTextContainsParameterCheckRule());
+return ftRule;
+}
+
public static final List
buildNormalizationRuleCollection() {
List normalization = new LinkedList<>();
normalization.add(new ResolveVariableRule());
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java
new file mode 100644
index 000..c8aa3f1
--- /dev/null
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.optimizer.rules;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+
+import org.apache.asterix.om.functions.AsterixBuiltinFunctions;
+import org.apache.asterix.om.types.ATypeTag;
+import org.apache.asterix.om
Change in asterixdb[master]: Full-text implementation step 2
Taewoo Kim has uploaded a new patch set (#2). Change subject: Full-text implementation step 2 .. Full-text implementation step 2 - Parameter checking during the compilation is now applied. Change-Id: Idec6b602ff7797846fd237a924005031c2395346 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java 3 files changed, 248 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/83/1383/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: Full-text implementation step 2
Jenkins has posted comments on this change. Change subject: Full-text implementation step 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3516/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 2
Jenkins has posted comments on this change. Change subject: Full-text implementation step 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3517/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration-Tests-1 Integration Tests Timed Out https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1289/ : ABORTED -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Add record reader and parser for CAP messages
Hello Till Westmann, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1269 to look at the new patch set (#16). Change subject: Add record reader and parser for CAP messages .. Add record reader and parser for CAP messages 1. Add record reader for CAP message. 2. Add CAP message parser based SAXParser. Element attributes are ignored currently. 3. Fix ASTERIX-1690: deadlock between close() and take() in FileSystemWatcher 4. Add test cases for using CAP adaptor in feed and load statement. 5. Add an option in configuration to allow user use CAP adaptor loading certain XML documents. - "collection" = "true" (Multiple records in one document, check "document_with_records_collection.xml" as an example). 6. Extract message timestamp from the comment. All datetimes in element content are treated as string due to different timezones. Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da --- A asterixdb/asterix-app/data/cap_messages/CAP_0.xml A asterixdb/asterix-app/data/cap_messages/CAP_1.xml A asterixdb/asterix-app/data/cap_messages/CAP_2.xml A asterixdb/asterix-app/data/cap_messages/CAP_3.xml A asterixdb/asterix-app/data/cap_messages/CAP_4.xml A asterixdb/asterix-app/data/document_with_records_collection.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-collection/caps-adaptor-collection.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-collection/caps-adaptor-collection.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-collection/caps-adaptor-collection.3.sleep.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-collection/caps-adaptor-collection.4.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-no-collection/caps-adaptor-no-collection.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-no-collection/caps-adaptor-no-collection.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-no-collection/caps-adaptor-no-collection.3.sleep.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-no-collection/caps-adaptor-no-collection.4.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-no-collection/caps-adaptor-no-collection.5.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/load/load-cap-collection/load-cap-collection.0.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/load/load-cap-collection/load-cap-collection.1.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/load/load-cap-collection/load-cap-collection.2.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/load/load-cap-messages/load-cap-messages.0.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/load/load-cap-messages/load-cap-messages.1.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/load/load-cap-messages/load-cap-messages.2.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/cap-adaptor-collection/cap-adaptor-collection.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/cap-adaptor-no-collection/cap-adaptor-no-collection.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/load/load-cap-collection/load-cap-collection.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/load/load-cap-messages/load-cap-messages.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/CAPMessageRecordReader.java A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/CAPMessageParser.java A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/CAPMessageParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/ParserFactoryProvider.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/StreamRecordReaderProvider.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java 35 files changed, 1,721 insertions(+), 36 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/69/1269/16 -- To view, visit https://asterix-gerrit.ics.uci.edu/1269 To unsubscribe,
Change in asterixdb[master]: minor POM cleanup
Jenkins has posted comments on this change. Change subject: minor POM cleanup .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/22/ -- To view, visit https://asterix-gerrit.ics.uci.edu/850 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7296c8cfd5d62df5c5419e69a4890e73c2b29a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Add record reader and parser for CAP messages
Jenkins has posted comments on this change. Change subject: Add record reader and parser for CAP messages .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3518/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1269 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: Extract common code of [Optimizer|Smoke]ParserTest
Jenkins has posted comments on this change. Change subject: Extract common code of [Optimizer|Smoke]ParserTest .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1293/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1379 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: some code reduction/cleanup
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/916 to look at the new patch set (#9). Change subject: some code reduction/cleanup .. some code reduction/cleanup Change-Id: I179a16fc183bd50d5d58cc12321234df1615abfd --- M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java 3 files changed, 68 insertions(+), 79 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/16/916/9 -- To view, visit https://asterix-gerrit.ics.uci.edu/916 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I179a16fc183bd50d5d58cc12321234df1615abfd Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Cameron Samak Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: some code reduction/cleanup
Jenkins has posted comments on this change. Change subject: some code reduction/cleanup .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3519/ -- To view, visit https://asterix-gerrit.ics.uci.edu/916 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I179a16fc183bd50d5d58cc12321234df1615abfd Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Cameron Samak Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Fix ASTERIXDB-1255
Jenkins has posted comments on this change. Change subject: Fix ASTERIXDB-1255 .. Patch Set 6: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1291/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Extract common code of [Optimizer|Smoke]ParserTest
Jenkins has posted comments on this change. Change subject: Extract common code of [Optimizer|Smoke]ParserTest .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/23/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1379 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: minor POM cleanup
Jenkins has posted comments on this change. Change subject: minor POM cleanup .. Patch Set 6: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1292/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/850 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7296c8cfd5d62df5c5419e69a4890e73c2b29a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 2
Jenkins has posted comments on this change. Change subject: Full-text implementation step 2 .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1294/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 2
Jenkins has posted comments on this change. Change subject: Full-text implementation step 2 .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/24/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Introduce CheckpointManager API
Till Westmann has posted comments on this change. Change subject: Introduce CheckpointManager API .. Patch Set 4: Code-Review+1 Good for me. Somebody with more area knowledge (Abdullah or Ian or ...?) should give the +2. -- To view, visit https://asterix-gerrit.ics.uci.edu/1380 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36c00ca195b93bbe1e53f39bb4a3b5a344657f0d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1295/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: minor POM cleanup
Till Westmann has submitted this change and it was merged.
Change subject: minor POM cleanup
..
minor POM cleanup
Change-Id: Iea7296c8cfd5d62df5c5419e69a4890e73c2b29a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/850
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Michael Blow
---
M asterixdb/asterix-external-data/pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git a/asterixdb/asterix-external-data/pom.xml
b/asterixdb/asterix-external-data/pom.xml
index aab1e57..f48ee43 100644
--- a/asterixdb/asterix-external-data/pom.xml
+++ b/asterixdb/asterix-external-data/pom.xml
@@ -43,7 +43,7 @@
${project.version}
src/main/resources/adm.grammar
-
${project.build.directory}/generated-sources/org/apache/asterix/runtime/operators/file/adm
+
${project.build.directory}/generated-sources/lexer/org/apache/asterix/runtime/operators/file/adm
@@ -68,7 +68,7 @@
-${project.build.directory}/generated-sources/
+
${project.build.directory}/generated-sources/lexer/
--
To view, visit https://asterix-gerrit.ics.uci.edu/850
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea7296c8cfd5d62df5c5419e69a4890e73c2b29a
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: minor POM cleanup
Michael Blow has posted comments on this change. Change subject: minor POM cleanup .. Patch Set 6: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/850 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7296c8cfd5d62df5c5419e69a4890e73c2b29a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Extract common code of [Optimizer|Smoke]ParserTest
Jenkins has posted comments on this change. Change subject: Extract common code of [Optimizer|Smoke]ParserTest .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1293/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1379 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Add record reader and parser for CAP messages
Jenkins has posted comments on this change. Change subject: Add record reader and parser for CAP messages .. Patch Set 16: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1296/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1269 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1350 to look at the new patch set (#17). Change subject: Index-only plan step 3: Top-down Select and Join transformation rule .. Index-only plan step 3: Top-down Select and Join transformation rule - Converted IntroduceSelectAccessMethodRule and IntroduceJoinAccessMethodRule from bottom-up approach to top-down approach from the root operator. - Index-only plan needs to verify the variables that are live in the select or join condition are the only variables to be used afterwards unless a variable is generated after the select or join operator. - In order to keep this information, top-down approach needs to be introduced. Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodAnalysisContext.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/RTreeAccessMethod.java 8 files changed, 465 insertions(+), 234 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/50/1350/17 -- To view, visit https://asterix-gerrit.ics.uci.edu/1350 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: ASTERIXDB-1566, ASTERIXDB-1733: Hash Group By and Hash Join ...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1056 to look at the new patch set (#40). Change subject: ASTERIXDB-1566, ASTERIXDB-1733: Hash Group By and Hash Join conform to the memory budget .. ASTERIXDB-1566, ASTERIXDB-1733: Hash Group By and Hash Join conform to the memory budget - External Hash Group By and Hash Join now conform to the memory budget (compiler.groupmemory and compiler.joinmemory) - For Optimzed Hybrid Hash Join, we calculate the expected hash table size when the build phase is done and try to spill one or more partitions if the freespace can't afford the hash table size. - For External Hash Group By, the number of hash entries (hash table size) is calculated based on an estimation of the aggregated tuple size and possible hash values for the given field size in that tuple. - Garbage Collection feature has been added to SerializableHashTable. For external hash group-by, whenever we spill a data partition to the disk, we also check the ratio of garbage in the hash table. If it's greater than the given threshold, we conduct a GC on Hash Table. Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/ExternalGroupByPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HybridHashJoinPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/InMemoryHashJoinPOperator.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/IFrameTupleReversibleAppender.java M hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/FixedSizeFrameTupleAppender.java A hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameBufferManager.java A hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FramePoolBackedFrameBufferManager.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java A hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/ISimpleFrameBufferManager.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/PreferToSpillFullyOccupiedFramePolicy.java A hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/TupleInFrameListAccessor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/external/ExternalGroupOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HybridHashJoinOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/InMemoryHashJoin.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/InMemoryHashJoinOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/ISerializableTable.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java A hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SimpleSerializableHashTable.java M hyracks-fullstack/hyracks/hyracks-dat
Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...
Jenkins has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule .. Patch Set 17: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3520/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1350 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1566, ASTERIXDB-1733: Hash Group By and Hash Join ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1566, ASTERIXDB-1733: Hash Group By and Hash Join conform to the memory budget .. Patch Set 40: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 Gerrit-PatchSet: 40 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1566, ASTERIXDB-1733: Hash Group By and Hash Join ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1566, ASTERIXDB-1733: Hash Group By and Hash Join conform to the memory budget .. Patch Set 40: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3521/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 Gerrit-PatchSet: 40 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Introduce CheckpointManager API
Ian Maxon has posted comments on this change.
Change subject: Introduce CheckpointManager API
..
Patch Set 4:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1380/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java:
Line 251: if (!pendingFailbackCompletion) {
It's not a checkpoint, but it's checkpointy ;)
https://asterix-gerrit.ics.uci.edu/#/c/1380/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java
File
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java:
Line 29: private static final int LOCAL_STORAGE_VERSION = 1;
Why a separate version?
https://asterix-gerrit.ics.uci.edu/#/c/1380/4/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointThread.java
File
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointThread.java:
Line 28: /**
s/demon/daemon
--
To view, visit https://asterix-gerrit.ics.uci.edu/1380
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36c00ca195b93bbe1e53f39bb4a3b5a344657f0d
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Gerrit-Reviewer: Ian Maxon
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1749: fix breaking of lines using '\r' .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1295/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Add record reader and parser for CAP messages
Jenkins has posted comments on this change. Change subject: Add record reader and parser for CAP messages .. Patch Set 16: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/25/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1269 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 2
Jenkins has posted comments on this change. Change subject: Full-text implementation step 2 .. Patch Set 2: Integration-Tests-1 Integration Tests Timed Out https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1294/ : ABORTED -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1749: fix breaking of lines using '\r'
Till Westmann has submitted this change and it was merged.
Change subject: ASTERIXDB-1749: fix breaking of lines using '\r'
..
ASTERIXDB-1749: fix breaking of lines using '\r'
Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1382
Reviewed-by: Michael Blow
Tested-by: Michael Blow
Integration-Tests: Jenkins
---
M
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java
A
asterixdb/asterix-lang-sqlpp/src/test/java/org/apache/asterix/lang/sqlpp/parser/ParserTest.java
2 files changed, 55 insertions(+), 1 deletion(-)
Approvals:
Michael Blow: Looks good to me, approved; Verified
Jenkins: Verified
diff --git
a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java
b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java
index 767eacb..1195d37 100644
---
a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java
+++
b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java
@@ -51,7 +51,7 @@
}
protected void setInput(String s) {
-inputLines = s.split("\n");
+inputLines = s.split("\n|\r\n?");
}
// Forbidden scopes are used to disallow, in a limit clause, variables
diff --git
a/asterixdb/asterix-lang-sqlpp/src/test/java/org/apache/asterix/lang/sqlpp/parser/ParserTest.java
b/asterixdb/asterix-lang-sqlpp/src/test/java/org/apache/asterix/lang/sqlpp/parser/ParserTest.java
new file mode 100644
index 000..27679a9
--- /dev/null
+++
b/asterixdb/asterix-lang-sqlpp/src/test/java/org/apache/asterix/lang/sqlpp/parser/ParserTest.java
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.lang.sqlpp.parser;
+
+import org.apache.asterix.common.exceptions.AsterixException;
+import org.apache.asterix.lang.common.base.IParser;
+import org.apache.asterix.lang.common.base.IParserFactory;
+import org.junit.Test;
+
+public class ParserTest {
+
+protected void testLineEnding(String query) throws Exception {
+IParserFactory factory = new SqlppParserFactory();
+IParser parser = factory.createParser(query);
+try {
+parser.parse();
+} catch (AsterixException e) {
+if (!e.getMessage().contains("Syntax error: In line 3")) {
+throw new Exception("Unexpected error", e);
+}
+}
+}
+
+@Test
+public void testCR() throws Exception {
+testLineEnding("select\rvalue\r1");
+}
+
+@Test
+public void testCRLF() throws Exception {
+testLineEnding("select\r\nvalue\r\n1");
+}
+
+@Test
+public void testLF() throws Exception {
+testLineEnding("select\nvalue\n1");
+}
+}
--
To view, visit https://asterix-gerrit.ics.uci.edu/1382
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: Yingyi Bu
[jira] [Commented] (ASTERIXDB-1749) ArrayIndexOutOfBoundsException parsing SQL++ file using '\r'
[
https://issues.apache.org/jira/browse/ASTERIXDB-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743860#comment-15743860
]
ASF subversion and git services commented on ASTERIXDB-1749:
Commit 3072ef35e0846883da03da59630ad1c9bd19f88e in asterixdb's branch
refs/heads/master from [~tillw]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=3072ef3 ]
ASTERIXDB-1749: fix breaking of lines using '\r'
Change-Id: Ica5ce0b82f1d2c6f2033be2ce20bf56a563fb57b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1382
Reviewed-by: Michael Blow
Tested-by: Michael Blow
Integration-Tests: Jenkins
> ArrayIndexOutOfBoundsException parsing SQL++ file using '\r'
>
>
> Key: ASTERIXDB-1749
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1749
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: Translator - SQL++
>Reporter: Till
>Assignee: Till
>
> When parsing a SQL++ query that
> a) contains an error and
> b) separates lines using '\r'
> an ArrayIndexOutOfBoundsException is thrown.
> For example is "select\rvalue\r1" throws
> {noformat}
> java.lang.ArrayIndexOutOfBoundsException: 2
> at
> org.apache.asterix.lang.common.parser.ScopeChecker.getLine(ScopeChecker.java:308)
> at
> org.apache.asterix.lang.sqlpp.parser.SQLPPParser.getMessage(SQLPPParser.java:283)
> at
> org.apache.asterix.lang.sqlpp.parser.SQLPPParser.parse(SQLPPParser.java:267)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Change in asterixdb[master]: Full-text implementation step 2
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1383 to look at the new patch set (#3). Change subject: Full-text implementation step 2 .. Full-text implementation step 2 - Parameter checking during the compilation is now applied. Change-Id: Idec6b602ff7797846fd237a924005031c2395346 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java 3 files changed, 248 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/83/1383/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Full-text implementation step 2
Jenkins has posted comments on this change. Change subject: Full-text implementation step 2 .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3522/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...
Jenkins has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule .. Patch Set 17: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1297/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1350 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Extract common code of [Optimizer|Smoke]ParserTest
Michael Blow has posted comments on this change. Change subject: Extract common code of [Optimizer|Smoke]ParserTest .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1379 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Extract common code of [Optimizer|Smoke]ParserTest
Till Westmann has submitted this change and it was merged.
Change subject: Extract common code of [Optimizer|Smoke]ParserTest
..
Extract common code of [Optimizer|Smoke]ParserTest
Change-Id: Iab916e71539ffac7b952ab6795614c00039ca7ff
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1379
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Michael Blow
---
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
A
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
3 files changed, 101 insertions(+), 103 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
index ef17c9f..31103a8 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
@@ -26,10 +26,8 @@
import org.apache.asterix.test.base.AsterixTestHelper;
import org.apache.asterix.test.common.TestHelper;
import org.junit.AfterClass;
-import org.junit.Assume;
import org.junit.BeforeClass;
import org.junit.Test;
-import org.junit.internal.AssumptionViolatedException;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
@@ -39,17 +37,14 @@
private static final Logger LOGGER =
Logger.getLogger(OptimizerParserTest.class.getName());
-private static final String SEPARATOR = File.separator;
private static final String EXTENSION_QUERY = "sqlpp";
private static final String EXTENSION_RESULT = "ast";
private static final String FILENAME_IGNORE = "ignore.txt";
private static final String FILENAME_ONLY = "only.txt";
-private static final String PATH_BASE = "src" + SEPARATOR + "test" +
SEPARATOR + "resources" + SEPARATOR
-+ "optimizerts" + SEPARATOR;
-private static final String PATH_QUERIES = PATH_BASE + "queries_sqlpp" +
SEPARATOR;
-private static final String PATH_EXPECTED = PATH_BASE +
"results_parser_sqlpp" + SEPARATOR;
-private static final String PATH_ACTUAL =
-"target" + File.separator + "opt_parserts" + SEPARATOR +
"results_parser_sqlpp" + SEPARATOR;
+private static final String PATH_BASE = TestHelper.joinPath("src", "test",
"resources", "optimizerts");
+private static final String PATH_QUERIES = TestHelper.joinPath(PATH_BASE,
"queries_sqlpp");
+private static final String PATH_EXPECTED = TestHelper.joinPath(PATH_BASE,
"results_parser_sqlpp");
+private static final String PATH_ACTUAL = TestHelper.joinPath("target",
"opt_parserts", "results_parser_sqlpp");
private static final ArrayList ignore =
AsterixTestHelper.readFile(FILENAME_IGNORE, PATH_BASE);
private static final ArrayList only =
AsterixTestHelper.readFile(FILENAME_ONLY, PATH_BASE);
@@ -68,24 +63,11 @@
}
}
-private static void suiteBuild(File dir, Collection testArgs,
String path) {
-for (File file : dir.listFiles()) {
-if (file.isDirectory() && !file.getName().startsWith(".")) {
-suiteBuild(file, testArgs, path + file.getName() + SEPARATOR);
-}
-if (file.isFile() && file.getName().endsWith(EXTENSION_QUERY)) {
-String resultFileName =
AsterixTestHelper.extToResExt(file.getName(), EXTENSION_RESULT);
-File expectedFile = new File(PATH_EXPECTED + path +
resultFileName);
-File actualFile = new File(PATH_ACTUAL + path +
resultFileName);
-testArgs.add(new Object[] { file, expectedFile, actualFile });
-}
-}
-}
-
@Parameters(name = "OptimizerParserTest {index}: {0}")
public static Collection tests() {
-Collection testArgs = new ArrayList();
-suiteBuild(new File(PATH_QUERIES), testArgs, "");
+Collection testArgs = new ArrayList<>();
+ParserTestUtil.suiteBuild(new File(PATH_QUERIES), testArgs, "",
File.separator, EXTENSION_QUERY,
+EXTENSION_RESULT, PATH_EXPECTED, PATH_ACTUAL);
return testArgs;
}
@@ -103,32 +85,7 @@
@Test
public void test() throws Exception {
-try {
-String queryFileShort =
queryFile.getPath().substring(PATH_QUERIES.length()).replace(SEPARATOR.charAt(0),
-'/');
-if (!only.isEmpty()) {
-boolean toRun = TestHelper.isInPrefixList(only,
queryFileShort);
-if (!toRun) {
-LOGGER.info("SKIP TEST:
Change in asterixdb[master]: Add record reader and parser for CAP messages
Jenkins has posted comments on this change. Change subject: Add record reader and parser for CAP messages .. Patch Set 16: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1296/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1269 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...
Jenkins has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule .. Patch Set 17: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/26/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1350 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Add record reader and parser for CAP messages
Xikui Wang has posted comments on this change. Change subject: Add record reader and parser for CAP messages .. Patch Set 16: Sorry for making so many changes in this patch. I found a couple of bugs when I was addressing your previous comments. Thanks! -- To view, visit https://asterix-gerrit.ics.uci.edu/1269 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: reduce code duplication a tiny bit
Michael Blow has posted comments on this change. Change subject: reduce code duplication a tiny bit .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1365 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f3bf5fb423cd55bd7fc168ac7a9014a24bc516c Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: reduce code duplication a tiny bit
Michael Blow has submitted this change and it was merged.
Change subject: reduce code duplication a tiny bit
..
reduce code duplication a tiny bit
Change-Id: I3f3bf5fb423cd55bd7fc168ac7a9014a24bc516c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1365
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Michael Blow
---
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DatasetDataSource.java
1 file changed, 14 insertions(+), 18 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified; Verified
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DatasetDataSource.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DatasetDataSource.java
index 6a13979..973651f 100644
---
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DatasetDataSource.java
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DatasetDataSource.java
@@ -116,24 +116,8 @@
Index primaryIndex =
MetadataManager.INSTANCE.getIndex(metadataProvider.getMetadataTxnContext(),
dataverseName, datasetName, datasetName);
-int[] minFilterFieldIndexes = null;
-if (minFilterVars != null && !minFilterVars.isEmpty()) {
-minFilterFieldIndexes = new int[minFilterVars.size()];
-int i = 0;
-for (LogicalVariable v : minFilterVars) {
-minFilterFieldIndexes[i] = opSchema.findVariable(v);
-i++;
-}
-}
-int[] maxFilterFieldIndexes = null;
-if (maxFilterVars != null && !maxFilterVars.isEmpty()) {
-maxFilterFieldIndexes = new int[maxFilterVars.size()];
-int i = 0;
-for (LogicalVariable v : maxFilterVars) {
-maxFilterFieldIndexes[i] = opSchema.findVariable(v);
-i++;
-}
-}
+int[] minFilterFieldIndexes =
createFilterIndexes(minFilterVars, opSchema);
+int[] maxFilterFieldIndexes =
createFilterIndexes(maxFilterVars, opSchema);
return metadataProvider.buildBtreeRuntime(jobSpec,
scanVariables, opSchema, typeEnv, context, true,
false, ((DatasetDataSource) dataSource).getDataset(),
primaryIndex.getIndexName(), null, null,
true, true, implConfig, minFilterFieldIndexes,
maxFilterFieldIndexes);
@@ -142,6 +126,18 @@
}
}
+private int[] createFilterIndexes(List filterVars,
IOperatorSchema opSchema) {
+if (filterVars != null && !filterVars.isEmpty()) {
+final int size = filterVars.size();
+int[] result = new int[size];
+for (int i = 0; i < size; ++i) {
+result[i] = opSchema.findVariable(filterVars.get(i));
+}
+return result;
+}
+return null;
+}
+
@Override
public boolean isScanAccessPathALeaf() {
return dataset.getDatasetType() == DatasetType.EXTERNAL;
--
To view, visit https://asterix-gerrit.ics.uci.edu/1365
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f3bf5fb423cd55bd7fc168ac7a9014a24bc516c
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log
Hello abdullah alamoudi, Ian Maxon, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1368 to look at the new patch set (#4). Change subject: ASTERIXDB-1711: rename asterix_transaction_log .. ASTERIXDB-1711: rename asterix_transaction_log - s/asterix_transaction_log/transaction_log/ - update storage version - remove some dead code Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogManagerProperties.java M hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java 2 files changed, 5 insertions(+), 18 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/68/1368/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1368 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Full-text implementation step 2
Jenkins has posted comments on this change. Change subject: Full-text implementation step 2 .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1298/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1711: rename asterix_transaction_log .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3523/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1368 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1711: rename asterix_transaction_log .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1368 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...
Jenkins has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule .. Patch Set 17: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1297/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1350 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 2
Jenkins has posted comments on this change. Change subject: Full-text implementation step 2 .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/27/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1711: rename asterix_transaction_log .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1299/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1368 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1711: rename asterix_transaction_log .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/28/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1368 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Full-text implementation step 2
Jenkins has posted comments on this change. Change subject: Full-text implementation step 2 .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1298/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec6b602ff7797846fd237a924005031c2395346 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1711: rename asterix_transaction_log .. Patch Set 4: Integration-Tests-1 Integration Tests Timed Out https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1299/ : ABORTED -- To view, visit https://asterix-gerrit.ics.uci.edu/1368 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
