Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2589/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1050/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1050/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/404/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2589/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/222/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5088/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/141/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1630 to look at the new patch set (#10). Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Index-Only Plan Patch Set 4: Index SearchCursor adjustment - Modify the search cursors to maintain the result of proceed() since the result will be required to check whether the given tuple is qualified to be part of an index-only plan result or not. More details will be followed in the next patch set. - Fix the search cursors to call cancel() correctly. Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 --- M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java 6 files changed, 175 insertions(+), 103 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/30/1630/10 -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3611/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Jenkins has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/220/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
Taewoo Kim has posted comments on this change. Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment .. Patch Set 9: (2 comments) Thanks YingYi. https://asterix-gerrit.ics.uci.edu/#/c/1630/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java: PS9, Line 131: . > Is it a no-op, essentially? you call lock and then unlock()? We need to make sure that the element is on a disk component. After this, we can return this element. https://asterix-gerrit.ics.uci.edu/#/c/1630/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java: PS9, Line 191: cancelProceed > We didn't add cancel proceed. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes
[jira] [Created] (ASTERIXDB-1893) Ansible start.sh fails on Ubuntu
Xikui Wang created ASTERIXDB-1893:
-
Summary: Ansible start.sh fails on Ubuntu
Key: ASTERIXDB-1893
URL: https://issues.apache.org/jira/browse/ASTERIXDB-1893
Project: Apache AsterixDB
Issue Type: Bug
Reporter: Xikui Wang
Priority: Minor
Trying to start a local instance with ansible start.sh, and it fails bringing
up cc. cc.log shows
{noformat}
Error: JAVA_HOME is not defined correctly.
We cannot execute
{noformat}
ncservice.log shows the same thing. JAVA_HOME env parameter is properly
configured in .bashrc and ncservice local cluster works properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Change in asterixdb[master]: Document the Query Service API
Till Westmann has posted comments on this change. Change subject: Document the Query Service API .. Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1698/1/asterixdb/asterix-doc/src/site/markdown/api.md File asterixdb/asterix-doc/src/site/markdown/api.md: Line 45: $ curl -v --data-urlencode "statement=select 1;" \ > I would suggest using a slightly more interesting query here - partly to ma I'm not sure. All of he API-specific encoding is done by the --data-urlencode option of curl (and I think that the description for "statement" should clarify that better). So all the encoding issues that we would illustrate here would actually be shell encoding issues - which are shell dependent and not API dependent. And they also would not apply for all other uses of the API in applications (which hopefully is the main use-case). So I think that having a simple query with an understandable command line here is a better solution. PS1, Line 47: client_context_id > could we have more explanation about the `client_context_id` and its usage? This is just a user-defined sequence of characters that the API receives and returns unchanged. One way this can be used is to match individual requests, jobs, and responses (as in the case of the cancellation API). Another option could be to use it for groups of requests if an application decides to put e.g. an group identifier into that field. We should probably expose the value in the logs as well so that once could use it to match e.g. an error in a query to the application's business process that used the query to retrieve data. Does this make sense? Line 157: $ curl -v http://localhost:19002/query/service/status/9-0 > What is the /9-0 suffix here? It should be completely opaque to the user - this is just something one gets as a handle from a previous call. II should at least write that. Maybe we shouldn't even document these endpoints as one should never construct an URL for these in an application (but we probably need to document the shape of the result somehow). Thoughts? -- To view, visit https://asterix-gerrit.ics.uci.edu/1698 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcefb1671ea305a5958c9a74a588b4aaa17f399f Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes
Change in asterixdb[master]: Document the Query Service API
Jianfeng Jia has posted comments on this change. Change subject: Document the Query Service API .. Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1698/1/asterixdb/asterix-doc/src/site/markdown/api.md File asterixdb/asterix-doc/src/site/markdown/api.md: PS1, Line 47: client_context_id could we have more explanation about the `client_context_id` and its usage? I only know one use case of canceling a running query. -- To view, visit https://asterix-gerrit.ics.uci.edu/1698 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcefb1671ea305a5958c9a74a588b4aaa17f399f Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes
Change in asterixdb[master]: Document the Query Service API
Michael Carey has posted comments on this change. Change subject: Document the Query Service API .. Patch Set 1: (4 comments) I've added a few comments... https://asterix-gerrit.ics.uci.edu/#/c/1698/1/asterixdb/asterix-doc/src/site/markdown/api.md File asterixdb/asterix-doc/src/site/markdown/api.md: Line 43: __Command (immedidate result delivery)__ immedidate -> immediate Line 45: $ curl -v --data-urlencode "statement=select 1;" \ I would suggest using a slightly more interesting query here - partly to make the results a little more illustrative on the JSON side, partly to clarify some encoding questions that might arise, and partly to make the timings a bit more illustrative on the performance side in the async case (maybe). E.g.: SELECT ds.BucketName, ds.DatasetName, ds.`Filter` FROM Metadata.`Dataset` ds WHERE ds.DataverseName LIKE "D%"; Line 157: $ curl -v http://localhost:19002/query/service/status/9-0 What is the /9-0 suffix here? More generally, maybe there needs to be a sentence about how one correlates the subsequent requests to the query request? I assume this is (somehow) the answer to that. :-) Line 182: $ curl -v http://localhost:19002/query/service/result/7-0 Same question/comment here. -- To view, visit https://asterix-gerrit.ics.uci.edu/1698 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcefb1671ea305a5958c9a74a588b4aaa17f399f Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2588/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. Patch Set 2: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1049/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1049/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/403/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/140/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5087/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1692 to look at the new patch set (#2). Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. ASTERIXDB-1885: Fix printing field separators for record printer - Fix commas to not appear at the beginning of a record. Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/insert_from_ext_ds/insert_from_ext_ds.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java 7 files changed, 121 insertions(+), 18 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/92/1692/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2588/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3610/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/221/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1885: Fix printing field separators for record printer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/219/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1692 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-1892) A similarity join fails with "Failed to insert a new buffer into the aggregate operator! [HyracksDataException]" exception.
[
https://issues.apache.org/jira/browse/ASTERIXDB-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980316#comment-15980316
]
Wenhai commented on ASTERIXDB-1892:
---
As for the issue case itself, actually, "$p.asin /* +indexnl */ = $i.asin and
$p.id >= int64("3748") and $p.id <= int64("4237")" is a lower bound that may
result in this error. Once we join the pairwise prefix tokens derived from more
than such scale, we always encounter that error with groupby on their pairwise
recordID.
> A similarity join fails with "Failed to insert a new buffer into the
> aggregate operator! [HyracksDataException]" exception.
> ---
>
> Key: ASTERIXDB-1892
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1892
> Project: Apache AsterixDB
> Issue Type: Bug
>Reporter: Taewoo Kim
>Assignee: Taewoo Kim
>
> Note: this currently happens in the similarity join branch. It doesn't happen
> in the master branch. However, this symptom can happen in a situation where
> the input data size to the group-by is large.
> The following query fails with "Failed to insert a new buffer into the
> aggregate operator! [HyracksDataException]" exception. This query fetches
> 50,000 tuples and uses them as the inner side when doing the similarity join.
> The original data set size is about 20GB. And there are 8 nodes (each has two
> partitions).
> {code}
> use dataverse exp;
> count(
> for $o in dataset
> "AmazonReviewNoDup"
> for $p in dataset
> "AmazonReviewProductID"
> for $i in dataset
> "AmazonReviewNoDup"
> where $p.asin /* +indexnl */ = $i.asin and $p.id >=
> int64("3748")
> and $p.id <=
> int64("8747")
> and /* +skip-index */ similarity-jaccard(word-tokens($o.summary),
> word-tokens($i.summary)) >= 0.8 and $i.id < $o.id
> return {"oid":$o.id, "iid":$i.id}
> );
> {code}
> compiler.groupmemory size: 128MB
> The cause of this issue:
> When the optimizer sees the group-by operator during the plan optimization,
> it calls ExternalGroupByPOperator.calculateGroupByTableCardinality() method
> to set the cardinality of the hash table size. This ensures that the hash
> table size is never grown beyond the "compiler.groupmemory" size.
> And in the actual external hash group-by operator descriptor, it has two
> phases - build and merge. If the input data can be fit into the memory, then
> the final result will be generated in the build phase. If not, some of
> partitions will be spilled to the disk and these spilled partitions will be
> gradually merged during the merge phase.
> So, it first builds an intermediate result if the given memory is not big
> compared to the data size (spilled partitions). Then, it tries to aggregate
> them using a different seed for the hash function. At this time during the
> merge phase, the cardinality of hash table is set to the number of tuples in
> each spilled partition. This cardinality is just given without considering
> the fact that the hash table can be grown beyound the budget.
> And for the hash table, we only compact the content frames, not the header
> frames, The header frame can grow up to the certain size. This size can be
> bigger than the allocated memory size. The structure of the hash table can be
> found in the following.
> https://docs.google.com/presentation/d/1AExoTqQlx9va-AaiZ6OSPxBuQ3NJqz-cG5NGrjdk5FU/edit
> So, a possible solution would be:
> During the merge phase, calculate the cardinality of the hash table based on
> the memory budget. And compare this number to the actual cardinality that the
> caller wants to set. Pick the smaller one to be the cardinality of the hash
> table. Then, we will be safe. Compacting the header part of the hash table
> will help in some sense. But, it doesn't solve the issue fundamentally.
> In this observed case,
> the cardinality of the hash table during the merge phase was 51,395,283. The
> header part alone will take 392 MB if all tuples are unique. And the budget
> was 128 MB. And, the number of partitions was 24. A spilled partition size
> was 2.8GB. All of these partitions were spilled to the disk. And at that
> time, the hash table alone takes 126MB, not including the data table part.
> Thus, additional memory couldn't be allocated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
