Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Michael Blow has submitted this change and it was merged.
Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node
detection threshold
..
[NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection
threshold
Help prevent nodes under heavy gc from missing too many heartbeats
Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2426
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Murtadha Hubail
---
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java
1 file changed, 45 insertions(+), 9 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Murtadha Hubail: Looks good to me, approved
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java
index aa7a4fe..daed5e4 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java
@@ -18,6 +18,8 @@
*/
package org.apache.hyracks.control.cc.work;
+import static org.apache.hyracks.api.config.Section.LOCALNC;
+import static org.apache.hyracks.api.config.Section.NC;
import static
org.apache.hyracks.control.common.controllers.ServiceConstants.NC_SERVICE_MAGIC_COOKIE;
import java.io.IOException;
@@ -25,8 +27,9 @@
import java.io.StringWriter;
import java.net.Socket;
-import org.apache.hyracks.api.config.Section;
+import org.apache.hyracks.api.config.IApplicationConfig;
import org.apache.hyracks.control.cc.ClusterControllerService;
+import org.apache.hyracks.control.common.config.ConfigManager;
import org.apache.hyracks.control.common.controllers.NCConfig;
import
org.apache.hyracks.control.common.controllers.ServiceConstants.ServiceCommand;
import org.apache.hyracks.control.common.work.AbstractWork;
@@ -34,6 +37,7 @@
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.ini4j.Ini;
+import org.ini4j.Profile.Section;
/**
* A work which is run at CC startup for each NC specified in the
configuration file.
@@ -42,6 +46,7 @@
public class TriggerNCWork extends AbstractWork {
private static final Logger LOGGER = LogManager.getLogger();
+private static final String JVM_ARG_MAX_GCPAUSE_MILLIS =
"-XX:MaxGCPauseMillis=";
private final ClusterControllerService ccs;
private final String ncHost;
@@ -64,7 +69,7 @@
ObjectOutputStream oos = new
ObjectOutputStream(s.getOutputStream());
oos.writeUTF(NC_SERVICE_MAGIC_COOKIE);
oos.writeUTF(ServiceCommand.START_NC.name());
-
oos.writeUTF(TriggerNCWork.this.serializeIni(ccs.getCCConfig().getIni()));
+oos.writeUTF(TriggerNCWork.this.serializeIni());
oos.close();
return;
// QQQ Should probably have an ACK here
@@ -83,21 +88,52 @@
/**
* Given an Ini object, serialize it to String with some enhancements.
- * @param ccini the ini file to decorate and forward to NC
*/
-private String serializeIni(Ini ccini) throws IOException {
+private String serializeIni() throws IOException {
StringWriter iniString = new StringWriter();
-
ccini.get(Section.NC.sectionName()).putIfAbsent(NCConfig.Option.CLUSTER_ADDRESS.ini(),
-ccs.getCCConfig().getClusterPublicAddress());
-
ccini.get(Section.NC.sectionName()).putIfAbsent(NCConfig.Option.CLUSTER_PORT.ini(),
-String.valueOf(ccs.getCCConfig().getClusterPublicPort()));
+ConfigManager configManager = ccs.getCCConfig().getConfigManager();
+Ini ccini = configManager.toIni(false);
+IApplicationConfig ncConfig =
configManager.getNodeEffectiveConfig(ncId);
+Section ncSection = getNcSection(ccini);
+configClusterAddress(ncConfig, ncSection);
+configMaxGcPause(ncConfig, ncSection);
// Finally insert *this* NC's name into localnc section - this is a
fixed
// entry point so that NCs can determine where all their config is.
-ccini.put(Section.LOCALNC.sectionName(),
NCConfig.Option.NODE_ID.ini(), ncId);
+ccini.put(LOCALNC.sectionName(), NCConfig.Option.NODE_ID.ini(), ncId);
ccini.store(iniString);
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("Returning Ini file:\n" + iniString.toString());
}
ret
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5767/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/SVYSb6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Resolved] (ASTERIXDB-2302) Incorrect result with non-enforced secondary index
[ https://issues.apache.org/jira/browse/ASTERIXDB-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Lychagin resolved ASTERIXDB-2302. Resolution: Fixed > Incorrect result with non-enforced secondary index > --- > > Key: ASTERIXDB-2302 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2302 > Project: Apache AsterixDB > Issue Type: Bug > Components: COMP - Compiler >Reporter: Dmitry Lychagin >Assignee: Dmitry Lychagin >Priority: Major > > Incorrect result for query that uses non-enforced secondary index when that > index is created as integer type while the data is of double type > create index idx_i64_on_d on TestOpen(c_d:int64); > c_d is an open field in the TestOpen dataset which contains double values. > Query: > select ... > from TestOpen > where c_d = 3.25 > The secondary index gets chosen by the query optimizer, but the plan is > incorrect because it does not convert the probe value (3.25) to an integer > value. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ASTERIXDB-2302) Incorrect result with non-enforced secondary index
[ https://issues.apache.org/jira/browse/ASTERIXDB-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378067#comment-16378067 ] ASF subversion and git services commented on ASTERIXDB-2302: Commit b8bf7aa92786127a97d049a764ff76c28a92d94e in asterixdb's branch refs/heads/master from [~dlychagin-cb] [ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=b8bf7aa ] [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index - user model changes: no - storage format changes: no - interface changes: no Details: - Incorrect result returned when a non-enforced index is created as integer type, but probed with double value Change-Id: I236c4c92d82bc3292193b2eb0f9b771042b3ca1a Reviewed-on: https://asterix-gerrit.ics.uci.edu/2425 Sonar-Qube: Jenkins Integration-Tests: Jenkins Tested-by: Jenkins Contrib: Jenkins Reviewed-by: Taewoo Kim > Incorrect result with non-enforced secondary index > --- > > Key: ASTERIXDB-2302 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2302 > Project: Apache AsterixDB > Issue Type: Bug > Components: COMP - Compiler >Reporter: Dmitry Lychagin >Assignee: Dmitry Lychagin >Priority: Major > > Incorrect result for query that uses non-enforced secondary index when that > index is created as integer type while the data is of double type > create index idx_i64_on_d on TestOpen(c_d:int64); > c_d is an open field in the TestOpen dataset which contains double values. > Query: > select ... > from TestOpen > where c_d = 3.25 > The secondary index gets chosen by the query optimizer, but the plan is > incorrect because it does not convert the probe value (3.25) to an integer > value. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index
Dmitry Lychagin has submitted this change and it was merged.
Change subject: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index
..
[ASTERIXDB-2302][COMP] Incorrect result with non-enforced index
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Incorrect result returned when a non-enforced index is created
as integer type, but probed with double value
Change-Id: I236c4c92d82bc3292193b2eb0f9b771042b3ca1a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2425
Sonar-Qube: Jenkins
Integration-Tests: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Reviewed-by: Taewoo Kim
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/open-index-non-enforced/index-selection/btree-index-04/btree-index-04.1.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/open-index-non-enforced/index-selection/btree-index-04/btree-index-04.2.update.ddl
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/open-index-non-enforced/index-selection/btree-index-04/btree-index-04.3.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/open-index-non-enforced/index-selection/btree-index-04/btree-index-04.4.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/open-index-non-enforced/index-selection/btree-index-04/btree-index-04.4.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
7 files changed, 178 insertions(+), 8 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Taewoo Kim: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
index 9950e37..eafbdaf 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
@@ -499,8 +499,7 @@
// In this case, we need to change the search parameter. Refer
to the caller section for the detail.
realTypeConvertedToIntegerType =
isRealTypeConvertedToIntegerType(constantValueTag,
indexedFieldTypeTag);
-if (realTypeConvertedToIntegerType && !index.isEnforced() &&
!index.isOverridingKeyFieldTypes()) {
-// For the index on a closed-type field,
+if (realTypeConvertedToIntegerType) {
// if a DOUBLE or FLOAT constant is converted to an INT
type value,
// we need to check a corner case where two real values
are located
// between an INT value. For example, the following query,
@@ -564,7 +563,7 @@
// NEQ should not be a case.
throw new IllegalStateException();
}
-} else if (!realTypeConvertedToIntegerType) {
+} else {
// Type conversion only case: (e.g., INT -> BIGINT)
replacedConstantValue =
getReplacedConstantValue(constantValue.getObject(), constantValueTag,
indexedFieldTypeTag, index.isEnforced(),
TypeCastingMathFunctionType.NONE);
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/open-index-non-enforced/index-selection/btree-index-04/btree-index-04.1.ddl.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/open-index-non-enforced/index-selection/btree-index-04/btree-index-04.1.ddl.sqlpp
new file mode 100644
index 000..f215764
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/open-index-non-enforced/index-selection/btree-index-04/btree-index-04.1.ddl.sqlpp
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+* Description : Ind
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2784/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2425 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I236c4c92d82bc3292193b2eb0f9b771042b3ca1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2784/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/v4oEfx : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3350/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3325/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5765/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2783/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2425 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I236c4c92d82bc3292193b2eb0f9b771042b3ca1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/oJL7r4 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5767/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/bVXgaQ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
abdullah alamoudi has uploaded a new patch set (#2). Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. [NO ISSUE][ING] Close and return on interrupt of ingestion - user model changes: no - storage format changes: no - interface changes: no Details: - Previously, we would still attempt to write through the network in case an ingestion task is interrupted. - The goal was to try and get as much data in as possible but in the case where the cluster was in a bad state, this could lead to hanging threads. - After this change, each record reader must implement the stop method correctly to allow for graceful stop while interrupts will always mean abort the task and return as soon as possible. Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java 5 files changed, 10 insertions(+), 19 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/28/2428/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6809/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3390/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/866/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8316/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2855/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3589/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3076/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2770/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2819/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2844/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2818/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/865/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3075/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3389/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2854/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2843/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3588/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8315/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6808/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2428
Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion
..
[NO ISSUE][ING] Close and return on interrupt of ingestion
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Previously, we would still attempt to write through the network
in case an ingestion task is interrupted.
- The goal was to try and get as much data in as possible but in
the case where the cluster was in a bad state, this could
lead to hanging threads.
- After this change, each record reader must implement the stop
method correctly to allow for graceful stop while interrupts
will always mean abort the task and return as soon as possible.
Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b
---
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
4 files changed, 9 insertions(+), 18 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/28/2428/1
diff --git
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
index 1a83603..04054f1 100644
---
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
+++
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
@@ -250,7 +250,6 @@
public static final int ACTIVE_RUNTIME_IS_ALREADY_REGISTERED = 3105;
public static final int ACTIVE_RUNTIME_IS_NOT_REGISTERED = 3106;
public static final int ACTIVE_EVENT_HANDLER_ALREADY_SUSPENDED = 3107;
-public static final int FEED_STOPPED_WHILE_WAITING_FOR_A_NEW_RECORD = 3108;
public static final int METADATA_DROP_FUCTION_IN_USE = 3109;
public static final int FEED_FAILED_WHILE_GETTING_A_NEW_RECORD = 3110;
public static final int FEED_START_FEED_WITHOUT_CONNECTION = 3111;
diff --git
a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
index 995b541..1fb8480 100644
--- a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
+++ b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
@@ -239,7 +239,6 @@
3105 = %1$s is already registered
3106 = %1$s is not registered
3107 = Active Notification Handler is already suspended
-3108 = Feed stopped while waiting for a new record
3109 = Function %1$s is being used. It cannot be dropped
3110 = Feed failed while reading a new record
3111 = Feed %1$s is not connected to any dataset
diff --git
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
index 306a2a5..9826be7 100644
---
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
+++
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
@@ -95,11 +95,7 @@
}
} catch (HyracksDataException e) {
LOGGER.log(Level.WARN, "Exception during ingestion", e);
-//if interrupted while waiting for a new record, then it is safe
to not fail forward
if (e.getComponent() == ErrorCode.ASTERIX
-&& (e.getErrorCode() ==
ErrorCode.FEED_STOPPED_WHILE_WAITING_FOR_A_NEW_RECORD)) {
-// Do nothing. interrupted by the active manager
-} else if (e.getComponent() == ErrorCode.ASTERIX
&& (e.getErrorCode() ==
ErrorCode.FEED_FAILED_WHILE_GETTING_A_NEW_RECORD)) {
// Failure but we know we can for sure push the previously
parsed records safely
failure = e;
@@ -141,11 +137,8 @@
private IRawRecord next() throws Exception {
try {
return recordReader.next();
-} catch (InterruptedException e) { // NOSONAR Gracefully handling
interrupt to push records in the pipeline
-if (flushing) {
-throw e;
-}
-throw new
RuntimeDataException(ErrorCode.FEED_STOPPED_WHILE_WAITING_FOR_A_NEW_RECORD, e);
+} catch (InterruptedException e) {
+throw e;
} catch (Exception e) {
if (flushing) {
throw e;
@@ -161,11 +15
Change in asterixdb[master]: [NO ISSUE][ING] Close and return on interrupt of ingestion
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Close and return on interrupt of ingestion .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2769/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2782/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2783/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2425 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I236c4c92d82bc3292193b2eb0f9b771042b3ca1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2782/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5764/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3349/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2425 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I236c4c92d82bc3292193b2eb0f9b771042b3ca1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2781/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/eXNEXo : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3348/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Michael Blow has submitted this change and it was merged.
Change subject: [NO ISSUE] Serialize String [] options as JSON arrays
..
[NO ISSUE] Serialize String [] options as JSON arrays
Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2427
Reviewed-by: Murtadha Hubail
Integration-Tests: Murtadha Hubail
Tested-by: Murtadha Hubail
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
3 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
Murtadha Hubail: Looks good to me, approved; Verified; Verified
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
index aee22c9..ba2b021 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
@@ -42,7 +42,7 @@
}
/**
- * @return the value in a format suitable for serialized JSON
+ * Serializes the value as a field in the provided object node
*/
void serializeJSONField(String fieldName, Object value, ObjectNode node);
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
index cba5e19..bdb2aed 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
@@ -76,10 +76,6 @@
commons-collections4
- org.apache.commons
- commons-lang3
-
-
org.apache.logging.log4j
log4j-api
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
index b188548..ae424b7 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
@@ -21,8 +21,8 @@
import java.net.MalformedURLException;
import java.util.ArrayList;
import java.util.List;
+import java.util.stream.Stream;
-import org.apache.commons.lang3.StringUtils;
import org.apache.hyracks.api.config.IOptionType;
import org.apache.hyracks.util.StorageUtil;
import org.apache.logging.log4j.Level;
@@ -305,7 +305,12 @@
@Override
public void serializeJSONField(String fieldName, Object value,
ObjectNode node) {
-node.put(fieldName, value == null ? null :
StringUtils.join((String[]) value, ','));
+if (value == null) {
+node.putNull(fieldName);
+} else {
+ArrayNode array = node.putArray(fieldName);
+Stream.of((String[]) value).forEachOrdered(array::add);
+}
}
};
--
To view, visit https://asterix-gerrit.ics.uci.edu/2427
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2781/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-1268) Sporadic test failure in record-remove-fields test
[
https://issues.apache.org/jira/browse/ASTERIXDB-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377972#comment-16377972
]
Michael Blow commented on ASTERIXDB-1268:
-
Hit again,
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3347/
> Sporadic test failure in record-remove-fields test
> --
>
> Key: ASTERIXDB-1268
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1268
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: FUN - Functions
>Reporter: Yingyi Bu
>Assignee: Heri Ramampiaro
>Priority: Critical
>
> {noformat}
> Error Message
> Test
> "src/test/resources/runtimets/queries/records/record-remove-fields/highly-nested-open/highly-nested-open.3.query.aql"
> FAILED!
> Stacktrace
> java.lang.Exception: Test
> "src/test/resources/runtimets/queries/records/record-remove-fields/highly-nested-open/highly-nested-open.3.query.aql"
> FAILED!
> at
> org.apache.asterix.test.aql.TestExecutor.runScriptAndCompareWithResult(TestExecutor.java:116)
> at
> org.apache.asterix.test.aql.TestExecutor.executeTest(TestExecutor.java:495)
> at
> org.apache.asterix.test.runtime.ExecutionTest.test(ExecutionTest.java:96)
> Standard Error
> Expected results file:
> src/test/resources/runtimets/results/records/record-remove-fields/highly-nested-open/highly-nested-open.3.adm
> testFile
> src/test/resources/runtimets/queries/records/record-remove-fields/highly-nested-open/highly-nested-open.3.query.aql
> raised an exception:
> java.lang.Exception: Result for
> src/test/resources/runtimets/queries/records/record-remove-fields/highly-nested-open/highly-nested-open.3.query.aql
> changed at line 1:
> < { "id": 1, "class": { "id": 1 } }
> > { "id": 1, "class": { "id": 1, "fullClassification": { "id": 1, "Kingdom":
> > "Animalia", "lower": { "id": 1, "Phylum": "Chordata", "lower": { "id": 1,
> > "Class": "Mammalia", "lower": { "id": 1, "Order": "Carnivora", "lower": {
> > "id": 1, "Family": "Mustelinae", "lower": { "id": 1, "Genus": "Gulo",
> > "lower": { "id": 1, "Species": "Gulo" } } } } } } } } }
> at
> org.apache.asterix.test.aql.TestExecutor.runScriptAndCompareWithResult(TestExecutor.java:116)
> at
> org.apache.asterix.test.aql.TestExecutor.executeTest(TestExecutor.java:495)
> at
> org.apache.asterix.test.runtime.ExecutionTest.test(ExecutionTest.java:96)
> at sun.reflect.GeneratedMethodAccessor26.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runners.Suite.runChild(Suite.java:127)
> at org.junit.runners.Suite.runChild(Suite.java:26)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
> at
> org.apache.maven.sur
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Code-Review+2 Integration-Tests+1 Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3324/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3587/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5765/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/epTtnG : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2853/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/EVagHT : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2768/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8314/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6807/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2817/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3074/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/864/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3388/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2426 to look at the new patch set (#2). Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold Help prevent nodes under heavy gc from missing too many heartbeats Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java 1 file changed, 45 insertions(+), 9 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/26/2426/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2842/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3347/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2780/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3323/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5763/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2780/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3586/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2426/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java: PS1, Line 107: -XX:MaxGCPauseMillis constant -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5764/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/FL6UUD : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/4JgBvy : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2767/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2427
Change subject: [NO ISSUE] Serialize String [] options as JSON arrays
..
[NO ISSUE] Serialize String [] options as JSON arrays
Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
3 files changed, 8 insertions(+), 7 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/27/2427/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
index aee22c9..ba2b021 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
@@ -42,7 +42,7 @@
}
/**
- * @return the value in a format suitable for serialized JSON
+ * Serializes the value as a field in the provided object node
*/
void serializeJSONField(String fieldName, Object value, ObjectNode node);
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
index cba5e19..bdb2aed 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
@@ -76,10 +76,6 @@
commons-collections4
- org.apache.commons
- commons-lang3
-
-
org.apache.logging.log4j
log4j-api
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
index b188548..ae424b7 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
@@ -21,8 +21,8 @@
import java.net.MalformedURLException;
import java.util.ArrayList;
import java.util.List;
+import java.util.stream.Stream;
-import org.apache.commons.lang3.StringUtils;
import org.apache.hyracks.api.config.IOptionType;
import org.apache.hyracks.util.StorageUtil;
import org.apache.logging.log4j.Level;
@@ -305,7 +305,12 @@
@Override
public void serializeJSONField(String fieldName, Object value,
ObjectNode node) {
-node.put(fieldName, value == null ? null :
StringUtils.join((String[]) value, ','));
+if (value == null) {
+node.putNull(fieldName);
+} else {
+ArrayNode array = node.putArray(fieldName);
+Stream.of((String[]) value).forEachOrdered(array::add);
+}
}
};
--
To view, visit https://asterix-gerrit.ics.uci.edu/2427
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6806/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2841/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3387/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2816/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8313/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2852/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/863/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Serialize String [] options as JSON arrays
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Serialize String [] options as JSON arrays .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3073/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e05c2b30b87597b5896318b5f3a4f755f889af4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3346/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3322/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5762/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2425 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I236c4c92d82bc3292193b2eb0f9b771042b3ca1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3585/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2302][COMP] Incorrect result with non-enforced index .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/nRNBz3 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2425 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I236c4c92d82bc3292193b2eb0f9b771042b3ca1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5763/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2851/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/vtRUsy : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2815/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2766/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/862/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3386/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead no...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Set MaxGCPauseMillis to not exceed 1/2 of dead node detection threshold .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6805/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e51db5ccfbb4771ba1f6e0264abfd69f833e7e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
