Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3152/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3152/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3964/ (9/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4229/ (4/4) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3726/ (7/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8974/ (1/3) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3942/ (8/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3423/ (5/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3511/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3499/ (2/3) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4043/ (6/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3470/ (3/4) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Relax JAVA_HOME check for sample cluster
Jenkins has posted comments on this change. Change subject: Relax JAVA_HOME check for sample cluster .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1518/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9421b9b480eeea94644a227faf614c2ccf2fb2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Luo Chen has posted comments on this change.
Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/2637/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java:
Line 109: if (includeMutableComponent &&
queueHead.getCursorIndex() == 0) {
> Why this additional check (queueHead.getCursorIndex()) is needed? Isn't inc
includeMutableComponent indicates the priority queue contains tuples from
memory components. However, the actual tuple here could still be originated
from disk components.
--
To view, visit https://asterix-gerrit.ics.uci.edu/2637
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Luo Chen
Gerrit-Reviewer: Taewoo Kim
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6380/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/ZQMAUk : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Taewoo Kim has posted comments on this change.
Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components
..
Patch Set 1:
(1 comment)
Thanks for taking care of this.
https://asterix-gerrit.ics.uci.edu/#/c/2637/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java:
Line 109: if (includeMutableComponent &&
queueHead.getCursorIndex() == 0) {
Why this additional check (queueHead.getCursorIndex()) is needed? Isn't
includeMutableComponent variable enough, since we set it to false once we
finish fetching all tuples from the in-memory component.
--
To view, visit https://asterix-gerrit.ics.uci.edu/2637
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Taewoo Kim
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Analytics Compatibility Tests Successful https://goo.gl/GHxMP8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/izQzY2 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6380/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3725/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3498/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3941/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3469/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4228/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1517/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3963/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4042/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7449/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3422/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8973/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3510/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Eliminate S Lock for Disk Components
Luo Chen has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2637
Change subject: [NO ISSUE][STO] Eliminate S Lock for Disk Components
..
[NO ISSUE][STO] Eliminate S Lock for Disk Components
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Eliminate S lock for tuples returned from disk components, since LSM
disk components only contain committed data and S lock is not needed to
prevent from reading uncommitted data.
Change-Id: Id6ec999b131cd6609d588966d7ae7788f429ab9d
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeSearchCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
4 files changed, 14 insertions(+), 6 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/37/2637/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
index 81f4a83..d84a778 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
@@ -106,8 +106,8 @@
if (!outputPriorityQueue.isEmpty()) {
PriorityQueueElement queueHead = outputPriorityQueue.peek();
if (canCallProceed) {
-resultOfSearchCallbackProceed =
searchCallback.proceed(queueHead.getTuple());
-if (includeMutableComponent) {
+if (includeMutableComponent && queueHead.getCursorIndex()
== 0) {
+resultOfSearchCallbackProceed =
searchCallback.proceed(queueHead.getTuple());
if (!resultOfSearchCallbackProceed) {
// In case proceed() fails and there is an
in-memory component,
// we can't simply use this element since there
might be a change.
@@ -150,6 +150,10 @@
includeMutableComponent = false;
}
}
+} else {
+// only perform locking for tuples from memory
components.
+// all tuples from disk components have already been
committed, and we're safe to proceed
+resultOfSearchCallbackProceed = true;
}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
index 4d444b9..d39c601 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
@@ -59,6 +59,7 @@
private List deletedKeysBTreeAccessors;
private RangePredicate keySearchPred;
private ILSMIndexOperationContext opCtx;
+private boolean includeMemoryComponents;
private List operationalComponents;
private ITupleReference currentTuple = null;
@@ -76,7 +77,7 @@
accessorIndex = 0;
this.searchPred = searchPred;
this.searchCallback = lsmInitState.getSearchOperationCallback();
-
+includeMemoryComponents = false;
// For searching the deleted-keys BTrees.
deletedKeysBTreeAccessors =
lsmInitState.getDeletedKeysBTreeAccessors();
deletedKeysBTreeCursors = new
IIndexCursor[deletedKeysBTreeAccessors.size()];
@@ -87,6 +88,7 @@
if (component.getType() == LSMComponentType.MEMORY) {
// No need for a bloom filter for the in-memory BTree.
deletedKeysBTreeBloomFilters[i] = null;
+includeMemoryComponents = true;
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan
Taewoo Kim has abandoned this change. Change subject: Index-only plan .. Abandoned -- To view, visit https://asterix-gerrit.ics.uci.edu/744 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560 Gerrit-PatchSet: 26 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Young-Seok Kim
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6379/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2375][RT] Evaluate constant experession in SELECT...
Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2375][RT] Evaluate constant experession in SELECT only once .. Patch Set 12: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2621/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java: Line 450: // if any exception happens, treat it as non-constant case. > In the NCServiceExceutionIT, the passed in are malformed. In that case, the Can we fix the testcase instead? -- To view, visit https://asterix-gerrit.ics.uci.edu/2621 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae4e78928da2bd63b2984b3624b88baed9b7cd73 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes
[jira] [Commented] (ASTERIXDB-2373) Allow Deployed Jobs to receive new Job Specifications
[ https://issues.apache.org/jira/browse/ASTERIXDB-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467776#comment-16467776 ] ASF subversion and git services commented on ASTERIXDB-2373: Commit 70a14b5bb4affd3e6711f95bf5118d07e5317a4d in asterixdb's branch refs/heads/master from [~sjaco002] [ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=70a14b5 ] [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs - user model changes: none - storage format changes: none - interface changes: new methods added This change adds the upsertDeployedJobSpec method, enabling a Deployed Job to update its Job Specification. Added call in test. Removed DeployedJobService (moved methods to BAD codebase). Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Reviewed-on: https://asterix-gerrit.ics.uci.edu/2619 Tested-by: Jenkins Contrib: Jenkins Reviewed-by: Xikui Wang > Allow Deployed Jobs to receive new Job Specifications > - > > Key: ASTERIXDB-2373 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2373 > Project: Apache AsterixDB > Issue Type: Improvement >Reporter: Steven Jacobs >Assignee: Steven Jacobs >Priority: Major > > It may be desirable to create a new Job Specification for a Deployed Job. We > need some way to handle this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb-bad[master]: Allow BAD jobs to update their specifications to use new ind...
Steven Jacobs has submitted this change and it was merged. Change subject: Allow BAD jobs to update their specifications to use new indexes .. Allow BAD jobs to update their specifications to use new indexes - storage format changes: new field for Channel body This changes uses the Asterix upsertDeployedJobSpec to recompile and update the channel job when new indexes are created. Added test case Moved methods from Asterix DeployedJobService to BADJobService Change-Id: If0a4d37a5b91063fcb1673dbfd008c140ed54ae6 --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java A asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java D asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DeployedJobSpecEventListener.java M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java M asterix-bad/src/main/resources/lang-extension/lang.txt A asterix-bad/src/test/java/org/apache/asterix/bad/test/BADListenerTest.java A asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.1.ddl.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.2.update.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.3.update.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.4.sleep.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.5.query.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/add_index/add_index.6.ddl.sqlpp A asterix-bad/src/test/resources/runtimets/queries/channel/drop_index/drop_index.1.ddl.sqlpp A asterix-bad/src/test/resources/runtimets/results/channel/add_index/add_index.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/create_channel_check_metadata/create_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/channel/drop_channel_check_metadata/drop_channel_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/results/procedure/create_procedure_check_metadata/create_procedure_check_metadata.1.adm M asterix-bad/src/test/resources/runtimets/testsuite.xml 26 files changed, 1,343 insertions(+), 307 deletions(-) Approvals: Jenkins: Verified Xikui Wang: Looks good to me, approved diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java b/asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java index d2d0fa3..d422663 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java @@ -50,6 +50,7 @@ String FIELD_NAME_RETURN_TYPE = "ReturnType"; String FIELD_NAME_DEFINITION = "Definition"; String FIELD_NAME_LANGUAGE = "Language"; +String FIELD_NAME_BODY = "Body"; //To enable new Asterix TxnId for separate deployed job spec invocations byte[] TRANSACTION_ID_PARAMETER_NAME = "TxnIdParameter".getBytes(); int EXECUTOR_TIMEOUT = 20; diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java new file mode 100644 index 000..e326ce6 --- /dev/null +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java @@ -0,0 +1,277 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.asterix.bad; + +import java.io.StringReader; +import java.time.Instant; +import java.util.Date; +i
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Steven Jacobs has submitted this change and it was merged.
Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for
Deployed Jobs
..
[ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs
- user model changes: none
- storage format changes: none
- interface changes: new methods added
This change adds the upsertDeployedJobSpec method, enabling
a Deployed Job to update its Job Specification.
Added call in test.
Removed DeployedJobService (moved methods to BAD codebase).
Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2619
Tested-by: Jenkins
Contrib: Jenkins
Reviewed-by: Xikui Wang
---
D
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/DeployedJobService.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceRemoteProxy.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClientInterfaceIPCI.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/DeployedJobSpecStore.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/DeployJobSpecWork.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerIPCI.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/DeployJobSpecWork.java
M
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DeployedJobSpecsTest.java
16 files changed, 115 insertions(+), 143 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified;
Xikui Wang: Looks good to me, approved
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/DeployedJobService.java
b/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/DeployedJobService.java
deleted file mode 100644
index bc6f1b1..000
---
a/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/DeployedJobService.java
+++ /dev/null
@@ -1,111 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.asterix.active;
-
-import java.time.Instant;
-import java.util.Date;
-import java.util.Map;
-import java.util.concurrent.Executors;
-import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.TimeUnit;
-
-import org.apache.asterix.common.transactions.ITxnIdFactory;
-import org.apache.hyracks.api.client.IHyracksClientConnection;
-import org.apache.hyracks.api.job.DeployedJobSpecId;
-import org.apache.hyracks.api.job.JobId;
-import org.apache.logging.log4j.Level;
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
-
-/**
- * Provides functionality for running DeployedJobSpecs
- */
-public class DeployedJobService {
-
-private static final Logger LOGGER = LogManager.getLogger();
-
-//To enable new As
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/nAWCSU : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Xikui Wang has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3151/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3151/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb-bad[master]: Allow BAD jobs to update their specifications to use new ind...
Xikui Wang has posted comments on this change. Change subject: Allow BAD jobs to update their specifications to use new indexes .. Patch Set 9: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2620 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0a4d37a5b91063fcb1673dbfd008c140ed54ae6 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Analytics Compatibility Compilation Successful https://goo.gl/8KFz7f : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3497/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3962/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1516/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3468/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4041/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8972/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6379/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3421/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7448/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3724/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4227/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3509/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Depl...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3940/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb-bad[master]: Allow BAD jobs to update their specifications to use new ind...
Steven Jacobs has posted comments on this change. Change subject: Allow BAD jobs to update their specifications to use new indexes .. Patch Set 9: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2620/9/asterix-bad/src/test/java/org/apache/asterix/bad/test/BADListenerTest.java File asterix-bad/src/test/java/org/apache/asterix/bad/test/BADListenerTest.java: Line 33: private static DeployedJobSpecEventListener djsel; > This test case doesn't cover what you would want to test. A good test examp I am covering such cases. Line 78 does (1), Line 79 does (2) then 5 seconds later line 78 completes and thereby completes (2). Lines 76 and 77 do (3). -- To view, visit https://asterix-gerrit.ics.uci.edu/2620 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0a4d37a5b91063fcb1673dbfd008c140ed54ae6 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6378/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/NFG49c : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/sb3BUP : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: -Integration-Tests Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6378/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6377/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3150/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3150/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/4Mx3xV : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6377/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4226/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1515/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3496/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8971/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3508/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3467/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3723/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3939/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4040/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7447/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3420/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3961/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2636
Change subject: [NO ISSUE][API] QueryServiceServlet HTTP API Improvements
..
[NO ISSUE][API] QueryServiceServlet HTTP API Improvements
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Default NC timeout to Long.MAX.
- Accept signature as parameter and default its
value to true and its returned value to {"*":"*"}.
- Accept "json" as a synonym for "application/json" format.
Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
3 files changed, 24 insertions(+), 6 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/36/2636/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
index dd03860..3d0858c 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
@@ -149,7 +149,8 @@
REWRITTEN_EXPRESSION_TREE("rewritten-expression-tree"),
LOGICAL_PLAN("logical-plan"),
OPTIMIZED_LOGICAL_PLAN("optimized-logical-plan"),
-JOB("job");
+JOB("job"),
+SIGNATURE("signature");
private final String str;
@@ -212,6 +213,7 @@
boolean logicalPlan;
boolean optimizedLogicalPlan;
boolean job;
+boolean signature;
@Override
public String toString() {
@@ -233,6 +235,7 @@
on.put("logicalPlan", logicalPlan);
on.put("optimizedLogicalPlan", optimizedLogicalPlan);
on.put("job", job);
+on.put("signature", signature);
return om.writer(new
MinimalPrettyPrinter()).writeValueAsString(on);
} catch (JsonProcessingException e) { // NOSONAR
LOGGER.debug("unexpected exception marshalling {} instance to
json", getClass(), e);
@@ -311,7 +314,7 @@
if (format.equals(HttpUtil.ContentType.APPLICATION_ADM)) {
return SessionConfig.OutputFormat.ADM;
}
-if (format.startsWith(HttpUtil.ContentType.APPLICATION_JSON)) {
+if (isJsonFormat(format)) {
return Boolean.parseBoolean(getParameterValue(format,
Attribute.LOSSLESS.str()))
? SessionConfig.OutputFormat.LOSSLESS_JSON :
SessionConfig.OutputFormat.CLEAN_JSON;
}
@@ -350,8 +353,15 @@
}
}
-private static void printSignature(PrintWriter pw) {
-ResultUtil.printField(pw, ResultFields.SIGNATURE.str(), "*");
+private static void printSignature(PrintWriter pw, RequestParameters
param) {
+if (param.signature) {
+pw.print("\t\"");
+pw.print(ResultFields.SIGNATURE.str());
+pw.print("\": {\n");
+pw.print("\t");
+ResultUtil.printField(pw, "*", "*", false);
+pw.print("\t},\n");
+}
}
private static void printType(PrintWriter pw, SessionConfig sessionConfig)
{
@@ -424,6 +434,7 @@
param.logicalPlan = getOptBoolean(jsonRequest,
Parameter.LOGICAL_PLAN.str(), false);
param.optimizedLogicalPlan = getOptBoolean(jsonRequest,
Parameter.OPTIMIZED_LOGICAL_PLAN.str(), false);
param.job = getOptBoolean(jsonRequest, Parameter.JOB.str(),
false);
+param.signature = getOptBoolean(jsonRequest,
Parameter.SIGNATURE.str(), true);
} catch (JsonParseException | JsonMappingException e) {
// if the JSON parsing fails, the statement is empty and we
get an empty statement error
GlobalConfig.ASTERIX_LOGGER.log(Level.ERROR, e.getMessage(),
e);
@@ -507,7 +518,7 @@
sessionOutput.out().print("{\n");
printRequestId(sessionOutput.out());
printClientContextID(sessionOutput.out(), param);
-printSignature(sessionOutput.out());
+printSignature(sessionOutput.out(), param);
printType(sessionOutput.out(), sessionConfig);
long errorCount = 1; // so far we just return 1 error
try {
@@ -622,4 +633,9 @@
}
pw.print(",\n");
}
+
+private static boolean isJsonFormat(String format) {
+return format.startsWith(HttpUtil.ContentType.APPLICATION_JSON)
+|| format.equalsIgnoreCase(HttpUtil.ContentType.JSON
[jira] [Resolved] (ASTERIXDB-2377) Invalid JSON in InsertDeleteUpsertOperator JSON Plan
[ https://issues.apache.org/jira/browse/ASTERIXDB-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtadha Hubail resolved ASTERIXDB-2377. Resolution: Fixed > Invalid JSON in InsertDeleteUpsertOperator JSON Plan > > > Key: ASTERIXDB-2377 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2377 > Project: Apache AsterixDB > Issue Type: Bug > Components: OTH - Other >Affects Versions: 0.9.3 >Reporter: Murtadha Hubail >Assignee: Murtadha Hubail >Priority: Major > Fix For: 0.9.4 > > > Invalid JSON is produced when InsertDeleteUpsertOperator has additional > non-filter expression (i.e. meta part). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ASTERIXDB-2385) Query Http API Response is Always Pretty
Murtadha Hubail created ASTERIXDB-2385: -- Summary: Query Http API Response is Always Pretty Key: ASTERIXDB-2385 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2385 Project: Apache AsterixDB Issue Type: Bug Components: API - HTTP API Affects Versions: 0.9.3 Reporter: Murtadha Hubail Currently the pretty flag is respected only in printing the result but not the whole response. For example, the metrics object is always indented. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
