Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Xikui Wang (Code Review)]

Xikui Wang has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

(4 comments)

Added several minor comments. It would be better for someone who is familiar 
with recovery to take a look...

https://asterix-gerrit.ics.uci.edu/#/c/2640/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java:

Line 185: GlobalRecoveryManager globalRecoveryManager =
My extension knowledge is very limited, so please correct me if I'm wrong. 
IMHO, I think the way for creating the GlobalRecoveryManager is not very ideal. 
I think an ideal flow would be: if there is no extension, create the default 
one; if there is an extension, let extension create one. The master relies on 
extension mode feels strange to me. The names of the two methods are confusing 
too. It feels more like a configuration but not a creation to me... Also, is 
recoveryManager still the same after the patch?


Line 202: return new 
ExtensionProperties(PropertiesAccessor.getInstance(ccServiceCtx.getAppConfig())).getExtensions();
Why this need to be changed?


https://asterix-gerrit.ics.uci.edu/#/c/2640/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java:

Line 132: MetadataManager.INSTANCE.getDataverse(mdTxnCtx, 
dataverse.getDataverseName());
this is for?


https://asterix-gerrit.ics.uci.edu/#/c/2640/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java:

Line 124: 
empty line.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6397/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3165/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3165/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2: Contrib-2

Analytics Compatibility Compilation Failed
https://goo.gl/y1qh4U : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6397/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8992/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4062/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1536/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7466/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3960/
 (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3517/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3488/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Steven Jacobs (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2640

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..

[ASTERIXDB-2386][CLUS] Allow extension of the global recovery manager

Allow the Asterix GlobalRecoveryManager to be extended
Add an hcc method to reset the deployed job id factory

Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/IGlobalRecoveryExtension.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IExtension.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IGlobalRecoveryManager.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/DeployedJobSpecIdFactory.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClientInterfaceIPCI.java
13 files changed, 146 insertions(+), 15 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/2640/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4247/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3744/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3982/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3441/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3529/
 (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Redeploy channels and procedures during recovery

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Redeploy channels and procedures during recovery
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/278/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2641
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6897ccf9cddb9ec8d10256e252ee893afe6db145
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Redeploy channels and procedures during recovery

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2641

to look at the new patch set (#2).

Change subject: Redeploy channels and procedures during recovery
..

Redeploy channels and procedures during recovery

Use the GlobalRecoveryManager extension to redeploy channels/procedures
Restart execution of channels during recovery
Some code cleanup

Change-Id: I6897ccf9cddb9ec8d10256e252ee893afe6db145
---
M asterix-bad/pom.xml
M asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DeployedJobSpecEventListener.java
M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureTupleTranslator.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADRecoveryExtension.java
M asterix-bad/src/main/resources/cc.conf
M asterix-bad/src/test/java/org/apache/asterix/bad/test/BADListenerTest.java
M 
asterix-bad/src/test/resources/runtimets/results/procedure/create_procedure_check_metadata/create_procedure_check_metadata.1.adm
16 files changed, 333 insertions(+), 138 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad 
refs/changes/41/2641/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2641
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6897ccf9cddb9ec8d10256e252ee893afe6db145
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1: Contrib-2

Analytics Compatibility Compilation Failed
https://goo.gl/jCsz6R : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Redeploy channels and procedures during recovery

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Redeploy channels and procedures during recovery
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/277/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2641
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6897ccf9cddb9ec8d10256e252ee893afe6db145
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Redeploy channels and procedures during recovery

[Steven Jacobs (Code Review)]

Steven Jacobs has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2641

Change subject: Redeploy channels and procedures during recovery
..

Redeploy channels and procedures during recovery

Use the GlobalRecoveryManager extension to redeploy channels/procedures
Restart execution of channels during recovery
Some code cleanup

Change-Id: I6897ccf9cddb9ec8d10256e252ee893afe6db145
---
M asterix-bad/pom.xml
M asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DeployedJobSpecEventListener.java
M asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Procedure.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ProcedureTupleTranslator.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
A 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADRecoveryExtension.java
M asterix-bad/src/main/resources/cc.conf
M asterix-bad/src/test/java/org/apache/asterix/bad/test/BADListenerTest.java
M 
asterix-bad/src/test/resources/runtimets/results/procedure/create_procedure_check_metadata/create_procedure_check_metadata.1.adm
16 files changed, 328 insertions(+), 138 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad 
refs/changes/41/2641/1

diff --git a/asterix-bad/pom.xml b/asterix-bad/pom.xml
index 6f5cd32..51aba74 100644
--- a/asterix-bad/pom.xml
+++ b/asterix-bad/pom.xml
@@ -271,6 +271,11 @@
 
 
   org.apache.hyracks
+  hyracks-control-common
+  ${hyracks.version}
+
+
+  org.apache.hyracks
   algebricks-runtime
 
 
diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java 
b/asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
index d422663..0467f6e 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
@@ -47,7 +47,7 @@
 String FIELD_NAME_ARITY = "Arity";
 String FIELD_NAME_DEPENDENCIES = "Dependencies";
 String FIELD_NAME_PARAMS = "Params";
-String FIELD_NAME_RETURN_TYPE = "ReturnType";
+String FIELD_NAME_TYPE = "Type";
 String FIELD_NAME_DEFINITION = "Definition";
 String FIELD_NAME_LANGUAGE = "Language";
 String FIELD_NAME_BODY = "Body";
diff --git 
a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java 
b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
index e326ce6..8090fb8 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
@@ -21,6 +21,7 @@
 import java.io.StringReader;
 import java.time.Instant;
 import java.util.Date;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.Executors;
@@ -51,6 +52,7 @@
 import org.apache.asterix.translator.IStatementExecutor;
 import org.apache.hyracks.api.client.IHyracksClientConnection;
 import org.apache.hyracks.api.dataset.IHyracksDataset;
+import org.apache.hyracks.api.dataset.ResultSetId;
 import org.apache.hyracks.api.job.DeployedJobSpecId;
 import org.apache.hyracks.api.job.JobId;
 import org.apache.hyracks.api.job.JobSpecification;
@@ -66,6 +68,19 @@
 private static final int POOL_SIZE = 1;
 
 private static final long millisecondTimeout = 
BADConstants.EXECUTOR_TIMEOUT * 1000;
+
+public static void setupExecutorJob(EntityId entityId, JobSpecification 
channeljobSpec,
+IHyracksClientConnection hcc, DeployedJobSpecEventListener 
listener, ITxnIdFactory txnIdFactory,
+String duration) throws Exception {
+if (channeljobSpec != null) {
+
channeljobSpec.setProperty(ActiveNotificationHandler.ACTIVE_ENTITY_PROPERTY_NAME,
 entityId);
+DeployedJobSpecId destributedId = 
hcc.deployJobSpec(channeljobSpec);
+ScheduledExecutorService ses = 
startRepetitiveDeployedJobSpec(destributedId, hcc, findPeriod(duration),
+new HashMap<>(), entityId, txnIdFactory, listener);
+listener.storeDistributedInfo(destributedId, ses);
+}
+
+}
 
 //Starts running a deployed job specification periodically with an 
interval of "period" seconds
 public static ScheduledExecutorService 

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6396/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3487/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3528/
 (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3743/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4246/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4061/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3516/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1535/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3959/
 (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7465/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3440/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3981/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8991/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2386][CLUS] Allow extension of the global recover...

[Steven Jacobs (Code Review)]

Steven Jacobs has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2640

Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery 
manager
..

[ASTERIXDB-2386][CLUS] Allow extension of the global recovery manager

Allow the Asterix GlobalRecoveryManager to be extended
Add an hcc method to reset the deployed job id factory

Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/IGlobalRecoveryExtension.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IExtension.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IGlobalRecoveryManager.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/DeployedJobSpecIdFactory.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClientInterfaceIPCI.java
13 files changed, 146 insertions(+), 15 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/2640/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java
index 1ba418a..9ad9dd7 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java
@@ -28,12 +28,14 @@
 import org.apache.asterix.app.translator.DefaultStatementExecutorFactory;
 import org.apache.asterix.common.api.ExtensionId;
 import org.apache.asterix.common.api.IExtension;
+import org.apache.asterix.common.cluster.IGlobalRecoveryManager;
 import org.apache.asterix.common.config.AsterixExtension;
 import org.apache.asterix.common.exceptions.ErrorCode;
 import org.apache.asterix.common.exceptions.RuntimeDataException;
 import org.apache.asterix.compiler.provider.AqlCompilationProvider;
 import org.apache.asterix.compiler.provider.ILangCompilationProvider;
 import org.apache.asterix.compiler.provider.SqlppCompilationProvider;
+import org.apache.asterix.hyracks.bootstrap.GlobalRecoveryManager;
 import org.apache.asterix.om.functions.IFunctionExtensionManager;
 import org.apache.asterix.om.functions.IFunctionManager;
 import org.apache.asterix.runtime.functions.FunctionCollection;
@@ -53,6 +55,7 @@
 private final ILangCompilationProvider aqlCompilationProvider;
 private final ILangCompilationProvider sqlppCompilationProvider;
 private final IFunctionManager functionManager;
+private final IGlobalRecoveryManager globalRecoveryManager;
 private transient IStatementExecutorFactory statementExecutorFactory;
 
 /**
@@ -71,6 +74,7 @@
 Pair sqlppcp = null;
 Pair fm = null;
 IStatementExecutorExtension see = null;
+IGlobalRecoveryManager grm = null;
 if (list != null) {
 Set extensionIds = new HashSet<>();
 for (AsterixExtension extensionConf : list) {
@@ -89,6 +93,9 @@
 sqlppcp = 
ExtensionUtil.extendLangCompilationProvider(Language.SQLPP, sqlppcp, le);
 fm = ExtensionUtil.extendFunctionManager(fm, le);
 break;
+case RECOVERY:
+grm = ((IGlobalRecoveryExtension) 
extension).getGlobalRecoveryManager();
+break;
 default:
 break;
 }
@@ -99,6 +106,7 @@
 this.sqlppCompilationProvider = sqlppcp == null ? new 
SqlppCompilationProvider() : sqlppcp.second;
 this.functionManager =
 fm == null ? new 
FunctionManager(FunctionCollection.createDefaultFunctionCollection()) : 
fm.second;
+this.globalRecoveryManager = grm;
 }
 
 /** @deprecated use getStatementExecutorFactory instead */
@@ -127,6 +135,13 @@
 }