Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Analytics Compatibility Compilation Successful https://goo.gl/kk9s2e : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3194/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6486/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1629/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7553/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3581/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3623/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4053/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4075/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4156/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2668 to look at the new patch set (#6). Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. [NO ISSUE][STO] Skip deleting unallocated memory component - user model changes: no - storage format changes: no - interface changes: no Details: - This change fixes the component delete logic - It first ensures that memory is allocated for the index - Then it checks whether the memory component is to be deleted - This is important since there might be cases where primary index has the memory allocated but not the secondary and without allocating secondary and deleting it, we could end up with memory components with different ids. Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java 2 files changed, 25 insertions(+), 17 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/68/2668/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9087/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3837/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3534/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4340/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3610/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Analytics Compatibility Compilation Successful https://goo.gl/gDRChK : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6485/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/iDb1ku : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/kqgsxu : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3533/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4155/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2673 to look at the new patch set (#4). Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting - user model changes: no - storage format changes: no - interface changes: no Details: Currently, before we do certain language rewritings, we take a snapshot of the var counter in the context and pass it to the rewriter. This works fine in most of the cases, but it can fail when the rewriter introduces new variables. This will cause different variables map to the same variable id. Although this error may be fixed by another ScopingVisitor, the compiler could fail if there is no more visitor down in the rewriting workflow. Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba --- M asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_06.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/denorm-cust-order.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/filter/inverted-btree-search-return-optional-field.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/gby_partitioning_property_01.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1806.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue601.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/rtree-index/rtree-sidx-idxonly-01-disable-idxonly.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/split-materialization.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in_correlated.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-1572.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1580.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping_broadcast.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_field_access/explain_field_access.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_field_access_closed/explain_field_access_closed.1.adm M asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/rewrites/AqlQueryRewriter.java M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/rewrites/LangRewritingContext.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppExpressionScopingVisitor.java 25 files changed, 186 insertions(+), 186 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/73/2673/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4052/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3580/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3622/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4074/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3609/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4339/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1628/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7552/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3836/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9086/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6484/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4051/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4073/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3579/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2673 to look at the new patch set (#3). Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting - user model changes: no - storage format changes: no - interface changes: no Details: Currently, before we do certain language rewrittings, we take a snapshot of the var counter in the context and pass it to the rewriter. This works fine in most of the cases, but it can fail when the rewriter introduces new variables. This will cause different variables map to the same variable id. Although this error may be fixed by another ScopingVisitor, the compiler could fail if there is no more visitor down in the rewriting workflow. Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba --- M asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_06.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/denorm-cust-order.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/filter/inverted-btree-search-return-optional-field.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/gby_partitioning_property_01.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1806.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue601.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/rtree-index/rtree-sidx-idxonly-01-disable-idxonly.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/split-materialization.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in_correlated.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-1572.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1580.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping_broadcast.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_field_access/explain_field_access.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_field_access_closed/explain_field_access_closed.1.adm M asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/rewrites/AqlQueryRewriter.java M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/rewrites/LangRewritingContext.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppExpressionScopingVisitor.java 25 files changed, 186 insertions(+), 186 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/73/2673/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7551/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4154/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3532/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4338/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1627/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3835/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3621/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9085/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3608/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7550/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9084/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4337/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4153/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2673 to look at the new patch set (#2). Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting - user model changes: no - storage format changes: no - interface changes: no Details: Currently, before we do certain language rewritting, we take a snapshot of the var counter in the context and pass it to the rewritter. This works fine in most of the cases, but it can fail when the rewritter introduces new variables. This will cause different variables map to the same variable id. Although this error may be fixed by another ScopingVisitor, the compiler could fail if there is no more visitor down in the rewritting workflow. Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba --- M asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_06.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/denorm-cust-order.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/filter/inverted-btree-search-return-optional-field.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/gby_partitioning_property_01.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1806.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue601.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/rtree-index/rtree-sidx-idxonly-01-disable-idxonly.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/split-materialization.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in_correlated.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-1572.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1580.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping_broadcast.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_field_access/explain_field_access.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_field_access_closed/explain_field_access_closed.1.adm M asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/rewrites/AqlQueryRewriter.java M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/rewrites/LangRewritingContext.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppExpressionScopingVisitor.java 25 files changed, 186 insertions(+), 186 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/73/2673/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3620/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3578/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4050/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3607/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1626/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3834/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4072/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3531/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 1: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/2673/1//COMMIT_MSG Commit Message: PS1, Line 14: rewritting rewritings PS1, Line 15: rewritter rewriter PS1, Line 16: rewritter rewriter PS1, Line 20: rewritting rewriting -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6482/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/zdScKr : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/kcEHpJ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 3: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/Z8jKBN : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Analytics Compatibility Compilation Successful https://goo.gl/XSSzmT : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6482/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9083/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3530/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3833/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7549/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4071/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1625/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3619/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2668 to look at the new patch set (#5). Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. [NO ISSUE][STO] Skip deleting unallocated memory component - user model changes: no - storage format changes: no - interface changes: no Details: - This change fixes the component delete logic - It first ensures that memory is allocated for the index - Then it checks whether the memory component is to be deleted - This is important since there might be cases where primary index has the memory allocated but not the secondary and without allocating secondary and deleting it, we could end up with memory components with different ids. Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java 2 files changed, 31 insertions(+), 21 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/68/2668/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4049/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3577/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4336/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3606/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4152/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2394][COMP] Align VarCounter in query rewritting .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6479/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2673 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/GJb9ty : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Analytics Compatibility Compilation Successful https://goo.gl/nXXumM : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6481/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4151/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3618/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4335/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3832/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3576/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1624/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4048/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4070/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9082/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2668 to look at the new patch set (#4). Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. [NO ISSUE][STO] Skip deleting unallocated memory component - user model changes: no - storage format changes: no - interface changes: no Details: - This change fixes the component delete logic - It first ensures that memory is allocated for the index - Then it checks whether the memory component is to be deleted - This is important since there might be cases where primary index has the memory allocated but not the secondary and without allocating secondary and deleting it, we could end up with memory components with different ids. Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java 2 files changed, 25 insertions(+), 17 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/68/2668/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3605/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3529/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Skip deleting unallocated memory component
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Skip deleting unallocated memory component .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7548/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2668 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c6c7968830f3c9241bd036c0a330be1400349b4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
