Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Analytics Compatibility Tests Failed https://goo.gl/283Anh : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Dmitry Lychagin has posted comments on this change.
Change subject: [NO ISSUE][FUN] Implement object-replace()
..
Patch Set 5:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/2708/5/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java:
Line 468: return INCOMPATIBLE_TYPES_COMPARISION_RESULT;
This might be error-prone because ComparisonHelper could be used for <, >
operations too, not just =. any result value < 0 means "less", not
"incompatible" types. so there could be collisions with -2. I don't think you
need to modify this class at all. Other evaluators that use ComparisonHelper
first check whether types are compatible by calling
ATypeHierarchy.isCompatible() and if they're then they call
ComparisonHelper.compare(). See
AbstractComparisonEvaluator.comparabilityCheck().
RecordReplaceEvaluator should do the same.
https://asterix-gerrit.ics.uci.edu/#/c/2708/5/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java:
Line 121: if (comparisonHelper.compare(existingValueTypeTag,
oldValueTypeTag, existingValuePtr, oldValuePtr) != 0) {
first call ATypeHierarchy.isCompatible() and only then
comparisonHelper.compare(). See my other comment.
--
To view, visit https://asterix-gerrit.ics.uci.edu/2708
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6610/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Jenkins has posted comments on this change. Change subject: Coordinated change to support parameterized queries .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/313/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2712 to look at the new patch set (#6). Change subject: Coordinated change to support parameterized queries .. Coordinated change to support parameterized queries Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java 8 files changed, 23 insertions(+), 44 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/12/2712/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Jenkins has posted comments on this change. Change subject: Coordinated change to support parameterized queries .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/312/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2712 to look at the new patch set (#5). Change subject: Coordinated change to support parameterized queries .. Coordinated change to support parameterized queries Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java 10 files changed, 25 insertions(+), 47 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/12/2712/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Jenkins has posted comments on this change. Change subject: Coordinated change to support parameterized queries .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/311/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2712 to look at the new patch set (#4). Change subject: Coordinated change to support parameterized queries .. Coordinated change to support parameterized queries Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java 10 files changed, 28 insertions(+), 50 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/12/2712/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3274/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3274/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/fGMC2Q : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/RaZr4e : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/ZAxKyg : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6610/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/49/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/47/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4177/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3659/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1755/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3962/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9215/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4285/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7679/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4199/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Murtadha Hubail has uploaded a new patch set (#2). Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. [NO ISSUE][FUN] Implement object-add(), object-put() - user model changes: no - storage format changes: no - interface changes: no Details: - Implement object-add function that add a new field to a given object. - Implement object-put function that adds, removes, or updates an existing field in a given object. - Add new functions to docs. - Add test cases. Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc --- M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_add/object_add.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_put/object_put.3.adm M asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CastTypeEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordPutDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordPutEvaluator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java 20 files changed, 878 insertions(+), 7 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/13/2713/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3706/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3748/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3735/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Analytics Compatibility Tests Failed https://goo.gl/GHXgJF : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/ecksx2 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6609/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Murtadha Hubail has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2713 Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. [NO ISSUE][FUN] Implement object-add(), object-put() - user model changes: no - storage format changes: no - interface changes: no Details: - Implement object-add function that add a new field to a given object. - Implement object-put function that adds, removes, or updates an existing field in a given object. - Add new functions to docs. - Add test cases. Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc --- M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_add/object_add.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_put/object_put.3.adm M asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CastTypeEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordPutDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordPutEvaluator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java 20 files changed, 880 insertions(+), 7 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/13/2713/1 diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml index 796913d..9273596 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml @@ -133,6 +133,16 @@ + + object_add + + + + + object_put + + + object_pairs diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.1.ddl.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.1.ddl.sqlpp new file mode 100644 index 000..0573cc7 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.1.ddl.sqlpp @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * Description : Testing object_add under different queries. + * Expected Res : Success + */ + +drop dataverse TinySocial if exists; +create dataverse TinySocial; + +use TinySocial; + +create type
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4176/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/48/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3658/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3747/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3705/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7678/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9214/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4284/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3961/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3734/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/46/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4198/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1754/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6608/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3273/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2397][*DB] Enable build on Java 10
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2397][*DB] Enable build on Java 10 .. Patch Set 1: Analytics Compatibility Tests Failed https://goo.gl/PcQ21k : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2702 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e6fef52cd0bf195941918a71073844eb9d4df74 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Analytics Compatibility Tests Failed https://goo.gl/RhsQ5H : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3273/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/QasmjK : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Jenkins has posted comments on this change. Change subject: Coordinated change to support parameterized queries .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/310/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2712 to look at the new patch set (#3). Change subject: Coordinated change to support parameterized queries .. Coordinated change to support parameterized queries Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java 11 files changed, 43 insertions(+), 71 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/12/2712/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Jenkins has posted comments on this change. Change subject: Coordinated change to support parameterized queries .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/309/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Analytics Compatibility Compilation Successful https://goo.gl/pjk33j : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2712 to look at the new patch set (#2). Change subject: Coordinated change to support parameterized queries .. Coordinated change to support parameterized queries Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java M asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java 11 files changed, 66 insertions(+), 79 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/12/2712/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp: Line 22: * Expected Res : Failure > Expected Res should be "Failure". Done https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp: Line 22: * Expected Res : Failure > Expected Res should be "Failure" Done https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java: Line 71: > let's not introduce a new type tag just for error reporting purposes. Done https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java: Line 94: } > you could use oldValueType.isDerived() here Done Line 100: final ATypeTag newValueType = PointableHelper.getTypeTag(newValuePointable); > or an array/multiset because an array/multiset can contain objects too. use Done Line 117: final IVisitablePointable fieldValue = fieldValues.get(i); > using RawBinaryComparatorFactory might be a problem here for comparing diff Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6608/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3746/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3704/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1753/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9213/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7677/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3960/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4283/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4197/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3733/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3657/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/47/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4175/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/45/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2708 to look at the new patch set (#5). Change subject: [NO ISSUE][FUN] Implement object-replace() .. [NO ISSUE][FUN] Implement object-replace() - user model changes: no - storage format changes: no - interface changes: no Details: - Implement object-replace function that replaces all occurrences of a value in a given object by a new value. - Add new function to docs. - Add test case. Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 --- M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.6.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_replace/object_replace.3.adm M asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CastTypeEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/exceptions/TypeMismatchException.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java 17 files changed, 544 insertions(+), 22 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/08/2708/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2397][*DB] Enable build on Java 10
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2397][*DB] Enable build on Java 10 .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2702 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e6fef52cd0bf195941918a71073844eb9d4df74 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2397][*DB] Fix sample cluster on Java 10
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2397][*DB] Fix sample cluster on Java 10 .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2701 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a03eba1c970d1f8c7d27f93dc4e7336a24800ea Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2397][*DB] Enable execution on Java 9/10
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2397][*DB] Enable execution on Java 9/10 .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2700 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I221dfba1b2d15e33b312feb3fb50e70d536027fd Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2286][COMP][FUN][HYR] Parallel Sort Optimization
Dmitry Lychagin has posted comments on this change.
Change subject: [ASTERIXDB-2286][COMP][FUN][HYR] Parallel Sort Optimization
..
Patch Set 11:
(18 comments)
still reviewing, but here's my first batch of comments.
https://asterix-gerrit.ics.uci.edu/#/c/2393/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java:
Line 385: public ILogicalOperator visitForwardOperator(ForwardOperator op,
Void arg) throws AlgebricksException {
union/intersect operators are not supported by this visitor.
they throw throw new UnsupportedOperationException(
"Nested subplans with a union operator should have been
disqualified for this rewriting!")
should do the same for forward operator? and make sure that this visitor does
not run on a subplan with forward operator.
https://asterix-gerrit.ics.uci.edu/#/c/2393/11/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/clause/OrderbyClause.java
File
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/clause/OrderbyClause.java:
Line 103: return isRPSSort;
need to copy this new property in
CloneAndSubstituteVariablesVisitor.visit(OrderbyClause)
Line 106: public void setRPSSort(boolean isRPSSort) {
need to give a better name to this property "sort" is redundant. "FullParallel"
or "RangeParallel" may be?
Line 112: return Objects.hash(modifierList, numFrames, numTuples,
orderbyList);
rangeMap and isRPSSort should be used in hashCode()
Line 116: public boolean equals(Object object) {
rangeMap and isRPSSort should be used in equals(). we don't really need an
interface IRangeMap because we have 1 implementation. let's use that class
instead and remove the interface. so equals() doesn't have to worry about
different interface implementations
https://asterix-gerrit.ics.uci.edu/#/c/2393/11/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj:
Line 206: private static final String NO_PARALLEL_SORT_HINT = "no-rps-sort";
can we give this hint a better name? it's on the orderby clause, so "-sort" is
redundant. may be "no-full-parallel" or "no-range-parallel"?
Line 3048:
oc.setRangeMap(RangeMapBuilder.parseHint(hint.substring(RANGE_HINT.length()),
parserFactory));
why do we need to create and pass SqllppParserFactory when we're already inside
the parser? let's change RangeMapBuilder.parseHint() to take IParser instance
as an argument. then we create the parser here: new
SQLPPParser(hint.substring(...))
Line 3050: throw new ParseException(e.getMessage());
need to add source location: throw
SqlppParseException(getSourceLocation(getHintToken(token)), e.getMessage())
https://asterix-gerrit.ics.uci.edu/#/c/2393/11/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/AbstractLogicalExpression.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/AbstractLogicalExpression.java:
Line 41: public void setParameters(Object[] expressionParameters) {
why can't we use AbstractFunctionCallExpression.setOpaqueParameters() for this
instead? and propagate them to FunctionDescriptor by implementing
IFunctionTypeInferer for that function (BuiltinFunctions.
GLOBAL_SAMPLING)?
https://asterix-gerrit.ics.uci.edu/#/c/2393/11/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/IsomorphismOperatorVisitor.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/IsomorphismOperatorVisitor.java:
Line 604: return true;
need to implement this. look at other operators in this class.
https://asterix-gerrit.ics.uci.edu/#/c/2393/11/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/IPartitioningProperty.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/IPartitioningProperty.java:
Line 72: /**
it seems that it should return a new object if there need to be any changes.
i.e. it should not modify the existing object. let's remove this comment.
https://asterix-gerrit.ics.uci.edu/#/c/2393/6/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java
File
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java:
Line
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_append function
Ali Alsuliman has posted comments on this change.
Change subject: [NO ISSUE][FUN] Implement array_append function
..
Patch Set 2:
(6 comments)
https://asterix-gerrit.ics.uci.edu/#/c/2710/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/ArrayAppendTypeComputer.java
File
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/ArrayAppendTypeComputer.java:
Line 42: throw new
CompilationException(ErrorCode.COMPILATION_INVALID_NUM_OF_ARGS, 2,
functionName);
> get source location from expr and pass it to the exception constructor
Done
Line 44: // type tag at [0] should be array or multiset.
> it could be any other type, but the function will return null in those case
Done
Line 48: resultType = new AOrderedListType(BuiltinType.ANY, null);
> use DefaultOpenFieldType.NESTED_OPEN_AORDERED_LIST_TYPE and NESTED_OPEN_AUN
Done
Line 52: return resultType;
> the result will be NULL if input type is not array/multiset or ANY, so let'
Done
https://asterix-gerrit.ics.uci.edu/#/c/2710/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CastTypeEvaluator.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CastTypeEvaluator.java:
Line 72: public void reset(IAType reqType, IAType inputType,
IScalarEvaluator argEvaluator) {
> minor. can you move this method up, right below the constructor? we need to
Done. Like being tidy and clean :)
https://asterix-gerrit.ics.uci.edu/#/c/2710/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java:
Line 82: /** Sets the types of the function arguments */
> same type inferer is being implemented in another change which is currently
Got it. Will wait.
--
To view, visit https://asterix-gerrit.ics.uci.edu/2710
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a65549957060beee4579b903e6bd323745fb875
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_append function
Dmitry Lychagin has posted comments on this change.
Change subject: [NO ISSUE][FUN] Implement array_append function
..
Patch Set 2:
(6 comments)
https://asterix-gerrit.ics.uci.edu/#/c/2710/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/ArrayAppendTypeComputer.java
File
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/ArrayAppendTypeComputer.java:
Line 42: throw new
CompilationException(ErrorCode.COMPILATION_INVALID_NUM_OF_ARGS, 2,
functionName);
get source location from expr and pass it to the exception constructor
Line 44: // type tag at [0] should be array or multiset.
it could be any other type, but the function will return null in those cases
Line 48: resultType = new AOrderedListType(BuiltinType.ANY, null);
use DefaultOpenFieldType.NESTED_OPEN_AORDERED_LIST_TYPE and
NESTED_OPEN_AUNORDERED_LIST_TYPE constants instead of creating new types here.
Line 52: return resultType;
the result will be NULL if input type is not array/multiset or ANY, so let's do
the following.
if (typeTag == ARRAY) { return NESTED_OPEN_AORDERED_LIST_TYPE } else if (if
typeTag == MULTISET) { return NESTED_OPEN_AUNORDERED_LIST_TYPE }
else return ANY
https://asterix-gerrit.ics.uci.edu/#/c/2710/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CastTypeEvaluator.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CastTypeEvaluator.java:
Line 72: public void reset(IAType reqType, IAType inputType,
IScalarEvaluator argEvaluator) {
minor. can you move this method up, right below the constructor? we need to
keep them in sync if adding more fields in the future.
https://asterix-gerrit.ics.uci.edu/#/c/2710/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java:
Line 82: /** Sets the types of the function arguments */
same type inferer is being implemented in another change which is currently
under review (ArgsTypeInferer):
https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
Make sure you coordinate, so we don't end up with two.
--
To view, visit https://asterix-gerrit.ics.uci.edu/2710
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a65549957060beee4579b903e6bd323745fb875
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2401][SQLPP] Support parameterized queries
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2401][SQLPP] Support parameterized queries .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/L8Y8oA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia612f731cd2370fccd54c4796bd9787fbea16766 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_append function
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_append function .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/7KZS88 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2710 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a65549957060beee4579b903e6bd323745fb875 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-replace()
Dmitry Lychagin has posted comments on this change.
Change subject: [NO ISSUE][FUN] Implement object-replace()
..
Patch Set 4:
(6 comments)
https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp:
Line 22: * Expected Res : Success
Expected Res should be "Failure".
https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp:
Line 22: * Expected Res : Success
Expected Res should be "Failure"
https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java
File
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java:
Line 71: PRIMITIVE(43);
let's not introduce a new type tag just for error reporting purposes.
(all type tags should correspond to types in the type system)
We can instead change TypeMistmachException constructor to accept a String or
String[] for expected type names and pass "primitive" there.
https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java:
Line 94: if (oldValueType == ATypeTag.OBJECT || oldValueType ==
ATypeTag.ARRAY || oldValueType == ATypeTag.MULTISET) {
you could use oldValueType.isDerived() here
Line 100: if (newValueType == ATypeTag.OBJECT) {
or an array/multiset because an array/multiset can contain objects too. use
newValueType.isDerved() here.
Line 117: if (binaryComparator.compare(fieldValue.getByteArray(),
fieldValue.getStartOffset(), fieldValue.getLength(),
using RawBinaryComparatorFactory might be a problem here for comparing
different numeric types (bigint and double, for instance). Can we add a
testcase: object_replace({"a":1}, 1.0, 2). It is supposed to perform the
replacement and return {"a": 2}. What do we return?
--
To view, visit https://asterix-gerrit.ics.uci.edu/2708
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Michael Blow has submitted this change and it was merged. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Merge branch 'release-0.9.4-pre-rc' into master Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 --- 0 files changed, 0 insertions(+), 0 deletions(-) Approvals: Anon. E. Moose #1000171: Jenkins: Verified; No violations found; ; Verified Murtadha Hubail: Looks good to me, approved -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Murtadha Hubail has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Jenkins has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6607/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Anon. E. Moose #1000171 has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/G8g4mC : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Till Westmann has posted comments on this change. Change subject: Coordinated change to support parameterized queries .. Patch Set 1: Code-Review-1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Jenkins has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3272/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2712
Change subject: Coordinated change to support parameterized queries
..
Coordinated change to support parameterized queries
Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5
---
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
13 files changed, 126 insertions(+), 101 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad
refs/changes/12/2712/1
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
index 69145d9..a52efeb 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
@@ -41,6 +41,7 @@
import org.apache.asterix.bad.metadata.DeployedJobSpecEventListener;
import org.apache.asterix.common.dataflow.ICcApplicationContext;
import org.apache.asterix.common.transactions.ITxnIdFactory;
+import org.apache.asterix.lang.common.base.IStatementRewriter;
import org.apache.asterix.lang.common.base.Statement;
import org.apache.asterix.lang.common.statement.Query;
import org.apache.asterix.lang.common.statement.SetStatement;
@@ -48,6 +49,7 @@
import org.apache.asterix.metadata.MetadataManager;
import org.apache.asterix.metadata.MetadataTransactionContext;
import org.apache.asterix.metadata.declared.MetadataProvider;
+import org.apache.asterix.om.base.IAObject;
import org.apache.asterix.translator.IRequestParameters;
import org.apache.asterix.translator.IStatementExecutor;
import org.apache.hyracks.api.client.IHyracksClientConnection;
@@ -108,9 +110,8 @@
public static boolean runDeployedJobSpecCheckPeriod(DeployedJobSpecId
distributedId, IHyracksClientConnection hcc,
Map jobParameters, long period, EntityId entityId,
ITxnIdFactory txnIdFactory,
DeployedJobSpecEventListener listener) throws Exception {
-long executionMilliseconds =
-runDeployedJobSpec(distributedId, hcc, null, jobParameters,
entityId, txnIdFactory, null, listener,
-null);
+long executionMilliseconds = runDeployedJobSpec(distributedId, hcc,
null, jobParameters, entityId, txnIdFactory,
+null, listener, null);
if (executionMilliseconds > period) {
LOGGER.log(Level.SEVERE,
"Periodic job for " + entityId.getExtensionName() + " " +
entityId.getDataverse() + "."
@@ -153,7 +154,6 @@
}
-
public static long findPeriod(String duration) {
//TODO: Allow Repetitive Channels to use YMD durations
String hoursMinutesSeconds = "";
@@ -183,13 +183,15 @@
}
public static JobSpecification compilePushChannel(IStatementExecutor
statementExecutor,
-MetadataProvider metadataProvider, IHyracksClientConnection hcc,
Query q) throws Exception {
+MetadataProvider metadataProvider, IHyracksClientConnection hcc,
Query q, Map stmtParams,
+IStatementRewriter stmtRewriter) throws Exception {
MetadataTransactionContext mdTxnCtx =
MetadataManager.INSTANCE.beginTransaction();
boolean bActiveTxn = true;
metadataProvider.setMetadataTxnContext(mdTxnCtx);
JobSpecification jobSpec = null;
try {
-jobSpec = ((QueryTranslator)
statementExecutor).rewriteCompileQuery(hcc, metadataProvider, q, null);
+jobSpec = ((QueryTranslator)
statementExecutor).rewriteCompileQuery(hcc, metadataProvider, q, null,
+stmtParams, stmtRewriter);
MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
bActiveTxn = false;
} catch (Exception e) {
@@
Change in asterixdb-bad[master]: Coordinated change to support parameterized queries
Jenkins has posted comments on this change. Change subject: Coordinated change to support parameterized queries .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/308/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce06a1548a4f4150545c1fda7e5be3608472af5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Jenkins has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3272/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Anon. E. Moose #1000171 has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/o5tKMk : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Jenkins has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6607/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Jenkins has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/44/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Jenkins has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/46/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Jenkins has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4174/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Jenkins has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3703/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Jenkins has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4196/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Merge branch 'release-0.9.4-pre-rc' into master
Jenkins has posted comments on this change. Change subject: Merge branch 'release-0.9.4-pre-rc' into master .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1752/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0f14671f13c4415d1377f5044925032dd77cd1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
