Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6633/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/aihYUV : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/tg7av4 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2286][COMP][FUN][HYR] Parallel Sort Optimization
Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2286][COMP][FUN][HYR] Parallel Sort Optimization .. Patch Set 11: Ali, I replied to you by email. Please take a look. -- To view, visit https://asterix-gerrit.ics.uci.edu/2393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73e128029a46f45e6b68c23dfb9310d5de10582f Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Steven Jacobs has submitted this change and it was merged. Change subject: Improve performance of NotifyBrokerRuntime code .. Improve performance of NotifyBrokerRuntime code Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 --- M asterix-bad/pom.xml M asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java 2 files changed, 77 insertions(+), 55 deletions(-) Approvals: Jenkins: Verified Xikui Wang: Looks good to me, approved diff --git a/asterix-bad/pom.xml b/asterix-bad/pom.xml index b7d775a..cc8204e 100644 --- a/asterix-bad/pom.xml +++ b/asterix-bad/pom.xml @@ -276,6 +276,16 @@ org.apache.hyracks + hyracks-util + ${hyracks.version} + + + org.apache.hyracks + algebricks-data + ${hyracks.version} + + + org.apache.hyracks hyracks-control-common ${hyracks.version} diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java b/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java index 6ffb244..8e07af2 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java @@ -19,34 +19,33 @@ package org.apache.asterix.bad.runtime; +import java.io.ByteArrayOutputStream; import java.io.DataInputStream; import java.io.DataOutputStream; import java.io.IOException; +import java.io.PrintStream; +import java.io.UnsupportedEncodingException; import java.net.HttpURLConnection; import java.net.URL; import java.nio.ByteBuffer; +import java.nio.charset.StandardCharsets; import java.util.HashMap; -import java.util.HashSet; import java.util.Map; import java.util.logging.Level; import java.util.logging.Logger; -import org.apache.asterix.active.ActiveManager; import org.apache.asterix.active.EntityId; import org.apache.asterix.bad.BADConstants; -import org.apache.asterix.common.api.INcApplicationContext; +import org.apache.asterix.dataflow.data.nontagged.printers.json.clean.AOrderedlistPrinterFactory; +import org.apache.asterix.dataflow.data.nontagged.printers.json.clean.ARecordPrinterFactory; import org.apache.asterix.dataflow.data.nontagged.serde.ADateTimeSerializerDeserializer; -import org.apache.asterix.dataflow.data.nontagged.serde.AOrderedListSerializerDeserializer; -import org.apache.asterix.dataflow.data.nontagged.serde.ARecordSerializerDeserializer; import org.apache.asterix.dataflow.data.nontagged.serde.AStringSerializerDeserializer; import org.apache.asterix.om.base.ADateTime; -import org.apache.asterix.om.base.AOrderedList; -import org.apache.asterix.om.base.ARecord; -import org.apache.asterix.om.base.AUUID; import org.apache.asterix.om.types.AOrderedListType; import org.apache.asterix.om.types.ARecordType; import org.apache.asterix.om.types.BuiltinType; import org.apache.asterix.om.types.IAType; +import org.apache.hyracks.algebricks.data.IPrinter; import org.apache.hyracks.algebricks.runtime.base.IScalarEvaluator; import org.apache.hyracks.algebricks.runtime.base.IScalarEvaluatorFactory; import org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime; @@ -58,15 +57,19 @@ import org.apache.hyracks.dataflow.common.comm.io.FrameTupleAccessor; import org.apache.hyracks.dataflow.common.comm.util.ByteBufferInputStream; import org.apache.hyracks.dataflow.common.data.accessors.FrameTupleReference; +import org.apache.hyracks.util.string.UTF8StringReader; +import org.apache.hyracks.util.string.UTF8StringWriter; public class NotifyBrokerRuntime extends AbstractOneInputOneOutputOneFramePushRuntime { private static final Logger LOGGER = Logger.getLogger(NotifyBrokerRuntime.class.getName()); private final ByteBufferInputStream bbis = new ByteBufferInputStream(); private final DataInputStream di = new DataInputStream(bbis); -private final AOrderedListSerializerDeserializer subSerDes = -new AOrderedListSerializerDeserializer(new AOrderedListType(BuiltinType.AUUID, null)); -private final ARecordSerializerDeserializer recordSerDes; +private static final AStringSerializerDeserializer stringSerDes = +new AStringSerializerDeserializer(new UTF8StringWriter(), new UTF8StringReader()); + +private final IPrinter recordPrinterFactory; +private final IPrinter subscriptionIdListPrinterFactory; private IPointable inputArg0 = new VoidPointable(); private IPointable inputArg1 = new VoidPointable(); @@ -74,14 +77,14 @@ private IScalarEvaluator eval0; private IScalarEvaluator eval1; private IScalarEvaluator eval2; -private final ActiveManager activeManager; private final EntityId entityId; private final boolean push; -private AOrderedList pushList; -private ARecord pushRecord; -
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Xikui Wang has posted comments on this change. Change subject: Improve performance of NotifyBrokerRuntime code .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/Z5W5m1 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6633/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4200/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4221/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3757/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7701/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3731/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1777/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/66/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3984/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9237/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Murtadha Hubail has uploaded a new patch set (#2). Change subject: [NO ISSUE][FUN] Implement object-values() .. [NO ISSUE][FUN] Implement object-values() - user model changes: no - storage format changes: no - interface changes: no Details: - Implement object-values function that returns an array of values of the fileds in a given object sorted by the field names. - Add new functions to docs. - Add test cases. Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 --- M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_values/object_values.3.adm M asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordValuesDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordValuesEvaluator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java 11 files changed, 372 insertions(+), 3 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/18/2718/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3681/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4307/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3770/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/68/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/ri8Rxr : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6632/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9236/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7700/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3983/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3756/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4220/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/65/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3680/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4199/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3730/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4306/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/67/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1776/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Murtadha Hubail has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2718 Change subject: [NO ISSUE][FUN] Implement object-values() .. [NO ISSUE][FUN] Implement object-values() - user model changes: no - storage format changes: no - interface changes: no Details: - Implement object-values function that returns an array of values of the fileds in a given object sorted by the field names. - Add new functions to docs. - Add test cases. Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 --- M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_values/object_values.3.adm M asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordValuesDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordValuesEvaluator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java 11 files changed, 372 insertions(+), 3 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/18/2718/1 diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml index 184500e..78322da 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml @@ -141,6 +141,11 @@ + + object_values + + + object_pairs diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.1.ddl.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.1.ddl.sqlpp new file mode 100644 index 000..1242661 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.1.ddl.sqlpp @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * Description : Testing object_values under different queries. + * Expected Res : Success + */ + +drop dataverse TinySocial if exists; +create dataverse TinySocial; + +use TinySocial; + +create type TinySocial.TwitterUserType as +{ + `screen-name` : string, + lang : string, + friends_count : bigint, + statuses_count : bigint +}; + +create type TinySocial.TweetMessageType as closed { + tweetid : string, + user : TwitterUserType, + `sender-location` : point?, + `send-time` : datetime, + `referred-topics` : {{string}}, + `message-text` : string +}; + +create dataset TwitterUsers(TwitterUserType) primary key `screen-name`; + +create dataset TweetMessages(TweetMessageType) primary key tweetid; diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.2.update.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.2.update.sqlpp new file mode 100644 index 000..72edf0c --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.2.update.sqlpp @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-values()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3769/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Jenkins has posted comments on this change. Change subject: Improve performance of NotifyBrokerRuntime code .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/320/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2717 to look at the new patch set (#4). Change subject: Improve performance of NotifyBrokerRuntime code .. Improve performance of NotifyBrokerRuntime code Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 --- M asterix-bad/pom.xml M asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java 2 files changed, 77 insertions(+), 55 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/17/2717/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2717 to look at the new patch set (#3). Change subject: Improve performance of NotifyBrokerRuntime code .. Improve performance of NotifyBrokerRuntime code Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 --- M asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java 1 file changed, 67 insertions(+), 55 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/17/2717/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Jenkins has posted comments on this change. Change subject: Improve performance of NotifyBrokerRuntime code .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/319/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Jenkins has posted comments on this change. Change subject: Improve performance of NotifyBrokerRuntime code .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/318/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2717 to look at the new patch set (#2). Change subject: Improve performance of NotifyBrokerRuntime code .. Improve performance of NotifyBrokerRuntime code Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 --- M asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java 1 file changed, 66 insertions(+), 55 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/17/2717/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Steven Jacobs has posted comments on this change. Change subject: Improve performance of NotifyBrokerRuntime code .. Patch Set 1: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/2717/1/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java File asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java: Line 99: listPrinterFactory = > -> subscriptionIdPrinter ? Done Line 114: String JSON = "{ \"dataverseName\":\"" + entityId.getDataverse() + "\", \"channelName\":\"" > let's take this chance to rename this variable to jsonStr. JSON is an actua Done PS1, Line 177: + 1 > What's this +1 for? To skip the type tag in the serialized value Line 178: endpoint = stringSerDes.deserialize(di).getStringValue(); > It seems the endpoint comes from one of the record field value? Do we have Done Line 181: sendStreams.putIfAbsent(endpoint, new PrintStream(sendbaos.get(endpoint), true, "UTF-8")); > use standard charset as well Not sure what this is referring to. Line 193: sendStreams.get(endpoint)); > uncheck firstResult? line 202 (happens in both cases) -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Xikui Wang has posted comments on this change. Change subject: Improve performance of NotifyBrokerRuntime code .. Patch Set 1: (6 comments) Added several comments. https://asterix-gerrit.ics.uci.edu/#/c/2717/1/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java File asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java: Line 99: listPrinterFactory = -> subscriptionIdPrinter ? Line 114: String JSON = "{ \"dataverseName\":\"" + entityId.getDataverse() + "\", \"channelName\":\"" let's take this chance to rename this variable to jsonStr. JSON is an actual library name. PS1, Line 177: + 1 What's this +1 for? Line 178: endpoint = stringSerDes.deserialize(di).getStringValue(); It seems the endpoint comes from one of the record field value? Do we have the record schema somewhere? If not, could you add some comments before this method? Line 181: sendStreams.putIfAbsent(endpoint, new PrintStream(sendbaos.get(endpoint), true, "UTF-8")); use standard charset as well Line 193: sendStreams.get(endpoint)); uncheck firstResult? -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6631/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Jenkins has posted comments on this change. Change subject: Improve performance of NotifyBrokerRuntime code .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/317/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb-bad[master]: Improve performance of NotifyBrokerRuntime code
Steven Jacobs has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2717 Change subject: Improve performance of NotifyBrokerRuntime code .. Improve performance of NotifyBrokerRuntime code Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 --- M asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java 1 file changed, 57 insertions(+), 52 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/17/2717/1 diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java b/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java index 6ffb244..97615b1 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java @@ -19,34 +19,33 @@ package org.apache.asterix.bad.runtime; +import java.io.ByteArrayOutputStream; import java.io.DataInputStream; import java.io.DataOutputStream; import java.io.IOException; +import java.io.PrintStream; +import java.io.UnsupportedEncodingException; import java.net.HttpURLConnection; import java.net.URL; import java.nio.ByteBuffer; +import java.nio.charset.StandardCharsets; import java.util.HashMap; -import java.util.HashSet; import java.util.Map; import java.util.logging.Level; import java.util.logging.Logger; -import org.apache.asterix.active.ActiveManager; import org.apache.asterix.active.EntityId; import org.apache.asterix.bad.BADConstants; -import org.apache.asterix.common.api.INcApplicationContext; +import org.apache.asterix.dataflow.data.nontagged.printers.json.clean.AOrderedlistPrinterFactory; +import org.apache.asterix.dataflow.data.nontagged.printers.json.clean.ARecordPrinterFactory; import org.apache.asterix.dataflow.data.nontagged.serde.ADateTimeSerializerDeserializer; -import org.apache.asterix.dataflow.data.nontagged.serde.AOrderedListSerializerDeserializer; -import org.apache.asterix.dataflow.data.nontagged.serde.ARecordSerializerDeserializer; import org.apache.asterix.dataflow.data.nontagged.serde.AStringSerializerDeserializer; import org.apache.asterix.om.base.ADateTime; -import org.apache.asterix.om.base.AOrderedList; -import org.apache.asterix.om.base.ARecord; -import org.apache.asterix.om.base.AUUID; import org.apache.asterix.om.types.AOrderedListType; import org.apache.asterix.om.types.ARecordType; import org.apache.asterix.om.types.BuiltinType; import org.apache.asterix.om.types.IAType; +import org.apache.hyracks.algebricks.data.IPrinter; import org.apache.hyracks.algebricks.runtime.base.IScalarEvaluator; import org.apache.hyracks.algebricks.runtime.base.IScalarEvaluatorFactory; import org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime; @@ -58,15 +57,19 @@ import org.apache.hyracks.dataflow.common.comm.io.FrameTupleAccessor; import org.apache.hyracks.dataflow.common.comm.util.ByteBufferInputStream; import org.apache.hyracks.dataflow.common.data.accessors.FrameTupleReference; +import org.apache.hyracks.util.string.UTF8StringReader; +import org.apache.hyracks.util.string.UTF8StringWriter; public class NotifyBrokerRuntime extends AbstractOneInputOneOutputOneFramePushRuntime { private static final Logger LOGGER = Logger.getLogger(NotifyBrokerRuntime.class.getName()); private final ByteBufferInputStream bbis = new ByteBufferInputStream(); private final DataInputStream di = new DataInputStream(bbis); -private final AOrderedListSerializerDeserializer subSerDes = -new AOrderedListSerializerDeserializer(new AOrderedListType(BuiltinType.AUUID, null)); -private final ARecordSerializerDeserializer recordSerDes; +private static final AStringSerializerDeserializer stringSerDes = +new AStringSerializerDeserializer(new UTF8StringWriter(), new UTF8StringReader()); + +private final IPrinter recordPrinterFactory; +private final IPrinter listPrinterFactory; private IPointable inputArg0 = new VoidPointable(); private IPointable inputArg1 = new VoidPointable(); @@ -74,14 +77,14 @@ private IScalarEvaluator eval0; private IScalarEvaluator eval1; private IScalarEvaluator eval2; -private final ActiveManager activeManager; private final EntityId entityId; private final boolean push; -private AOrderedList pushList; -private ARecord pushRecord; -private final IAType recordType; -private final Map> sendData = new HashMap<>(); +private final Map sendData = new HashMap<>(); +private final Map sendbaos = new HashMap<>(); +private final Map sendStreams = new HashMap<>(); private String executionTimeString; +private boolean firstResult = true; +String endpoint; public NotifyBrokerRuntime(IHyracksTaskContext ctx,
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][REPL] Ignore Replica Request On Non-Active NC Status
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][REPL] Ignore Replica Request On Non-Active NC Status .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2716 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f89ac68ba97ef4cf278c2ee429038a5a1bbf57e Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][REPL] Ignore Replica Request On Non-Active NC Status
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][REPL] Ignore Replica Request On Non-Active NC Status .. Patch Set 1: Analytics Compilation Successful -- To view, visit https://asterix-gerrit.ics.uci.edu/2716 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f89ac68ba97ef4cf278c2ee429038a5a1bbf57e Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3285/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/VsXtZR : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3285/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3284/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3284/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4198/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4219/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][REPL] Ignore Replica Request On Non-Active NC Status
Jenkins has posted comments on this change. Change subject: [NO ISSUE][REPL] Ignore Replica Request On Non-Active NC Status .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6626/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2716 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f89ac68ba97ef4cf278c2ee429038a5a1bbf57e Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/64/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Cleanup active listener
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Cleanup active listener .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6627/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f3b14aec46728fbe8b256b915d0e30992b2fe47 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4218/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6631/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4197/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4196/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4217/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Analytics Compatibility Compilation Successful https://goo.gl/onKNZA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2713/7//COMMIT_MSG Commit Message: PS7, Line 14: add > adds Done https://asterix-gerrit.ics.uci.edu/#/c/2713/7/asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md File asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md: PS7, Line 469: Adds, modifies, or removes a field of an object. : * Arguments: : * `input_object` : an object value. > Put "Adds, modifies, or removes a field of an an object." here and leave th Done https://asterix-gerrit.ics.uci.edu/#/c/2713/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddEvaluator.java: PS7, Line 71: > I wonder about that too. As we create more functions we should explore oppo Agreed to all of that. I had that planned for a refactoring only change that extends beyond these two functions. However, given the similarities between these two, I moved the common code to an abstract class. -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7699/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3768/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3755/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1775/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3982/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4305/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9235/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3729/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3679/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/66/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2713 to look at the new patch set (#8). Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. [NO ISSUE][FUN] Implement object-add(), object-put() - user model changes: no - storage format changes: no - interface changes: no Details: - Implement object-add function that adds a new field to a given object. - Implement object-put function that adds, removes, or updates an existing field in a given object. - Add new functions to docs. - Add test cases. Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc --- M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_add/object_add.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_put/object_put.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_add/object_add.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/objects/object_put/object_put.3.adm M asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/AbstractRecordAddPutEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddEvaluator.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordPutDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordPutEvaluator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java 19 files changed, 817 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/13/2713/8 -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][REPL] Ignore Replica Request On Non-Active NC Status
Jenkins has posted comments on this change. Change subject: [NO ISSUE][REPL] Ignore Replica Request On Non-Active NC Status .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3728/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2716 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f89ac68ba97ef4cf278c2ee429038a5a1bbf57e Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/63/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3981/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9234/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3767/ (1/2) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7698/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1774/ (6/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3725/ (2/5) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/62/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3980/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3678/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3754/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6629/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3677/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3753/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement array_position function
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/65/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 7: -Integration-Tests Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6628/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4303/ (5/7) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Implement object-add(), object-put()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3766/ (1/2) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No