Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7245/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Analytics Compatibility Compilation Successful https://goo.gl/WQe7Yf : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4640/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4386/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4331/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2432/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4421/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4978/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9897/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4810/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8358/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4772/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Hello Anon. E. Moose #1000171, abdullah alamoudi, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2927 to look at the new patch set (#7). Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage - user model changes: no - storage format changes: yes - interface changes: yes Details: - Replace the usage of system clock timestamps in LSM index components file names by a sequencer. The next sequence id to use is determined by checking the list of existing components on disk. Note that due to a rollback, an index checkpoint file may have last valid component sequence which is greater than what is on disk. This should not cause any issues since only components that have a sequence greater than that appears in the checkpoint will be deleted. - Replace the usage of system clock timestamps in LSM index components ids by a monotonically increasing sequencer. The sequencer is initialized after restarts by the last valid component id that appears in the index checkpoint. - Refactor the logic to generate flush/merge file names. - Refactor the logic to check invalid components. - Adapt test cases to new naming format. Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManager.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmIoOpCallbackFactory.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/PersistentLocalResourceRepositoryTest.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/IIndexCheckpointManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/IndexCheckpoint.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMIOOperationCallbackTest.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/CheckpointPartitionIndexesTask.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/ComponentMaskTask.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/MarkComponentValidTask.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/ReplicateFileTask.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeFileManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyFileManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMComponentIdGenerator.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IndexComponentFileReference.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentId.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentIdGenerator.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexFileManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeFileManager.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-common-test/src/test/java/org/apache/hyracks/storage/am/lsm/common/component/TestLsmIndexFileManager.java 24 files changed, 515 insertions(+), 498 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/27/2927/7 -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #100017
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4420/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7244/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7244/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Analytics Compatibility Compilation Successful https://goo.gl/4Y3i6R : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4420/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4639/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8357/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2431/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9896/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4385/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4330/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4419/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Hello Anon. E. Moose #1000171, abdullah alamoudi, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2927 to look at the new patch set (#6). Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage - user model changes: no - storage format changes: yes - interface changes: yes Details: - Replace the usage of system clock timestamps in LSM index components file names by a sequencer. The next sequence id to use is determined by checking the list of existing components on disk. Note that due to a rollback, an index checkpoint file may have last valid component sequence which is greater than what is on disk. This should not cause any issues since only components that have a sequence greater than that appears in the checkpoint will be deleted. - Replace the usage of system clock timestamps in LSM index components ids by a monotonically increasing sequencer. The sequencer is initialized after restarts by the last valid component id that appears in the index checkpoint. - Refactor the logic to generate flush/merge file names. - Refactor the logic to check invalid components. - Adapt test cases to new naming format. Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManager.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmIoOpCallbackFactory.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/PersistentLocalResourceRepositoryTest.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/IIndexCheckpointManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/IndexCheckpoint.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMIOOperationCallbackTest.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/CheckpointPartitionIndexesTask.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/ComponentMaskTask.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/MarkComponentValidTask.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/ReplicateFileTask.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeFileManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyFileManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMComponentIdGenerator.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IndexComponentFileReference.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentId.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentIdGenerator.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexFileManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeFileManager.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-common-test/src/test/java/org/apache/hyracks/storage/am/lsm/common/component/TestLsmIndexFileManager.java 24 files changed, 503 insertions(+), 493 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/27/2927/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #100017
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4771/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4809/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4977/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7243/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Analytics Compatibility Compilation Failed https://goo.gl/Jx34ov : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4976/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4329/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4638/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9895/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4384/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4419/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8356/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4418/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4808/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2430/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4770/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7242/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Contrib-2 Analytics Compatibility Compilation Failed https://goo.gl/auotWk : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4383/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Hello Anon. E. Moose #1000171, abdullah alamoudi, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2927 to look at the new patch set (#4). Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage - user model changes: no - storage format changes: yes - interface changes: yes Details: - Replace the usage of system clock timestamps in LSM index components file names by a sequencer. The next sequence id to use is determined by checking the list of existing components on disk. Note that due to a rollback, an index checkpoint file may have last valid component sequence which is greater than what is on disk. This should not cause any issues since only components that have a sequence greater than that appears in the checkpoint will be deleted. - Replace the usage of system clock timestamps in LSM index components ids by a monotonically increasing sequencer. The sequencer is initialized after restarts by the last valid component id that appears in the index checkpoint. - Refactor the logic to generate flush/merge file names. - Refactor the logic to check invalid components. - Adapt test cases to new naming format. Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManager.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmIoOpCallbackFactory.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/PersistentLocalResourceRepositoryTest.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.2.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/IIndexCheckpointManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/IndexCheckpoint.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMIOOperationCallbackTest.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/ClosedRecordConstructorResultType.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/OpenRecordConstructorResultType.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/CheckpointPartitionIndexesTask.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/ComponentMaskTask.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/MarkComponentValidTask.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/ReplicateFileTask.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeFileManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyFileManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMComponentIdGenerator.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IndexComponentFileReference.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentId.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentIdGenerator.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexFileManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeFil
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4807/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4975/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4328/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4637/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9894/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4418/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2429/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8355/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4769/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4417/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Somehow, I am surprised it passed. but I am glad that it did too -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage
abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2444][STO] Avoid Using System Clock in Storage .. Patch Set 3: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2927/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: PS3, Line 616: return MIN_VALID_COMPONENT_ID; In what case do we get here? -- To view, visit https://asterix-gerrit.ics.uci.edu/2927 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dff8ffb38ce8064a199d03b070ed1f5b924b8a4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][LOG] Include destination IP in thread name on pus...
abdullah alamoudi has submitted this change and it was merged.
Change subject: [NO ISSUE][LOG] Include destination IP in thread name on push
back
..
[NO ISSUE][LOG] Include destination IP in thread name on push back
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- In certain cases, we noticed that threads of certain jobs are
waiting on the network boundaries to send tuples.
- In that case and in a big cluster, it is difficult to tell which
node is pushing back.
- To make this easy, we include the IP of the receiving node
in the thread name.
Change-Id: I81b48cb7a79de0a37f2171a1bd3b82141f89b49d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2929
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Reviewed-by: Murtadha Hubail
Integration-Tests: Jenkins
---
M
hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
M
hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelControlBlock.java
M
hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelSet.java
M
hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/MultiplexedConnection.java
4 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Murtadha Hubail: Looks good to me, approved
diff --git
a/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
b/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
index 334fb5c..261e7c4 100644
---
a/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
+++
b/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
@@ -18,9 +18,11 @@
*/
package org.apache.hyracks.comm.channels;
+import java.net.InetSocketAddress;
import java.nio.ByteBuffer;
import java.util.ArrayDeque;
import java.util.Deque;
+import java.util.Objects;
import org.apache.hyracks.api.comm.IBufferAcceptor;
import org.apache.hyracks.api.comm.IFrameWriter;
@@ -75,7 +77,15 @@
break;
}
try {
-wait();
+InetSocketAddress remoteAddress =
ccb.getRemoteAddress();
+String nameBefore = Thread.currentThread().getName();
+try {
+Thread.currentThread()
+.setName(nameBefore + ":SendingTo(" +
Objects.toString(remoteAddress) + ")");
+wait();
+} finally {
+Thread.currentThread().setName(nameBefore);
+}
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw HyracksDataException.create(e);
diff --git
a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelControlBlock.java
b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelControlBlock.java
index 998acfb..f7ef2aa 100644
---
a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelControlBlock.java
+++
b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelControlBlock.java
@@ -19,6 +19,7 @@
package org.apache.hyracks.net.protocols.muxdemux;
import java.io.IOException;
+import java.net.InetSocketAddress;
import java.nio.channels.SocketChannel;
import java.util.concurrent.atomic.AtomicBoolean;
@@ -163,4 +164,8 @@
+ " remoteClose: " + remoteClose + " remoteCloseAck:" +
remoteCloseAck + " readCredits: "
+ ri.getCredits() + " writeCredits: " + wi.getCredits() + "]";
}
+
+public InetSocketAddress getRemoteAddress() {
+return cSet.getMultiplexedConnection().getRemoteAddress();
+}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelSet.java
b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelSet.java
index 31a37ef..f5cdf2c 100644
---
a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelSet.java
+++
b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelSet.java
@@ -239,4 +239,8 @@
ccbArray = Arrays.copyOf(ccbArray, ccbArray.length * 2);
}
}
+
+public MultiplexedConnecti
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/2rAhBF : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3631/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7241/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3631/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][LOG] Include destination IP in thread name on pus...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][LOG] Include destination IP in thread name on push back .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7240/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2929 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81b48cb7a79de0a37f2171a1bd3b82141f89b49d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4768/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4806/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Resolved] (ASTERIXDB-2446) Improve exception thrown for duplicate column names in SELECT clause
[ https://issues.apache.org/jira/browse/ASTERIXDB-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Lychagin resolved ASTERIXDB-2446. Resolution: Fixed > Improve exception thrown for duplicate column names in SELECT clause > > > Key: ASTERIXDB-2446 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2446 > Project: Apache AsterixDB > Issue Type: Improvement > Components: COMP - Compiler >Reporter: Dmitry Lychagin >Assignee: Dmitry Lychagin >Priority: Minor > > The error message thrown when there're duplicate column names in the select > clause is confusing. It's IllegalStateException inside HyracksDataException > Query: select t as a, 2 as a from range(1,10) t > Exception: > org.apache.hyracks.api.exceptions.HyracksDataException: > java.lang.IllegalStateException: ASX0013: Duplicate field name "a" > at > org.apache.hyracks.api.exceptions.HyracksDataException.create(HyracksDataException.java:51) > ~[classes/:?] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.close(AbstractOneInputOneOutputOneFramePushRuntime.java:68) > ~[classes/:?] > at > org.apache.hyracks.api.dataflow.EnforceFrameWriter.close(EnforceFrameWriter.java:113) > ~[classes/:?] > at org.apache.hyracks.api.util.CleanupUtils.close(CleanupUtils.java:66) > ~[classes/:?] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.close(AbstractOneInputOneOutputOneFramePushRuntime.java:65) > ~[classes/:?] > at > org.apache.hyracks.algebricks.runtime.operators.std.StreamLimitRuntimeFactory$1.close(StreamLimitRuntimeFactory.java:131) > ~[classes/:?] > at > org.apache.hyracks.api.dataflow.EnforceFrameWriter.close(EnforceFrameWriter.java:113) > ~[classes/:?] > at > org.apache.hyracks.algebricks.runtime.operators.std.EmptyTupleSourceRuntimeFactory$1.close(EmptyTupleSourceRuntimeFactory.java:61) > ~[classes/:?] > at > org.apache.hyracks.api.dataflow.EnforceFrameWriter.close(EnforceFrameWriter.java:113) > ~[classes/:?] > at > org.apache.hyracks.algebricks.runtime.operators.meta.AlgebricksMetaOperatorDescriptor$SourcePushRuntime.initialize(AlgebricksMetaOperatorDescriptor.java:111) > ~[classes/:?] > at > org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.lambda$runInParallel$0(SuperActivityOperatorNodePushable.java:212) > ~[classes/:?] > at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_161] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [?:1.8.0_161] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [?:1.8.0_161] > at java.lang.Thread.run(Thread.java:748) [?:1.8.0_161] > Caused by: java.lang.IllegalStateException: ASX0013: Duplicate field name "a" > at > org.apache.asterix.om.types.runtime.RuntimeRecordTypeInfo.reset(RuntimeRecordTypeInfo.java:108) > ~[classes/:?] > at org.apache.asterix.builders.RecordBuilder.reset(RecordBuilder.java:113) > ~[classes/:?] > at > org.apache.asterix.runtime.evaluators.common.ClosedRecordConstructorEvalFactory$ClosedRecordConstructorEval.evaluate(ClosedRecordConstructorEvalFactory.java:77) > ~[classes/:?] > at > org.apache.hyracks.algebricks.runtime.operators.std.AssignRuntimeFactory$1.produceTuple(AssignRuntimeFactory.java:159) > ~[classes/:?] > at > org.apache.hyracks.algebricks.runtime.operators.std.AssignRuntimeFactory$1.nextFrame(AssignRuntimeFactory.java:128) > ~[classes/:?] > at > org.apache.hyracks.api.dataflow.EnforceFrameWriter.nextFrame(EnforceFrameWriter.java:76) > ~[classes/:?] > at > org.apache.hyracks.dataflow.common.comm.io.AbstractFrameAppender.write(AbstractFrameAppender.java:93) > ~[classes/:?] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushAndReset(AbstractOneInputOneOutputOneFramePushRuntime.java:74) > ~[classes/:?] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushIfNotFailed(AbstractOneInputOneOutputOneFramePushRuntime.java:80) > ~[classes/:?] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.close(AbstractOneInputOneOutputOneFramePushRuntime.java:60) > ~[classes/:?] > ... 13 more > Caused by: org.apache.asterix.common.exceptions.RuntimeDataException: > ASX0013: Duplicate field name "a" > at > org.apache.asterix.om.types.runtime.RuntimeRecordTypeInfo.reset(RuntimeRecordTypeInfo.java:104) > ~[classes/:?] > at org.apache.asterix.builders.RecordBuilder.reset(RecordBuilder.java:113) > ~[classes/:?] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2446][COMP] Improve error raised for a duplicate ...
Dmitry Lychagin has submitted this change and it was merged.
Change subject: [ASTERIXDB-2446][COMP] Improve error raised for a duplicate
field name
..
[ASTERIXDB-2446][COMP] Improve error raised for a duplicate field name
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- Improve error raised in case when there is a duplicate field name
in the SELECT clause. Throw compilation exception instead of
IllegalStateException at runtime
Change-Id: I2f442acd73b3018058909f65626694dfbb49acc6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2930
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Till Westmann
---
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.1.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.2.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/ClosedRecordConstructorResultType.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/OpenRecordConstructorResultType.java
6 files changed, 100 insertions(+), 3 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.1.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.1.query.sqlpp
new file mode 100644
index 000..554cf28
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.1.query.sqlpp
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*
+ * Description: Ensure error if there's a duplicate field name in the
SELECT clause
+ */
+
+select t as a, 2 as a from range(1, 10) t
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.2.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.2.query.sqlpp
new file mode 100644
index 000..b548b5d
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.2.query.sqlpp
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*
+ * Description: Ensure error if there's a duplicate field name in the
closed-object-constructor() function
+ */
+
+set `import-private-functions` `true`;
+
+`closed-object-constructor`('b',get_year(current_date()),'c',[20],'c',[30]);
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.3.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/query-ASTERIXDB-2446/query-ASTERIXDB-2446.3.query.sqlpp
new file mode 100644
index 000..73810d8
--- /de
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/611/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7239/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/Q9RNpu : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/dGHkoh : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4327/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7241/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9893/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4636/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4416/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/686/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2428/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4417/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4974/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4382/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Jenkins has posted comments on this change. Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntroduceGroupByCombinerRule .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8354/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2933 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO-ISSUE][COMP] Avoid adding redundant var in AbstractIntro...
Xikui Wang has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2933
Change subject: [NO-ISSUE][COMP] Avoid adding redundant var in
AbstractIntroduceGroupByCombinerRule
..
[NO-ISSUE][COMP] Avoid adding redundant var in
AbstractIntroduceGroupByCombinerRule
- user model changes: no
- storage format changes: no
- interface changes: no
For live variables added in new Group-by op, they should not be added
again.
Change-Id: Ic1ab9aee31db95d5782385bc3d53777da54f6d83
---
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/redundant-var-in-groupby.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/redundant-var-in-groupby.plan
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java
3 files changed, 140 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/33/2933/1
diff --git
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/redundant-var-in-groupby.sqlpp
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/redundant-var-in-groupby.sqlpp
new file mode 100644
index 000..202a03d
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/redundant-var-in-groupby.sqlpp
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+drop dataverse test if exists;
+create dataverse test;
+use test;
+
+create type TweetType as open {
+ id : int64,
+ created_at : datetime
+};
+
+create type StoredTweetType as open {
+ tid : uuid
+};
+create dataset Tweets1(StoredTweetType) primary key tid autogenerated;
+create dataset Tweets2(StoredTweetType) primary key tid autogenerated;
+
+drop dataset ReligiousBuildingDataset if exists;
+drop type ReligiousBuildingType if exists;
+create type ReligiousBuildingType as open {
+religiousBuildingId : string,
+religionName : string,
+buildingLocation : point,
+registeredBeliever: int
+};
+create dataset ReligiousBuildingDataset(ReligiousBuildingType) primary key
religiousBuildingId;
+
+drop dataset AttackEventsDataset if exists;
+drop type AttackEventsType if exists;
+create type AttackEventsType as open {
+attackRecordId: string,
+attackDatetime: datetime,
+attackLocation: point,
+relatedReligion: string
+};
+create dataset AttackEventsDataset(AttackEventsType) primary key
attackRecordId;
+
+create function annotateTweet(x) {
+LET nearby_religious_attack = (select r.religionName as Religion,
count(a.attackRecordId) as AttackNum
+ from ReligiousBuildingDataset r, AttackEventsDataset a
+ where spatial_intersect(create_point(x.latitude, x.longitude),
create_circle(r.buildingLocation, 3.0))
+ and x.created_at < a.attackDatetime + duration("P2M")
+ and x.created_at > a.attackDatetime
+ and r.religionName = a.relatedReligion
+ group by r.religionName)
+select x.*, nearby_religious_attack
+};
+
+insert into Tweets2 (
+select annotateTweet(t) from Tweets1
+);
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/optimizerts/results/redundant-var-in-groupby.plan
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/redundant-var-in-groupby.plan
new file mode 100644
index 000..f3ae099
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/redundant-var-in-groupby.plan
@@ -0,0 +1,70 @@
+-- COMMIT |PARTITIONED|
+ -- STREAM_PROJECT |PARTITIONED|
+-- ONE_TO_ONE_EXCHANGE |PARTITIONED|
+ -- INSERT_DELETE |PARTITIONED|
+-- HASH_PARTITION_EXCHANGE [$$105] |PARTITIONED|
+ -- ASSIGN |PARTITIONED|
+-- STREAM_PROJECT |PARTITIONED|
+ -- ASSIGN |PARTITIONED|
+-- STREAM_PROJECT |PARTITIONED|
+ -- ASSIGN |PARTITIONED|
+-- STREAM_PROJECT |PARTITIONED|
+ -- ASSIGN |PARTITIONED|
+-- STREAM_PROJECT |PARTITIONED|
+ -- ONE_TO_ONE_EXCHANGE |PARTITIONED|
+-- PRE_
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3630/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][LOG] Include destination IP in thread name on pus...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][LOG] Include destination IP in thread name on push back .. Patch Set 2: -Integration-Tests Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7240/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2929 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81b48cb7a79de0a37f2171a1bd3b82141f89b49d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2446][COMP] Improve error raised for a duplicate ...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2446][COMP] Improve error raised for a duplicate field name .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2930 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f442acd73b3018058909f65626694dfbb49acc6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3630/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4767/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/ibjeG8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4326/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7239/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][LOG] Include destination IP in thread name on pus...
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][LOG] Include destination IP in thread name on push back .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2929 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81b48cb7a79de0a37f2171a1bd3b82141f89b49d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4415/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
