Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7377/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/tiGqzu : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3679/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3679/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4900/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Analytics Compatibility Compilation Successful
https://goo.gl/gzNKc9 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4464/ 
(12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7377/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5122/ (1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4773/ 
(2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Taewoo Kim (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1076

to look at the new patch set (#93).

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..

[NO ISSUE][COMP][RT] Enable multiway similarity joins

- Enable the FuzzyJoinRule that transforms
  a nested-loop-similarity-join plan to a three-stage-similarity join.
- Modify FuzzyJoinRuleCollections.
  - Add the ExtractCommonExpressionRule to extract common expressions
in the star-like multiple similarity join substitutions.
  - Add the InlineSubplanInputForNestedTupleSourceRule to translate
the generated subplan from the similarity function-derived
substitution into join in case of nested schemas.
  - Use similarity-jaccard-prefix to enable the pp+ join strategy.
  - Use the right side to build the heavy hash join on
the prefix tokens from both sides.
  - Add RemoveAssign/Variables/AggRules to iteratively remove unused
assign/vars once FuzzyJoinRule is applied in each round.
- Add three new optimization cases for multiway similarity joins.
  - link-like multiway similarity joins
  - star-like multiway similarity joins
  - hybrid multiway similarity joins with the both styles of similarity joins.
- Add a check whether a similarity function is on
  a select over an existing similarity join.
- Change the inverted-index-based similarity join to the three-stage-similarity 
join
  due to efficiency considerations.

Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/FuzzyUtils.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
A asterixdb/asterix-app/data/dblp-small/csx-small-multi-id.txt
A asterixdb/asterix-app/data/dblp-small/dblp-small-multi-id.txt
A asterixdb/asterix-app/data/pub-small/csx-small-multi-id.txt
A asterixdb/asterix-app/data/pub-small/csxauthors.adm
A asterixdb/asterix-app/data/pub-small/dblp-small-multi-id.txt
A asterixdb/asterix-app/data/pub-small/dblpauthors.adm
M asterixdb/asterix-app/src/test/resources/optimizerts/ignore.txt
M asterixdb/asterix-app/src/test/resources/optimizerts/only.txt
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-hybrid.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-selflink.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-simple.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-star.aql
M asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/similarity/jaccard-similarity-join-dual-order.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/similarity/jaccard-similarity-join-right-ahead.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/ASTERIXDB-2402.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/fj-dblp-csx-hybrid.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/fj-dblp-csx-selflink.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/fj-dblp-csx-simple.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/fj-dblp-csx-star.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/fj-dblp-csx.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join-noeqjoin/ngram-jaccard-inline.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join-noeqjoin/word-jaccard-inline.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/issue741.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/leftouterjoin-probe-pidx-with-join-jaccard-check-idx_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-fuzzyeq-jaccard_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-fuzzyeq-jaccard_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-fuzzyeq-jaccard_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_03.plan
M 

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10033/ (8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4940/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/760/ (6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2564/ 
(9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8501/ (5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4556/
 (10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4553/ 
(3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4520/ 
(11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins
..


Patch Set 93:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/685/ 
(7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 93
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

2018-10-02 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


Patch Set 2:

(16 comments)

first (incomplete) round of questions/comments

https://asterix-gerrit.ics.uci.edu/#/c/2857/2/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java:

PS2, Line 34: hints
no such parameter


PS2, Line 42: isPrimary
This parameter doesn't seem right. Why would the compression manager know about 
different index types?


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java:

PS2, Line 60: CompressionSchemeHint
This seems to be a parameter and not a hint.


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/compression/ICompressorDecompressor.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/compression/ICompressorDecompressor.java:

PS2, Line 37: computeCompressBufferSize
s/computeCompressBufferSize/computeCompressedBufferSize/


PS2, Line 58: uncompressedBuffer
s/uncompressedBuffer/uBuffer/


PS2, Line 58: compressedBuffer
s/compressedBuffer/cBuffer/


PS2, Line 80: uncompressedBuffer
s/uncompressedBuffer/uBuffer/


PS2, Line 80: compressedBuffer
s/compressedBuffer/cBuffer/


PS2, Line 81: length
s/length/cLength/


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/am/lsm/btree/LSMBTreeOperatorTestHelper.java
File 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/am/lsm/btree/LSMBTreeOperatorTestHelper.java:

PS2, Line 49: null
Use a NOOP ICompressorDecompressorFactory instead of null?


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/AppendOnlyLinkedMetadataPageManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/AppendOnlyLinkedMetadataPageManager.java:

PS2, Line 262: //At least there are 4 pages to consider the index is not empty
Could you expand the comment with more details?


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java:

PS2, Line 289: compressedPageWriter
Could we have a NOOP compressedPageWriter instead? Or just a PageWriter?


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/dataflow/LSMBTreeLocalResource.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/dataflow/LSMBTreeLocalResource.java:

PS2, Line 134: "compressorDecompressorFactory", 
compressorDecompressorFactory.toJson(registry)
Wondering if we could have something less physical here. But I'm not sure about 
the trade-offs.


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java:

PS2, Line 374: compressed
This parameter seems unfortunate. Why does the getter of the file reference 
need to know if the file is compressed?


PS2, Line 382: isCompressable
s/isCompressable/isCompressible/ ?


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/CachedPage.java
File 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/CachedPage.java:

PS2, Line 53: private long compressedOffset;
: private int compressedSize;
move this above the DEBUG members?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: 

Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4899/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4463/ 
(12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7376/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7376/ 
: FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1: Contrib-2

Analytics Compatibility Compilation Failed
https://goo.gl/SLk5mi : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4939/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/759/ (9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4519/ 
(2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8500/ (5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10032/ (10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Ian Maxon (Code Review)
Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2985

Change subject: Merge release-0.9.4 into master
..

Merge release-0.9.4 into master

Change-Id:Ied2b685f015e0f35563ebd0510231a5d663494f4
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/85/2985/1


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4555/
 (11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4552/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4772/ 
(6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5121/ (1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2563/ 
(3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Merge release-0.9.4 into master

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Merge release-0.9.4 into master
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/684/ 
(7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2985
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in incubator-asterixdb-site[asf-site]: Add 0.9.4

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add 0.9.4
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asf-site/121/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2984
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f2
Gerrit-PatchSet: 1
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in incubator-asterixdb-site[asf-site]: Add 0.9.4

2018-10-02 Thread Ian Maxon (Code Review)
Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2984

Change subject: Add 0.9.4
..

Add 0.9.4

Change-Id:Ied2b685f015e0f35563ebd0510231a5d663494f2
---
M _config.yml
M content/about.html
M content/community.html
M content/dev-setup.html
A content/docs/0.9.4/api.html
A content/docs/0.9.4/aql/externaldata.html
A content/docs/0.9.4/aql/filters.html
A content/docs/0.9.4/aql/fulltext.html
A content/docs/0.9.4/aql/js-sdk.html
A content/docs/0.9.4/aql/manual.html
A content/docs/0.9.4/aql/primer.html
A content/docs/0.9.4/aql/similarity.html
A content/docs/0.9.4/css/apache-maven-fluido-1.7.min.css
A content/docs/0.9.4/css/print.css
A content/docs/0.9.4/css/site.css
A content/docs/0.9.4/csv.html
A content/docs/0.9.4/data/chm.adm
A content/docs/0.9.4/data/chu.adm
A content/docs/0.9.4/data/fbm.adm
A content/docs/0.9.4/data/fbu.adm
A content/docs/0.9.4/data/gbm.adm
A content/docs/0.9.4/data/gbu.adm
A content/docs/0.9.4/data/lineitem.tbl
A content/docs/0.9.4/data/twm.adm
A content/docs/0.9.4/data/twu.adm
A content/docs/0.9.4/feeds/tutorial.html
A content/docs/0.9.4/fonts/glyphicons-halflings-regular.eot
A content/docs/0.9.4/fonts/glyphicons-halflings-regular.svg
A content/docs/0.9.4/fonts/glyphicons-halflings-regular.ttf
A content/docs/0.9.4/fonts/glyphicons-halflings-regular.woff
A content/docs/0.9.4/images/AsterixCluster.png
A content/docs/0.9.4/images/accessories-text-editor.png
A content/docs/0.9.4/images/add.gif
A content/docs/0.9.4/images/apache-maven-project-2.png
A content/docs/0.9.4/images/application-certificate.png
A content/docs/0.9.4/images/asf_logo_wide.png
A content/docs/0.9.4/images/asterix_webui.png
A content/docs/0.9.4/images/asterixdb_interface.png
A content/docs/0.9.4/images/asterixlogo.png
A content/docs/0.9.4/images/contact-new.png
A content/docs/0.9.4/images/document-properties.png
A content/docs/0.9.4/images/drive-harddisk.png
A content/docs/0.9.4/images/egg-logo.png
A content/docs/0.9.4/images/fix.gif
A content/docs/0.9.4/images/hyrax_ts.png
A content/docs/0.9.4/images/icon_error_sml.gif
A content/docs/0.9.4/images/icon_help_sml.gif
A content/docs/0.9.4/images/icon_info_sml.gif
A content/docs/0.9.4/images/icon_success_sml.gif
A content/docs/0.9.4/images/icon_warning_sml.gif
A content/docs/0.9.4/images/image-x-generic.png
A content/docs/0.9.4/images/internet-web-browser.png
A content/docs/0.9.4/images/logos/build-by-maven-black.png
A content/docs/0.9.4/images/logos/build-by-maven-white.png
A content/docs/0.9.4/images/logos/maven-feather.png
A content/docs/0.9.4/images/ncservice.png
A content/docs/0.9.4/images/network-server.png
A content/docs/0.9.4/images/package-x-generic.png
A content/docs/0.9.4/images/profiles/pre-release.png
A content/docs/0.9.4/images/profiles/retired.png
A content/docs/0.9.4/images/profiles/sandbox.png
A content/docs/0.9.4/images/remove.gif
A content/docs/0.9.4/images/rss.png
A content/docs/0.9.4/images/running_inst.png
A content/docs/0.9.4/images/update.gif
A content/docs/0.9.4/images/window-new.png
A content/docs/0.9.4/images/yarn_clust.png
A content/docs/0.9.4/img/glyphicons-halflings-white.png
A content/docs/0.9.4/img/glyphicons-halflings.png
A content/docs/0.9.4/index.html
A content/docs/0.9.4/js/apache-maven-fluido-1.7.min.js
A content/docs/0.9.4/ncservice.html
A content/docs/0.9.4/overview.html
A content/docs/0.9.4/sqlpp/primer-sqlpp.html
A content/docs/0.9.4/udf.html
M content/download.html
M content/extension.html
M content/index.html
M content/pushing.html
M content/site.html
M content/tools.html
A docs/0.9.4/api.html
A docs/0.9.4/aql/externaldata.html
A docs/0.9.4/aql/filters.html
A docs/0.9.4/aql/fulltext.html
A docs/0.9.4/aql/js-sdk.html
A docs/0.9.4/aql/manual.html
A docs/0.9.4/aql/primer.html
A docs/0.9.4/aql/similarity.html
A docs/0.9.4/css/apache-maven-fluido-1.7.min.css
A docs/0.9.4/css/print.css
A docs/0.9.4/css/site.css
A docs/0.9.4/csv.html
A docs/0.9.4/data/chm.adm
A docs/0.9.4/data/chu.adm
A docs/0.9.4/data/fbm.adm
A docs/0.9.4/data/fbu.adm
A docs/0.9.4/data/gbm.adm
A docs/0.9.4/data/gbu.adm
A docs/0.9.4/data/lineitem.tbl
A docs/0.9.4/data/twm.adm
A docs/0.9.4/data/twu.adm
A docs/0.9.4/feeds/tutorial.html
A docs/0.9.4/fonts/glyphicons-halflings-regular.eot
A docs/0.9.4/fonts/glyphicons-halflings-regular.svg
A docs/0.9.4/fonts/glyphicons-halflings-regular.ttf
A docs/0.9.4/fonts/glyphicons-halflings-regular.woff
A docs/0.9.4/images/AsterixCluster.png
A docs/0.9.4/images/accessories-text-editor.png
A docs/0.9.4/images/add.gif
A docs/0.9.4/images/apache-maven-project-2.png
A docs/0.9.4/images/application-certificate.png
A docs/0.9.4/images/asf_logo_wide.png
A docs/0.9.4/images/asterix_webui.png
A docs/0.9.4/images/asterixdb_interface.png
A docs/0.9.4/images/asterixlogo.png
A docs/0.9.4/images/contact-new.png
A docs/0.9.4/images/document-properties.png
A docs/0.9.4/images/drive-harddisk.png
A docs/0.9.4/images/egg-logo.png
A docs/0.9.4/images/fix.gif
A 

Change in asterixdb[release-0.9.4-rc2]: Release Apache AsterixDB 0.9.4 and 0.3.4

2018-10-02 Thread Ian Maxon (Code Review)
Ian Maxon has submitted this change and it was merged.

Change subject: Release Apache AsterixDB 0.9.4 and 0.3.4
..


Release Apache AsterixDB 0.9.4 and 0.3.4

Change-Id:Ib015ae6e13f38eb726512a9c5ddeeda428ad1dff
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2952
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Ian Maxon 
---
M asterixdb/asterix-active/pom.xml
M asterixdb/asterix-algebra/pom.xml
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-benchmark/pom.xml
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M asterixdb/asterix-coverage/pom.xml
M asterixdb/asterix-dashboard/pom.xml
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-docker/pom.xml
M asterixdb/asterix-examples/pom.xml
M asterixdb/asterix-external-data/pom.xml
M asterixdb/asterix-fuzzyjoin/pom.xml
M asterixdb/asterix-hivecompat/pom.xml
M asterixdb/asterix-lang-aql/pom.xml
M asterixdb/asterix-lang-common/pom.xml
M asterixdb/asterix-lang-sqlpp/pom.xml
M asterixdb/asterix-license/pom.xml
M 
asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/pom.xml
M asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/pom.xml
M 
asterixdb/asterix-maven-plugins/asterix-test-datagenerator-maven-plugin/pom.xml
M asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/pom.xml
M asterixdb/asterix-maven-plugins/pom.xml
M asterixdb/asterix-maven-plugins/record-manager-generator-maven-plugin/pom.xml
M asterixdb/asterix-metadata/pom.xml
M asterixdb/asterix-om/pom.xml
M asterixdb/asterix-replication/pom.xml
M asterixdb/asterix-runtime/pom.xml
M asterixdb/asterix-server/pom.xml
M asterixdb/asterix-test-framework/pom.xml
M asterixdb/asterix-tools/pom.xml
M asterixdb/asterix-transactions/pom.xml
M asterixdb/pom.xml
M hyracks-fullstack/algebricks/algebricks-common/pom.xml
M hyracks-fullstack/algebricks/algebricks-compiler/pom.xml
M hyracks-fullstack/algebricks/algebricks-core/pom.xml
M hyracks-fullstack/algebricks/algebricks-data/pom.xml
M hyracks-fullstack/algebricks/algebricks-rewriter/pom.xml
M hyracks-fullstack/algebricks/algebricks-runtime/pom.xml
M hyracks-fullstack/algebricks/algebricks-tests/pom.xml
M hyracks-fullstack/algebricks/pom.xml
M hyracks-fullstack/hyracks-fullstack-license/pom.xml
M hyracks-fullstack/hyracks/hyracks-api/pom.xml
M hyracks-fullstack/hyracks/hyracks-client/pom.xml
M hyracks-fullstack/hyracks/hyracks-comm/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/pom.xml
M hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/pom.xml
M hyracks-fullstack/hyracks/hyracks-data/pom.xml
M hyracks-fullstack/hyracks/hyracks-dataflow-common/pom.xml
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M hyracks-fullstack/hyracks/hyracks-dist/pom.xml
M hyracks-fullstack/hyracks/hyracks-documentation/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreeclient/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreehelper/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreeserver/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/btree-example/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/hyracks-shutdown-test/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/text-example/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/text-example/textclient/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/text-example/texthelper/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/tpch-example/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/tpch-example/tpchclient/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/tpch-example/tpchserver/pom.xml
M hyracks-fullstack/hyracks/hyracks-hdfs/pom.xml
M hyracks-fullstack/hyracks/hyracks-http/pom.xml
M hyracks-fullstack/hyracks/hyracks-ipc/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-maven-plugins/hyracks-virtualcluster-maven-plugin/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/pom.xml
M hyracks-fullstack/hyracks/hyracks-maven-plugins/pom.xml
M hyracks-fullstack/hyracks/hyracks-net/pom.xml
M hyracks-fullstack/hyracks/hyracks-server/pom.xml
M hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/pom.xml
M hyracks-fullstack/hyracks/hyracks-storage-am-btree/pom.xml
M hyracks-fullstack/hyracks/hyracks-storage-am-common/pom.xml
M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/pom.xml
M 

Change in asterixdb[release-0.9.4-rc2]: Advance version to AsterixDB 0.9.5-SNAPSHOT and Hyracks 0.3....

2018-10-02 Thread Ian Maxon (Code Review)
Ian Maxon has submitted this change and it was merged.

Change subject: Advance version to AsterixDB 0.9.5-SNAPSHOT and Hyracks 
0.3.5-SNAPSHOT
..


Advance version to AsterixDB 0.9.5-SNAPSHOT and Hyracks 0.3.5-SNAPSHOT

Change-Id:Ied2b685f015e0f35563ebd0510231a5d663494f7
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2953
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Ian Maxon 
---
M asterixdb/asterix-active/pom.xml
M asterixdb/asterix-algebra/pom.xml
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-benchmark/pom.xml
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M asterixdb/asterix-coverage/pom.xml
M asterixdb/asterix-dashboard/pom.xml
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-docker/pom.xml
M asterixdb/asterix-examples/pom.xml
M asterixdb/asterix-external-data/pom.xml
M asterixdb/asterix-fuzzyjoin/pom.xml
M asterixdb/asterix-hivecompat/pom.xml
M asterixdb/asterix-lang-aql/pom.xml
M asterixdb/asterix-lang-common/pom.xml
M asterixdb/asterix-lang-sqlpp/pom.xml
M asterixdb/asterix-license/pom.xml
M 
asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/pom.xml
M asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/pom.xml
M 
asterixdb/asterix-maven-plugins/asterix-test-datagenerator-maven-plugin/pom.xml
M asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/pom.xml
M asterixdb/asterix-maven-plugins/pom.xml
M asterixdb/asterix-maven-plugins/record-manager-generator-maven-plugin/pom.xml
M asterixdb/asterix-metadata/pom.xml
M asterixdb/asterix-om/pom.xml
M asterixdb/asterix-replication/pom.xml
M asterixdb/asterix-runtime/pom.xml
M asterixdb/asterix-server/pom.xml
M asterixdb/asterix-test-framework/pom.xml
M asterixdb/asterix-tools/pom.xml
M asterixdb/asterix-transactions/pom.xml
M asterixdb/pom.xml
M hyracks-fullstack/algebricks/algebricks-common/pom.xml
M hyracks-fullstack/algebricks/algebricks-compiler/pom.xml
M hyracks-fullstack/algebricks/algebricks-core/pom.xml
M hyracks-fullstack/algebricks/algebricks-data/pom.xml
M hyracks-fullstack/algebricks/algebricks-rewriter/pom.xml
M hyracks-fullstack/algebricks/algebricks-runtime/pom.xml
M hyracks-fullstack/algebricks/algebricks-tests/pom.xml
M hyracks-fullstack/algebricks/pom.xml
M hyracks-fullstack/hyracks-fullstack-license/pom.xml
M hyracks-fullstack/hyracks/hyracks-api/pom.xml
M hyracks-fullstack/hyracks/hyracks-client/pom.xml
M hyracks-fullstack/hyracks/hyracks-comm/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/pom.xml
M hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/pom.xml
M hyracks-fullstack/hyracks/hyracks-data/pom.xml
M hyracks-fullstack/hyracks/hyracks-dataflow-common/pom.xml
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M hyracks-fullstack/hyracks/hyracks-dist/pom.xml
M hyracks-fullstack/hyracks/hyracks-documentation/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreeclient/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreehelper/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreeserver/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/btree-example/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/hyracks-shutdown-test/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/text-example/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/text-example/textclient/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/text-example/texthelper/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/tpch-example/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/tpch-example/tpchclient/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/tpch-example/tpchserver/pom.xml
M hyracks-fullstack/hyracks/hyracks-hdfs/pom.xml
M hyracks-fullstack/hyracks/hyracks-http/pom.xml
M hyracks-fullstack/hyracks/hyracks-ipc/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-maven-plugins/hyracks-virtualcluster-maven-plugin/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/pom.xml
M hyracks-fullstack/hyracks/hyracks-maven-plugins/pom.xml
M hyracks-fullstack/hyracks/hyracks-net/pom.xml
M hyracks-fullstack/hyracks/hyracks-server/pom.xml
M hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/pom.xml
M hyracks-fullstack/hyracks/hyracks-storage-am-btree/pom.xml
M hyracks-fullstack/hyracks/hyracks-storage-am-common/pom.xml
M 

Change in asterixdb[release-0.9.4-rc2]: Advance version to AsterixDB 0.9.5-SNAPSHOT and Hyracks 0.3....

2018-10-02 Thread Ian Maxon (Code Review)
Ian Maxon has posted comments on this change.

Change subject: Advance version to AsterixDB 0.9.5-SNAPSHOT and Hyracks 
0.3.5-SNAPSHOT
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2953
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2b685f015e0f35563ebd0510231a5d663494f7
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-rc2
Gerrit-Owner: Jenkins 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-rc2]: Release Apache AsterixDB 0.9.4 and 0.3.4

2018-10-02 Thread Ian Maxon (Code Review)
Ian Maxon has posted comments on this change.

Change subject: Release Apache AsterixDB 0.9.4 and 0.3.4
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2952
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib015ae6e13f38eb726512a9c5ddeeda428ad1dff
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-rc2
Gerrit-Owner: Jenkins 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Michael Carey (Code Review)
Michael Carey has submitted this change and it was merged.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


[ASTERIXDB-2456][DOC] Re-add insert to primer

Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2983
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Carey 
---
M asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md
1 file changed, 30 insertions(+), 0 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Michael Carey: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified



diff --git a/asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md 
b/asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md
index 1c78cc4..40b81d6 100644
--- a/asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md
+++ b/asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md
@@ -850,6 +850,36 @@
 { "chirp": { "chirpId": "5", "user": { "screenName": 
"NathanGiesen@211", "lang": "en", "friendsCount": 39339, "statusesCount": 473, 
"name": "Nathan Giesen", "followersCount": 49416 }, "senderLocation": 
point("40.09,92.69"), "sendTime": datetime("2006-08-04T10:10:00.000Z"), 
"referredTopics": {{ "product-w", "speed" }}, "messageText": " can't stand 
product-w its speed is terrible:(" }, "similarChirps": [  ] }
 { "chirp": { "chirpId": "8", "user": { "screenName": 
"NathanGiesen@211", "lang": "en", "friendsCount": 39339, "statusesCount": 473, 
"name": "Nathan Giesen", "followersCount": 49416 }, "senderLocation": 
point("46.05,93.34"), "sendTime": datetime("2005-10-14T10:10:00.000Z"), 
"referredTopics": {{ "product-z", "shortcut-menu" }}, "messageText": " like 
product-z the shortcut-menu is awesome:)" }, "similarChirps": [  ] }
 
+## Inserting New Data  ###
+In addition to loading and querying data, AsterixDB supports incremental 
additions to datasets via the SQL++ _INSERT_ statement.
+
+The following example adds a new chirp by user "NathanGiesen@211" to the 
ChirpMessages dataset.
+(An astute reader may notice that this chirp was issued a half an hour after 
his last chirp, so his counts
+have all gone up in the interim, although he appears not to have moved in the 
last half hour.)
+
+USE TinySocial;
+
+INSERT INTO ChirpMessages
+(
+   {"chirpId": "13",
+"user":
+{"screenName": "NathanGiesen@211",
+ "lang": "en",
+ "friendsCount": 39345,
+ "statusesCount": 479,
+ "name": "Nathan Giesen",
+ "followersCount": 49420
+},
+"senderLocation": point("47.44,80.65"),
+"sendTime": datetime("2008-04-26T10:10:35"),
+"referredTopics": {{"chirping"}},
+"messageText": "chirpy chirp, my fellow chirpers!"
+   }
+);
+
+In general, the data to be inserted may be specified using any valid SQL++ 
query expression.
+The insertion of a single object instance, as in this example, is just a 
special case where
+the query expression happens to be a object constructor involving only 
constants.
 
 ### Deleting Existing Data  ###
 In addition to inserting new data, AsterixDB supports deletion from datasets 
via the SQL++ _DELETE_ statement.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2286][COMP][FUN][HYR] Parallel Sort Optimization

2018-10-02 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2286][COMP][FUN][HYR] Parallel Sort Optimization
..


Patch Set 25:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2393/25/asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/fullparallelsort.sqlpp
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/hints/fullparallelsort.sqlpp:

Line 21: * Description  : Test no full parallel hint to disable full parallel 
sort.
the description is incorrect.


https://asterix-gerrit.ics.uci.edu/#/c/2393/25/asterixdb/asterix-app/src/test/resources/optimizerts/results/introhashpartitionmerge.plan
File 
asterixdb/asterix-app/src/test/resources/optimizerts/results/introhashpartitionmerge.plan:

Line 16
I think we need to turn off parallel sort for this query because the intent was 
to test HASH_PARTITION_MERGE_EXCHANGE and it's no longer in the plan with full 
parallel sort


https://asterix-gerrit.ics.uci.edu/#/c/2393/25/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/RangePartitionExchangePOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/RangePartitionExchangePOperator.java:

Line 136: final String splitCount = rangeMap == null ? "" : 
Integer.toString(rangeMap.getSplitCount());
minor. let's no print "SPLIT COUNT: " if range map is dynamic so there's no 
split count available at compile time. (we can do it in a follow up change)


https://asterix-gerrit.ics.uci.edu/#/c/2393/25/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/ForwardOperatorDescriptor.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/ForwardOperatorDescriptor.java:

Line 222: TaskUtil.put(rangeMapKeyInContext, 
rangeMapState.rangeMap, ctx);
Seems like we can just call TaskUtil.put() in the 
RangeMapReaderActivityNodePushable.close() , so we won't need RangeMapState at 
all. Is that the case? (not critical, we can do in a follow up change)


https://asterix-gerrit.ics.uci.edu/#/c/2393/25/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractExternalSortRunMerger.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractExternalSortRunMerger.java:

Line 161: LOGGER.info("number of passes: " + 
numberOfPasses);
minor. let's move it to the debug level and merge with the previous line.  also 
put if (LOGGER.isDebugEnabled()) around it.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73e128029a46f45e6b68c23dfb9310d5de10582f
Gerrit-PatchSet: 25
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/toFmC3 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7375/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3678/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3678/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add more data types for external library

2018-10-02 Thread Xikui Wang (Code Review)
Xikui Wang has submitted this change and it was merged.

Change subject: [NO ISSUE][FUN] Add more data types for external library
..


[NO ISSUE][FUN] Add more data types for external library

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
1. Added more types for external library.
2. Added test case for data types.
3. Fixed minor bug where the parameter type is not trimmed in UDF.

Change-Id: I6ce73e791533b0617074536e0d841242d9e0ee31
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2871
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Dmitry Lychagin 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/type_validation/type_validation.1.lib.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/type_validation/type_validation.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/type_validation/type_validation.3.lib.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/type_validation/type_validation.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/type_validation/type_validation.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/validate-default-library/validate-default-library.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_sqlpp.xml
A 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/TypeValidationFunction.java
A 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/TypeValidationFunctionFactory.java
M asterixdb/asterix-external-data/src/test/resources/library_descriptor.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/ExternalFunctionCompilerUtil.java
M 
asterixdb/asterix-server/src/test/resources/integrationts/library/results/library-metadata/functionDataset/functionDataset.1.adm
13 files changed, 229 insertions(+), 7 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Jenkins: Verified; No violations found; ; Verified
  Dmitry Lychagin: Looks good to me, approved



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
index 0af1b9d..0eac212 100755
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
@@ -222,7 +222,7 @@
 String functionType = function.getFunctionType().trim();
 List args = new ArrayList<>();
 for (String arg : fargs) {
-args.add(arg);
+args.add(arg.trim());
 }
 FunctionSignature signature = new 
FunctionSignature(dataverse, functionFullName, args.size());
 Function f = new Function(signature, args, 
functionReturnType, functionDefinition, functionLanguage,
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/type_validation/type_validation.1.lib.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/type_validation/type_validation.1.lib.sqlpp
new file mode 100644
index 000..25aff38
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/type_validation/type_validation.1.lib.sqlpp
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+install externallibtest testlib 
target/data/externallib/asterix-external-data-testlib.zip
\ No newline at end of file
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/type_validation/type_validation.2.query.sqlpp
 

Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4898/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4462/ 
(12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/yhZL79 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7375/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8499/ (5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4518/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10031/ (7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Ian Maxon (Code Review)
Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2983

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..

[ASTERIXDB-2456][DOC] Re-add insert to primer

Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
---
M asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md
1 file changed, 30 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/83/2983/1

diff --git a/asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md 
b/asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md
index 1c78cc4..40b81d6 100644
--- a/asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md
+++ b/asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md
@@ -850,6 +850,36 @@
 { "chirp": { "chirpId": "5", "user": { "screenName": 
"NathanGiesen@211", "lang": "en", "friendsCount": 39339, "statusesCount": 473, 
"name": "Nathan Giesen", "followersCount": 49416 }, "senderLocation": 
point("40.09,92.69"), "sendTime": datetime("2006-08-04T10:10:00.000Z"), 
"referredTopics": {{ "product-w", "speed" }}, "messageText": " can't stand 
product-w its speed is terrible:(" }, "similarChirps": [  ] }
 { "chirp": { "chirpId": "8", "user": { "screenName": 
"NathanGiesen@211", "lang": "en", "friendsCount": 39339, "statusesCount": 473, 
"name": "Nathan Giesen", "followersCount": 49416 }, "senderLocation": 
point("46.05,93.34"), "sendTime": datetime("2005-10-14T10:10:00.000Z"), 
"referredTopics": {{ "product-z", "shortcut-menu" }}, "messageText": " like 
product-z the shortcut-menu is awesome:)" }, "similarChirps": [  ] }
 
+## Inserting New Data  ###
+In addition to loading and querying data, AsterixDB supports incremental 
additions to datasets via the SQL++ _INSERT_ statement.
+
+The following example adds a new chirp by user "NathanGiesen@211" to the 
ChirpMessages dataset.
+(An astute reader may notice that this chirp was issued a half an hour after 
his last chirp, so his counts
+have all gone up in the interim, although he appears not to have moved in the 
last half hour.)
+
+USE TinySocial;
+
+INSERT INTO ChirpMessages
+(
+   {"chirpId": "13",
+"user":
+{"screenName": "NathanGiesen@211",
+ "lang": "en",
+ "friendsCount": 39345,
+ "statusesCount": 479,
+ "name": "Nathan Giesen",
+ "followersCount": 49420
+},
+"senderLocation": point("47.44,80.65"),
+"sendTime": datetime("2008-04-26T10:10:35"),
+"referredTopics": {{"chirping"}},
+"messageText": "chirpy chirp, my fellow chirpers!"
+   }
+);
+
+In general, the data to be inserted may be specified using any valid SQL++ 
query expression.
+The insertion of a single object instance, as in this example, is just a 
special case where
+the query expression happens to be a object constructor involving only 
constants.
 
 ### Deleting Existing Data  ###
 In addition to inserting new data, AsterixDB supports deletion from datasets 
via the SQL++ _DELETE_ statement.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4551/ 
(11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4938/ 
(3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4554/
 (9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2562/ 
(2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5120/ (1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/683/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/758/ (6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4771/ 
(10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2983
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I404246ea4a8568e28190cd2371356175db1471cc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN][COMP] fix ifnan(), ifnanorinf(), ifinf()

2018-10-02 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has submitted this change and it was merged.

Change subject: [NO ISSUE][FUN][COMP] fix ifnan(), ifnanorinf(), ifinf()
..


[NO ISSUE][FUN][COMP] fix ifnan(), ifnanorinf(), ifinf()

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
This patch is to fix the mentioned functions. The fix is
to make ifnan() & ifnanorinf() skip the argument being
inspected if it's a missing value and check the next one.
For ifinf(), it should return missing if the argument
being inspected is a missing value. Also, number of args
is checked now.

Change-Id: Ib7cc3d18ca0443857ae271b6e14f2c9e920f1c1f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2981
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Dmitry Lychagin 
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifinf/ifinf.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifinf/ifinf.2.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifnan/ifnan.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifnan/ifnan.2.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifnanorinf/ifnanorinf.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifnanorinf/ifnanorinf.2.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifinf/ifinf.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifnan/ifnan.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifnanorinf/ifnanorinf.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/IfNanOrInfTypeComputer.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfInfDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfNanDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfNanOrInfDescriptor.java
15 files changed, 178 insertions(+), 55 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Jenkins: Verified; ; Verified
  Dmitry Lychagin: Looks good to me, approved

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifinf/ifinf.1.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifinf/ifinf.1.query.sqlpp
index 479e290..243663f 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifinf/ifinf.1.query.sqlpp
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifinf/ifinf.1.query.sqlpp
@@ -19,19 +19,18 @@
 
 select value t
 from [
-[ 0, isnull(ifinf()) ],
-[ 1, isnull(ifinf(null)) ],
-[ 2, ismissing(ifinf(missing)) ],
-[ 3, isnull(ifinf(double("INF"))) ],
-[ 4, isnull(ifinf(double("-INF"))) ],
-[ 5, isnull(ifinf(float("INF"))) ],
-[ 6, isnull(ifinf(float("-INF"))) ],
-[ 7, ifinf(tinyint("1")) ],
-[ 8, ifinf(smallint("2")) ],
-[ 9, ifinf(integer("3")) ],
-[ 10, ifinf(bigint("4")) ],
-[ 11, ifinf(float("1.5")) ],
-[ 12, ifinf(double("2.5")) ],
+[ 1, isnull(ifinf(null, null)) ],
+[ 2, ismissing(ifinf(missing, null)) ],
+[ 3, isnull(ifinf(double("INF"), double("INF"))) ],
+[ 4, isnull(ifinf(double("-INF"), double("-INF"))) ],
+[ 5, isnull(ifinf(float("INF"), float("INF"))) ],
+[ 6, isnull(ifinf(float("-INF"), float("-INF"))) ],
+[ 7, ifinf(tinyint("1"), 5) ],
+[ 8, ifinf(smallint("2"), 5) ],
+[ 9, ifinf(integer("3"), 5) ],
+[ 10, ifinf(bigint("4"), 5) ],
+[ 11, ifinf(float("1.5"), 5) ],
+[ 12, ifinf(double("2.5"), 5) ],
 [ 13, ifinf(2, null, missing) ],
 [ 14, isnull(ifinf(null, missing, 2)) ],
 [ 15, ismissing(ifinf(missing, null, 2)) ],
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifinf/ifinf.2.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifinf/ifinf.2.query.sqlpp
new file mode 100644
index 000..d1daed0
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/ifinf/ifinf.2.query.sqlpp
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ 

Change in asterixdb[master]: [NO ISSUE][FUN][COMP] fix ifnan(), ifnanorinf(), ifinf()

2018-10-02 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change.

Change subject: [NO ISSUE][FUN][COMP] fix ifnan(), ifnanorinf(), ifinf()
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2981
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7cc3d18ca0443857ae271b6e14f2c9e920f1c1f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add more data types for external library

2018-10-02 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add more data types for external library
..


Patch Set 11: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2871
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ce73e791533b0617074536e0d841242d9e0ee31
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP] allow optimization rule to inspect other fu...

2018-10-02 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] allow optimization rule to inspect other 
functions
..


Patch Set 2: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/yeCYAC : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2980
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65679e934a41e00b04bc3fd479ed404af293eb21
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No