Change in asterixdb[master]: [NO ISSUE][API][MTD] Refactor query service servlet - user m...

2018-11-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][API][MTD] Refactor query service servlet - user 
model changes: no - storage format changes: no - interface changes: no
..


Patch Set 1:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3038/1//COMMIT_MSG
Commit Message:

Line 7: [NO ISSUE][API][MTD] Refactor query service servlet
\n


https://asterix-gerrit.ics.uci.edu/#/c/3038/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java:

PS1, Line 426: setFromJSON
A better place for this might be QueryServiceRequestParameters.ofJson(JsonNode 
request). But you may just rename this now to setParamFromJSON and that can be 
done on a later stage.


PS1, Line 432: setFromRequest
A better place for this might be 
QueryServiceRequestParameters.of(IServletRequest request). But you may just 
rename this now to setParamFromRequest and that can be done on a later stage.


PS1, Line 661: printPre
rename to printOptionalResultFields


https://asterix-gerrit.ics.uci.edu/#/c/3038/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java:

PS1, Line 1800: "`" + dvName + "`"
You may introduce a SQL++ escape method in a util and use it here.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3038
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbc81219cbe2f337b3c4aaf4a242ef2ebeb165c5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...

2018-11-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has submitted this change and it was merged.

Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing 
It
..


[ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- When recycling a buffer, calculate the buffer remaining before
  releasing it for reuse to prevent other threads from changing
  its remaining.
- Add test case.

Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3036
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 
---
M hyracks-fullstack/hyracks/hyracks-net/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
A 
hyracks-fullstack/hyracks/hyracks-net/src/test/java/org/apache/hyracks/net/tests/FullFrameChannelReadInterfaceTest.java
3 files changed, 188 insertions(+), 2 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git a/hyracks-fullstack/hyracks/hyracks-net/pom.xml 
b/hyracks-fullstack/hyracks/hyracks-net/pom.xml
index 1040e81..4ca20ca 100644
--- a/hyracks-fullstack/hyracks/hyracks-net/pom.xml
+++ b/hyracks-fullstack/hyracks/hyracks-net/pom.xml
@@ -60,5 +60,11 @@
   hyracks-util
   ${project.version}
 
+
+  org.mockito
+  mockito-all
+  2.0.2-beta
+  test
+
   
 
diff --git 
a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
 
b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
index 32bf77e..3ba8627 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
@@ -36,7 +36,7 @@
 private final BlockingDeque riEmptyStack;
 private final IChannelControlBlock ccb;
 
-FullFrameChannelReadInterface(IChannelControlBlock ccb) {
+public FullFrameChannelReadInterface(IChannelControlBlock ccb) {
 this.ccb = ccb;
 riEmptyStack = new LinkedBlockingDeque<>();
 credits = 0;
@@ -45,8 +45,8 @@
 if (ccb.isRemotelyClosed()) {
 return;
 }
-riEmptyStack.push(buffer);
 final int delta = buffer.remaining();
+riEmptyStack.push(buffer);
 ccb.addPendingCredits(delta);
 };
 }
diff --git 
a/hyracks-fullstack/hyracks/hyracks-net/src/test/java/org/apache/hyracks/net/tests/FullFrameChannelReadInterfaceTest.java
 
b/hyracks-fullstack/hyracks/hyracks-net/src/test/java/org/apache/hyracks/net/tests/FullFrameChannelReadInterfaceTest.java
new file mode 100644
index 000..f9a610c
--- /dev/null
+++ 
b/hyracks-fullstack/hyracks/hyracks-net/src/test/java/org/apache/hyracks/net/tests/FullFrameChannelReadInterfaceTest.java
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.hyracks.net.tests;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.channels.SocketChannel;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingDeque;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import org.apache.hyracks.api.comm.IBufferFactory;
+import org.apache.hyracks.api.comm.IChannelControlBlock;
+import org.apache.hyracks.api.comm.ICloseableBufferAcceptor;
+import org.apache.hyracks.net.protocols.muxdemux.ChannelControlBlock;
+import org.apache.hyracks.net.protocols.muxdemux.FullFrameChannelReadInterface;
+import org.apache.hyracks.util.StorageUtil;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.mockito.Mockito;
+
+@RunWith(Parameterized.class)
+public class 

Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7606/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7606/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8727/ (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2789/ 
(2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5119/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/otZBdy : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10260/ (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4781/
 (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4745/ 
(8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4690/ 
(4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5000/ 
(1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3044

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..

[NO ISSUE][OTH] Pass Request Parameters To Extensions

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Pass request parameters to create/drop dataverse
  statements to allow extensions to use optional
  request parameters.

Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/44/3044/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index 8e86b9c..f619ab6 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@ -309,7 +309,7 @@
 activeDataverse = 
handleUseDataverseStatement(metadataProvider, stmt);
 break;
 case CREATE_DATAVERSE:
-handleCreateDataverseStatement(metadataProvider, stmt);
+handleCreateDataverseStatement(metadataProvider, stmt, 
requestParameters);
 break;
 case DATASET_DECL:
 handleCreateDatasetStatement(metadataProvider, stmt, 
hcc, requestParameters);
@@ -324,7 +324,7 @@
 handleCreateNodeGroupStatement(metadataProvider, stmt);
 break;
 case DATAVERSE_DROP:
-handleDataverseDropStatement(metadataProvider, stmt, 
hcc);
+handleDataverseDropStatement(metadataProvider, stmt, 
hcc, requestParameters);
 break;
 case DATASET_DROP:
 handleDatasetDropStatement(metadataProvider, stmt, 
hcc, requestParameters);
@@ -466,7 +466,8 @@
 }
 }
 
-protected void handleCreateDataverseStatement(MetadataProvider 
metadataProvider, Statement stmt) throws Exception {
+protected void handleCreateDataverseStatement(MetadataProvider 
metadataProvider, Statement stmt,
+IRequestParameters requestParameters) throws Exception {
 CreateDataverseStatement stmtCreateDataverse = 
(CreateDataverseStatement) stmt;
 String dvName = stmtCreateDataverse.getDataverseName().getValue();
 MetadataTransactionContext mdTxnCtx = 
MetadataManager.INSTANCE.beginTransaction();
@@ -1227,7 +1228,7 @@
 }
 
 protected void handleDataverseDropStatement(MetadataProvider 
metadataProvider, Statement stmt,
-IHyracksClientConnection hcc) throws Exception {
+IHyracksClientConnection hcc, IRequestParameters 
requestParameters) throws Exception {
 DataverseDropStatement stmtDelete = (DataverseDropStatement) stmt;
 SourceLocation sourceLoc = stmtDelete.getSourceLocation();
 String dataverseName = stmtDelete.getDataverseName().getValue();

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4779/ 
(3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5349/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Pass Request Parameters To Extensions

2018-11-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Pass Request Parameters To Extensions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5165/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3044
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No