Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Ali Alsuliman has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Code-Review-1 Hold on. Feeds don't seem to work properly when I connect many datasets. I will try separating them and see. -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/62zaEj : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7648/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/13/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3046 to look at the new patch set (#4). Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. [ASTERIXDB-2476][COMP] Array slicing parser syntax - user model changes: yes - storage format changes: no - interface changes: no Details: - Added slice parser syntax. [list][start:end], the syntax accepts end expression as an optional argument, the expression can be written as [list][start:]. - Added slice parser test cases. Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_01/list-slice_01.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_01/list-slice_01.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_01/list-slice_01.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_02/list-slice_02.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_02/list-slice_02.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_02/list-slice_02.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_03/list-slice_03.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_03/list-slice_03.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_03/list-slice_03.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/list/list-slice_01/list-slice_01.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/list/list-slice_02/list-slice_02.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/list/list-slice_03/list-slice_03.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/Expression.java A asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/ListSliceExpression.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppInlineUdfsVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckDatasetOnlyResolutionVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckSql92AggregateVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckSubqueryVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/DeepCopyVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/FreeVariableVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppCloneAndSubstituteVariablesVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppFormatPrintVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppAstVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppSimpleExpressionVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/ISqlppVisitor.java M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java 34 files changed, 646 insertions(+), 10 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/46/3046/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5163/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5391/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Analytics Compatibility Compilation Successful https://goo.gl/Jg8U4k : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/243/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4826/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7648/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4821/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/237/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4787/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5207/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10303/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2831/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4732/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5042/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8770/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/AoWK1m : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3837/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7647/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3837/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/12/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/skv68x : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Tracer improvements
Ali Alsuliman has posted comments on this change.
Change subject: [NO ISSUE] Tracer improvements
..
Patch Set 2:
(6 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3064/2/asterixdb/asterix-app/src/test/resources/log4j2-asterixdb-test.xml
File asterixdb/asterix-app/src/test/resources/log4j2-asterixdb-test.xml:
PS2, Line 41: level="ALL"
Is there a reason we're setting this as ALL?
https://asterix-gerrit.ics.uci.edu/#/c/3064/2/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Event.java
File
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Event.java:
PS2, Line 80: "".equals(args)
Use isEmpty().
https://asterix-gerrit.ics.uci.edu/#/c/3064/2/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java
File
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java:
PS2, Line 24: void stop();
No need for this. The closing "]" is optional as per the tracer spec doc.
https://asterix-gerrit.ics.uci.edu/#/c/3064/2/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java
File
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java:
PS2, Line 41: forName("TRACER", 600);
Is there a reason we're changing the level from INFO to a custom one?
PS2, Line 58: LOGGER.log(TRACE_LOG_LEVEL, "[");
Use "header" in the pattern layout. Also, LOGGER logs "[" while traceLog logs
"]" in the stop method. Is this by mistake?
PS2, Line 109: ","
Put it in the pattern layout. There are some callers who expect the message to
be logged without the comma.
--
To view, visit https://asterix-gerrit.ics.uci.edu/3064
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81c158fcd17927d65e7b501345fdbc98001ba86a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5162/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2830/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5041/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4825/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7647/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Ali Alsuliman has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/3069 Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. [NO ISSUE][ING][EXT] Include count in test cases for meta() filter - user model changes: no - storage format changes: no - interface changes: no Details: This patch is to modify the test cases for feed with filter on meta() to include the count to check the number of tuples correctly ingested. Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec --- M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.11.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.12.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.13.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.14.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.15.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.16.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.17.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.4.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.5.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.6.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.7.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.8.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.9.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.11.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.12.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.13.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.14.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.15.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.16.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.17.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.4.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.5.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.6.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.7.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.8.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.9.adm 28 files changed, 98 insertions(+), 98 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/69/3069/1 diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-filter-on-meta/change-feed-with-filter-on-meta.11.query.sqlpp b/asterixdb/a
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4786/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/242/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5390/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5206/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4731/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4820/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10302/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8769/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/236/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-2490) Support Inter Cluster Secure Connections
[ https://issues.apache.org/jira/browse/ASTERIXDB-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716044#comment-16716044 ] ASF subversion and git services commented on ASTERIXDB-2490: Commit 595a0f3e8496f9f095146764bf6dc0ac33f1df58 in asterixdb's branch refs/heads/master from [~mhubail] [ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=595a0f3 ] [ASTERIXDB-2490][NET] Support Encrypted IPC Connections - user model changes: no - storage format changes: no - interface changes: yes Details: - Add CC/NC options to support SSL connections. - Add APIS to support secured connections. - Support encrypted connections for CC/NC IPCs. - Add keys/certificates for testing. - Add SqlppExecutionTest with SSL connections enabled. - Sort imports. Change-Id: I7007a9be25287a94c5936d440355cfedb8e032b9 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3052 Sonar-Qube: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Contrib: Jenkins Reviewed-by: Murtadha Hubail Reviewed-by: Michael Blow > Support Inter Cluster Secure Connections > > > Key: ASTERIXDB-2490 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2490 > Project: Apache AsterixDB > Issue Type: Improvement > Components: NET - Network >Affects Versions: 0.9.5 >Reporter: Murtadha Hubail >Assignee: Murtadha Hubail >Priority: Major > Fix For: 0.9.5 > > > Add the option to use encrypted connections between CC and NCs within a > cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2490][NET] Support Encrypted IPC Connections
Murtadha Hubail has submitted this change and it was merged. Change subject: [ASTERIXDB-2490][NET] Support Encrypted IPC Connections .. [ASTERIXDB-2490][NET] Support Encrypted IPC Connections - user model changes: no - storage format changes: no - interface changes: yes Details: - Add CC/NC options to support SSL connections. - Add APIS to support secured connections. - Support encrypted connections for CC/NC IPCs. - Add keys/certificates for testing. - Add SqlppExecutionTest with SSL connections enabled. - Sort imports. Change-Id: I7007a9be25287a94c5936d440355cfedb8e032b9 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3052 Sonar-Qube: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Contrib: Jenkins Reviewed-by: Murtadha Hubail Reviewed-by: Michael Blow --- M asterixdb/asterix-app/pom.xml M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ServletUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/api/common/SslAsterixHyracksIntegrationUtil.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SslSqlppExecutionTest.java A asterixdb/asterix-app/src/test/resources/cc-ssl.conf M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm A asterixdb/asterix-app/src/test/resources/security/cc/cc.crt A asterixdb/asterix-app/src/test/resources/security/cc/cc.jks A asterixdb/asterix-app/src/test/resources/security/cc/cc.key A asterixdb/asterix-app/src/test/resources/security/cc/cc.p12 A asterixdb/asterix-app/src/test/resources/security/nc1/asterix_nc1.crt A asterixdb/asterix-app/src/test/resources/security/nc1/asterix_nc1.jks A asterixdb/asterix-app/src/test/resources/security/nc1/asterix_nc1.key A asterixdb/asterix-app/src/test/resources/security/nc1/asterix_nc1.p12 A asterixdb/asterix-app/src/test/resources/security/nc2/asterix_nc2.crt A asterixdb/asterix-app/src/test/resources/security/nc2/asterix_nc2.jks A asterixdb/asterix-app/src/test/resources/security/nc2/asterix_nc2.key A asterixdb/asterix-app/src/test/resources/security/nc2/asterix_nc2.p12 A asterixdb/asterix-app/src/test/resources/security/root/root.truststore A asterixdb/asterix-app/src/test/resources/security/root/rootCA.crt A asterixdb/asterix-app/src/test/resources/security/root/rootCA.key A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/network/INetworkSecurityConfig.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/network/INetworkSecurityManager.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/network/ISocketChannel.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/network/ISocketChannelFactory.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/IControllerService.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/result/ResultDirectory.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/result/ResultSet.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractIntegrationTest.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractMultiNCIntegrationTest.java M hyracks-fullstack/hyracks/hyracks-hdfs/src/test/java/org/apache/hyracks/hdfs/utils/HyracksUtils.java M hyracks-fullstack/hyracks/hyracks-hdfs/src/test/java/org/apache/hyracks/hdfs2/dataflow/DataflowTest.java M hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/Hyr
Change in asterixdb-bad[master]: [ASTERIXDB-2490][BAD] Coordinated Change For Encrypted IPC
Murtadha Hubail has submitted this change and it was merged. Change subject: [ASTERIXDB-2490][BAD] Coordinated Change For Encrypted IPC .. [ASTERIXDB-2490][BAD] Coordinated Change For Encrypted IPC Change-Id: I3792fc7937aec09a263b365b50f281c9aca9b883 --- M asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins: Verified Michael Blow: Looks good to me, approved Murtadha Hubail: Looks good to me, but someone else must approve diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java b/asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java index d2a6613..3fab8ba 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java @@ -145,12 +145,12 @@ listener.suspend(); activeEventHandler.registerListener(listener); BADJobService.redeployJobSpec(entityId, procedure.getBody(), metadataProvider, badStatementExecutor, hcc, -new RequestParameters( -new ResultSet(hcc, appCtx.getCompilerProperties().getFrameSize(), -ResultReader.NUM_READERS), +new RequestParameters(new ResultSet(hcc, + appCtx.getServiceContext().getControllerService().getNetworkSecurityManager() +.getSocketChannelFactory(), appCtx.getCompilerProperties().getFrameSize(), +ResultReader.NUM_READERS), new ResultProperties(IStatementExecutor.ResultDelivery.IMMEDIATE), -new IStatementExecutor.Stats(), null, null, null, null, true), -true); +new IStatementExecutor.Stats(), null, null, null, null, true), true); metadataProvider.getLocks().unlock(); //Log that the procedure stopped by cluster restart. Procedure is available again now. LOGGER.log(Level.SEVERE, entityId.getExtensionName() + " " + entityId.getDataverse() + "." -- To view, visit https://asterix-gerrit.ics.uci.edu/3060 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3792fc7937aec09a263b365b50f281c9aca9b883 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3836/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3836/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4824/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3065 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2490][NET] Support Encrypted IPC Connections
Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2490][NET] Support Encrypted IPC Connections .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3052 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7007a9be25287a94c5936d440355cfedb8e032b9 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4823/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3835/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3835/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4822/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/Vk7TeK : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7646/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/11/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5161/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/235/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4821/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/G2T3zj : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7646/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5205/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4785/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4819/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10301/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8768/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2829/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4730/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/241/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5389/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5040/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Xikui Wang has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3068
Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields
..
[NO ISSUE][EXT] Fix JRecord setField for open fields
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
setField method should be friendly to open fields.
Change-Id: I4ec185d62e78e8100215334bc656586268314797
---
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
2 files changed, 2 insertions(+), 7 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/68/3068/1
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
index 4402130..464ecb2 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
@@ -35,8 +35,7 @@
};
create type DetectResultType as open{
-id:int64,
-sensitive: boolean
+id:int64
};
create dataset EmpDataset(InputRecordType) primary key id;
diff --git
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
index 7fa9d0b..10c228d 100644
---
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
+++
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
@@ -99,11 +99,7 @@
if (pos >= 0) {
fields[pos] = fieldValue;
} else {
-if (openFields.get(fieldName) != null) {
-openFields.put(fieldName, fieldValue);
-} else {
-throw new
RuntimeDataException(ErrorCode.LIBRARY_JAVA_JOBJECTS_UNKNOWN_FIELD, fieldName);
-}
+openFields.put(fieldName, fieldValue);
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/3068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang
