Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Analytics Compatibility Tests Failed https://goo.gl/YHvc4a : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Analytics Compatibility Tests Failed https://goo.gl/icCfvx : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-2496) Error response to an overly large object is very misleading
[ https://issues.apache.org/jira/browse/ASTERIXDB-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718473#comment-16718473 ] Michael J. Carey commented on ASTERIXDB-2496: - [https://firebase.google.com/docs/database/web/structure-data|http://example.com] > Error response to an overly large object is very misleading > --- > > Key: ASTERIXDB-2496 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2496 > Project: Apache AsterixDB > Issue Type: Bug > Components: *DB - AsterixDB, FAIL - Failure handling/reporting, HYR > - Hyracks >Affects Versions: 0.9.4 >Reporter: Michael J. Carey >Assignee: Till >Priority: Major > Fix For: 0.9.5 > > > If you try to LOAD a JSON object that exceeds the system's limit, it > complains as follows: > ASX3021: Malformed input stream [HyracksDataException] > This is not very helpful to users - I spent awhile today with one such user. > He had been given a "data set" in the form of a JSON dump file from Firebase, > and it contained exactly one HUGE JSON document. That object was about 90MB, > but it was not malformed - it was perfectly good JSON that was parsable by > Javascript's JSON parser, so the user was puzzled. > In this case the system should have reported that the size was the problem, > e.g., "Incoming object exceeded system size limit". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (ASTERIXDB-2496) Error response to an overly large object is very misleading
[ https://issues.apache.org/jira/browse/ASTERIXDB-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718472#comment-16718472 ] Michael J. Carey edited comment on ASTERIXDB-2496 at 12/12/18 5:08 AM: --- (The JSON object was probably the most ill-designed example of JSON that I have ever seen - but - very interesting, and thought-provoking. :)) was (Author: dtabass): (The JSON object was probably the most ill-designed example of JSON that I have ever seen - but - very interested, and thought-provoking. :)) > Error response to an overly large object is very misleading > --- > > Key: ASTERIXDB-2496 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2496 > Project: Apache AsterixDB > Issue Type: Bug > Components: *DB - AsterixDB, FAIL - Failure handling/reporting, HYR > - Hyracks >Affects Versions: 0.9.4 >Reporter: Michael J. Carey >Assignee: Till >Priority: Major > Fix For: 0.9.5 > > > If you try to LOAD a JSON object that exceeds the system's limit, it > complains as follows: > ASX3021: Malformed input stream [HyracksDataException] > This is not very helpful to users - I spent awhile today with one such user. > He had been given a "data set" in the form of a JSON dump file from Firebase, > and it contained exactly one HUGE JSON document. That object was about 90MB, > but it was not malformed - it was perfectly good JSON that was parsable by > Javascript's JSON parser, so the user was puzzled. > In this case the system should have reported that the size was the problem, > e.g., "Incoming object exceeded system size limit". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ASTERIXDB-2496) Error response to an overly large object is very misleading
[ https://issues.apache.org/jira/browse/ASTERIXDB-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718472#comment-16718472 ] Michael J. Carey commented on ASTERIXDB-2496: - (The JSON object was probably the most ill-designed example of JSON that I have ever seen - but - very interested, and thought-provoking. :)) > Error response to an overly large object is very misleading > --- > > Key: ASTERIXDB-2496 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2496 > Project: Apache AsterixDB > Issue Type: Bug > Components: *DB - AsterixDB, FAIL - Failure handling/reporting, HYR > - Hyracks >Affects Versions: 0.9.4 >Reporter: Michael J. Carey >Assignee: Till >Priority: Major > Fix For: 0.9.5 > > > If you try to LOAD a JSON object that exceeds the system's limit, it > complains as follows: > ASX3021: Malformed input stream [HyracksDataException] > This is not very helpful to users - I spent awhile today with one such user. > He had been given a "data set" in the form of a JSON dump file from Firebase, > and it contained exactly one HUGE JSON document. That object was about 90MB, > but it was not malformed - it was perfectly good JSON that was parsable by > Javascript's JSON parser, so the user was puzzled. > In this case the system should have reported that the size was the problem, > e.g., "Incoming object exceeded system size limit". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ASTERIXDB-2496) Error response to an overly large object is very misleading
Michael J. Carey created ASTERIXDB-2496: --- Summary: Error response to an overly large object is very misleading Key: ASTERIXDB-2496 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2496 Project: Apache AsterixDB Issue Type: Bug Components: *DB - AsterixDB, FAIL - Failure handling/reporting, HYR - Hyracks Affects Versions: 0.9.4 Reporter: Michael J. Carey Assignee: Till Fix For: 0.9.5 If you try to LOAD a JSON object that exceeds the system's limit, it complains as follows: ASX3021: Malformed input stream [HyracksDataException] This is not very helpful to users - I spent awhile today with one such user. He had been given a "data set" in the form of a JSON dump file from Firebase, and it contained exactly one HUGE JSON document. That object was about 90MB, but it was not malformed - it was perfectly good JSON that was parsable by Javascript's JSON parser, so the user was puzzled. In this case the system should have reported that the size was the problem, e.g., "Incoming object exceeded system size limit". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/nEHUuq : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7658/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3846/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5174/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3846/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/26/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/249/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5218/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3046/6/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/ListSliceExpression.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/ListSliceExpression.java: Line 19: package org.apache.asterix.lang.sqlpp.expression; > Let's move it to org.apache.asterix.lang.common.expression package, because On second thought, if it's too much work to have it the common expression package because it'll require too many AQL changes, then we can leave it here as a SQL++ only feature. -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5173/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Dmitry Lychagin has posted comments on this change.
Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax
..
Patch Set 6:
(9 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3046/6/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java:
Line 1113:
langExprToAlgExpression(expression.getStartIndexExpression(), tupSource);
I think you need to give it expressionPair.second instead of tupSource. Seems
like IndexAccessor translation has a bug that it does not do that. We should
fix that too (and may be do all IndexAccessor fixes in a separate change?). Try
giving subqueries as start index / end index exprs, to verify this.
Line 1119: endIndexPair =
langExprToAlgExpression(expression.getEndIndexExpression(), tupSource);
should be startIndexPair.second instead of tupSource
Line 1137: a.getInputs().add(expressionPair.second);
the assign input should either be startIndexPair.second or endIndexPair.second
if end index exists.
https://asterix-gerrit.ics.uci.edu/#/c/3046/6/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/ListSliceExpression.java
File
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/ListSliceExpression.java:
Line 19: package org.apache.asterix.lang.sqlpp.expression;
Let's move it to org.apache.asterix.lang.common.expression package, because
FieldAccessor and IndexAccessor are there already. (so as ListConstructor).
Line 72: return 31 * super.hashCode() +
Objects.hash(startIndexExpression) + Objects.hash(endIndexExpression);
Why not "Objects.hash(startIndexExpression, endIndexExpression)" ?
https://asterix-gerrit.ics.uci.edu/#/c/3046/6/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java
File
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java:
Line 412: public Void visit(ListSliceExpression expression, Void arg)
throws CompilationException {
let's also fix parent GatherFunctionCallsVisitor to visit IndexAccessor's index
expression
https://asterix-gerrit.ics.uci.edu/#/c/3046/6/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckSql92AggregateVisitor.java
File
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckSql92AggregateVisitor.java:
Line 128: return expression.getExpr().accept(this, parentSelectBlock);
Need to visit both start and end index expressions too here. Let's fix
visit(IndexAccessor) above too, so it visits it's index expression if it exists
https://asterix-gerrit.ics.uci.edu/#/c/3046/6/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/ISqlppVisitor.java
File
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/ISqlppVisitor.java:
Line 72: R visit(ListSliceExpression ria, T arg) throws
CompilationException;
Once we move ListSliceExpression to the common package this method will also
need to be moved into ILangVisitor
https://asterix-gerrit.ics.uci.edu/#/c/3046/6/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj:
Line 2301: LOOKAHEAD(ListSliceExpression(accessor != null ? accessor :
expr))
we don't need an expensive syntactic LOOKAHEAD here if we go back to the
previous version of the grammar where we extended IndexAccessor production to
handle slicing. We just need to fix the issue that Ali mentioned there (I
confirmed it with him). So the IndexAccessor production should become: “[”
first_expr ( “:” second_expr?) ? “]” and return AbstractAccessor type.
Once you see ":" set a boolean flag indicating that we need to return a
ListSliceExpression. That expression may or may not have a second_expr. If we
did not see ":" then return IndexAccessor
--
To view, visit https://asterix-gerrit.ics.uci.edu/3046
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Jenkins
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2842/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4837/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/254/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/248/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8780/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5402/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7658/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4836/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4798/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/3YR9AZ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8781/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5053/ (4/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4743/ (1/3) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10314/ (2/5) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4832/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4742/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2841/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4831/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/253/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5217/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10313/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5401/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5052/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4797/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3068 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/fytNhr : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: (1 comment) BAD tests failed, you probably need to rebase https://asterix-gerrit.ics.uci.edu/#/c/3072/2//COMMIT_MSG Commit Message: PS2, Line 14: incline should be "inline" -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7657/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Contrib-2 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3845/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3845/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5172/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/25/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5051/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7657/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4830/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4835/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/zxXPCs : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2840/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4796/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5400/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8779/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3072 to look at the new patch set (#2). Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds - user model changes: no - storage format changes: no - interface changes: no LET is not necessary for applying functions to data feeds. We could incline the function calls when constructing the pipeline query. Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.3.lib.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.4.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.5.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/udf_filter_on_feed/udf_filter_on_feed.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/validate-default-library/validate-default-library.1.adm A asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFactory.java A asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFunction.java M asterixdb/asterix-external-data/src/test/resources/library_descriptor.xml 11 files changed, 240 insertions(+), 16 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/72/3072/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/247/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/252/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10312/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5216/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4741/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/fKqNKE : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3844/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5171/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3844/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/24/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration .. Patch Set 5: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/23/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Armin Balalaie Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/246/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7655/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration .. Patch Set 5: -Integration-Tests Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/23/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Armin Balalaie Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Tracer improvements
Ian Maxon has posted comments on this change.
Change subject: [NO ISSUE] Tracer improvements
..
Patch Set 2:
(6 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3064/2/asterixdb/asterix-app/src/test/resources/log4j2-asterixdb-test.xml
File asterixdb/asterix-app/src/test/resources/log4j2-asterixdb-test.xml:
PS2, Line 41: level="ALL"
> Is there a reason we're setting this as ALL?
Yeah guess it should be at TRACE.
https://asterix-gerrit.ics.uci.edu/#/c/3064/2/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Event.java
File
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Event.java:
PS2, Line 80: "".equals(args)
> Use isEmpty().
Done
https://asterix-gerrit.ics.uci.edu/#/c/3064/2/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java
File
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java:
PS2, Line 24: void stop();
> No need for this. The closing "]" is optional as per the tracer spec doc.
Sure.
https://asterix-gerrit.ics.uci.edu/#/c/3064/2/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java
File
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java:
PS2, Line 41: forName("TRACER", 600);
> Is there a reason we're changing the level from INFO to a custom one?
Yeah, more or less for the same reason ACCESS is it's own level. It should make
it easier to differentiate from other types of logs for routing purposes.
PS2, Line 58: LOGGER.log(TRACE_LOG_LEVEL, "[");
> Use "header" in the pattern layout. Also, LOGGER logs "[" while traceLog lo
Yeah that is odd. It works somehow? Not intentional though.
PS2, Line 109: ","
> Put it in the pattern layout. There are some callers who expect the message
Sure.
--
To view, visit https://asterix-gerrit.ics.uci.edu/3064
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81c158fcd17927d65e7b501345fdbc98001ba86a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon
Gerrit-Reviewer: Jenkins
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/22/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4834/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7656/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5215/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2839/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/5PNgQi : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5050/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4740/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5399/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/251/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Xikui Wang has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3072
Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
..
[ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
- user model changes: no
- storage format changes: no
- interface changes: no
LET is not necessary for applying functions to data feeds. We could
incline the function calls when constructing the pipeline query.
Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.1.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.2.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.3.lib.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.4.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.5.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/udf_filter_on_feed/udf_filter_on_feed.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/validate-default-library/validate-default-library.1.adm
A
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFactory.java
A
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFunction.java
M asterixdb/asterix-external-data/src/test/resources/library_descriptor.xml
11 files changed, 251 insertions(+), 15 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/72/3072/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
index 593d7ce..1049e66 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
@@ -184,8 +184,8 @@
argExprs.add(new LiteralExpr(new IntegerLiteral((Integer)
arg)));
} else if (arg instanceof String) {
argExprs.add(new LiteralExpr(new StringLiteral((String) arg)));
-} else if (arg instanceof VariableExpr) {
-argExprs.add((VariableExpr) arg);
+} else if (arg instanceof Expression) {
+argExprs.add((Expression) arg);
}
}
return argExprs;
@@ -216,25 +216,28 @@
whereClause = new WhereClause(whereClauseQuery.getBody());
}
-// TODO: This can be the place to add select predicate for ingestion
// Attaching functions
int varIdx = 1;
-VariableExpr previousVarExpr = fromTermLeftExpr;
-ArrayList letClauses = new ArrayList<>();
-for (FunctionSignature funcSig : feedConnection.getAppliedFunctions())
{
-VarIdentifier intermediateVar = SqlppVariableUtil
-
.toInternalVariableIdentifier(FEED_DATAFLOW_INTERMEIDATE_VAL_PREFIX +
String.valueOf(varIdx));
-VariableExpr intermediateVarExpr = new
VariableExpr(intermediateVar);
-CallExpr functionCallExpr = new CallExpr(funcSig,
addArgs(previousVarExpr));
-previousVarExpr = intermediateVarExpr;
-LetClause letClause = new LetClause(intermediateVarExpr,
functionCallExpr);
-letClauses.add(letClause);
-varIdx++;
+Expression previousVarExpr = fromTermLeftExpr;
+for (FunctionSignature functionSignature :
feedConnection.getAppliedFunctions()) {
+CallExpr functionCallExpr = new CallExpr(functionSignature,
addArgs(previousVarExpr));
+previousVarExpr = functionCallExpr;
}
+//ArrayList letClauses = new ArrayList<>();
+//for (FunctionSignature funcSig :
feedConnection.getAppliedFunctions()) {
+//VarIdentifier intermediateVar = SqlppVariableUtil
+//
.toInternalVariableIdentifier(FEED_DATAFLOW_INTERMEIDATE_VAL_PREFIX +
String.valueOf(varIdx));
+//VariableExpr intermediateVarExpr = new
VariableExpr(intermediateVar);
+//CallExpr functionCallExpr = new CallExpr(funcSig,
addArgs(previousVarExpr));
+//previousVarExpr = intermediateVarExpr;
+//LetClause letClause = new LetClause(intermediateVarExpr,
functionCallExpr);
+//letClauses.add(letClause);
+//
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8778/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4829/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10311/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4795/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-2495) Avoid LET in applying functions in data feeds
Xikui Wang created ASTERIXDB-2495: - Summary: Avoid LET in applying functions in data feeds Key: ASTERIXDB-2495 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2495 Project: Apache AsterixDB Issue Type: Bug Reporter: Xikui Wang This makes sure that applying function and filtering incoming tuples can work together. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Hussain Towaileb has posted comments on this change.
Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax
..
Patch Set 6:
(10 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3046/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:
PS3, Line 760: case VA
> I don't think we're using "any" (i.e. ?). This should be removed.
Done.
Checks are only for optional parameter.
PS3, Line 765:
> Better to call it startIndexPair
Done.
PS3, Line 767: ression(
> Need to check if the end position is supplied first and then translate it.
Done
PS3, Line 770:
> Need to make the right choice whether it's WITH or WITHOUT function based o
Done
PS3, Line 773: args.add(new MutableObject<>(eo.first));
> Depends on whether it WITH or WITHOUT function
Done
https://asterix-gerrit.ics.uci.edu/#/c/3046/3/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_01/list-slice_01.3.query.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-slice_01/list-slice_01.3.query.sqlpp:
PS3, Line 20: use test;
> Can we add a test case without end position?
Done, also added further test cases in the other test files.
Only missing test is using a SELECT subquery, it's causing an exception, I'm
still debugging it.
https://asterix-gerrit.ics.uci.edu/#/c/3046/3/asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/visitor/base/AbstractAqlSimpleExpressionVisitor.java
File
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/visitor/base/AbstractAqlSimpleExpressionVisitor.java:
PS3, Line 56:
> I believe slice syntax is only for SQL++. Check WindowExpression and see ho
Done, all classes and changes were moved to the SQL++ classes, no changes on
AQL files.
https://asterix-gerrit.ics.uci.edu/#/c/3046/3/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/RangeIndexAccessor.java
File
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/RangeIndexAccessor.java:
PS3, Line 28:
> I believe this should be removed based on the slice syntax. We're returning
Done.
PS3, Line 34:
> startIndexExpression cannot be null. We have to have it.
Done.
Only null option is for the end expression argument which is an optional
parameter.
https://asterix-gerrit.ics.uci.edu/#/c/3046/3/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj:
PS3, Line 2340: }
: }
: )
:
: {
: IndexAccessor ia = new IndexAccessor(inputExpr, expr);
: return addSourceLocation(ia, startToken);
: }
: }
:
: ListSliceExpression ListSliceExpression(Expression
inputExpression) throws ParseException:
: {
: Token startToken = null;
: Ex
> I think there is a problem in the grammar now. With this, the slice syntax
Done.
Also, the expression is completely decoupled now from the Index expression.
--
To view, visit https://asterix-gerrit.ics.uci.edu/3046
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Jenkins
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5214/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5170/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/250/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7655/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/MsYzba : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4828/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax .. Patch Set 6: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/ND9rjg : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4833/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING][EXT] Include count in test cases for meta() ...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING][EXT] Include count in test cases for meta() filter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/245/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c258e00b869facaeeaf2dc47d227c304eefaec Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration .. Patch Set 5: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/21/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Armin Balalaie Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
