Change in asterixdb[master]: [NO ISSUE] Tracer improvements

2018-12-13 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has posted comments on this change.

Change subject: [NO ISSUE] Tracer improvements
..


Patch Set 3:

(18 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3064/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java:

PS3, Line 186: }
Could we remove this file from the commit now that there are no changes to it?


https://asterix-gerrit.ics.uci.edu/#/c/3064/3/asterixdb/asterix-app/src/main/resources/log4j2.xml
File asterixdb/asterix-app/src/main/resources/log4j2.xml:

PS3, Line 22: "600"
Well, if you're changing it to 600, then that's basically log4j's TRACE which 
has the same level. Either remove this custom level and use log4j's TRACE, or 
really give it a different custom level than provided by log4j.


PS3, Line 32: "%m%n"
I'm assuming you don't want the comma in the console output.


PS3, Line 35: "%m%n"
Shouldn't this have a comma in between? we should try to keep this .xml config 
file and the code configuring the logging in sync as much as possible, at least 
to avoid confusion.


PS3, Line 46: name="org.apache.hyracks.util.trace"
Change this to match the one in the code (i.e. 
org.apache.hyracks.util.trace.Tracer.Traces). We only want the "traceLog" 
logger embedded inside Tracer to use this setup (Also Tracer.java has its own 
LOGGER which should log normally like any other loggers).


https://asterix-gerrit.ics.uci.edu/#/c/3064/3/asterixdb/asterix-app/src/test/resources/log4j2-asterixdb-test.xml
File asterixdb/asterix-app/src/test/resources/log4j2-asterixdb-test.xml:

PS3, Line 31: "%m%n"
I'm assuming you don't want the comma in the console output.


PS3, Line 41: org.apache.hyracks.util.trace.Tracer
Change this to "org.apache.hyracks.util.trace.Tracer.Traces". You don't want 
the Tracer.java LOGGER to use this setup. You want the embedded traceLog logger 
to use this setup.


PS3, Line 41: level="TRACER"
I don't think this will work. How is this file referencing a custom level 
defined in another file?


https://asterix-gerrit.ics.uci.edu/#/c/3064/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java:

PS3, Line 82: 500
500 here but 600 in the .xml file? Also, 500 is already log4j's DEBUG. We 
should either use DEBUG or give this custom level TRACER a different level.


https://asterix-gerrit.ics.uci.edu/#/c/3064/3/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java
File 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java:

PS3, Line 85: @Override
Can we remove this file from the commit?


https://asterix-gerrit.ics.uci.edu/#/c/3064/3/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java
File 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java:

PS3, Line 32: import static org.apache.logging.log4j.Level.INFO;
Can we also remove this import after reverting the below changes?


PS3, Line 33: import static org.apache.logging.log4j.Level.TRACE;
Can we remove this unused import?


PS3, Line 38: Tracer
Could you make all of the below variables private?


PS3, Line 42: 500
500 here but 600 in the .xml file? Also 500 is log4j's DEBUG


PS3, Line 48: TraceCategoryRegistry
Could you make this final?


PS3, Line 54: log(INFO, 
This is effectively the same as the original one, LOGGER.info(). Can we revert 
this?


PS3, Line 59: traceLog.log(TRACE_LOG_LEVEL, "[");
I think this should be part of the layout definition (whether you're doing it 
in the code programmatically or in the .xml file). Have you tried "header" and 
it didn't work?


PS3, Line 70: log(INFO, 
Same here


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3064
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81c158fcd17927d65e7b501345fdbc98001ba86a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/SAs7LS : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3855/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7688/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/47/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3855/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5204/
 (14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/286/
 (4/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4776/ 
(7/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10346/ (10/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4871/
 (13/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/AAGddC : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7688/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/279/
 (12/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5085/ 
(3/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8813/ (2/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2874/ 
(6/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5248/ 
(9/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/20/ 
(11/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5434/ (1/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Wail Alkowaileet (Code Review)
Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3088

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..

[ASTERIXDB-2492][TXN] Skip filter update on undo

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Filter values should not be undone on UPDATE as the tuple
does not contain the filtered field.

Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/88/3088/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
index 946815f..3fce4d8 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
@@ -75,7 +75,6 @@
 import org.apache.hyracks.storage.am.common.impls.NoOpIndexAccessParameters;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentId;
 import 
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentId.IdCompareResult;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentIdGenerator;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperation;
 import 
org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperation.LSMIOOperationStatus;
@@ -752,6 +751,8 @@
 ILSMIndex index =
 (ILSMIndex) 
datasetLifecycleManager.getIndex(logRecord.getDatasetId(), 
logRecord.getResourceId());
 ILSMIndexAccessor indexAccessor = 
index.createAccessor(NoOpIndexAccessParameters.INSTANCE);
+ILSMIndexOperationContext opCtx = indexAccessor.getOpContext();
+opCtx.setFilterSkip(true);
 try {
 switch (logRecord.getNewOp()) {
 case 
AbstractIndexModificationOperationCallback.INSERT_BYTE:

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4830/ 
(8/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4864/ 
(5/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7687/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/46/ : 
UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/46/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5203/
 (14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/278/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4863/ 
(4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4870/
 (13/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7687/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5084/ 
(6/8)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4829/ (5/7)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5247/ 
(2/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/19/ 
(12/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5433/ (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2873/ 
(9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8812/ (7/9)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10345/ (3/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4775/ (1/4)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/285/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/mqnGHt : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-...

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-safe
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4869/
 (14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28c8a622b05f486d5c97705ee56587a4347b8752
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

2018-12-13 Thread Ian Maxon (Code Review)
Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4:

Yeah, the filter undo is good. I thought that was already disabled for some 
reason. 
There's a test now to check for the txn logs between upgrades, so when you 
resubmit expect it to give -1 Verified similar to other storage changes.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/bV1xQS : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/W245sx : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/18/ 
(14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4:

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3854/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/17/ 
(14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3854/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/bxLkHD : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

2018-12-13 Thread Wail Alkowaileet (Code Review)
Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4:

Hi Murtadha, 
I will send an email to the dev to discuss this matter and submit a separate 
patch for the undo issue.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2490][NET] Support Encrypted Multiplexed Connections

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2490][NET] Support Encrypted Multiplexed Connections
..


Patch Set 9: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/7RkgXX : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cbed93c162018bad17923d50d4987011cbba16c
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/16/ 
(14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-...

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-safe
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4868/
 (14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28c8a622b05f486d5c97705ee56587a4347b8752
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/15/ 
(14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax
..


Patch Set 6: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/wThTAU : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3046
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2488][COMP] Support aggregate window functions

2018-12-13 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has posted comments on this change.

Change subject: [ASTERIXDB-2488][COMP] Support aggregate window functions
..


Patch Set 2:

(16 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3049/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java:

PS2, Line 1057: List>> 
orderExprListOut = Collections.emptyList();
If it's not much trouble and can be done, can we extract out different sections 
into different private methods to help readability?


https://asterix-gerrit.ics.uci.edu/#/c/3049/2/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/AbstractInlineUdfsVisitor.java
File 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/AbstractInlineUdfsVisitor.java:

PS2, Line 338: protected
private?


PS2, Line 362: protected
private?


https://asterix-gerrit.ics.uci.edu/#/c/3049/2/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/CloneAndSubstituteVariablesVisitor.java
File 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/CloneAndSubstituteVariablesVisitor.java:

PS2, Line 104: null
When gc.hasGroupFieldList() is false, then the original groupFieldList could 
either be null or empty list which probably could happen when we have a GROUP 
AS g only. Is that correct?


https://asterix-gerrit.ics.uci.edu/#/c/3049/2/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/WindowExpression.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/WindowExpression.java:

PS2, Line 35: WindowExpression
If you want, we can override toString()


https://asterix-gerrit.ics.uci.edu/#/c/3049/2/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckSubqueryVisitor.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckSubqueryVisitor.java:

PS2, Line 275: for (Pair field : 
gc.getGroupFieldList()) {
 : if (visit(field.first, arg)) {
 : return true;
 : }
 : }
You could use visitFieldList() if you want, and put it inside the parent "if".


PS2, Line 282: for (Expression expr : gc.getWithVarMap().keySet()) {
 : if (visit(expr, arg)) {
 : return true;
 : }
 : }
You could use visitExprList() if you want. But you would have to change the 
first arg from List<> to Collection<>


https://asterix-gerrit.ics.uci.edu/#/c/3049/2/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/DeepCopyVisitor.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/DeepCopyVisitor.java:

PS2, Line 295: decorPairList
Shouldn't this be set to null to make a true deep copy of the original 
GroupbyClause gc? or is that not the case? It might be worth looking at the 
GroupbyClause and its visitors to see the instance variables and what 
assumptions are made maybe in a separate change.


https://asterix-gerrit.ics.uci.edu/#/c/3049/2/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppFormatPrintVisitor.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppFormatPrintVisitor.java:

PS2, Line 340: windowExpr.hasWindowVar()
Are we missing the window field list? or is that taken care of somewhere else?


https://asterix-gerrit.ics.uci.edu/#/c/3049/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/runningaggregates/std/NtileRunningAggregateEvaluator.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/runningaggregates/std/NtileRunningAggregateEvaluator.java:

PS2, Line 22: import 
org.apache.asterix.dataflow.data.nontagged.serde.ANullSerializerDeserializer
Not used I believe.


https://asterix-gerrit.ics.uci.edu/#/c/3049/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/WindowOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/WindowOperator.java:

PS2, Line 41: 
We could update the doc with the new guys.


https://asterix-gerrit.ics.uci.edu/#/c/3049/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/IsomorphismOperatorVisitor.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/IsomorphismOperatorVisitor.java:

PS2, Line 697: for 

Change in asterixdb[master]: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-...

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-safe
..


Patch Set 3: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/2vTswt : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28c8a622b05f486d5c97705ee56587a4347b8752
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] added parse-only request parameter

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][API] added parse-only request parameter
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/cCrk53 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd2f461c22b05a5fcaa50a6e4f9b7dcd91acc184
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: sandeep.gu...@couchbase.com
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Tracer improvements

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE] Tracer improvements
..


Patch Set 3: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/pjFxi1 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3064
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81c158fcd17927d65e7b501345fdbc98001ba86a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2490][NET] Support Encrypted Multiplexed Connections

2018-12-13 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2490][NET] Support Encrypted Multiplexed Connections
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cbed93c162018bad17923d50d4987011cbba16c
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-...

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-safe
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4867/
 (14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28c8a622b05f486d5c97705ee56587a4347b8752
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3853/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
..


Patch Set 2: -Contrib

Analytics Compatibility Compilation Successful
https://goo.gl/z4SQzT : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7686/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][COMP] Array slicing parser syntax

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2476][COMP] Array slicing parser syntax
..


Patch Set 6: -Contrib

Analytics Compatibility Compilation Successful
https://goo.gl/Rz388Q : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3046
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3853/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][EXT] Fix JRecord setField for open fields

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields
..


Patch Set 2: -Contrib

Analytics Compatibility Compilation Successful
https://goo.gl/NeUzJs : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4: -Contrib

Analytics Compatibility Compilation Successful
https://goo.gl/cxFXQz : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2: -Contrib

Analytics Compatibility Compilation Successful
https://goo.gl/yic2qJ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2490][NET] Support Encrypted Multiplexed Connections

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2490][NET] Support Encrypted Multiplexed Connections
..


Patch Set 9: -Contrib

Analytics Compatibility Compilation Successful
https://goo.gl/aWkc1P : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cbed93c162018bad17923d50d4987011cbba16c
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-XXX][TEST] Adds SpiderSilk Integration
..


Patch Set 5:

Analytics Compatibility Compilation Failed
https://goo.gl/NKDTfR : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] added parse-only request parameter

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][API] added parse-only request parameter
..


Patch Set 1: -Contrib

Analytics Compatibility Compilation Successful
https://goo.gl/izBSwb : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd2f461c22b05a5fcaa50a6e4f9b7dcd91acc184
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: sandeep.gu...@couchbase.com
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Tracer improvements

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE] Tracer improvements
..


Patch Set 3: -Contrib

Analytics Compatibility Compilation Successful
https://goo.gl/x5ngA8 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3064
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81c158fcd17927d65e7b501345fdbc98001ba86a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-...

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-safe
..


Patch Set 3: -Contrib

Analytics Compatibility Compilation Successful
https://goo.gl/ZpJsPM : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28c8a622b05f486d5c97705ee56587a4347b8752
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-...

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-safe
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3852/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28c8a622b05f486d5c97705ee56587a4347b8752
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5083/ 
(5/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-...

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-safe
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3852/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28c8a622b05f486d5c97705ee56587a4347b8752
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5202/
 (14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/277/
 (13/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4866/
 (12/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4828/ 
(6/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4774/ 
(1/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5246/ 
(11/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10344/ (7/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7686/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2: Contrib-2

Analytics Compatibility Compilation Failed
https://goo.gl/s6WLps : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/284/
 (9/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2872/ 
(4/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-...

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-safe
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7685/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28c8a622b05f486d5c97705ee56587a4347b8752
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5432/ (10/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8811/ (3/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/14/ 
(2/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4862/ 
(8/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Murtadha Hubail (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3087

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..

[ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Set the flush LSN of log records before giving it
  to the log flusher to avoid reading invalid value
  if the flush is completed before setting the LSN.
- Ensure log record LSN is thread-safe.
- Warn in case of a flush with LSN = 0.

Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
3 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/87/3087/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-...

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-safe
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/276/
 (13/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28c8a622b05f486d5c97705ee56587a4347b8752
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-...

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2494][RT] Ensure Dataset Ref Counters Are Thread-safe
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5201/
 (14/14)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28c8a622b05f486d5c97705ee56587a4347b8752
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set

2018-12-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7684/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3087
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


  1   2   3   >