Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/GWgGLi : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8093/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/st3oH8 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4044/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4044/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/298/ 
(16/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8092/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8093/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5528/
 (15/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/685/
 (14/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8092/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5682/ 
(13/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5534/ 
(12/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5276/ 
(11/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9266/ (10/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Dmitry Lychagin (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3257

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..

[ASTERIXDB-2528][COMP] Fix illegal state exception in the compiler

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix illegal state exception raised by the compiler when
  a variable used by SQL aggregate function is not mapped
  by GROUP AS clause

Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/sugar-08-negative/sugar-08-negative.1.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/Sql92AggregateFunctionVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppGroupByAggregationSugarVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppWindowAggregationSugarVisitor.java
7 files changed, 86 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/57/3257/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5891/ (9/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5310/
 (8/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/622/
 (7/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://goo.gl/wzXWHh : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10798/ (6/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/481/ (1/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/132/ 
(2/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3324/ 
(3/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5220/ 
(5/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5315/ 
(4/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app-stabilization-f69489/62/
 (9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9265/ (4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/fvaDMo : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5275/ 
(13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/480/ (1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10797/ (7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5309/
 (3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/684/
 (6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3323/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5681/ 
(11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5890/ (12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5533/ 
(5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5314/ 
(10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5219/ 
(2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][COMP] Refactor function lookup in expression tran...

2019-03-08 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3258

Change subject: [NO ISSUE][COMP] Refactor function lookup in expression 
translator
..

[NO ISSUE][COMP] Refactor function lookup in expression translator

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Move function lookup code in LangExpressionToPlanTranslator
  into a separate method so it can be modified by product extensions

Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
1 file changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/58/3258/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
index 91de474..084c774 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
@@ -779,15 +779,8 @@
 }
 
 SourceLocation sourceLoc = fcall.getSourceLocation();
-AbstractFunctionCallExpression f;
-if ((f = lookupUserDefinedFunction(signature, args, sourceLoc)) == 
null) {
-f = lookupBuiltinFunction(signature.getName(), 
signature.getArity(), args, sourceLoc);
-}
 
-if (f == null) {
-throw new CompilationException(ErrorCode.UNKNOWN_FUNCTION, 
sourceLoc,
-signature.getName() + "@" + signature.getArity());
-}
+AbstractFunctionCallExpression f = lookupFunction(signature, args, 
sourceLoc);
 
 // Put hints into function call expr.
 if (fcall.hasHints()) {
@@ -816,6 +809,19 @@
 return varRef;
 }
 
+protected AbstractFunctionCallExpression lookupFunction(FunctionSignature 
signature,
+List> args, SourceLocation sourceLoc) 
throws CompilationException {
+AbstractFunctionCallExpression f;
+if ((f = lookupUserDefinedFunction(signature, args, sourceLoc)) == 
null) {
+f = lookupBuiltinFunction(signature.getName(), 
signature.getArity(), args, sourceLoc);
+}
+if (f == null) {
+throw new CompilationException(ErrorCode.UNKNOWN_FUNCTION, 
sourceLoc,
+signature.getName() + "@" + signature.getArity());
+}
+return f;
+}
+
 private AbstractFunctionCallExpression 
lookupUserDefinedFunction(FunctionSignature signature,
 List> args, SourceLocation sourceLoc) 
throws CompilationException {
 try {

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3258
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Dmitry Lychagin 


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/297/ 
(16/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8091/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8091/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Xikui Wang (Code Review)
Xikui Wang has abandoned this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Abandoned

Not right.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5527/
 (2/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/683/
 (4/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5889/ (14/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/YT9bLX : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5274/ 
(15/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3322/ 
(7/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5532/ 
(13/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5680/ 
(11/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9264/ (12/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5308/
 (1/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3257

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..

[ASTERIXDB-2528][COMP] Fix illegal state exception in the compiler

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix illegal state exception raised by the compiler when
  a variable used by SQL aggregate function is not mapped
  by GROUP AS clause

Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/sugar-08-negative/sugar-08-negative.1.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/Sql92AggregateFunctionVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppGroupByAggregationSugarVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppWindowAggregationSugarVisitor.java
7 files changed, 87 insertions(+), 16 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/57/3257/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/sugar-08-negative/sugar-08-negative.1.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/sugar-08-negative/sugar-08-negative.1.query.sqlpp
new file mode 100644
index 000..7df10ae
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/sugar-08-negative/sugar-08-negative.1.query.sqlpp
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Description: Test error message when a variable used by SQL aggregate
+ *  is not mapped by GROUP AS clause
+ */
+
+from [{"f2":1, "f1":"foo"}] as t
+let x = t.f2 + 1
+group by t.f2
+group as g (t as tt)
+select t.f2, g, sum(x);
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml 
b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 6d90c86..23db0b1 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -4119,6 +4119,12 @@
   
 
 
+  
+core-01
+ASX1103: Illegal use of identifier: x
+  
+
+
   
 null
   
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
index ecf4eff..459773b 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
@@ -189,6 +189,7 @@
 public static final int COMPILATION_UNEXPECTED_WINDOW_EXPRESSION = 1100;
 public static final int COMPILATION_UNEXPECTED_WINDOW_ORDERBY = 1101;
 public static final int COMPILATION_EXPECTED_WINDOW_FUNCTION = 1102;
+public static final int COMPILATION_ILLEGAL_USE_OF_IDENTIFIER = 1103;
 
 // Feed errors
 public static final int DATAFLOW_ILLEGAL_STATE = 3001;
diff --git 
a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties 
b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
index c1b5d47..94d6942 100644
--- a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
+++ b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
@@ -176,6 +176,7 @@
 1100 = Unexpected window expression
 1101 = Unexpected ORDER BY clause in window expression
 1102 = Expected window or aggregate function, got: %1$s
+1103 = Illegal use of identifier: %1$s
 
 # Feed Errors
 3001 = Illegal state.
diff --git 
a

Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5313/ 
(6/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5218/ 
(8/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/479/ (10/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10796/ (5/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/131/ 
(9/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2528][COMP] Fix illegal state exception in the co...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2528][COMP] Fix illegal state exception in the 
compiler
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/621/
 (3/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3257
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


[jira] [Created] (ASTERIXDB-2528) Illegal state exception in the compiler

2019-03-08 Thread Dmitry Lychagin (JIRA)
Dmitry Lychagin created ASTERIXDB-2528:
--

 Summary: Illegal state exception in the compiler
 Key: ASTERIXDB-2528
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2528
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: COMP - Compiler
Reporter: Dmitry Lychagin
Assignee: Dmitry Lychagin


java.lang.Exception: IllegalStateException: []:[$x]

thrown for the following query:

{noformat}
from [{"f2":1, "f1":"foo"}] as t
let x = [9]
group by t.f2
group as g (t as tt)
select t.f2, g, sum(x);
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/296/ 
(16/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8090/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


[jira] [Resolved] (ASTERIXDB-2527) Illegal state error in the compiler

2019-03-08 Thread Dmitry Lychagin (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Lychagin resolved ASTERIXDB-2527.

Resolution: Fixed

> Illegal state error in the compiler
> ---
>
> Key: ASTERIXDB-2527
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2527
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: COMP - Compiler
>Reporter: Dmitry Lychagin
>Assignee: Dmitry Lychagin
>Priority: Major
>
> The following query throws: ASX1038: Illegal state. $x
> {noformat}
> SELECT t
> FROM range(1, 4) t
> WHERE ANY x IN [2, 3] SATISFIES x - t + 2 = x END
> {noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Change in asterixdb[master]: [ASTERIXDB-2527][COMP] Fix illegal state error

2019-03-08 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2527][COMP] Fix illegal state error
..


Patch Set 1: Verified+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3253
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53046ffd104035e36395e8a0fa4c624ccfdedf09
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2527][COMP] Fix illegal state error

2019-03-08 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has submitted this change and it was merged.

Change subject: [ASTERIXDB-2527][COMP] Fix illegal state error
..


[ASTERIXDB-2527][COMP] Fix illegal state error

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix Illegal State error raised by the compiler
  for a query with a quantified expression

Change-Id: I53046ffd104035e36395e8a0fa4c624ccfdedf09
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3253
Reviewed-by: Ali Alsuliman 
Tested-by: Dmitry Lychagin 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/in_as_or/in_as_or.10.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/in_as_or/in_as_or.10.adm
5 files changed, 40 insertions(+), 5 deletions(-)

Approvals:
  Ali Alsuliman: Looks good to me, approved
  Dmitry Lychagin: Verified



diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
index e777c4e..aacffbf 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
@@ -175,7 +175,7 @@
 }
 
 @Override
-protected boolean expressionNeedsNoNesting(Expression expr) {
+protected boolean expressionNeedsNoNesting(Expression expr) throws 
CompilationException {
 boolean isFLWOGR = expr.getKind() == Kind.FLWOGR_EXPRESSION;
 boolean letOnly = true;
 // No nesting is needed for a FLWOR expression that only has LETs and 
RETURN.
diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
index 61c525e..0362820 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
@@ -1667,7 +1667,7 @@
 
 }
 
-protected boolean expressionNeedsNoNesting(Expression expr) {
+protected boolean expressionNeedsNoNesting(Expression expr) throws 
CompilationException {
 Kind k = expr.getKind();
 boolean noNesting = k == Kind.LITERAL_EXPRESSION || k == 
Kind.LIST_CONSTRUCTOR_EXPRESSION
 || k == Kind.RECORD_CONSTRUCTOR_EXPRESSION || k == 
Kind.VARIABLE_EXPRESSION;
diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
index 81f054a..65d59c7 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
@@ -868,7 +868,7 @@
 }
 
 @Override
-protected boolean expressionNeedsNoNesting(Expression expr) {
+protected boolean expressionNeedsNoNesting(Expression expr) throws 
CompilationException {
 return super.expressionNeedsNoNesting(expr) || (translateInAsOr && 
expr.getKind() == Kind.QUANTIFIED_EXPRESSION
 && isInOperatorWithStaticList((QuantifiedExpression) expr));
 }
@@ -884,7 +884,7 @@
 // "some $y in list_expr satisfies $x = $y"
 // Look for such quantified expression with a constant list_expr ([e1, e2, 
... eN])
 // and translate it into "$x=e1 || $x=e2 || ... || $x=eN"
-private boolean isInOperatorWithStaticList(QuantifiedExpression qe) {
+private boolean isInOperatorWithStaticList(QuantifiedExpression qe) throws 
CompilationException {
 if (qe.getQuantifier() != QuantifiedExpression.Quantifier.SOME) {
 return false;
 }
@@ -906,10 +906,17 @@
 if (operandExprs.size() != 2) {
 return false;
 }
-int varPos = operandExprs.indexOf(qp.getVarExpr());
+VariableExpr varExpr = qp.getVarExpr();
+int varPos = operandExprs.indexOf(varExpr);
 if (varPos < 0) {
 return false;
 }
+Expression operandExpr = operandExprs.get(1 - varPos);
+
+if (SqlppRewriteUtil.getFreeVariable(operandExpr).contains(varExpr)) {
+return false;
+}
+
 Exp

Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/6SAK64 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


[jira] [Commented] (ASTERIXDB-2527) Illegal state error in the compiler

2019-03-08 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788275#comment-16788275
 ] 

ASF subversion and git services commented on ASTERIXDB-2527:


Commit ec69fc0740e2c00a95b956e90e666555fcef982a in asterixdb's branch 
refs/heads/master from Dmitry Lychagin
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=ec69fc0 ]

[ASTERIXDB-2527][COMP] Fix illegal state error

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix Illegal State error raised by the compiler
  for a query with a quantified expression

Change-Id: I53046ffd104035e36395e8a0fa4c624ccfdedf09
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3253
Reviewed-by: Ali Alsuliman 
Tested-by: Dmitry Lychagin 


> Illegal state error in the compiler
> ---
>
> Key: ASTERIXDB-2527
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2527
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: COMP - Compiler
>Reporter: Dmitry Lychagin
>Assignee: Dmitry Lychagin
>Priority: Major
>
> The following query throws: ASX1038: Illegal state. $x
> {noformat}
> SELECT t
> FROM range(1, 4) t
> WHERE ANY x IN [2, 3] SATISFIES x - t + 2 = x END
> {noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Change in asterixdb[master]: [ASTERIXDB-2527][COMP] Fix illegal state error

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2527][COMP] Fix illegal state error
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4043/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3253
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53046ffd104035e36395e8a0fa4c624ccfdedf09
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2527][COMP] Fix illegal state error

2019-03-08 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has posted comments on this change.

Change subject: [ASTERIXDB-2527][COMP] Fix illegal state error
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3253
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53046ffd104035e36395e8a0fa4c624ccfdedf09
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/478/ (11/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8090/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3321/ 
(8/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10795/ (6/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/F4mqCT : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5273/ 
(15/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5526/
 (4/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/682/
 (5/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5888/ (7/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/620/
 (9/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5531/ 
(2/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5217/ 
(13/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9263/ (3/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5312/ 
(10/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5307/
 (1/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/130/ 
(12/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5679/ 
(14/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Fix flush in OneFramePushRuntime

2019-03-08 Thread Xikui Wang (Code Review)
Xikui Wang has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3256

Change subject: [NO ISSUE][RT] Fix flush in OneFramePushRuntime
..

[NO ISSUE][RT] Fix flush in OneFramePushRuntime

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
The AbstractOneInputOneOutputOneFramePushRuntime doesn't flush data
records in its flushAndReset() method. This causes the data records are
not flushed as expected if there is a partitioned connected after it. In
data feeds particularly, when the feeding rate is low, the ingested data
will not be able to be queried, even if they are ingested for a very
long time.

Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
---
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputOneOutputOneFramePushRuntime.java
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/56/3256/1

diff --git 
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputOneOutputOneFramePushRuntime.java
 
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputOneOutputOneFramePushRuntime.java
index 71b44d3..81edfe0 100644
--- 
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputOneOutputOneFramePushRuntime.java
+++ 
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputOneOutputOneFramePushRuntime.java
@@ -72,6 +72,7 @@
 protected void flushAndReset() throws HyracksDataException {
 if (appender.getTupleCount() > 0) {
 appender.write(writer, true);
+writer.flush();
 }
 }
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3256
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c2768a41fb9d23f8ce990c8c5c52ec14c2319e5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 


Change in asterixdb[master]: [ASTERIXDB-2527][COMP] Fix illegal state error

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2527][COMP] Fix illegal state error
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/477/ (16/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3253
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53046ffd104035e36395e8a0fa4c624ccfdedf09
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP] Make scalar/primitive comparators singleton...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Make scalar/primitive comparators singleton 
and stateless
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/295/ 
(16/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP] Make scalar/primitive comparators singleton...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Make scalar/primitive comparators singleton 
and stateless
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8089/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP] Make scalar/primitive comparators singleton...

2019-03-08 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] Make scalar/primitive comparators singleton 
and stateless
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/M2AZaC : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP] Make scalar/primitive comparators singleton...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Make scalar/primitive comparators singleton 
and stateless
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8089/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP] Make scalar/primitive comparators singleton...

2019-03-08 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] Make scalar/primitive comparators singleton 
and stateless
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/Yu4gTY : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP] Make scalar/primitive comparators singleton...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Make scalar/primitive comparators singleton 
and stateless
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3320/ 
(11/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP] Make scalar/primitive comparators singleton...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Make scalar/primitive comparators singleton 
and stateless
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP] Make scalar/primitive comparators singleton...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Make scalar/primitive comparators singleton 
and stateless
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5272/ 
(15/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP] Make scalar/primitive comparators singleton...

2019-03-08 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Make scalar/primitive comparators singleton 
and stateless
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5525/
 (8/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


  1   2   >