Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/tstuN6k81C88Fwh2A : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 06:29:02 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8587/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 06:18:12 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/5LJ99VuCrLUfWjnB7 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:10:22 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4437/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:22:44 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9767/ (2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:07 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6031/ 
(16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:10:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4437/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:09:05 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8587/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:08:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5789/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:24 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/749/ 
(12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Murtadha Hubail (Code Review)
Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3401

to look at the new patch set (#2).

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..

[NO ISSUE][API] Return Async Query Results As JSON

- user model changes: yes
- storage format changes: no
- interface changes: yes

Details:
- Add ResultMetadata that can hold metadata about a job's
  result.
- Add required CC functions to get ResultMetadata.
- Add IJobResultCallback that is called when a job's result
  is written successfully.
- Calculate a job's processed objects on the job completion.
- Calculate a job's duration on the job completion.
- Use the async query request format when serving the result
  from QueryResultApiServlet.
- Return a proper JSON envelop in QueryResultApiServlet
  which includes the results as well as metrics fields.
- Add test case for returning JSON response for async
  query.

Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/base/ILangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/ResultMetadata.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultReader.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/resource/PlanStagesGeneratorTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/AsyncDeferredQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/async-json/async-json.1.async.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/async-json/async-json.2.pollget.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/async-json/async-json.3.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/async-json/async-json.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/async-json/async-json.2.regex
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/async-json/async-json.3.json
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DistributeResultOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/OperatorDeepCopyVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/DistributeResultPOperator.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/ICCApplication.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java
A 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/IJobResultCallback.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/IResultDirectory.java
A 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/IResultMetadata.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/IResultPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/IResultSetReader.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultSetMetaData.java
M 
hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/result/ResultDirectory.java
M 
hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/result/ResultDirectoryRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyrac

Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5725/ 
(13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:21 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5808/
 (14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1176/
 (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3820/ 
(4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:08 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/590/ 
(11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:16 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6391/ (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:08 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1085/
 (8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:11 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5976/
 (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:15 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6181/ 
(9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:13 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11300/ (1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:07 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5826/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:07 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/987/ (7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 05:06:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5825/ 
(10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8586/ 
: FAILURE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:56:45 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/zF5Rv6je9bA6KgME8 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:59:51 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1: Contrib-2

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4436/ : FAILURE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:59:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:58:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4436/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:57:27 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8586/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:55:21 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5975/
 (12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:22 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/748/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/986/ (9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:16 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11299/ (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5807/
 (14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:25 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5788/ 
(16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:28 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/589/ 
(8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:14 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6180/ 
(11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:20 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3819/ 
(2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:08 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5724/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:07 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6030/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:08 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1175/
 (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1084/
 (7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:13 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9766/ (4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6390/ (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:54:11 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 04:29:42 +
Gerrit-HasComments: No


[jira] [Commented] (ASTERIXDB-2288) Problems in SQL++ compilation when types "open up"

2019-05-21 Thread Michael J. Carey (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845486#comment-16845486
 ] 

Michael J. Carey commented on ASTERIXDB-2288:
-

Ah - interesting - empty records seem weird, so I stand by my classification, 
but it also seems correct per your explanation.  :)

> Problems in SQL++ compilation when types "open up"
> --
>
> Key: ASTERIXDB-2288
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2288
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: COMP - Compiler
>Affects Versions: 0.9.4
>Reporter: Michael J. Carey
>Assignee: Ali Alsuliman
>Priority: Major
>  Labels: triaged
> Fix For: 0.9.4.2
>
>
> USE TinySocial;
> -- This works based on the TinySocial tutorial schema
> SELECT VALUE a FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE 
> g FROM GleambookUsers g) AS a;
> -- This doesn't work properly (field accesses broken)
> SELECT name FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE g 
> FROM GleambookUsers g) AS a;
> -- This one is weird (returns some empty records)
> SELECT alias FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE g 
> FROM GleambookUsers g) AS a;



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/WKbMfYo9wiKL67HR6 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 23:50:02 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8585/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 23:29:42 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4435/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:37:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Hussain Towaileb (Code Review)
Hussain Towaileb has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java
File 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java:

https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@89
PS4, Line 89: // Prepare tests
> remove this println() (or switch to use logger)?
Done, removed.


https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@107
PS4, Line 107:
> remove this println() (or switch to use logger)?
Done, removed.


https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java
File 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java:

https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java@94
PS4, Line 94: // Do any needed preparations once
> remove this println() (or switch to use logger)?
Done, removed.


https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java@120
PS4, Line 120:
> remove this println() (or switch to use logger)?
Done, removed.



--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:26:22 +
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5974/
 (14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:29 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/985/ (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/u7W2a2aiVSbCBonA7 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:21:31 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4435/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:20:31 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1083/
 (9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1174/
 (12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:25 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/747/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:31 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8585/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:18:49 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6179/ 
(13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:27 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9765/ (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:21 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5806/
 (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:34 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3818/ 
(8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:17 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5723/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6029/ 
(6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:12 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5787/ 
(5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:11 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6389/ (7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:14 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/588/ 
(2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5824/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11298/ (4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 22:17:11 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Hussain Towaileb (Code Review)
Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins, Hussain Towaileb, 
Dmitry Lychagin,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3393

to look at the new patch set (#5).

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..

[ASTERIXDB-2569][TEST] Refactor type computer tests

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Converted type computer tests to be parameterized.
- Moved the tests to appropriate packages to use the
log4j logger.
- Type computer instances check is based on the field
type instead of field name.

Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
---
M asterixdb/asterix-om/pom.xml
D 
asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java
D 
asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java
A 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java
A 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java
R 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/util/JSONDeserializerForTypesTest.java
6 files changed, 464 insertions(+), 301 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/93/3393/5
--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java
File 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java:

https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@89
PS4, Line 89: 
System.out.println("\n--");
remove this println() (or switch to use logger)?


https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@107
PS4, Line 107: 
System.out.println("--\n");
remove this println() (or switch to use logger)?


https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java
File 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java:

https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java@94
PS4, Line 94: 
System.out.println("\n--");
remove this println() (or switch to use logger)?


https://asterix-gerrit.ics.uci.edu/#/c/3393/4/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java@120
PS4, Line 120: 
System.out.println("--\n");
remove this println() (or switch to use logger)?



--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 20:57:43 +
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/WJE4c1HEuoACF76k9 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 19:58:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8584/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 19:42:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4434/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:50:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/984/ (8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8584/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:31:34 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/GWb4XXWtf9HkhT7k8 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:34:33 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4434/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:33:38 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Hussain Towaileb (Code Review)
Hussain Towaileb has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/pom.xml
File asterixdb/asterix-om/pom.xml:

https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/pom.xml@135
PS3, Line 135:   test
> add test . it's a test-only dependency, right?
You're right, my bad, done.


https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java
File 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java:

https://asterix-gerrit.ics.uci.edu/#/c/3393/3/asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java@20
PS3, Line 20: package org.apache.asterix.test.om.typecomputer;
> can you explain why these tests were moved to the "test" package? The usual
The Log4j is using the log4j2-asterixdb-test.xml file for the test logging 
configuration, which looks for the reflection for "org.apache.asterix.test" to 
use the ConsoleTest appender, that's why I moved the tests to the "test" 
package.

I noticed the same is being done for other tests, if you check the asterix-app 
module, the tests are under org.apache.asterix.test package as well.

When I had it in the original package (before modifications), the logger 
wouldn't log anything, and it only started working after moving them.

Please note that before we were using "System.out.print" for logging rather 
than Logger, that's why it wasn't an issue, but with the Logger, I had to move 
them.



--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:33:14 +
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5786/ 
(14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:30 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/587/ 
(11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:24 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6178/ 
(7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:17 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11297/ (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:33 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5805/
 (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5823/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:32 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1082/
 (9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/746/ 
(12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5973/
 (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:29 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5722/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:14 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6028/ 
(4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:16 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1173/
 (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:16 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6388/ (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:16 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3817/ 
(2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:14 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3393 )

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9764/ (3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 21 May 2019 18:30:15 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests

2019-05-21 Thread Hussain Towaileb (Code Review)
Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins, Hussain Towaileb, 
Dmitry Lychagin,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3393

to look at the new patch set (#4).

Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..

[ASTERIXDB-2569][TEST] Refactor type computer tests

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Converted type computer tests to be parameterized.
- Moved the tests to appropriate packages to use the
log4j logger.
- Type computer instances check is based on the field
type instead of field name.

Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
---
M asterixdb/asterix-om/pom.xml
D 
asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java
D 
asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java
A 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java
A 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java
R 
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/util/JSONDeserializerForTypesTest.java
6 files changed, 472 insertions(+), 301 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/93/3393/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/3393
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Gerrit-Change-Number: 3393
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions

2019-05-21 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3377 )

Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions
..


Patch Set 13:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithoutAllFlagDescriptor.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithoutAllFlagDescriptor.java:

https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithoutAllFlagDescriptor.java@82
PS13, Line 82: if (flagEvaluator != null) {
is flagEvaluator always 'null' here? This is 'WithoutAllFlag' function.  Is it 
possible to have one evaluator for both 'with' and 'without' flag functions? 
Seems like there's a lot of code that can be shared between the two.


https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/exceptions/TypeMismatchException.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/exceptions/TypeMismatchException.java:

https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/exceptions/TypeMismatchException.java@74
PS13, Line 74: public TypeMismatchException(byte actualTypeTag, byte... 
expectedTypeTags) {
This new constructor is only used by the newly added 
PointableHelper.getLongValue(), right? If we remove that method and use 
ATypeHierarchy, then we'll no longer need this new constructor.



--
To view, visit https://asterix-gerrit.ics.uci.edu/3377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6
Gerrit-Change-Number: 3377
Gerrit-PatchSet: 13
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 21 May 2019 17:59:16 +
Gerrit-HasComments: Yes


[jira] [Commented] (ASTERIXDB-2288) Problems in SQL++ compilation when types "open up"

2019-05-21 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845066#comment-16845066
 ] 

ASF subversion and git services commented on ASTERIXDB-2288:


Commit 249c95599c6ca1a61de81ec0a80374eed0cd0784 in asterixdb's branch 
refs/heads/master from Ali Alsuliman
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=249c955 ]

[ASTERIXDB-2288][COMP] Fix field access with UNION

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
For UNION, if there is an assign operator above UNION, the optimizer
will move the assign operator under UNION into both branches. If
the assign operator has field access by index, the index is based on
the output record of the union operator which could be different from
the field index in left and right branches. The fix is to map the
index to the correct index of the input operator where the assign
is copied to.

Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3400
Contrib: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Dmitry Lychagin 


> Problems in SQL++ compilation when types "open up"
> --
>
> Key: ASTERIXDB-2288
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2288
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: COMP - Compiler
>Affects Versions: 0.9.4
>Reporter: Michael J. Carey
>Assignee: Ali Alsuliman
>Priority: Major
>  Labels: triaged
> Fix For: 0.9.4.2
>
>
> USE TinySocial;
> -- This works based on the TinySocial tutorial schema
> SELECT VALUE a FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE 
> g FROM GleambookUsers g) AS a;
> -- This doesn't work properly (field accesses broken)
> SELECT name FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE g 
> FROM GleambookUsers g) AS a;
> -- This one is weird (returns some empty records)
> SELECT alias FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE g 
> FROM GleambookUsers g) AS a;



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ASTERIXDB-2288) Problems in SQL++ compilation when types "open up"

2019-05-21 Thread Ali Alsuliman (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845082#comment-16845082
 ] 

Ali Alsuliman commented on ASTERIXDB-2288:
--

[~dtabass]

2nd query should work now.

3rd query, isn't that supposed to be the behaviour or am I missing something? 
"alias" field does not exist in ChirpUsers. The empty records are coming from 
ChirpUsers dataset where "alias" field is missing.

> Problems in SQL++ compilation when types "open up"
> --
>
> Key: ASTERIXDB-2288
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2288
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: COMP - Compiler
>Affects Versions: 0.9.4
>Reporter: Michael J. Carey
>Assignee: Ali Alsuliman
>Priority: Major
>  Labels: triaged
> Fix For: 0.9.4.2
>
>
> USE TinySocial;
> -- This works based on the TinySocial tutorial schema
> SELECT VALUE a FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE 
> g FROM GleambookUsers g) AS a;
> -- This doesn't work properly (field accesses broken)
> SELECT name FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE g 
> FROM GleambookUsers g) AS a;
> -- This one is weird (returns some empty records)
> SELECT alias FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE g 
> FROM GleambookUsers g) AS a;



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   >