Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7: Contrib-2

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4567/ : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 05:11:30 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4567/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:54:28 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/yNWgeDLf2kYv7VSK8 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:55:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8740/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:52:29 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6334/ 
(16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:20 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1330/
 (12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:13 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Shiva Jahangiri (Code Review)
Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#7).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
9 files changed, 845 insertions(+), 394 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/7
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6545/ (15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11454/ (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/740/ 
(7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:05 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5986/ 
(8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:06 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5881/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:01 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5963/
 (4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:02 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6184/ 
(11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:11 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1141/ (2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:01 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5945/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:01 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1234/
 (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:15 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6123/
 (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:02 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9920/ (14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:17 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3968/ 
(9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:08 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/900/ 
(6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 04:51:03 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/JqNpRLp3dXmiT2Q77 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 01:40:03 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8739/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 01:15:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/gEqVD8MhCr31mPKXA : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:31:49 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4566/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:20:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:03:56 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4566/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:03:58 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/vkboayLV7WpKkkDJA : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:03:42 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8739/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:02:21 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9919/ (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:00:05 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1140/ (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:00:03 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6122/
 (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:00:11 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5985/ 
(2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 23:59:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6183/ 
(6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 23:59:57 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6544/ (8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 23:59:59 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/899/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:00:17 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11453/ (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 23:59:57 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Luo Chen (Code Review)
Hello Anon. E. Moose (1000171), Till Westmann, Jenkins, Michael Blow, Murtadha 
Hubail, Ian Maxon,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3285

to look at the new patch set (#10).

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..

[ASTERIXDB-2540] Optimize Storage Disk I/O

- user model changes: yes. Add two new storage options:
 storage.disk.force.bytes (default 16MB),
 storage.write.rate.limit (default 0)
- storage format changes: yes.
 Modified LSM metadata. But this patch is backward-compatible
- interface changes: yes.
 Introduced IPageWriteCallback to LSM indexes

Details:
- Bypass all queuing (from BufferCache and IOManager) for disk writes.
This queuing is unnecessary but destroys fairness among multiple
writers.
- Introduce IPageWriteCallback to control the behavior of disk page
writes. Currently, two features are implemented using this interface,
namely regular disk forces and rate limiting.

Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmBTreeResourceFactoryProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IRateLimiterFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetRateLimiterFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIndexPageWriteCallbackFactory.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/BTreeResourceFactoryProvider.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/InvertedIndexResourceFactoryProvider.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/RTreeResourceFactoryProvider.java
M 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/am/lsm/btree/LSMBTreeOperatorTestHelper.java
M 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/am/lsm/rtree/LSMRTreeOperatorTestHelper.java
M 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/am/lsm/rtree/LSMRTreeWithAntiMatterTuplesOperatorTestHelper.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IPageManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexBulkLoadOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/AppendOnlyLinkedMetadataPageManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/dataflow/ExternalBTreeLocalResource.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/dataflow/ExternalBTreeLocalResourceFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/dataflow/ExternalBTreeWithBuddyLocalResource.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/dataflow/ExternalBTreeWithBuddyLocalResourceFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/dataflow/LSMBTreeLocalResource.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/dataflow/LSMBTreeLocalResourceFactory.java
M 

Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3967/ 
(12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:00:07 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5962/
 (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:00:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5944/ 
(4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 23:59:56 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/739/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 23:59:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6333/ 
(14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:00:14 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1233/
 (9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:00:01 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1329/
 (7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 23:59:58 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 10:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5880/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 10
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 23:59:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Luo Chen (Code Review)
Luo Chen has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 9: -Code-Review

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java:

https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java@99
PS9, Line 99: The maximum disk write rate (bytes/s) for each dataset
> what does 0 (the default) mean; we should probably indicate that here
Done


https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java@101
PS9, Line 101: for
> before?
Done


https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java:

https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java@359
PS9, Line 359: populateRateLimiter
> can we return the rate limiter from this method, to avoid the extra lookup?
Done


https://asterix-gerrit.ics.uci.edu/#/c/3285/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java
File 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java:

https://asterix-gerrit.ics.uci.edu/#/c/3285/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java@65
PS9, Line 65: A
> a
Done


https://asterix-gerrit.ics.uci.edu/#/c/3285/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java@65
PS9, Line 65: F
> f
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 9
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 23:59:52 +
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8738/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 23:05:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Document window functions.

2019-06-18 Thread Simon Dew (Code Review)
Simon Dew has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3448 )

Change subject: [NO ISSUE] Document window functions.
..


Patch Set 1:

(17 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/0_toc.md
File asterixdb/asterix-doc/src/main/markdown/builtins/0_toc.md:

https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/0_toc.md@38
PS1, Line 38: * [Window Clause (OVER Clause)](#WindowClause)
> OVER clause is strictly speaking not a window clause.
Changed to "OVER clause (Window Definition)"


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md
File asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md:

https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@260
PS1, Line 260:   tied objects in the window frame, the function returns the 
lowest value
> "lowest"? what if ORDER BY had DESC modifier?
Changed to "first". Added a note that the order of tuples depends on the window 
order clause.


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@491
PS1, Line 491:   tied objects in the window frame, the function returns the 
highest
> "highest"? What if ORDER BY had DESC modifier?
Changed to "last". Added a note that the order of tuples depends on the window 
order clause.


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@691
PS1, Line 691: * [Nth Val From](#nthval-from): (Optional) Determines where 
the function
> trailing whitespace
Done


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@743
PS1, Line 743: * If the window frame is defined by `RANGE` or `GROUPS`, and 
there are
> lowest/highest will also depend on the ORDER BY modifier (DESC/ASC)
Changed to "first" and "last". Added a note that the order of tuples depends on 
the window order clause.


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md
File asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md:

https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md@20
PS1, Line 20: ## Window Clause (OVER Clause) ##
> May be instead of "window clause" we should call it "window function call e
I've called it "OVER Clause (Window Function Calls)".


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md@23
PS1, Line 23: the order of objects within the window, and the size of the 
window frame.
> May be say "the order of tuples within those partitions". Also, I'd may be
Done


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md@24
PS1, Line 24: The `OVER` keyword introduces the window clause.
> " ... introduces the window function call" ?
Removed this, as I think it's not necessary if referring to the "OVER clause".


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md@94
PS1, Line 94: The AS keyword enables you to specify an alias for the window 
clause.
> ".. an alias for the window frame contents". It introduces a variable which
Done


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md@97
PS1, Line 97: window clause using this alias, for example:
> may be "refers to this alias"? The alias is just a variable that's introduc
Done


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md@99
PS1, Line 99: FROM source
> I'd give an alias for "source" too: "FROM source AS src", then change "FROM
Done


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md@125
PS1, Line 125: ### Window Clause ###
> Again, we probably should not call it "Window Clause" to avoid confusion wi
I've gone for "Window Definition", following PostgreSQL


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md@137
PS1, Line 137: The **window partition clause** groups the query results into 
partitions using
> "groups the query results" might be confusing. Unlike GROUP BY window funct
Done


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md@150
PS1, Line 150: The **window order clause** determines how objects are ordered 
within each
> I think we call them "tuples" in this documentation, not "objects".
Done throughout


https://asterix-gerrit.ics.uci.edu/#/c/3448/1/asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md@238
PS1, Line 238: The ordering term expression 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4565/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 22:06:43 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4565/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:52:20 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/FeDH24TLSU5vgoTq5 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:52:29 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8738/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:50:27 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1139/ (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:49:04 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1232/
 (8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:48:59 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5961/
 (15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:49:17 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/738/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:48:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1328/
 (9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:49:02 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6121/
 (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:49:11 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6182/ 
(6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:48:56 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9918/ (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:49:07 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/898/ 
(16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:49:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6332/ 
(12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:49:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3966/ 
(14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:49:14 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Shiva Jahangiri (Code Review)
Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#6).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinTest.java
11 files changed, 822 insertions(+), 392 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/6
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6543/ (7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:48:57 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5943/ 
(4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:48:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11452/ (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:48:56 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5879/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:48:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5984/ 
(2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:48:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/VPBus8vR36Sf3HEN9 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:21:01 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8737/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 20:51:03 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix error message thrown by ATypeHierarchy

2019-06-18 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has submitted this change and it was merged. ( 
https://asterix-gerrit.ics.uci.edu/3441 )

Change subject: [NO ISSUE] Fix error message thrown by ATypeHierarchy
..

[NO ISSUE] Fix error message thrown by ATypeHierarchy

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Align type mismatch error message thrown by ATypeHierarchy
  with the one produced by TypeMismatchException

Change-Id: I830e93056d18123610b933a0e36fd1b54c6e140b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3441
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Dmitry Lychagin 
Reviewed-by: Ali Alsuliman 
---
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/exceptions/ExceptionUtil.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ATypeHierarchy.java
2 files changed, 18 insertions(+), 17 deletions(-)

Approvals:
  Jenkins: Verified; Verified
  Dmitry Lychagin: Looks good to me, but someone else must approve
  Ali Alsuliman: Looks good to me, approved

Objections:
  Jenkins: Violations found
  Anon. E. Moose (1000171): Violations found



diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/exceptions/ExceptionUtil.java
 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/exceptions/ExceptionUtil.java
index 9a115c8..bdcb201 100644
--- 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/exceptions/ExceptionUtil.java
+++ 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/exceptions/ExceptionUtil.java
@@ -24,7 +24,7 @@
 private ExceptionUtil() {
 }

-static String toExpectedTypeString(Object... expectedItems) {
+public static String toExpectedTypeString(Object... expectedItems) {
 StringBuilder expectedTypes = new StringBuilder();
 int numCandidateTypes = expectedItems.length;
 for (int index = 0; index < numCandidateTypes; ++index) {
@@ -40,7 +40,7 @@
 return expectedTypes.toString();
 }
 
-static String indexToPosition(int index) {
+public static String indexToPosition(int index) {
 int i = index + 1;
 switch (i % 100) {
 case 11:
diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ATypeHierarchy.java
 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ATypeHierarchy.java
index f182370..e5b1c62 100644
--- 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ATypeHierarchy.java
+++ 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ATypeHierarchy.java
@@ -20,7 +20,6 @@

 import java.io.DataOutput;
 import java.io.IOException;
-import java.util.Arrays;
 import java.util.BitSet;
 import java.util.EnumMap;
 import java.util.HashMap;
@@ -32,6 +31,7 @@
 import org.apache.asterix.om.base.AFloat;
 import org.apache.asterix.om.base.IAObject;
 import org.apache.asterix.om.constants.AsterixConstantValue;
+import org.apache.asterix.om.exceptions.ExceptionUtil;
 import org.apache.asterix.om.types.ATypeTag;
 import org.apache.asterix.om.types.EnumDeserializer;
 import org.apache.commons.lang3.tuple.Pair;
@@ -315,10 +315,8 @@
 case DOUBLE:
 return 
DoubleToInt32TypeConvertComputer.getInstance(strictDemote).convertType(bytes, 
offset);
 default:
-throw new 
RuntimeDataException(ErrorCode.TYPE_MISMATCH_FUNCTION, name, argIndex,
-Arrays.toString(new Object[] { ATypeTag.TINYINT, 
ATypeTag.SMALLINT, ATypeTag.INTEGER,
-ATypeTag.BIGINT, ATypeTag.FLOAT, 
ATypeTag.DOUBLE }),
-sourceTypeTag);
+throw createTypeMismatchException(name, argIndex, 
sourceTypeTag, ATypeTag.TINYINT, ATypeTag.SMALLINT,
+ATypeTag.INTEGER, ATypeTag.BIGINT, ATypeTag.FLOAT, 
ATypeTag.DOUBLE);
 }
 }

@@ -354,10 +352,8 @@
 case DOUBLE:
 return 
DoubleToInt64TypeConvertComputer.getInstance(strictDemote).convertType(bytes, 
offset);
 default:
-throw new 
RuntimeDataException(ErrorCode.TYPE_MISMATCH_FUNCTION, name, argIndex,
-Arrays.toString(new Object[] { ATypeTag.TINYINT, 
ATypeTag.SMALLINT, ATypeTag.INTEGER,
-ATypeTag.BIGINT, ATypeTag.FLOAT, 
ATypeTag.DOUBLE }),
-sourceTypeTag);
+throw createTypeMismatchException(name, argIndex, 
sourceTypeTag, ATypeTag.TINYINT, ATypeTag.SMALLINT,
+ATypeTag.INTEGER, ATypeTag.BIGINT, ATypeTag.FLOAT, 
ATypeTag.DOUBLE);
 }
 }

@@ -385,18 +381,16 @@
 case BIGINT:
 return 
IntegerToDoubleTypeConvertComputer.getInstance().convertType(bytes, offset, 
sourceTypeTag);
 default:
-throw new 
RuntimeDataException(ErrorCode.TYPE_MISMATCH_FUNCTION, 

Change in asterixdb[master]: [NO ISSUE] Fix error message thrown by ATypeHierarchy

2019-06-18 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3441 )

Change subject: [NO ISSUE] Fix error message thrown by ATypeHierarchy
..


Patch Set 2: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/3441
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I830e93056d18123610b933a0e36fd1b54c6e140b
Gerrit-Change-Number: 3441
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Anon. E. Moose 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 20:11:48 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4564/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:55:25 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/yUVe4cymumMPkfyr5 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:39:22 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8737/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:39:15 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:39:17 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4564/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:38:24 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5960/
 (14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:44 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6181/ 
(16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:48 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5983/ 
(12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:40 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3965/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:46 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/737/ 
(13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:42 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5942/ 
(10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:35 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11451/ (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:38 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/897/ 
(9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:33 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6120/
 (8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:32 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1231/
 (3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:29 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1138/ (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:31 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6331/ 
(7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:31 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5878/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:28 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9917/ (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:30 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6542/ (2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:29 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3223 )

Change subject: [WIP] adding new range multi partitioning operator
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1327/
 (4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
Gerrit-Change-Number: 3223
Gerrit-PatchSet: 19
Gerrit-Owner: Stephen Ermshar 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:35:30 +
Gerrit-HasComments: No


Change in asterixdb[master]: [WIP] adding new range multi partitioning operator

2019-06-18 Thread Stephen Ermshar (Code Review)
Hello Anon. E. Moose (1000171), Preston Carman, Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3223

to look at the new patch set (#19).

Change subject: [WIP] adding new range multi partitioning operator
..

[WIP] adding new range multi partitioning operator

Change-Id: Ib31da7352394cca58e54d8316d6e77cc7c2ce217
---
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/RangeMapBuilder.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AGenericDescBinaryComparator.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AIntervalAscPartialBinaryComparatorFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AIntervalDescPartialBinaryComparatorFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AIntervalEndpointAscPartialBinaryComparatorFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AIntervalStartpointDescPartialBinaryComparatorFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AbstractAGenericBinaryComparator.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java
A 
asterixdb/asterix-om/src/test/java/org/apache/asterix/dataflow/data/nontagged/comparators/AIntervalPartialBinaryComparatorFactoryTest.java
A 
asterixdb/asterix-om/src/test/java/org/apache/asterix/om/util/FieldRangeMultiPartitionComputerFactoryTest.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/RangePartitionExchangePOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/RangePartitionMergeExchangePOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/OrderedPartitionedProperty.java
M 
hyracks-fullstack/algebricks/algebricks-data/src/main/java/org/apache/hyracks/algebricks/data/IBinaryComparatorFactoryProvider.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java
A 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/value/ITupleMultiPartitionComputer.java
A 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/value/ITupleMultiPartitionComputerFactory.java
A 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/value/ITupleMultiPartitionComputerFamily.java
A 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/value/RangePartitioningType.java
A 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/storage/IGrowableIntArray.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/data/partition/range/DynamicFieldRangeMultiPartitionComputerFactory.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/data/partition/range/FieldRangeMultiPartitionComputerFactory.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/data/partition/range/StaticFieldRangeMultiPartitionComputerFactory.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-common/src/test/java/org/apache/hyracks/dataflow/common/data/partition/range/AbstractRangeMapTest.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-common/src/test/java/org/apache/hyracks/dataflow/common/data/partition/range/RangeMapTest.java
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/MToNMultiPartitioningConnectorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/MToNMultiPartitioningMergingConnectorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/MultiPartitionDataWriter.java
A 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/unit/FieldRangeMultiPartitionComputerFactoryTest.java
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/arraylist/IntArrayList.java
32 files changed, 2,321 insertions(+), 40 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/23/3223/19
--
To view, visit https://asterix-gerrit.ics.uci.edu/3223
To unsubscribe, visit 

Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 9:

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/71RLwPBkBUUCauC48 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 9
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 19:32:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix error message thrown by ATypeHierarchy

2019-06-18 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3441 )

Change subject: [NO ISSUE] Fix error message thrown by ATypeHierarchy
..


Patch Set 2: Code-Review+1


--
To view, visit https://asterix-gerrit.ics.uci.edu/3441
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I830e93056d18123610b933a0e36fd1b54c6e140b
Gerrit-Change-Number: 3441
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Anon. E. Moose 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 18 Jun 2019 18:08:08 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()

2019-06-18 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has submitted this change and it was merged. ( 
https://asterix-gerrit.ics.uci.edu/3449 )

Change subject: [NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()
..

[NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()

- user model changes: yes
- storage format changes: no
- interface changes: no

Details:
- Support frame specification in RATIO_TO_REPORT()
  window function call

Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3449
Contrib: Jenkins 
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Dmitry Lychagin 
Reviewed-by: Ali Alsuliman 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
4 files changed, 36 insertions(+), 6 deletions(-)

Approvals:
  Jenkins: Verified; ; Verified
  Anon. E. Moose (1000171):
  Dmitry Lychagin: Looks good to me, but someone else must approve
  Ali Alsuliman: Looks good to me, approved

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
index 1c5750c..988723f 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
@@ -1228,11 +1228,6 @@
 createOperatorExpr(fargs.get(1), OperatorType.MINUS, 
new IntegerLiteral(1), sourceLoc);
 } else if (BuiltinFunctions.RATIO_TO_REPORT_IMPL.equals(fi)) {
 // ratio_to_report(x) over (...) --> x / sum(x) over (...)
-winFrameMode = WindowExpression.FrameMode.RANGE;
-winFrameStartKind = 
WindowExpression.FrameBoundaryKind.UNBOUNDED_PRECEDING;
-winFrameEndKind = 
WindowExpression.FrameBoundaryKind.CURRENT_ROW;
-winFrameExclusionKind = 
WindowExpression.FrameExclusionKind.NO_OTHERS;
-
 nestedAggFunc = BuiltinFunctions.SCALAR_SQL_SUM;
 postWinResultFunc = BuiltinFunctions.NUMERIC_DIVIDE;
 postWinExpr = fargs.get(1);
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
new file mode 100644
index 000..9408641
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/ratio_to_report_01/ratio_to_report_01.8.query.sqlpp
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description  : Test RATIO_TO_REPORT() with frame specification
+ * Expected Res : SUCCESS
+ */
+
+FROM range(1, 2) x, range(1, 4) y
+SELECT x, y,
+  round_half_to_even(ratio_to_report(y) over (partition by x order by y rows 
between 1 preceding and 1 following), 2) rr
+ORDER BY x, y
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
new file mode 100644
index 000..5ff1afc
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/window/ratio_to_report_01/ratio_to_report_01.8.adm
@@ -0,0 +1,8 @@
+{ "x": 1, "y": 1, "rr": 0.33 }
+{ "x": 1, "y": 2, "rr": 0.33 }
+{ "x": 1, "y": 3, "rr": 0.33 }
+{ "x": 1, "y": 4, "rr": 0.57 }
+{ "x": 2, "y": 1, "rr": 0.33 }
+{ "x": 2, "y": 2, "rr": 0.33 }
+{ "x": 2, "y": 3, "rr": 0.33 }
+{ "x": 2, "y": 4, "rr": 0.57 }
\ No newline at 

Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-18 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3285 )

Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O
..


Patch Set 9:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java:

https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java@99
PS9, Line 99: The maximum disk write rate (bytes/s) for each dataset
what does 0 (the default) mean; we should probably indicate that here


https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java@101
PS9, Line 101: for
before?


https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java:

https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java@359
PS9, Line 359: populateRateLimiter
can we return the rate limiter from this method, to avoid the extra lookup?


https://asterix-gerrit.ics.uci.edu/#/c/3285/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java
File 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java:

https://asterix-gerrit.ics.uci.edu/#/c/3285/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java@65
PS9, Line 65: F
f


https://asterix-gerrit.ics.uci.edu/#/c/3285/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java@65
PS9, Line 65: A
a



--
To view, visit https://asterix-gerrit.ics.uci.edu/3285
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b
Gerrit-Change-Number: 3285
Gerrit-PatchSet: 9
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 18 Jun 2019 17:27:14 +
Gerrit-HasComments: Yes


  1   2   >