Change in asterixdb[trinity]: Merge branch 'gerrit/neo' into 'gerrit/trinity'
>From Michael Blow : Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18256 ) Change subject: Merge branch 'gerrit/neo' into 'gerrit/trinity' .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18256 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I312b65d84030f7f4557bec637f966d2003aa17a4 Gerrit-Change-Number: 18256 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Comment-Date: Sun, 28 Apr 2024 04:35:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[trinity]: Merge branch 'gerrit/neo' into 'gerrit/trinity'
>From Michael Blow :
Michael Blow has submitted this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18256 )
Change subject: Merge branch 'gerrit/neo' into 'gerrit/trinity'
..
Merge branch 'gerrit/neo' into 'gerrit/trinity'
Change-Id: I312b65d84030f7f4557bec637f966d2003aa17a4
---
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
2 files changed, 18 insertions(+), 5 deletions(-)
Approvals:
Jenkins: Verified
Michael Blow: Looks good to me, approved; Verified
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
index e5d03c9..9c25f6e 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
@@ -116,7 +116,9 @@
}
};
-<<< HEAD (f805cf [ASTERIXDB-3343][API] Include job details in
active/complete)
+public static final IFunctionTypeInferer MEDIAN_MEMORY =
+(expr, fd, context, compilerProps) ->
fd.setImmutableStates(compilerProps.getSortMemoryFrames());
+
public static final IFunctionTypeInferer RECORD_MODIFY_INFERER = (expr,
fd, context, compilerProps) -> {
AbstractFunctionCallExpression f = (AbstractFunctionCallExpression)
expr;
IAType outType = (IAType) context.getType(expr);
@@ -126,10 +128,6 @@
}
fd.setImmutableStates(outType, inType);
};
-===
-public static final IFunctionTypeInferer MEDIAN_MEMORY =
-(expr, fd, context, compilerProps) ->
fd.setImmutableStates(compilerProps.getSortMemoryFrames());
->>> BRANCH (ed4bd1 [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function)
public static final class CastTypeInferer implements IFunctionTypeInferer {
@Override
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18256
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I312b65d84030f7f4557bec637f966d2003aa17a4
Gerrit-Change-Number: 18256
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-MessageType: merged
Change in asterixdb[trinity]: Merge branch 'gerrit/neo' into 'gerrit/trinity'
>From Michael Blow : Attention is currently required from: Michael Blow. Michael Blow has removed a vote from this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18256 ) Change subject: Merge branch 'gerrit/neo' into 'gerrit/trinity' .. Removed Verified-1 by Jenkins -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18256 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I312b65d84030f7f4557bec637f966d2003aa17a4 Gerrit-Change-Number: 18256 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Attention: Michael Blow Gerrit-MessageType: deleteVote
Change in asterixdb[trinity]: Merge branch 'gerrit/neo' into 'gerrit/trinity'
>From Jenkins : Attention is currently required from: Michael Blow. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18256 ) Change subject: Merge branch 'gerrit/neo' into 'gerrit/trinity' .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/390/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18256 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I312b65d84030f7f4557bec637f966d2003aa17a4 Gerrit-Change-Number: 18256 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Attention: Michael Blow Gerrit-Comment-Date: Sun, 28 Apr 2024 01:35:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Vijay Sarathy : Attention is currently required from: Ali Alsuliman. Vijay Sarathy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 16: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 16 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Vijay Sarathy Gerrit-CC: Ali Alsuliman Gerrit-Attention: Ali Alsuliman Gerrit-Comment-Date: Sun, 28 Apr 2024 01:28:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
Attention is currently required from: Ali Alsuliman, Vijay Sarathy. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 16: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/AJZV8Rvkxvqj3aZj8 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 16 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Vijay Sarathy Gerrit-CC: Ali Alsuliman Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Vijay Sarathy Gerrit-Comment-Date: Sun, 28 Apr 2024 01:22:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[trinity]: Merge branch 'gerrit/neo' into 'gerrit/trinity'
>From Michael Blow :
Michael Blow has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18256 )
Change subject: Merge branch 'gerrit/neo' into 'gerrit/trinity'
..
Merge branch 'gerrit/neo' into 'gerrit/trinity'
Change-Id: I312b65d84030f7f4557bec637f966d2003aa17a4
---
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
2 files changed, 18 insertions(+), 5 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/56/18256/1
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
index e5d03c9..9c25f6e 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionTypeInferers.java
@@ -116,7 +116,9 @@
}
};
-<<< HEAD (f805cf [ASTERIXDB-3343][API] Include job details in
active/complete)
+public static final IFunctionTypeInferer MEDIAN_MEMORY =
+(expr, fd, context, compilerProps) ->
fd.setImmutableStates(compilerProps.getSortMemoryFrames());
+
public static final IFunctionTypeInferer RECORD_MODIFY_INFERER = (expr,
fd, context, compilerProps) -> {
AbstractFunctionCallExpression f = (AbstractFunctionCallExpression)
expr;
IAType outType = (IAType) context.getType(expr);
@@ -126,10 +128,6 @@
}
fd.setImmutableStates(outType, inType);
};
-===
-public static final IFunctionTypeInferer MEDIAN_MEMORY =
-(expr, fd, context, compilerProps) ->
fd.setImmutableStates(compilerProps.getSortMemoryFrames());
->>> BRANCH (ed4bd1 [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function)
public static final class CastTypeInferer implements IFunctionTypeInferer {
@Override
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18256
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I312b65d84030f7f4557bec637f966d2003aa17a4
Gerrit-Change-Number: 18256
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow
Gerrit-MessageType: newchange
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Jenkins : Attention is currently required from: Ali Alsuliman. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 16: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/389/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 16 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Vijay Sarathy Gerrit-CC: Ali Alsuliman Gerrit-Attention: Ali Alsuliman Gerrit-Comment-Date: Sat, 27 Apr 2024 23:38:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
Attention is currently required from: Ali Alsuliman. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 16: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/bbQ31Vj1Kx6PahgXA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 16 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Vijay Sarathy Gerrit-CC: Ali Alsuliman Gerrit-Attention: Ali Alsuliman Gerrit-Comment-Date: Sat, 27 Apr 2024 23:10:36 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Vijay Sarathy : Attention is currently required from: Ali Alsuliman. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 to look at the new patch set (#16). Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac --- M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-12.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-15.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-14.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-11.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/hints-indexnl-params/hints-indexnl-params-5.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java D asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-7.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-16.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/hints-indexnl-params/hints-indexnl-params-7.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/hints-indexnl-params/hints-indexnl-params-4.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-10.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-13.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IAccessMethod.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/SkipSecondaryIndexSearchExpressionAnnotation.java M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-10.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-16.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-13.plan M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/AbstractExpressionAnnotationWithIndexNames.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/IndexedNLJoinExpressionAnnotation.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/SecondaryIndexSearchPreferenceAnnotation.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-14.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/hints-indexnl-params/hints-indexnl-params-6.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-12.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-11.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-15.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/RTreeAccessMethod.java D asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-5.plan 35 files changed, 299 insertions(+), 296 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/77/18177/16 -- To view, visit
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Vijay Sarathy :
Attention is currently required from: Ali Alsuliman.
Vijay Sarathy has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 )
Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not
working correctly
..
Patch Set 15:
(5 comments)
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/d9a8368a_245911d8
PS14, Line 377:
> Remove extra line.
Done
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/da114869_d592e0b4
PS14, Line 564: || (annotationRemoved && (this instanceof
IntroduceJoinAccessMethodRule))
> Take it to an else part and then call: […]
Done
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/0ce78c41_baccfe40
PS14, Line 626: applicableIndexNames != null
> How can this ever be 'null'?
Done
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/ca28ba84_d250ba6f
PS14, Line 644: if (anno instanceof SecondaryIndexSearchPreferenceAnnotation) {
: param1 =
SecondaryIndexSearchPreferenceAnnotation.HINT_STRING;
: } else if (anno instanceof
IndexedNLJoinExpressionAnnotation) {
: param1 =
IndexedNLJoinExpressionAnnotation.HINT_STRING;
: }
> I had a comment before about the use of instanceof and that it's not
> accurate. […]
Done
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/7dabd039_74682b7f
PS14, Line 1071: public AbstractExpressionAnnotationWithIndexNames
getSecondaryIndexAnnotation
> We shouldn't duplicate code here. […]
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 15
Gerrit-Owner: Vijay Sarathy
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Vijay Sarathy
Gerrit-CC: Ali Alsuliman
Gerrit-Attention: Ali Alsuliman
Gerrit-Comment-Date: Sat, 27 Apr 2024 22:03:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ali Alsuliman
Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Vijay Sarathy : Vijay Sarathy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 15: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 15 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Vijay Sarathy Gerrit-CC: Ali Alsuliman Gerrit-Comment-Date: Sat, 27 Apr 2024 22:02:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching
Attention is currently required from: Wail Alkowaileet. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255 ) Change subject: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/YxEZaC8eJrmkg9tF8 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iababcc5fc1d4e5e2de36f9b26c3f86ffabfb4e54 Gerrit-Change-Number: 18255 Gerrit-PatchSet: 2 Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Sat, 27 Apr 2024 19:59:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching
>From Jenkins : Attention is currently required from: Wail Alkowaileet. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255 ) Change subject: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/388/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iababcc5fc1d4e5e2de36f9b26c3f86ffabfb4e54 Gerrit-Change-Number: 18255 Gerrit-PatchSet: 2 Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Sat, 27 Apr 2024 18:54:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching
Attention is currently required from: Wail Alkowaileet. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255 ) Change subject: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/U4UG1VPBgbaxqvfH6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iababcc5fc1d4e5e2de36f9b26c3f86ffabfb4e54 Gerrit-Change-Number: 18255 Gerrit-PatchSet: 2 Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Sat, 27 Apr 2024 17:49:53 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching
>From Wail Alkowaileet : Attention is currently required from: Wail Alkowaileet. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255 to look at the new patch set (#2). Change subject: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching .. [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching - user model changes: no - storage format changes: yes - interface changes: yes Details: - Several modifications in columnar APIs to accommodate disk caching - Pass read/write buffer cache context to LSMColumnBTree bulkloader and cursors - Some refactoring in hyracks-cloud API (ASTERIXDB-3375) Storage changes: - Store the length (in bytes) of the mega leaf node in Page0 instead of the of the number of pages Change-Id: Iababcc5fc1d4e5e2de36f9b26c3f86ffabfb4e54 --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/btree/ColumnBTreePointSearchCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/pom.xml M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java M hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/cache/service/CloudDiskResourceCacheLockNotifier.java M hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndexBulkLoader.java M hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/LinuxFileSystemOperator.java M hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/btree/ColumnBTreeWriteLeafFrame.java M asterixdb/asterix-column/src/main/java/org/apache/asterix/column/ColumnManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/utils/LSMColumnBTreeUtil.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/api/AbstractColumnTupleWriter.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/btree/ColumnBTreeLeafFrameFactory.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/lsm/LSMColumnBTree.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/NoOpColumnIndexDiskCacheManager.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/buffercache/IColumnReadContext.java M asterixdb/asterix-column/src/test/java/org/apache/asterix/column/test/bytes/AbstractBytesTest.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/api/IColumnManager.java M asterixdb/asterix-column/src/main/java/org/apache/asterix/column/metadata/AbstractColumnMetadata.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/btree/ColumnBTreeRangeSearchCursor.java M asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/merge/MergeColumnTupleReaderWriterFactory.java M hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/sweeper/Sweeper.java M hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/PhysicalDrive.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/cloud/DefaultIndexDiskCacheManager.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/buffercache/read/DefaultColumnReadContext.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/lsm/LSMColumnPointSearchCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/cloud/IIndexDiskCacheManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/btree/ColumnBTreeReadLeafFrame.java M hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeNSMBulkLoader.java A
Change in asterixdb[master]: [ASTERIXDB-3384][DOC] Document COPY
>From Wail Alkowaileet : Attention is currently required from: Peeyush Gupta, Ian Maxon, Hussain Towaileb. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 ) Change subject: [ASTERIXDB-3384][DOC] Document COPY .. Patch Set 3: (1 comment) File asterixdb/asterix-doc/src/main/markdown/sqlpp/7_ddl_dml.md: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243/comment/3f9e7e15_07d1101d PS3, Line 756: / You won't need /. It will be added for you :) -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ibdacf4e6b156a3b6ef15b1420a4102c122f8bf1c Gerrit-Change-Number: 18243 Gerrit-PatchSet: 3 Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Peeyush Gupta Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ian Maxon Gerrit-Attention: Hussain Towaileb Gerrit-Comment-Date: Sat, 27 Apr 2024 17:24:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
